From: "Robin Jarry" <rjarry@redhat.com>
To: <dev@dpdk.org>
Cc: "Olivier Matz" <olivier.matz@6wind.com>,
"Ferruh Yigit" <ferruh.yigit@xilinx.com>,
"Bruce Richardson" <bruce.richardson@intel.com>
Subject: Re: [PATCH v5] usertools: rewrite pmdinfo
Date: Mon, 26 Sep 2022 14:52:44 +0200 [thread overview]
Message-ID: <CN6CINC0E3SV.2AWFS5XL5YCVZ@marty> (raw)
In-Reply-To: <20220922115802.32744-1-rjarry@redhat.com>
Robin Jarry, Sep 22, 2022 at 13:58:
> +# ----------------------------------------------------------------------------
> +def ld_so_path() -> Iterator[str]:
> + """
> + Return the list of directories where dynamic libraries are loaded based
> + on the contents of /etc/ld.so.conf/*.conf.
> + """
> + for conf in glob.iglob("/etc/ld.so.conf/*.conf"):
I just noticed that this folder path is invalid. I did not encounter any
errors since I did not test with librte_*.so libs installed in /usr/*.
> + try:
> + with open(conf, "r", encoding="utf-8") as f:
> + for line in f:
> + line = line.strip()
> + if os.path.isdir(line):
> + yield line
> + except OSError:
> + pass
> +
> +
> +LD_SO_CONF_PATH = ld_so_path()
Also, this is stupid. The iterator will be exhausted after iterating
once over it and the SO path folders will be empty on subsequent
lookups. I'll submit a v6 with a fix for these two bugs.
next prev parent reply other threads:[~2022-09-26 12:52 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 10:58 [PATCH] " Robin Jarry
2022-09-13 11:29 ` Ferruh Yigit
2022-09-13 11:49 ` Robin Jarry
2022-09-13 13:50 ` Ferruh Yigit
2022-09-13 13:59 ` Robin Jarry
2022-09-13 14:17 ` Ferruh Yigit
2022-09-13 14:17 ` Bruce Richardson
2022-09-13 19:42 ` [PATCH v2] " Robin Jarry
2022-09-13 20:54 ` Ferruh Yigit
2022-09-13 21:22 ` Robin Jarry
2022-09-14 11:46 ` Ferruh Yigit
2022-09-15 9:18 ` Robin Jarry
2022-09-20 9:08 ` [PATCH v3] " Robin Jarry
2022-09-20 10:10 ` Ferruh Yigit
2022-09-20 10:12 ` Robin Jarry
2022-09-20 10:42 ` [PATCH v4] " Robin Jarry
2022-09-20 14:08 ` Olivier Matz
2022-09-20 17:48 ` Ferruh Yigit
2022-09-20 17:50 ` Ferruh Yigit
2022-09-21 7:27 ` Thomas Monjalon
2022-09-21 8:02 ` Ferruh Yigit
2022-09-20 19:15 ` Robin Jarry
2022-09-21 7:58 ` Ferruh Yigit
2022-09-21 9:57 ` Ferruh Yigit
2022-09-22 11:58 ` [PATCH v5] " Robin Jarry
2022-09-22 12:03 ` Bruce Richardson
2022-09-22 15:12 ` Ferruh Yigit
2022-09-26 11:55 ` Olivier Matz
2022-09-26 12:52 ` Robin Jarry [this message]
2022-09-26 13:44 ` [PATCH v6] " Robin Jarry
2022-09-26 15:17 ` Bruce Richardson
2022-09-28 6:51 ` Robin Jarry
2022-09-28 10:53 ` Bruce Richardson
2022-09-28 11:12 ` Robin Jarry
2022-10-04 19:29 ` [PATCH v7] " Robin Jarry
2022-10-10 22:44 ` Thomas Monjalon
2022-10-12 15:16 ` Olivier Matz
2022-10-12 16:16 ` Thomas Monjalon
2022-10-12 16:30 ` Robin Jarry
2022-10-12 16:44 ` Thomas Monjalon
2022-10-12 16:48 ` Robin Jarry
2022-10-12 20:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CN6CINC0E3SV.2AWFS5XL5YCVZ@marty \
--to=rjarry@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).