From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10B6BA0C43; Fri, 1 Oct 2021 07:21:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EBC284067E; Fri, 1 Oct 2021 07:21:37 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 07C9B4067A for ; Fri, 1 Oct 2021 07:21:36 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10123"; a="204834858" X-IronPort-AV: E=Sophos;i="5.85,337,1624345200"; d="scan'208";a="204834858" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2021 22:21:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,337,1624345200"; d="scan'208";a="656147763" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga005.jf.intel.com with ESMTP; 30 Sep 2021 22:21:35 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 30 Sep 2021 22:21:34 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 30 Sep 2021 22:21:34 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.174) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 30 Sep 2021 22:21:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vsye6bTyJiqUMGeqDM3pvSSIcvmRSg/UMSLrzEb8ieNGCVVU6o1O5tWVsyLcO2k7h2VL5fJ8FcSjDuPouTWET5XOfsBI1k824CKBEKlWIwRdLdlptbYIdgBV6ZKo8i79opZEtZhiLxuI60ZqbiCx/re9yIBoLCxvaCKqiN3eylRp5G8OScD3ZJO55TMQRiUd+pxg34NQmk/2dEaTZA2gAMW/AXALKvFDtlTEpgjdlXFLZsSNZ6Cmy+vUdq/dRxjPegBRkPyTSOiZxejt2GmOnmAedu/NKLLTK1+QxZXzTAMIbTxUt7SAwT5uk99dcP9ZYeVbN4Y9cH4HW60fqp6Wjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YbdBzQNRpOE8OBxBmfytLd+wcuqmYSvzX/jC3McO2Kc=; b=nTe1cVgeY4s612I53jm1W8qiQg7Cjx+OTC2MWAoqL6WEDJOlfkQld0M4bXtyrbzh/zonBJdFUu5NL+pnvdNKZB1VT4zRSfBN56U6BEbm1S5zNn/53sSu44OFYtfYivAXmWkLoGDTt+agr/6qXGWroozVNDNm7wkjz6aXCH3uKJaCo9+r0tuOtKgL4ICWHYE12WSrPgbodoAsM4jDEYz+oWD/1p5ci1Sdj/4h5CrpWVlqtH889tBMpaF1V64xUcMssx8cq8OAW9OJR6h3DMxk6/WVVrGnMgs+jaFcSS8Os4rrWGQORmPZrWLOxSehmwr1gTtiSVqo/6HUpzJMdVOgow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YbdBzQNRpOE8OBxBmfytLd+wcuqmYSvzX/jC3McO2Kc=; b=rXjyIaEvME6p2d0jGaW1p5pf/at0cmD+nBaqLOn1UVROK4Ls/i4q8aL/JoBBNrLwlbN0KHQMO9l43W6bMYoPdZ6xBlqgaInXya+nzp6vBnmtlS0rP1tQTLGWYrBcNuol7qS1VaBoK5m6iKPgyFpFFw/GCTOEeT6ghWBAXG1CaIg= Received: from CO1PR11MB4882.namprd11.prod.outlook.com (2603:10b6:303:97::8) by MWHPR1101MB2126.namprd11.prod.outlook.com (2603:10b6:301:50::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14; Fri, 1 Oct 2021 05:21:32 +0000 Received: from CO1PR11MB4882.namprd11.prod.outlook.com ([fe80::2df9:a342:1f49:6260]) by CO1PR11MB4882.namprd11.prod.outlook.com ([fe80::2df9:a342:1f49:6260%5]) with mapi id 15.20.4566.015; Fri, 1 Oct 2021 05:21:32 +0000 From: "Kundapura, Ganapati" To: "Naga Harish K, S V" , "jerinjacobk@gmail.com" , "dev@dpdk.org" CC: "Jayatheerthan, Jay" Thread-Topic: [dpdk-dev] [PATCH v2] eventdev/rx-adapter: segfault in queue conf get Thread-Index: AQHXtfs4Iu9Uc4vys0aY/jiYtUEsS6u9kYSAgAAKyaA= Date: Fri, 1 Oct 2021 05:21:32 +0000 Message-ID: References: <20210930124712.424427-1-ganapati.kundapura@intel.com> <20210930130001.430924-1-ganapati.kundapura@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2614625c-6e6b-417f-bd3a-08d9849b5499 x-ms-traffictypediagnostic: MWHPR1101MB2126: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:494; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yYpBtn5yscDs+SsBCxir9C//8KUe/sa1h3L9XcQ0pBjCqMBvdt8UpOokF4O7Z3CVGUCAMYiSyzoOhumvBDwt6FcdLLqWeucbu5BsSQssZoI93+ESuKCjyLOrde0gD+3Rra//nJb6iSwW2tYDGlKWsw0wV0PePabQliPUGZisWnXlZeflUKhx/b6rqF5XsOMCdtbj7eWXCR7+k5gT80sfGJadHzOAznu4fAkbUSfbbMzYcD2rVUzlzavPgPpTw7uTPN97kuVJSH51RdTqgGcTbJAUf8BptqG+4S/9/oBU0kREwJBCPIKg/aDeX3dIAFM+iYYCmF01PQ23O/gbJHrFVo1t+XUiVYY7HI1I216lVU2gd70XwNHPbj7lybk7KLOq4vOPUOl/zyynw7fvxzfUl2tIsM/MzEu+ICj4+bBD9nvnrcH1pxlEgP6lFPC+8ucazW4cZDSWKT5wyDqg1vYzZK3hd2qq/ZNXIX9TnpL7akH4FaOE0dTCOIgOqg6hd8iuTQjJCTw/5eTbI3aHE1YBD3DPMEvFZbido2fPAGd7rIwuL19yZq8yGxBsMXPiE3YeDTKQOpZmge5htYISe9f1CCl0I4JeufZW9oA9kFCDdEZ7PPuqeR5w2XtuqCamiKBlvpX5MMmkr4ORvleVMhj4ZmIfErDeolc1XIZwc/uCoo/G+q6d6W2UqBsnJxG9hpRNG/rPdHQH3mFzMZeLgT27Ig== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB4882.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(83380400001)(26005)(186003)(2906002)(66946007)(122000001)(66556008)(55236004)(6506007)(53546011)(66476007)(66446008)(64756008)(38100700002)(38070700005)(71200400001)(7696005)(76116006)(107886003)(5660300002)(8676002)(4326008)(52536014)(8936002)(55016002)(316002)(110136005)(86362001)(9686003)(33656002)(508600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0ztEongGDacXRJxEedl1aCjooRHGOPppYxSAZaU1XUBqK+ke3Fl4lcfCpCO3?= =?us-ascii?Q?7YU3m8i3vBCv88VPiJSGhg4w9AIEhT64Vnt+plz4dwBMGdnQofbh8gA6UEB+?= =?us-ascii?Q?xKX96iYNVq5LR3aJo/1zzlCUkhMWZ6NMkC+S06QLyLNskCrtPusX9e+OfihQ?= =?us-ascii?Q?okJauvhTgxme4dUmhTpquBPgWtat/y26FUodiXzjG9I2rjcqlC4qZEpkjTJM?= =?us-ascii?Q?HMPQp4P8QDmyGoq1luStIFr3i772a++3lqcE1byJd/xBm1sSbXo1OQZUydfk?= =?us-ascii?Q?ETgs5eEKz7b8Ue9r6i5e1M5PZnF6QpyNfSoesuGWVYQyP9V3FgKrN5yJuTQo?= =?us-ascii?Q?19ia4jMu+wy2M2j0DVgSj4oEDf4k73zJ4628l6MCyr06OceNBi42URW7FV0Q?= =?us-ascii?Q?WPFl7ZgrmDT1LX0vVsaJHAwNrWNBHzUu6tq4Z7CtBu+065oOyVdfojAfZ6RD?= =?us-ascii?Q?TzCdrNkLlvN+WKFJX+vAMxJH5oWCdVcO18UOh5wGUQEsDX01yLRHw4jMppsw?= =?us-ascii?Q?PVI+uLnM3RqROBcYr4+j3k8MAyodYs3LOCi/QWPx+HOpq3CJGoSrR84br39p?= =?us-ascii?Q?R6pu5p1TMqN05txnVgrFgniOYeEkQamkNy78YnIMnD8S/gI7S44kuG/3HSO9?= =?us-ascii?Q?TwY+xTILFSGFjWmj/ldkptiIrwM6fV0lNqER+W/dcCbwQxQlyepWZ2Qx3wFM?= =?us-ascii?Q?f3v+/vZYluxE48cbqjMxR9NtUe/Vr7ZDqcx0c0oAxPrtjPJNpIyesedYri3U?= =?us-ascii?Q?cteMVXnsC4dxDfl/bjDENWVVRoDzHIKDVMDa7iv+B1GkOtA+RTJdoisateHg?= =?us-ascii?Q?hNV+DrTOphKoK2kxNKMBLAFcxIRwAX6yjH6evLKRPOt+XPqkMJ+P/ARkkV8J?= =?us-ascii?Q?1VinSf1Ig+2B6WjL5VozPs4/kuC6ektNUZ8YegdCp8z/ZHSbQJ+D6KsBefML?= =?us-ascii?Q?J8iKJ6bvyUlha83Ykl39vDjqgdadxYT6lGnykYyWkueMtvgU717p8mcgjNXi?= =?us-ascii?Q?hz//9wZz1OIrCExLvdM2O8PRfmR4I9Jl12SfmQ/x4Z6/rjC+dACawN70UGTd?= =?us-ascii?Q?yPjuI4Rrz+sZFqmYUvqo76wHje1pNYxlLKhFIsBQkcxCBDHATG9QZEuMdgRi?= =?us-ascii?Q?z/xlhg+axcXfW5vO+yhe3aes30UF9sBV/W2n05nt6ZEamA86kGrkpkbou+v6?= =?us-ascii?Q?2NAcsVaC9qgbMOzdQwpP/2gY+49D1B8vXwZl93sZ3BPBJK7n4StP3oAw2TgD?= =?us-ascii?Q?VewJ1XG0YrdhFmjEC5zcZNxVa213oJMHtS8ZJ9gB4cogqd5foFi4/Vu0idr9?= =?us-ascii?Q?h/FveUeUYu0KnbMHYsisZhYS?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4882.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2614625c-6e6b-417f-bd3a-08d9849b5499 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Oct 2021 05:21:32.1833 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yJgzc1BUinsu5nrBc00iH8lAS0o15ruk5637Xi4phEi7Tb87qYFbbQ9ojnV6MDsdLI3onOYSUFalO2MCL5mxD4TbMdZje9A1l5HMXxiV6j0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2126 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] eventdev/rx-adapter: segfault in queue conf get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Harish, > -----Original Message----- > From: Naga Harish K, S V > Sent: 01 October 2021 10:12 > To: Kundapura, Ganapati ; > jerinjacobk@gmail.com; dev@dpdk.org > Cc: Jayatheerthan, Jay > Subject: RE: [dpdk-dev] [PATCH v2] eventdev/rx-adapter: segfault in queue > conf get >=20 > Hi Ganapati, >=20 > > -----Original Message----- > > From: dev On Behalf Of Ganapati Kundapura > > Sent: Thursday, September 30, 2021 6:30 PM > > To: jerinjacobk@gmail.com; dev@dpdk.org > > Cc: Jayatheerthan, Jay > > Subject: [dpdk-dev] [PATCH v2] eventdev/rx-adapter: segfault in queue > > conf get >=20 > The commit message can be "fix segfault in queue conf get API" >=20 > > > > rte_event_eth_rx_adapter_queue_conf_get() segfaults if called without > > queue added to the Rx adapter. > > > > Added check to no queues in Rx adapter and error out on being called > > with no queue in Rx adapter. > > > > Added test case to call queue conf get without queues in Rx adapter. > > >=20 > You may need to mention the commit details which is getting fixed. >=20 Done > > Signed-off-by: Ganapati Kundapura > > > > --- > > v2: > > * Corrected typo in the comment > > --- > > > > diff --git a/app/test/test_event_eth_rx_adapter.c > > b/app/test/test_event_eth_rx_adapter.c > > index 13664a3..d0dc552 100644 > > --- a/app/test/test_event_eth_rx_adapter.c > > +++ b/app/test/test_event_eth_rx_adapter.c > > @@ -751,20 +751,48 @@ static int > > adapter_queue_conf(void) > > { > > int err; > > - struct rte_event_eth_rx_adapter_queue_conf queue_conf; > > + struct rte_event_eth_rx_adapter_queue_conf queue_conf =3D {0}; > > > > - err =3D rte_event_eth_rx_adapter_queue_conf_get(TEST_INST_ID, > > TEST_DEV_ID, > > + /* Case 1: queue conf get without any queues in Rx adapter */ > > + err =3D rte_event_eth_rx_adapter_queue_conf_get(TEST_INST_ID, > > + TEST_ETHDEV_ID, > > + 0, &queue_conf); > > + TEST_ASSERT(err =3D=3D -EINVAL, "Expected -EINVAL got %d", err); > > + > > + /* Add queue to Rx adapter */ > > + queue_conf.ev.queue_id =3D 0; > > + queue_conf.ev.sched_type =3D RTE_SCHED_TYPE_ATOMIC; > > + queue_conf.ev.priority =3D RTE_EVENT_DEV_PRIORITY_NORMAL; > > + > > + err =3D rte_event_eth_rx_adapter_queue_add(TEST_INST_ID, > > + TEST_ETHDEV_ID, > > + 0, &queue_conf); > > + TEST_ASSERT(err =3D=3D 0, "Expected 0 got %d", err); > > + > > + /* Case 2: queue conf get with queue added to Rx adapter */ > > + err =3D rte_event_eth_rx_adapter_queue_conf_get(TEST_INST_ID, > > + TEST_ETHDEV_ID, > > 0, &queue_conf); > > TEST_ASSERT(err =3D=3D 0, "Expected 0 got %d", err); > > > > - err =3D rte_event_eth_rx_adapter_queue_conf_get(TEST_INST_ID, > > TEST_DEV_ID, > > + /* Case 3: queue conf get with invalid rx queue id */ > > + err =3D rte_event_eth_rx_adapter_queue_conf_get(TEST_INST_ID, > > + TEST_ETHDEV_ID, > > -1, &queue_conf); > > TEST_ASSERT(err =3D=3D -EINVAL, "Expected -EINVAL got %d", err); > > > > - err =3D rte_event_eth_rx_adapter_queue_conf_get(TEST_INST_ID, > > TEST_DEV_ID, > > + /* Case 4: queue conf get with NULL queue conf struct */ > > + err =3D rte_event_eth_rx_adapter_queue_conf_get(TEST_INST_ID, > > + TEST_ETHDEV_ID, > > 0, NULL); > > TEST_ASSERT(err =3D=3D -EINVAL, "Expected -EINVAL got %d", err); > > > > + /* Delete queue from the Rx adapter */ > > + err =3D rte_event_eth_rx_adapter_queue_del(TEST_INST_ID, > > + TEST_ETHDEV_ID, > > + 0); > > + TEST_ASSERT(err =3D=3D 0, "Expected 0 got %d", err); > > + > > return TEST_SUCCESS; > > } > > > > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c > > b/lib/eventdev/rte_event_eth_rx_adapter.c > > index 10491ca..2a84490 100644 > > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > > @@ -2844,12 +2844,13 @@ > > rte_event_eth_rx_adapter_queue_conf_get(uint8_t id, > > return -EINVAL; > > > > dev_info =3D &rx_adapter->eth_devices[eth_dev_id]; > > - queue_info =3D &dev_info->rx_queue[rx_queue_id]; > > - if (!queue_info->queue_enabled) { > > + if (dev_info->rx_queue =3D=3D NULL || > > + !dev_info->rx_queue[rx_queue_id].queue_enabled) { > > RTE_EDEV_LOG_ERR("Rx queue %u not added", > rx_queue_id); > > return -EINVAL; > > } > > > > + queue_info =3D &dev_info->rx_queue[rx_queue_id]; > > qi_ev =3D (struct rte_event *)&queue_info->event; > > > > memset(queue_conf, 0, sizeof(*queue_conf)); > > -- > > 2.6.4