From: "Li, Miao" <miao.li@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Hunt, David" <david.hunt@intel.com>,
"Wang, Yinan" <yinan.wang@intel.com>
Subject: RE: [PATCH v1] power: add wakeup log
Date: Thu, 24 Feb 2022 02:45:09 +0000 [thread overview]
Message-ID: <CO1PR11MB490001E24A2BA17F9CFE5E0DEE3D9@CO1PR11MB4900.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220222080713.5ea7a07d@hermes.local>
Hi,
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Wednesday, February 23, 2022 12:07 AM
> To: Li, Miao <miao.li@intel.com>
> Cc: dev@dpdk.org; Hunt, David <david.hunt@intel.com>; Wang, Yinan
> <yinan.wang@intel.com>
> Subject: Re: [PATCH v1] power: add wakeup log
>
> On Tue, 22 Feb 2022 13:52:27 +0000
> Miao Li <miao.li@intel.com> wrote:
>
> > + "lcore %u is waked up from value change\n",
>
> That is awkward phrasing in English and should be DEBUG not INFO level
> because it may happen often.
I will fix it in the next version.
>
> Maybe:
> "lcore %u awoke because value changed\n"
> or something better.
I will change the log content in next version.
>
> PS: sometimes it is good idea to using grammar tools when wording commit
> or messages.
Thanks,
Miao
next prev parent reply other threads:[~2022-02-24 2:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 13:52 Miao Li
2022-02-22 16:07 ` Stephen Hemminger
2022-02-24 2:45 ` Li, Miao [this message]
2022-02-22 16:32 ` David Hunt
2022-02-24 2:38 ` Li, Miao
2022-02-25 11:19 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB490001E24A2BA17F9CFE5E0DEE3D9@CO1PR11MB4900.namprd11.prod.outlook.com \
--to=miao.li@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=yinan.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).