From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 418D145AA2; Tue, 8 Oct 2024 23:29:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C2A6E406B7; Tue, 8 Oct 2024 23:29:28 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by mails.dpdk.org (Postfix) with ESMTP id 5950D40656 for ; Tue, 8 Oct 2024 23:29:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728422967; x=1759958967; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=pNIvNBt2CB8W8pEY3lM2nacSAP3dOmix8/6S2vGFq70=; b=hcws2oH99swLu7deRziYdBkDMW7J31F8afKMNe4YWBRJXLhREp5xwZMK 5H67c+hUDAJkhcDu1Ww8i598cn81aFRTYDMNTy6mHzPoGkmg+xAIH/7Ma aJcb3Jc4MrXqL3RlbemNq7ZIqg7U2mDMQPVp69zHISJr5nfQCEL89udBJ DNMZtUkCofIXRsvJDkux4b2yJBQ0x+kHq8MJEV8Sv4CtyFN7vbix0aprR LlIzX+BtpXmPraJg0ZnLrY/9JLP622pNZ/7IPLBI6Edpu0U9zm37Jja0C RqDAw/q8QUm2aBRKTdJwB8lmWjOJ1PbGYBR8D8kGIhNXKw1AVSZxBMzbS w==; X-CSE-ConnectionGUID: ujHN7oURS/qEpxF8mTWZEQ== X-CSE-MsgGUID: nRTVlD59Rq2b4VrX1+erIQ== X-IronPort-AV: E=McAfee;i="6700,10204,11219"; a="27803334" X-IronPort-AV: E=Sophos;i="6.11,188,1725346800"; d="scan'208";a="27803334" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2024 14:29:26 -0700 X-CSE-ConnectionGUID: GI3cbYsuTkOARyVO9f5yAQ== X-CSE-MsgGUID: Rx9ui31DS3qp7FB1zs2LYg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,188,1725346800"; d="scan'208";a="106826267" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Oct 2024 14:29:25 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 8 Oct 2024 14:29:25 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 8 Oct 2024 14:29:25 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 8 Oct 2024 14:29:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YRTDDf5FNnTKM0MvkNkM/QW1DfD5QLoI3bVV62CNXlDkLasLrX6xog/qpgwChTNrvqptXb5NLaA/7CjY45etOdRF7XYo4ET9PxKdNiCtt5F8OJnQPoTc+GPXDCXLGksVQ+5ktzo4N4a/o4HQM2YZFMEzDlVmi9rHfxdzWP3GXtEBsd22a4XfODQGaqfqvQoPJK5Ir4kauIv5QDeqBnAa618iR9Oi7unat+icaaHJmq4eCwAPFIJvMc++6r14lGZfKUmUPozXIf7+OlZQRuCzJUAOx7i7z2kpBW5uA8iEkSQkOOldSoOqZDHbz5S9r6s6ULA9zNPBV/KhkHbzFQMYuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mrfdbugMPWB7F7yCMYMUMCKvxYup97Cr4NIGD8+8iDk=; b=kwFqub0kNScbjT8fKa5Vq2xL7cr4JBvFUEQ9gRMl85rPMDCEkqo3wFQWsblTYSMRmt8mdqXBH/RwPxlMaP9Fz/nY3z1mYeQ8ipki02aQ3NUUpLDpGXrOJm3oWzyA8M9IV88SbfFCq9FrJa87ewfNDJCnhZS67BuXonzjCeVD0Pls49I7WASAKsJqYx830aHiR1jbeyYn1py+d09acah7DWz99xR/zMs0YyLHR5U4KbzKViiuCM0qMaEdS3zSunNZ6F9lfw4gfyN1Y4kbG77iOzOTWEkXmHdB7uNrFVT66vfAC28+E+LC/zrKq9Kg5gf7VmgDR254b58OnShkSzlJOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB5009.namprd11.prod.outlook.com (2603:10b6:303:9e::11) by MN2PR11MB4679.namprd11.prod.outlook.com (2603:10b6:208:26b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8005.21; Tue, 8 Oct 2024 21:29:22 +0000 Received: from CO1PR11MB5009.namprd11.prod.outlook.com ([fe80::b03a:b02:c24e:b976]) by CO1PR11MB5009.namprd11.prod.outlook.com ([fe80::b03a:b02:c24e:b976%6]) with mapi id 15.20.8026.020; Tue, 8 Oct 2024 21:29:22 +0000 From: "Kusztal, ArkadiuszX" To: Stephen Hemminger CC: "dev@dpdk.org" , "gakhil@marvell.com" , "Dooley, Brian" Subject: RE: [PATCH v4 2/4] cryptodev: add ec points to sm2 op Thread-Topic: [PATCH v4 2/4] cryptodev: add ec points to sm2 op Thread-Index: AQHbGbh774UYoCO9qEOCxCPYlAbwgrJ9UtgAgAACOkCAAAQgAIAAAVDg Date: Tue, 8 Oct 2024 21:29:22 +0000 Message-ID: References: <20241008062845.11071-1-arkadiuszx.kusztal@intel.com> <20241008181433.57591-1-arkadiuszx.kusztal@intel.com> <20241008181433.57591-3-arkadiuszx.kusztal@intel.com> <20241008134626.282bf9f3@hermes.local> <20241008140910.1cd601e7@hermes.local> In-Reply-To: <20241008140910.1cd601e7@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB5009:EE_|MN2PR11MB4679:EE_ x-ms-office365-filtering-correlation-id: 4dcef58f-7c95-460b-25b8-08dce7e046db x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|366016|376014|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?eqCw/U4xfdjYoaFET9kLv+B1s6ZHZS+6hWSFO5/vKxPQ+hCXoUcIzTVGzIY1?= =?us-ascii?Q?8IfMECdWCR1N+buOtnmJy3+cB9cLbz9VAWeRarQ6TQ83N1NLJcNp0s8tETly?= =?us-ascii?Q?Tsc1EKfUWYH7qF/95DsQbku9vfIcrpxfphlPbLpdGowdiU9aA5CiWuul3B8s?= =?us-ascii?Q?JkgmTcQJCn5iOIlqAzi1jAiyGXWZVSLpf9Kn0APDTc8EB0GrsjtoTHRQ5n46?= =?us-ascii?Q?LtsajtKFoVO0CpF0Zu+K4dKNc9wmwEZFr/PlMSV5pQIpgczPWxE1ui1eBImF?= =?us-ascii?Q?Ve9aiw5Cay97j3giukg8PdV32H1JHSgBWeRfw1f19VD3HVw/rvoKIJFhOspL?= =?us-ascii?Q?2Nu8ImPpH7d4YpEeHlCQdBgu7bMORepZitDLx6BuV1Q0Ua83ltpZYzKK8pzJ?= =?us-ascii?Q?cefVhwmj7+SvXVqIrVoMdiyowW92dQeGS/16qahtlHO4iBiuaKuCTb6GKk8i?= =?us-ascii?Q?tyNn6WS3XN465VVxwVKGaaLneO8MujtFzkktQ53PMPN20xvWJqSlM7yBKM97?= =?us-ascii?Q?pqQ2JAEQ8R6SneIkY59DMFmuHqUFKNl75/EEx+8CwEs4Tz0zdOUuCPEGbCKw?= =?us-ascii?Q?o4lquPkA2T+MJ4150OnudYiURWA5vvzclTCl5lzB1PPBNX0kqMACnjwzJKfY?= =?us-ascii?Q?1DadAzSAwUag9m4MmfVjRXXdKIH52h0rXGYnN5koBzKcj3Umtgo5xEYPRKGG?= =?us-ascii?Q?w2F/bsRtazogk572WAzWtqomnEtVyx4Mp5GDsQcyjOLRJMw3rbi64NduJPLB?= =?us-ascii?Q?xDlZVKA7QNfP37I7UufXobpxx+wRldEW0jLN6IeJrRTYwqvcA62zEhICGQKa?= =?us-ascii?Q?8JxThESM81T1O5q0VQH/CTT5DAJzvGEYZlfIO+X2iElrbxqr31zNjpIFkArF?= =?us-ascii?Q?qUKCTE/lAy3WRnC1ThEKAeTUrIjxIsPEB0IjQlZgiPKRqOhvo3kJ+iSo/fR0?= =?us-ascii?Q?GcoVdYGdYZFKmubA1/PD41h+6rIRpSnQ4lVLibFigGwmePxvzzhyfVGbiGbz?= =?us-ascii?Q?zfa8i/p8Es+f4kVOPYx4KDDQL1ZSDLqHzU3jqlC7APo6w8+89BdNA8d0iMGU?= =?us-ascii?Q?umqV9dPudnexR4Gb4xPzY/Fbpv/QIjO+LHRsqdTVJaTKIJgQgdU3WHII4F63?= =?us-ascii?Q?CRkz0pHRZcEYdwWbhmXiA26tq2AgSH6A4Bk+/VyRzLvmPdN+kdZ8h4+oH7Nk?= =?us-ascii?Q?1IlQCoTEtLC0RCmnJv2QF83PMWMn/IRTsggD7Wmb1MZ3TJVZ1Uw7POrqLS5B?= =?us-ascii?Q?ltoaF6441iBfHRGg0sAg8Q9r6WVX72hqTO7ib2hnNUfdV74o3/hAqL5Oaazn?= =?us-ascii?Q?4Dl6ooNfiY9RbNQ2VOJZClmYyn27GYElui7HPR+XThpMSw=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB5009.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4BMeMm0utG5rtSW7XkhhyazX5fUqvMedu0rlHZzTS2I3g5qlVm1fPfoqw/f0?= =?us-ascii?Q?sVRZraZVwdwE8TKV+f3g1HrshPagT2bG1c6WDnAclV+0qF8E3H3uGyf+TlVV?= =?us-ascii?Q?3YbpIBBtMXPN7mVQDaqDNguGg2do8wg8uPqGt1ClseRhIQSyHcZW1XWL+y0g?= =?us-ascii?Q?eSS5pZPNrNaLqtekM/jjkCYlXH3l1dlJ4mzgKIoq2r067yoqlYR1+fWFMDpW?= =?us-ascii?Q?Vz8vPM5u9R1wnvVK65wVl+pvEaSuSkZOYkqCSdRbwgZda+02x+MWS5h8hlg8?= =?us-ascii?Q?cmuBbHRGMvrsHgNHwmQJtQP2/NvSPY20QFKjsvSGNzcwrlYXQXYhExY91u1r?= =?us-ascii?Q?C9WheQroSruhXvdoWuGKeOLyaDk3nl5E+epUorG5teB99WT1xcIdgbG6BvnF?= =?us-ascii?Q?1+pu3RG3rmCqE86AxxmgFtXLlwwwHRGG+sUozR9BtEgC1iRXn/AGI6nTjf27?= =?us-ascii?Q?a8WRy40pbOo5WttImPS4am0VjXYTJ/wY9Y5l5tCivsQdDWNbTzDVYp4IpLGN?= =?us-ascii?Q?BRUIaLB20MJY7qW+T9C4oGmnMpHBZ8ZuxL9d+TnQYtAql8MRVr24q5d97GXO?= =?us-ascii?Q?Tw/Agv0RjRzzmXGveMd9g3ZcCUMSErwwluqisi3dXeUdIGabToeIaBWKhxKH?= =?us-ascii?Q?hTIMiM3FCe7CucHD+IXMlYoQzAWQuIwmyl2WRvbewZoSloB213XfWk9QXlcz?= =?us-ascii?Q?iEkGZIL9HHkvsTuxkMUsoSJnptZ7mf9NFhDARmyPNNDtecWzNZsRSxcSEUbW?= =?us-ascii?Q?23fLc3xHmRIwVuXPDdx3nLzHzSP3EdNIX9lX769nghkFG+JUJgDnRXWmJXJK?= =?us-ascii?Q?dZs8EioQp5qoYDomJ/n4FXRzJBQ9NGpaneqB+RBvg1fiocpTXadrlUM0ux5r?= =?us-ascii?Q?KLEjAqafpybhonOSMUyxEutmQCinvRK7O+31NkEg8m4nUwAUuWc1XqMhYJpj?= =?us-ascii?Q?C0pYGX4aTGYnQzlZYWegOpEx2fC1JbZEB26Yx8SIZ8tipJm8prgNqParuncX?= =?us-ascii?Q?yo1bHPXpAh3SUeFjjwFMFQGYLGYOxfAyOPX+KoCME2r0AX4aFz8Qlgw7dhlm?= =?us-ascii?Q?tUndJZZNEB0mRo3lnW9vY5fqKN4a3AF0dloJzyDbqkB3My0AHAXK4D3FIA7s?= =?us-ascii?Q?eVzK22SAJiQCqAIiqA3JyXfIAb2QrxFWN1WiS1xdUGgkvh6+6hbHa3ZHomGj?= =?us-ascii?Q?yZut+121Gl4oXSE2jIxTMETM2DALh70LunEEM1KX4SUfQHQujI0SYXdZ02S4?= =?us-ascii?Q?0DH1aOrhlrx8n0fehzkpKQnjYDFdB4Q1m7HOeSiygH/4HU0GQdOU3AZkx2VP?= =?us-ascii?Q?GF3xOwkbgJOiBlh0gvnRCao7f0SJyAjOzWaTGveXC7LswWzjddsnqvTzuft4?= =?us-ascii?Q?nzLTX6FfmJX+X5VEnc5cDr94cHHicwMAFYywri/d1OY8e40dNbk40fpDC5gD?= =?us-ascii?Q?SyhEr2H8pRZcb6RkuMo2SHiUkm73mclfDQrHQChxxrnkRWfYQi0fpGGMdhtl?= =?us-ascii?Q?gqGibh4bA5vKWrfA3NZ1/LjNyLepZt8/5kslj9ZVjN5s01gl8kHs0mwVE/Vv?= =?us-ascii?Q?bVmLh5Kq6VbXJMte6i2ntp0AnDWrqIrvfvUq8thwf52DXaWCMdNssKkiWK6x?= =?us-ascii?Q?Ig=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5009.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4dcef58f-7c95-460b-25b8-08dce7e046db X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2024 21:29:22.7028 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vhrTIoVfH8pvUzt4WDQQP3Jv2SDGOTtqeZA8+keqR6a5rkQcpXYD5/hgTsiJXvrEqJyBAE6ARyWV7rx/w5inuHMGneTaXmXyTWmDOqIn/Aw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4679 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Tuesday, October 8, 2024 11:09 PM > To: Kusztal, ArkadiuszX > Cc: dev@dpdk.org; gakhil@marvell.com; Dooley, Brian > > Subject: Re: [PATCH v4 2/4] cryptodev: add ec points to sm2 op >=20 > On Tue, 8 Oct 2024 21:00:50 +0000 > "Kusztal, ArkadiuszX" wrote: >=20 > > Hi Stephen, > > > > > -----Original Message----- > > > From: Stephen Hemminger > > > Sent: Tuesday, October 8, 2024 10:46 PM > > > To: Kusztal, ArkadiuszX > > > Cc: dev@dpdk.org; gakhil@marvell.com; Dooley, Brian > > > > > > Subject: Re: [PATCH v4 2/4] cryptodev: add ec points to sm2 op > > > > > > On Tue, 8 Oct 2024 19:14:31 +0100 > > > Arkadiusz Kusztal wrote: > > > > > > > + RTE_CRYPTO_SM2_PARTIAL, > > > > + /**< > > > > + * PMD does not support the full process of the > > > > + * SM2 encryption/decryption, but the elliptic > > > > + * curve part only > > > > > > Couldn't this just be: > > > /**< PMD only supports elliptic curve */ > > > > SM2 encryption involves several steps: random number generation, hashin= g, > some trivial xor's etc, and calculation of elliptic curve points, what I = meant here > is that only this EC calculation will be performed. > > But when I read it now, I probably may need to add some more clarity to= it. >=20 >=20 > My point is what developers write tends to be overly wordy and redundant. > Comments and documentation should be as succinct as possible. I agree, I will change it to the more technical/precise.