From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1966DA0542; Fri, 18 Nov 2022 10:59:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0AA254067B; Fri, 18 Nov 2022 10:59:09 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 772D44021F for ; Fri, 18 Nov 2022 10:59:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668765547; x=1700301547; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Fc1M0m+jVYikicH6jaoLtb0In+0ZHd247xmiIrGujD8=; b=cSrbgI+PpZ9RoxS0/hiG9Xoh5w9gWxBpFi6QlRm8tIOGuqJUoXOnMAfu pGxa2VVmFToM6w1a7D1tF2k8K6ouin9YPf1rCnb3gzg/Usdzi/1nXpiQS WJ09kPylLADOfG78Ziz2aq6bJsftv1TngX7ENt6QeQDBCxuzMiWezaR5W s1gqvCIZrG1H+co00WefvrqsgY24VR/71GyrfIRb0Kdew9h0+eIykcF9i k7gE21oDhLJTQ7VBvrGKjVwmo+B7qdd8F5JA0rU5JvMAB0C69roOLoyqf /7irL/R3AJs4ayTJKnHT9ugR7943lUrnUIDBweUcrvGl5+s3YEb/4SSx5 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10534"; a="311806181" X-IronPort-AV: E=Sophos;i="5.96,173,1665471600"; d="scan'208";a="311806181" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2022 01:59:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10534"; a="969226778" X-IronPort-AV: E=Sophos;i="5.96,173,1665471600"; d="scan'208";a="969226778" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 18 Nov 2022 01:59:06 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 18 Nov 2022 01:59:06 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 18 Nov 2022 01:59:06 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 18 Nov 2022 01:59:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LYh6BTcNeGpik19rWIQQfi8l3Xq8gTvKFsU32DdDLbHiAvWTmDSfWsZxoY6KKzK82zeuzOtc6S6T+8JSWaNah6+HxCifPLi05wsYVU2kC80Hlu9xxO17s6ymtFxvUfieMPaY86Nk38IOgQbwB84O1pa+MC5UJX3MtwFu/KJ6QgU/JY3hwfaVap8CB3IRtZbhzsLfcjUC8Lgrgj40MetZ/Zt9TRyxrbKNm9kz+SJZ14KciO98PghXKBqU1UjJSvjBllK6venhinz1Bx5Pm7J2mksGDschqV6XHo2QIbDEnS9FDPfys8tDQGx/Divy+JQ1kV3YVVUuvSAoq1/l77Ttqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fc1M0m+jVYikicH6jaoLtb0In+0ZHd247xmiIrGujD8=; b=e3El0aU1ClPprwXB+ftyZwI+NHB4NxNN5bTFMw6vr9nzEV1S8Ac6ySYDoUxFcRYJ5vU0w8/HWB/kqOUAN45c9WftNtNofeRv182stHmg3+GSdMEedImJsuCkxZQdFqZr+ofLYR36+eM/Z9tdu/xlTT8Q/lg6GnlyRqpkv6lx4nS7r1VPcLESPNFGC/bw2GYhJVpvW8VCGxWd6+N3m0Z9mpZdfAutP7U9YNQIejU5s6u4Fo9B4pNZuSHfhf/XSyY0h+ZhGMixjkg6bjxVVyJXaahRuIt69Z9wPTvdjzciP54cACeXa7oF15+v9lgYQpeEkDpdqOAHstQwwhG290Rx/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB5058.namprd11.prod.outlook.com (2603:10b6:303:99::17) by MN0PR11MB6059.namprd11.prod.outlook.com (2603:10b6:208:377::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20; Fri, 18 Nov 2022 09:59:02 +0000 Received: from CO1PR11MB5058.namprd11.prod.outlook.com ([fe80::6769:3d2c:f872:3c89]) by CO1PR11MB5058.namprd11.prod.outlook.com ([fe80::6769:3d2c:f872:3c89%4]) with mapi id 15.20.5813.019; Fri, 18 Nov 2022 09:59:02 +0000 From: "Peng, Yuan" To: "Xing, Beilei" , "Wu, Jingjing" CC: "dev@dpdk.org" Subject: RE: [PATCH v3] net/idpf: fix crash when launching l3fwd Thread-Topic: [PATCH v3] net/idpf: fix crash when launching l3fwd Thread-Index: AQHY+xvN+JsfoVIAkEmLs5Eo55gHAq5EcMiw Date: Fri, 18 Nov 2022 09:59:02 +0000 Message-ID: References: <20221117101509.14472-1-beilei.xing@intel.com> <20221118070246.114513-1-beilei.xing@intel.com> In-Reply-To: <20221118070246.114513-1-beilei.xing@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB5058:EE_|MN0PR11MB6059:EE_ x-ms-office365-filtering-correlation-id: c9e3d0ae-fb9e-4d8f-0b75-08dac94b8580 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: veChRTb8pE2fDY9uIS/4q5LZRlr05UB3aYTKVlPhdVc9cAmh1WS3Xf+xIMfXrMPaAXRoSYLJ+NutLydTvoK9Lto5bYADhfb9+Zaw644NievYlUvrnQWMHp0Jb+BKTlgUcqN6D6eNIWIWEbX4ossIiC5ZQVLK4EIFdngaga/aj0H/VPUP6Ksii9e61pJW2msT+wlik9N/c4PTI+PICPBt736Zv2apmqFtMcWeeyaLLNEOZQXfv4bctIATVXW08eJI/+Vbv8V9RKsPikfKpd+i7JYEaE7NE/QHZKE74PTq2ksSDPuiT9oMV8xMfHMarU4dEQAObYDGH7eAHkBpHmOKB5WlHkCr/L6Hae2acRmnWWCDLiVSV3Zdzm8Jc9QJb1n/+tgsP4S0x4KmHb2yLT+BPgk/SiamvRS5+xgxZQCwxVf5VS0nbbEdgKZb9t9esoFs1bK0yph8wYnOnzSMXjpnoCpBpyjGyDUQ3BzLJZpiCL31xZPSiRFm9aFw3AaYg/BJwVr2yhN1OdPAJecesfdFFKGHHQ9aYlPUHw//yVH51kdPI6DPQMz9cwQ4a3PhIGqyS/QDoFihyZPxXYlbg3Y1ypjZgcZrqAOVVLz1TzeE5130KP/TiM9gApVB1/2XppZWNrrsd9KsagmlIR/daNvbJZpBGPatgGOmEcYhoofVzpTrF3esaSjTzj0eUG362OKzlwmDreWwS5VhcqLvVoXpYwmp9vytaAcn/6bC2cWE4WQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB5058.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(376002)(39860400002)(136003)(366004)(346002)(451199015)(41300700001)(4326008)(76116006)(38070700005)(122000001)(8676002)(52536014)(4744005)(83380400001)(71200400001)(8936002)(316002)(86362001)(186003)(6636002)(55016003)(5660300002)(6506007)(7696005)(9686003)(66946007)(38100700002)(64756008)(66476007)(66556008)(66446008)(66899015)(82960400001)(110136005)(53546011)(33656002)(2906002)(26005)(478600001)(32563001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Aq4FCQrHxFZ7xvLcXAh38h1//6VyXBKF5z6nkUB8qgIjSsTlTKEqg19p2HHl?= =?us-ascii?Q?TTqBTrcqI3ui/Am44iUge1YK4FWaGwMMq2qqUeohYxUqBnD4AV5x+92oc6sY?= =?us-ascii?Q?RbBeXutDb/dv9X+U4sEDAfE95KhEXH35dxMtjbMzXDmE4exdX27h9otWe1Fn?= =?us-ascii?Q?pSWYQmaUUFiHsH5UtZHuhx58/jwpZmul8VO1AiWHVE17dlRz5JGxqqdm7I47?= =?us-ascii?Q?omY2jcLn7utIY97/YRGQ18ic0UUe0C/dHzBzQ277kh+JHYYhTZm1RWzPUBMo?= =?us-ascii?Q?GcZcLXLPuyA2i8gyefBp3QAm4Zkow322xTNRC3jz8j4TOErtddKGRJKI7d+P?= =?us-ascii?Q?f6dbVdkVytowNY/BGV/ReAt24sTi0Kszm4LGKz4sx7YdteV8q5nJEWZx+Epe?= =?us-ascii?Q?nU8jY5sinJnoAjuJ0G9L1ONk9wYgrWt0hL+5kwSDpNqQjLoSILBiWDKVbRAj?= =?us-ascii?Q?qPWFqioL/sOvkjwxx4eZTjrPjWZrRb5khn+4P3qxC9VHUs4+oXj/XohK+imW?= =?us-ascii?Q?yso8y2naCMd/sbgRP7J5w7hphd5J8d0uKZcViC8m+EjGdp+abK6SP2JjPdTS?= =?us-ascii?Q?91WXMHZn87himr203SmLleAscLAlpj0K+3wIhcZKbOQoyju5bzclQ2jzA4ei?= =?us-ascii?Q?/egz+/jP/0n/k0HIKoS86EFij7Tn94/O239sOuIlGNE3oeIa4Nfzc6p8BqdA?= =?us-ascii?Q?TZDw8YaquFiHML+iT2Zp2neJ6uv5ayiYfEB+XqJxjisF56Y8apNsAsaoqZMQ?= =?us-ascii?Q?C5cpxRlS4jS4z/QgQbOVmMg2h86bDQKbbZbTaRRUZbX6iJRG6cLIIu47elZ5?= =?us-ascii?Q?3F2/WfZopfliKPoJMm4kjasGvqgZRvaLGFfFFiGOWlmi4ep0By66oLaErmCG?= =?us-ascii?Q?z3lON8lRvvuCchEhm3dRRfCEYzo9ikEn8MgZFN81Exq2BlvZ90N19WPBjgUU?= =?us-ascii?Q?PPdXShGvlPdGCOAhQGt7i1zInQMGCPcFvUQXnXuCGQIefI0jQaSevqezlHef?= =?us-ascii?Q?oLJvmotYFcYwbNVOdwoGBLXq05U6cz8IhZEwveULBRhkTJnuGH6IzF/ejGHN?= =?us-ascii?Q?cW/VZV08vuoLso1dqw+LkTuMxxCiVlpXJ8QINsqdjrXVUfUbXGLdghgttROJ?= =?us-ascii?Q?KpF0I1IfhOxWI1Bc77Cjh2lBlXRDX8sis3IqxKHS9UmhGwyLj/oCyNdVkrv5?= =?us-ascii?Q?3L4fEY4YKEKoCZYSIrF7WPjxeKNVFHX9PVgMHpo456BYpWfQpL34Alv4yqPd?= =?us-ascii?Q?FvJjVMyaM7SOIFlYBHYWaUgpVQmaydtwKRd4TIcpum1sVZqLDJ6kPq/QP1nR?= =?us-ascii?Q?HpmrN3/4i5njTCB2StESc8KOy4fsNJJDYJD+x8oB5NBTPdjfS16quXaaDBdC?= =?us-ascii?Q?zytIKhxMhodCdpKOo4uGBCM6qaT2ZB6NFBB93JrTRSLDuAHJ8HREaaScU75i?= =?us-ascii?Q?lpZnXEhocAMN1gupz6c+ENkqrNiggIjqqXW8wzvbbmNS+3lCoGRqir0nQ62N?= =?us-ascii?Q?540WyasI+tVsMhZbUIqmHQn4HWQSQ6ESD7vNwoPLgjy6aesV1fT1PVzdaCYo?= =?us-ascii?Q?yn1ITHY+bQo1fe0dNLIiClIyyBtZdO5UB2i9PxbU?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5058.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9e3d0ae-fb9e-4d8f-0b75-08dac94b8580 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2022 09:59:02.5525 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gmYRlQ3YKPUzeB/awJjUkOjmymgvA9YgALbzy51h9A8sk6RgE+tPBQ8tSgbI+xSm5Y4kipU1KJgCkYDo43dXjw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6059 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Xing, Beilei > Sent: Friday, November 18, 2022 3:03 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Peng, Yuan ; Xing, Beilei > > Subject: [PATCH v3] net/idpf: fix crash when launching l3fwd >=20 > From: Beilei Xing >=20 > There's core dump when launching l3fwd with 1 queue 1 core. It's because > NULL pointer is used if fail to configure device. > This patch removes incorrect check during device configuration, and check= s > NULL pointer when executing VIRTCHNL2_OP_DEALLOC_VECTORS. >=20 > Fixes: 549343c25db8 ("net/idpf: support device initialization") > Fixes: 70675bcc3a57 ("net/idpf: support RSS") > Fixes: 37291a68fd78 ("net/idpf: support write back based on ITR expire") >=20 > Signed-off-by: Beilei Xing Tested-by: Peng, Yuan