From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB1D1A04FD; Fri, 29 Jul 2022 12:14:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C382C4069C; Fri, 29 Jul 2022 12:14:59 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 8642D40151 for ; Fri, 29 Jul 2022 12:14:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659089697; x=1690625697; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=bWAoxmoYEhujuGIkdoa/Oh27B+DrtDSCk1GGciCxSDw=; b=SkoD5wCCohz9BESWxxXQV9SMgQhJ+fn9oFQ5aK0QQIC9cMwQ+MQBfHPB sYUgOvsnIrvvG2cF5G7XbF7SFnInplNaxSX5OxzASZniTfJJp/TTJ2Deg mRPdfqaD5ymMbXyHeUOrsfFA08rQjlpVTwNqAEsciT48UYQeB7NU0dDwt RiatJRM0CwYRTXkORHazfeCiGPPS1F9Omy5GNebHkY8HqXES9E1YoZhpU s3YsyEKSs+oTZSLuxwIm2/zZQZ9h+8sQeOV2+NFQXXIt0DpUBd/msl8io ww172e9ZH3KwU1ns5+iit2zTvQpHnLD2PZ1+QMuLKGPwJXvMTk6QXzf02 Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10422"; a="352737413" X-IronPort-AV: E=Sophos;i="5.93,201,1654585200"; d="scan'208";a="352737413" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2022 03:14:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,201,1654585200"; d="scan'208";a="551691189" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP; 29 Jul 2022 03:14:56 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 29 Jul 2022 03:14:55 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Fri, 29 Jul 2022 03:14:55 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Fri, 29 Jul 2022 03:14:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AkdvBEpSwyoAfYHKWIN4/hZxNYcSy3ZL72I+BA9WDGuAsl2XcTGobPYtGOUG5/THNXCeB5ZBhwpXPURGDgkce6ASMsmYk0vKXdcq+a/v0D4Y526TkRgtmpWwvgYTZt0eS63Z4pJVjxi2CojyeYnZWdWbnn/Ok3FqjfaaZJ7Yx1b9p9gxYUqO/fJHf3fyxso7MjY2LETctDHaZHWr3EFFIxEq/C9VxFrTrJn8JQze1427tOZkF9pq3T9FJJVO8nfwtFx8Wpr7zVFNNyCS79Rk8ENXBQiYOo2/vcHvx6I1/2nkHyNOYU9nGBl3LiYQTAeq9PFiL+T8y7lM7F0FkTkHFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TShNeqYDU995bEHj9s8cIPIj8+F8dmzMI8VhEvgsig4=; b=KJLDetD8T10jDx/GguvSHFoU3n6emEKN4qV2jhpIBbR6DbDvyn6EoTGGv5qwpp7s6EUfW7qLlTiQRKewTma/0eCOCnd4e7CM2ufi6HxOVoDQxoSLc3+BXQ6dI81G1TuI0mn+xmZRJSj28tHbm9ACL2cKxyRhBw2TntPqDfA/oYWm1mxo7BtCPG3XQR2QYCYZtBEV674QCD/bw/KaMwb9nsajK+hHZwgKFh0/l2Lv15+g3s4fYOCOWyfcyrv4Zlo9X/ED5g1idhRkni+aeT04ikH91mVlbN5qiG4vzvTZp2P41y8+qkpIrL2zHHgp5s8s54jhvi0Mh5phWc4/y8uqCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB5105.namprd11.prod.outlook.com (2603:10b6:303:9f::7) by MN2PR11MB4253.namprd11.prod.outlook.com (2603:10b6:208:18d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Fri, 29 Jul 2022 10:14:53 +0000 Received: from CO1PR11MB5105.namprd11.prod.outlook.com ([fe80::2dc1:333d:62e7:7f30]) by CO1PR11MB5105.namprd11.prod.outlook.com ([fe80::2dc1:333d:62e7:7f30%4]) with mapi id 15.20.5482.006; Fri, 29 Jul 2022 10:14:53 +0000 From: "Zhang, Peng1X" To: "Zhang, Qi Z" , "Yang, Qiming" , "dev@dpdk.org" Subject: RE: [PATCH v6] net/ice: add retry mechanism for DCF after failure Thread-Topic: [PATCH v6] net/ice: add retry mechanism for DCF after failure Thread-Index: AQHYkQE7dvP2l4X5GUO7bRes9itmxK1yeyaAgCLIu1A= Date: Fri, 29 Jul 2022 10:14:53 +0000 Message-ID: References: <20220706141709.7681-1-peng1x.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a7037803-d266-451d-725b-08da714b2de2 x-ms-traffictypediagnostic: MN2PR11MB4253:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SXEHYjtNbRV3OFIFTE/r5msL/MF/OBwekRFDtG7tHNFXKQ+1WMMOpqdgXDJuJ++hacj0d3pLYJjaD8uhfudi9w8bah6xccuGzX55yUhESbRU0/xyXPVMZvba/7VtrKYqK62VUfkxVCS4GTrZvEUsWoSXST4ezmqpglxn+a14HYcjvihJD+W5LZiANov6nHKcVJpduq5VpfVG3fSDIqXaWtJEmG0C82BHjJTRGvk4nzrLfoL9LlCmr6lFASBbzBeIcLfNajEEd5ZIzU9jO71sySYgSjKOhtH9XAA87s68iW9KrSAoG+M8gOOOv2bO2XCE4INYAMTAAOEkHrN2s213HjBCR1QU5uBvDmC6/pVSMJ/cISK0N32BRlTGI4iMDVtBUokKb06Hwh0aD18Ts6EgqJa5ueKBQW3JozwZ/9EqmD7j2CKqp+VkCN37XK2moVt+1HxIEfh9tITRdCgHUk/jBSTCbJYYObeblnN2IuZwlR60YkuuD2jtMkxZ7upyX0bcAqdFvtEWquLnShvmiFK1xcflwqI1hBtiUAj417lM+bFdvZvcfl7Mj19AbbDxoercf75lz1bnSAbAxupMlRdGGTZZYPSZSdL7URyjjqTRLqO+XXnjuW+Aeh8wC4MBZe4WXpSLzA4MjdBx4/jhIWCuBL2XmWWJPMYLAcMdJWH9m+CKssJ9vikAOSgY5epmWwUQ+GAjYC1Z5cGiStAL4zXDcjiGx6EK8UXT8BD1SCvzuAz1xQoAxd4z92JfTk3nbEPuTm89lyRCEq4O9aEe4J4WUituqXyzAHAuBm1GzD6xyYVTks+/4vyBGCjWCYB/FeHE x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB5105.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(39860400002)(396003)(136003)(346002)(376002)(110136005)(41300700001)(53546011)(2906002)(86362001)(316002)(33656002)(64756008)(66556008)(8936002)(55016003)(8676002)(66946007)(478600001)(5660300002)(76116006)(71200400001)(122000001)(38100700002)(83380400001)(186003)(26005)(66446008)(9686003)(7696005)(52536014)(6506007)(38070700005)(66476007)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SnbzGF5PMcPaYwGfkB4Gn7YhgYy2zfbN6YnTp8hpoOhCsUfu0h9Kc7VG5JHa?= =?us-ascii?Q?q71vemYw/OAzY6fcpo0AWjyYMYEMPLR8X8f2nWtrdV6LQo6n3oo1FfFlBwZw?= =?us-ascii?Q?yz6yVpl+lsL8lF6mSqqDYSneFnlmmYfFzKtNUvzUH0MDB0HZ9Xhns+QB3Xjy?= =?us-ascii?Q?Nj0Q0TdCeb0lVh8ylDxbP68XJBEERzY04oqrCgNPx0RzGMSgdvTgKFrHPBg4?= =?us-ascii?Q?YVONx2bY04h0q3fYnRy59pYj2WNWa3EBqojxDpMyImagXvL2QfMimZKqMJqY?= =?us-ascii?Q?9wDSMJU6QzvwKo7ppIMGJV+CtAQaaHtdAOl2DKEsEir2gxYy9edRAKFIEApa?= =?us-ascii?Q?UrwBTeDvdNREoEBYz8ILw5hu7biRXmvunBqxCOXmabDxmqGWIKebBdij+x1W?= =?us-ascii?Q?WN9AbuTZSr9zVzZP+udxd5zx5sg4feD7JWafKNlQ21kCbd8NtGMWE/EZa92X?= =?us-ascii?Q?XMcXSj5rsv5/dH+zzwgj8fgcT3egeBzA6Wus8WM9iAgrPMDdkkSHdZguEjY5?= =?us-ascii?Q?oG6yapGVB45eArRaKC+uxiLR97LYmUvXzIsOg+jmthZ6zXVL6HG68A/EZ7IU?= =?us-ascii?Q?8dTtkJqgj5s013KpANPA9fpVbC0Sh7dpY1dOqaax9IB1cphMfh/vvlT64lco?= =?us-ascii?Q?DwaikrO5dt6tqMqoNNii+CPwa1btYiOLDm7NZ/+BwPYgLaewYtdELg2n0kuL?= =?us-ascii?Q?XqtjTjF66PsA4ZeQ3spRgbqyfOSm89kRaophPMtVRUrqwynnXgFy9NrzMBY7?= =?us-ascii?Q?bFiQhQYk8B+WnMpP4bVoNL9oFAhjis9evdHA3xwzF43j3Tzyd8HofJpfCifx?= =?us-ascii?Q?BrAcfS3nOuVCHhFAL8x/C8XMa8nPvfodF+6thrRWx+00HWZQ2nV0ufJvgFnh?= =?us-ascii?Q?iyeGN+tjAvLSQCR6os70p5YKrNpuj84OWo6IKy0C5p/jG+eQ0kfsk7vxItJ9?= =?us-ascii?Q?9LEhFC8S+SqNokVsocj9PZvnblK93yc3p1yIaGA+KucczmSye/pJfXCoa6WN?= =?us-ascii?Q?2dCOkENpDM/O3aNWIOP9pmmhDjJESupUMtSR1c1Ccli4u/0q8ky0kZ0zGQh9?= =?us-ascii?Q?dz8k4hgMaQWee2LVf4LcwgluYrFwOYavgSlBYoz36qa1p8JpIWUNqmzrGaDQ?= =?us-ascii?Q?PBo1ZCFH42q/P+5t7Pu2bbzo+YgCKr1qnMaHpMpqYDqnsBC7PdCQibKc0pfc?= =?us-ascii?Q?LYesAF3RzgYjHMVGJ0j7Vj1E2w1EYZ8jSvHU7+/v96FSjzyKMRKTEgZNWEGF?= =?us-ascii?Q?JFnH8r72QIFHyon7EC5AVLkqAJowKNIL9cGpgP4HlP/UMKMqie2fEqi2b2NF?= =?us-ascii?Q?6VTg/2dLZYdIXfZ+qy0CosD6GbPa0PbaxlRqzgYbSA4XvaoI99doyDVfUWVB?= =?us-ascii?Q?mqN8OAyzAls1MP4kDaYsBJpwE3IXm2RoSJybFDcWUyylSNYC/RAnbAiFkCTN?= =?us-ascii?Q?RYOv0Bj8g0UcyD3JRvs1OTLcX30idQpfX/2ikgkj34apQcVa8hV3fvIQUdln?= =?us-ascii?Q?2NwVZe9O7n1gco0RHuCeUG+fMHehAC093Zh/xlqai2GMW4lp/yXMhSDmGBTr?= =?us-ascii?Q?AxwodZa0ltpLoCbfHY4YevsjbcAOgifE9HO7YHkn?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5105.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7037803-d266-451d-725b-08da714b2de2 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jul 2022 10:14:53.2491 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5Zo6pxQRRvWguik6briZ6zG2BPHFjkuuA2TeWrAT7vC3WfcsT2KAdpXqH1jtUiS8b3ZRMgVifvHZTu6nAb5Pcg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4253 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The error code 'VIRTCHNL_STATUS_ERR_RETRY' is used in kernel when DC= F state is busy or pause. If DPDK receive VIRTCHNL_STATUS_ERR_RETRY from kernel, actually in 'ice_dcf= _send_aq_cmd' function the error code 'VIRTCHNL_STATUS_ERR_RETRY' will be treated as 'IAVF_ERR_NOT= _READY'. > -----Original Message----- > From: Zhang, Qi Z > Sent: Thursday, July 7, 2022 2:56 PM > To: Zhang, Peng1X ; Yang, Qiming > ; dev@dpdk.org > Subject: RE: [PATCH v6] net/ice: add retry mechanism for DCF after failur= e >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Peng1X > > Sent: Wednesday, July 6, 2022 10:17 PM > > To: Yang, Qiming ; Zhang, Qi Z > > ; dev@dpdk.org > > Subject: [PATCH v6] net/ice: add retry mechanism for DCF after failure > > > > From: Peng Zhang > > > > The origin design is if error happen during the step 3 of given > > situation, it will return error directly without retry. While in > > current patch, it will retry at every interval time during certain > > time if receive designed error code 'VIRTCHNL_STATUS_ERR_RETRY' > > from kernel. If retry succeed, rule can be continuously created. > > > > The given situation as following steps show: > > step 1. Kernel PF and DPDK DCF are ready at the beginning. > > step 2. A VF reset happen, kernel send an event to DCF and set STATE to > pause. > > step 3. Before DCF receive the event, it is possible a rule creation > > is ongoing and virtual channel command from DCF to kernel PF is executi= ng. > > step 4. Then result of command is failure, it will lead to error code > > return to DCF. Error code will be set as EINVAL, not EAGAIN. > > > > Fixes: daa714d55c72 ("net/ice: handle AdminQ command by DCF") > > Cc: stable@dpdk.org > > > > Signed-off-by: Peng Zhang > > --- > > v6 changes: > > - Add retry mechanism for DCF if receive designed error code from kern= el. > > v5 changes: > > - Add retry mechanism for DCF if the result of sending virtual channel > > command is failure. > > v4 changes: > > - Add retry mechanism if the result of sending adminQ queue command is > > failure. > > v3 Changes: > > - Add the situation description, expected error code and incorrect > > error code in commit log. > > v2 Changes: > > - Modify DCF state checking mechanism. > > > > drivers/common/iavf/virtchnl.h | 1 + > > drivers/net/ice/ice_dcf.c | 32 ++++++++++++++++++++------------ > > 2 files changed, 21 insertions(+), 12 deletions(-) > > > > diff --git a/drivers/common/iavf/virtchnl.h > > b/drivers/common/iavf/virtchnl.h index f123daec8e..e15e3a4439 100644 > > --- a/drivers/common/iavf/virtchnl.h > > +++ b/drivers/common/iavf/virtchnl.h > > @@ -49,6 +49,7 @@ enum virtchnl_status_code { > > VIRTCHNL_STATUS_ERR_CQP_COMPL_ERROR =3D -39, > > VIRTCHNL_STATUS_ERR_INVALID_VF_ID =3D -40, > > VIRTCHNL_STATUS_ERR_ADMIN_QUEUE_ERROR =3D -53, > > + VIRTCHNL_STATUS_ERR_RETRY =3D -63, >=20 > Where this error code be used?