From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5FA6342A12; Fri, 28 Apr 2023 09:26:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F91442DA5; Fri, 28 Apr 2023 09:26:53 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id E7B8740EE1; Thu, 27 Apr 2023 23:18:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682630312; x=1714166312; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=xrQ2qJrTJ2lM6RVCArhuUh0CtOLX91SBD/mEMm4D7xg=; b=Ipodl5WCy9bhP78KukzgsXvx9XZGBHm5jl8PZyu77cWmCeJsd5DvwKLO uUe207dxRj7EXxnFqP1XlgahBSd43Z/6FMzJDsFj0RxcA3q0ZWxkgq849 l9UXW3DGJh6osN3Dw4BUeDdw/Y/0QXBKil9qf1CCJCESgrYgV6LjOz9Ma ZTpjhavdafw++fDWMhxZVP6PqqU54uLtxQIQHeIpQWGo5DjRT6zH9tShK b6oLoVvbFiZJHAo/CNqWr4dShnvlRK2JPjetYTS3GoOjR1Zim/XMTmpbs 20ZYXY6KAyjh6KIEm0SQnHF3iXyYTZ69YmCbOLUjFDYjXC48xUk0g0Tb4 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10693"; a="347594526" X-IronPort-AV: E=Sophos;i="5.99,232,1677571200"; d="scan'208";a="347594526" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2023 14:18:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10693"; a="697252761" X-IronPort-AV: E=Sophos;i="5.99,232,1677571200"; d="scan'208";a="697252761" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 27 Apr 2023 14:18:22 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 27 Apr 2023 14:18:21 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 27 Apr 2023 14:18:21 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 27 Apr 2023 14:18:21 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 27 Apr 2023 14:18:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Io4QkdTyspVlsau/K+obXHFGKv8ne2UHt70i5CsV2SmnzxMJ7y6SUwImDSVKRsCzaeTcSkzWd8OCW006Cd7IFPtga8CrN5ij1cHpuFWAdfMO9ssbGvblLmUoFrpw9YwN/7wkejsawasJ1HL8GLcWXtQHSXSYWuHxaOKxbN5nRLj4moWnTA8yhJJ/577sKga/0DG/EVLOqdOsaEfJu976Kgdtz6/3tO9aohXZb/D2jPqoo92ij0+xJYc5RT0dftPPI9HPjd0Bujh85c75RI+Cjnn2LoP/lMtjIYZZclnIOySQHfBrlJXoRgtbaC+yQdF3+dQqSnYWRTlCGv1BDD5d5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dpsv/r+3yTM6pMpexrDCsmsdsrqZQdhHEZPqCjiJ5sA=; b=DWFrbUn3IlNEn7GvpZfdumpkoBMm9/jSAYO0GAsOYPbb+U3qdFRKZ0ngV2ng8bx7/06kgJVJqg/Ez4T0dwC/lm1cQWhiJvKx6WRPQjUpsxEKxRdercxObeVSFKwsO9l1nar1iEJFZicmQJ5etGyVbrdYWEOBBVlEIdLo3XykcRNRz2RT8jyOO8KIzTZVeekECWezgE31RZ/icOQOL8tFg8Kt/17A8soNqJqovrLrYH75W6GduWGnMx5/bRwtxUs9m9Wm3iGqWTpzFWfz6WHcn78RM9RRvZZeCKKKY+TpkOiI07AlQmtH6aoccpVS3CX/41JckaxLe2yvzr/qK5AnHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB5140.namprd11.prod.outlook.com (2603:10b6:303:9e::21) by DS0PR11MB7312.namprd11.prod.outlook.com (2603:10b6:8:11f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.22; Thu, 27 Apr 2023 21:18:19 +0000 Received: from CO1PR11MB5140.namprd11.prod.outlook.com ([fe80::fca4:4471:b9d2:72aa]) by CO1PR11MB5140.namprd11.prod.outlook.com ([fe80::fca4:4471:b9d2:72aa%5]) with mapi id 15.20.6340.022; Thu, 27 Apr 2023 21:18:19 +0000 From: "Greenwalt, Paul" To: "Yang, Qiming" , "dev@dpdk.org" CC: "Zhang, Qi Z" , "stable@dpdk.org" Subject: RE: [PATCH 30/30] net/ice/base: fix Generic Checksum acronym Thread-Topic: [PATCH 30/30] net/ice/base: fix Generic Checksum acronym Thread-Index: AQHZeNLskjZO8b5wEUayGj04Fb6Q268/pvSg Date: Thu, 27 Apr 2023 21:18:19 +0000 Message-ID: References: <20230427062001.478032-1-qiming.yang@intel.com> <20230427062001.478032-31-qiming.yang@intel.com> In-Reply-To: <20230427062001.478032-31-qiming.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO1PR11MB5140:EE_|DS0PR11MB7312:EE_ x-ms-office365-filtering-correlation-id: 73af4d5c-81f8-4c44-2734-08db4764ec8c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vHmw+keehgK2AWCNmtZsyIDt5hxfkHzOZ0YMgfET1jVzghm6e42kKMmkzK/pT0E85/KrMEDcfuIoo+OtTdi35H1Zcml7NF/o+pqdRa/JR0rgmj6bajSPTt8MgoQLBKaf0cn+MvkNmeiDekd2x+vtOp57gxsIwzcaZkvz3q2KX+AOhaOLLy9YgUjUzJg/Qota8K/5M4u/JdTvyZGLkUEXLTqR4bBjIzSRnbcU+AZjsdADXfxHw5RvOCU+H/Yoo6IHF+4yfTtOql9gxcxmXdBR3USpTiyUv4apPgS9OJAoXEygcrDk+4IHg4bncHj+T6BFYulj76JlbHoW8KZgTqpKQMIdgUCNwbLnfZWVBoRfeG9raMutdEBSMGUKwS1tC3agSEBCITj1+0dlzClkzL4le9sjJvxOrebqHAH7R5e3Bfut/8/MgmC7z7BvyZmZSTCrvhsO35uOBIETtsTjTyITNKPlUWbMiqd4QmppuJ9mZxIKzhwWtek5uJbBIhN5GvEUFbv/WuzCBfNASrBNi84RJ+ic/jhpx6IqRSOah0WZschH16LmHVgVgxtr6ZePSPJ9K3ghXVsrxJSTjJJFl5ZCv/49j6GuKBZTjw19901/2X+pbUZZoqvnJMCFDxqaZ+Aa3ruVr4VceDx8jv2GKFOyBg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB5140.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(396003)(346002)(136003)(39860400002)(376002)(451199021)(55016003)(76116006)(110136005)(66446008)(66476007)(66556008)(4326008)(450100002)(478600001)(8676002)(8936002)(52536014)(54906003)(82960400001)(38100700002)(316002)(66946007)(41300700001)(5660300002)(122000001)(64756008)(186003)(83380400001)(71200400001)(7696005)(53546011)(26005)(9686003)(6506007)(86362001)(33656002)(2906002)(38070700005)(41533002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/EAYfrpKusCCBAVc78YWvqJ3H3flL36i7eI3xyfNRNg6Zw7eyQJZDuQiKTAP?= =?us-ascii?Q?T3OTWhFoFHodOvZZn7+oK/APiQ3Ln6wDu2kumr1wEen5dx4heMJQZ+ZQjk8G?= =?us-ascii?Q?zcwEdW2t0lsynJZ6yU17jAJbE+rqXj3OL8+0ikbN/cedWRj7DvhOt+JhMze9?= =?us-ascii?Q?Z7oRHu1irnvs4qYOVQhI6vkRTfGLtH/qyU6uaG7Y2By03+R3eeObEuCJOhsC?= =?us-ascii?Q?MAzkh8o1QuvIyeYG1rSPuh0yLoybPpnY/zVcJ/n32Y+oV7gbHrpFEI7TiP7O?= =?us-ascii?Q?TuwtAA2aDJ0n0EqX1rfGkYF/rjb0PqqLuuoA8oVFrBtotOrXShcl9x1hwb0d?= =?us-ascii?Q?/XsbsBMZX2mspBOnqv0qRzvIeDHkT3wcsJyneoX8NUakxz6pTVjVQst1UCH8?= =?us-ascii?Q?SSeUd02udXmgp89e7G8j00MZOVbqiHZCveRjWV/dc2J6ipw+PNJoTAo5fQBq?= =?us-ascii?Q?5MPbeTgNaCO4UlvSZ0geJiliFRQ1NnnpKaaXIgPZgrexEBcVD0lE6WlzPI6f?= =?us-ascii?Q?U8YX1d2fVhRFSJpXHT+9ZPiPvhsZn7xTEZA+UHhKpSGrE3RndZp4cmwRSPyI?= =?us-ascii?Q?6mLz0IK6mMum5UpztiJMHmrdWYNyvp7nrBZR4766BwPLF7XRTIvUKh8VpEqZ?= =?us-ascii?Q?A6Mr+Afq/ZhmqhwHbiNkpVzERjTQC59tKW0twr3BC/Goc/2FgYcuKLGHu5tU?= =?us-ascii?Q?iZu28Q5TuUduUnCbkYRO+whT7aRuCQ3UekrxAN/AuC4VE7JNjJz26iSaORr6?= =?us-ascii?Q?AnYkQ/5Sx4+i97NuDEBXNK3imc+o+7EbFbTj9oN5j9euXRSHb5NZRuiznxXt?= =?us-ascii?Q?ELm1IEBtS9nyT8k+IsFh6WSGtOP/OGry46CMxXkYGjtMlrutQfmSxCiLys37?= =?us-ascii?Q?90qb/TtuMwn8rlQ/Oym2DMM/EdKv0mulhOjb55Y2kPWFaDBRKkhzetXFsm01?= =?us-ascii?Q?1G8tpCPEibTmNW04LQKjLVgAP1oS8gQIp1dSpfeq0gIF1g4gkr2U5DUS799D?= =?us-ascii?Q?8xQBwXdx/+PSpGFfLDH2vGr7wMrVH4ogOT1DcyADiydDVQYq1/HohYoMT7PT?= =?us-ascii?Q?0WxBKlhG1ILfbFbKCOtlCd8qb3f1WIGssfqWgY/RP7giYScOoD58h/cLbFEA?= =?us-ascii?Q?4eod+1L9/AvXdEanGCqZvSjshzy54xfjxqSGoflRv4piyO5cJJWl27uDJgDy?= =?us-ascii?Q?BUE1cLrBQiJ4HGvpXzT+JjpMicmSnbWdBX1tBf3koiII+9XtPBb442SYCqzJ?= =?us-ascii?Q?cy0f9sHc2RJGiDFbFJViK7Lb7iSYVMNfHKvvzYax/F+omsSpJlRLHh4ztZrz?= =?us-ascii?Q?ghQgfJ2Yz6S0EMIBZr0VJTy2TcghCmGqyOG+sJnvTT+dPoqOGmihN1OKdlda?= =?us-ascii?Q?KDYXAC2Z0DU8Rq91jmyVnaggIEOS1Chjw7HpFnZjZQV/XMh4L0kokJEG8IYo?= =?us-ascii?Q?FvdbkyivDChF3u2VMSnQ4wsh6Tp7naIF0EeauuWG7tMRXCKEwbhWZ+3T+YDa?= =?us-ascii?Q?I3BIQCe/04s7GVnoTcmD8AIZSQniwmdtzZYtUWMzkMtzcjCxrq8UK27LOUns?= =?us-ascii?Q?VemGd6e1be1eRPki8FaWhD/vMGnF6ozi5pn9EbyK?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5140.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73af4d5c-81f8-4c44-2734-08db4764ec8c X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2023 21:18:19.3604 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: w7U7Y804zvcqifbIdNTiI+8whrh7/ctAODyLcvcBkW1PogotdlYsHBuB9I+qeEu38t9anPpu7CvHH9wEtIzehznMNEJFT5ZJo4SBtw9Atko= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7312 X-OriginatorOrg: intel.com X-Mailman-Approved-At: Fri, 28 Apr 2023 09:26:51 +0200 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Since the E830 Generic Checksum requirements have changed, this patch shoul= d probably wait until the code changes have been completed. GCO is no longe= r by the LAN Tx Queue Context, but will be done by the LAN Tx Context Descr= iptor GCS field. Also the RX Flex Id will be 2, not 9. Thanks, Paul -----Original Message----- From: Yang, Qiming =20 Sent: Wednesday, April 26, 2023 11:20 PM To: dev@dpdk.org Cc: Zhang, Qi Z ; Yang, Qiming ; stable@dpdk.org; Greenwalt, Paul Subject: [PATCH 30/30] net/ice/base: fix Generic Checksum acronym Fixes: c31095a0b20f ("net/ice/base: add GCO defines and GCO flex descriptor= ") Cc: stable@dpdk.org Signed-off-by: Paul Greenwalt Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_common.c | 2 +- drivers/net/ice/base/ice_lan_tx_rx.h | 15 ++++++++------- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_c= ommon.c index 7d2a254c47..c324500b54 100644 --- a/drivers/net/ice/base/ice_common.c +++ b/drivers/net/ice/base/ice_common.c @@ -1488,7 +1488,7 @@ const struct ice_ctx_ele ice_tlan_ctx_info[] =3D { ICE_CTX_STORE(ice_tlan_ctx, cache_prof_idx, 2, 166), ICE_CTX_STORE(ice_tlan_ctx, pkt_shaper_prof_idx, 3, 168), ICE_CTX_STORE(ice_tlan_ctx, int_q_state, 122, 171), - ICE_CTX_STORE(ice_tlan_ctx, gsc_ena, 1, 172), + ICE_CTX_STORE(ice_tlan_ctx, gcs_ena, 1, 172), { 0 } }; =20 diff --git a/drivers/net/ice/base/ice_lan_tx_rx.h b/drivers/net/ice/base/ic= e_lan_tx_rx.h index d8ac841e46..d84f2f6db5 100644 --- a/drivers/net/ice/base/ice_lan_tx_rx.h +++ b/drivers/net/ice/base/ice_lan_tx_rx.h @@ -747,7 +747,7 @@ enum ice_rxdid { ICE_RXDID_FLEX_NIC =3D 2, ICE_RXDID_FLEX_NIC_2 =3D 6, ICE_RXDID_HW =3D 7, - ICE_RXDID_GSC =3D 9, + ICE_RXDID_GCS =3D 9, ICE_RXDID_COMMS_GENERIC =3D 16, ICE_RXDID_COMMS_AUX_VLAN =3D 17, ICE_RXDID_COMMS_AUX_IPV4 =3D 18, @@ -1069,14 +1069,14 @@ enum ice_tx_desc_len_fields { struct ice_tx_ctx_de= sc { __le32 tunneling_params; __le16 l2tag2; - __le16 gsc; + __le16 gcs; __le64 qw1; }; =20 -#define ICE_TX_GSC_DESC_START 0 /* 7 BITS */ -#define ICE_TX_GSC_DESC_OFFSET 7 /* 4 BITS */ -#define ICE_TX_GSC_DESC_TYPE 11 /* 2 BITS */ -#define ICE_TX_GSC_DESC_ENA 13 /* 1 BIT */ +#define ICE_TX_GCS_DESC_START 0 /* 7 BITS */ +#define ICE_TX_GCS_DESC_OFFSET 7 /* 4 BITS */ +#define ICE_TX_GCS_DESC_TYPE 11 /* 2 BITS */ +#define ICE_TX_GCS_DESC_ENA 13 /* 1 BIT */ =20 #define ICE_TXD_CTX_QW1_DTYPE_S 0 #define ICE_TXD_CTX_QW1_DTYPE_M (0xFUL << ICE_TXD_CTX_QW1_DTYPE_S) @@ -1188,8 +1188,9 @@ struct ice_tlan_ctx { u8 drop_ena; u8 cache_prof_idx; u8 pkt_shaper_prof_idx; - u8 gsc_ena; + u8 gcs_ena; u8 int_q_state; /* width not needed - internal - DO NOT WRITE!!! */ + u16 tail; }; =20 /* LAN Tx Completion Queue data */ -- 2.25.1