From: "Wang, Yipeng1" <yipeng1.wang@intel.com>
To: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Chilikin, Andrey" <andrey.chilikin@intel.com>,
"Kinsella, Ray" <ray.kinsella@intel.com>,
"Gobriel, Sameh" <sameh.gobriel@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"kda@semihalf.com" <kda@semihalf.com>
Subject: Re: [dpdk-dev] [PATCH v2] hash: fix tuple adjustment
Date: Wed, 5 May 2021 17:57:43 +0000 [thread overview]
Message-ID: <CO1PR11MB51723959450FFEBAFA24CDD6C3599@CO1PR11MB5172.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1620138304-203463-1-git-send-email-vladimir.medvedkin@intel.com>
> -----Original Message-----
> From: Medvedkin, Vladimir <vladimir.medvedkin@intel.com>
> Sent: Tuesday, May 4, 2021 7:25 AM
> To: dev@dpdk.org
> Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Chilikin, Andrey
> <andrey.chilikin@intel.com>; Kinsella, Ray <ray.kinsella@intel.com>; Wang,
> Yipeng1 <yipeng1.wang@intel.com>; Gobriel, Sameh
> <sameh.gobriel@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; david.marchand@redhat.com;
> kda@semihalf.com; Medvedkin, Vladimir <vladimir.medvedkin@intel.com>
> Subject: [PATCH v2] hash: fix tuple adjustment
>
> rte_thash_adjust_tuple() uses random to generate a new subtuple if
> fn() callback reports about collision. In some cases random changes the
> subtuple in a way that after complementary bits are applied the original tuple
> is obtained. This patch replaces random with subtuple increment.
>
> Fixes: 28ebff11c2dc ("hash: add predictable RSS")
> Cc: vladimir.medvedkin@intel.com
>
> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> ---
Acked-by: Yipeng Wang <yipeng1.wang@intel.com>
next prev parent reply other threads:[~2021-05-05 17:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 14:07 [dpdk-dev] [PATCH] " Vladimir Medvedkin
2021-05-04 14:25 ` [dpdk-dev] [PATCH v2] " Vladimir Medvedkin
2021-05-05 10:16 ` Thomas Monjalon
2021-05-05 17:57 ` Wang, Yipeng1 [this message]
2021-05-05 19:13 ` Stanislaw Kardach
2021-05-06 11:40 ` [dpdk-dev] [PATCH v3] " Vladimir Medvedkin
2021-05-10 13:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB51723959450FFEBAFA24CDD6C3599@CO1PR11MB5172.namprd11.prod.outlook.com \
--to=yipeng1.wang@intel.com \
--cc=andrey.chilikin@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=kda@semihalf.com \
--cc=konstantin.ananyev@intel.com \
--cc=ray.kinsella@intel.com \
--cc=sameh.gobriel@intel.com \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).