From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E771CA0524; Wed, 5 May 2021 19:58:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD13040040; Wed, 5 May 2021 19:58:19 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 7B61840040 for ; Wed, 5 May 2021 19:58:17 +0200 (CEST) IronPort-SDR: 91fCuRx4I0V2wC937FXR6NhxPiXh5AjcNc1Q22Gss+TWbMMjVpzT473PRMLUsZFin9Tph4wAjv xFbvUBt95feA== X-IronPort-AV: E=McAfee;i="6200,9189,9975"; a="197905255" X-IronPort-AV: E=Sophos;i="5.82,276,1613462400"; d="scan'208";a="197905255" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2021 10:57:55 -0700 IronPort-SDR: JK2jdBYJ78v3NCuzfXOEmb0x5HvovCb4ZcCgY1DRCwEAxfc3nQH1lyZGG104fNb/IMxhESyaPN C+az8FrLg9AA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,276,1613462400"; d="scan'208";a="429979655" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga008.fm.intel.com with ESMTP; 05 May 2021 10:57:55 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 5 May 2021 10:57:55 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 5 May 2021 10:57:55 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 5 May 2021 10:57:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HuDIiEA0vu+4mzOJcAGT0FiI1/P0+Qhiv8obsNxmitaUTao+XxOXiQXO80DjsUEF0OJ1su/snvJsqYrQsgNzm+qvI6ggDyDI+YwaNT78DF4/kz0daRAcZJ04bzYWXLkGIGrQfCAWXNaB4FV0EsWWR3Mc10bQc3oRmIYhuflfXqjj9XXkEHRDa8kCtsHh8LStArcWuSc4+vCSRkL56+eiIBAX/O8F8YQcspAWnD858YHRlkblJCywREz42pdXaLTcOr82+P00CNAfaguFyN/FGqQkUpjGycIhDW4jL4AoXS94gtIdcK97rMlKleGE0Mygbnm0y/zylyi6esb3kkAlQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dRVE7rP8Ubnem0wKIGu3Q1zXIGZ2q7XFFMYwQNNSYLY=; b=XpbAAOK+HTPbIhO7nDAW2jaoWW/kHArY2SVMqPdWxuQdv049L+NjpQ4r9rhz2FwasG9eE1k7ZtKwLkPSxj/3psjWuHoJNW7K+Ik+m8/r9HHDxBnOloTposuDGzQ4zrJiuW0/x+xk8JIcSK9hYuTBTLTyL2/CgHhkXzcIu87NAFdSqouRIkTluYZIRw1ATNo5rQL/4lvr8PMiuZcPc6JFY60KIlVevpj8y5rUUBgi3YQ9z2GWOTjoHELfTMeW4JxkMoepb8z1WomxaFd1ApnDeYJ0uRTpeN1jMB4aRruSt6kIJW8PNmQRTyjOC9to1R1TYY7BinNhZaiwCiEctYMSNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dRVE7rP8Ubnem0wKIGu3Q1zXIGZ2q7XFFMYwQNNSYLY=; b=LVCq0nZlfc+P0O0RhLrAFH/dqSF+ego9wJPL6cc+nnQa1F9cQG0YNKISH4XQCO+iXNYG4TJ69TUrTb8T7sVVVel2yMA0hefGdCYUtIHjSmQK1R6qahW0vO3YhheAR8XpZ0Akg+FElqegNHwp5wvMTLspgj0Up+ydVxmvc0Y2EBg= Received: from CO1PR11MB5172.namprd11.prod.outlook.com (2603:10b6:303:95::12) by CO1PR11MB4899.namprd11.prod.outlook.com (2603:10b6:303:6e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.38; Wed, 5 May 2021 17:57:43 +0000 Received: from CO1PR11MB5172.namprd11.prod.outlook.com ([fe80::49d6:4a9b:a2b7:5049]) by CO1PR11MB5172.namprd11.prod.outlook.com ([fe80::49d6:4a9b:a2b7:5049%5]) with mapi id 15.20.4108.026; Wed, 5 May 2021 17:57:43 +0000 From: "Wang, Yipeng1" To: "Medvedkin, Vladimir" , "dev@dpdk.org" CC: "Ananyev, Konstantin" , "Chilikin, Andrey" , "Kinsella, Ray" , "Gobriel, Sameh" , "Richardson, Bruce" , "david.marchand@redhat.com" , "kda@semihalf.com" Thread-Topic: [PATCH v2] hash: fix tuple adjustment Thread-Index: AQHXQPFTY8aDWFpE4UGr3xxbq1EGjKrVLkCg Date: Wed, 5 May 2021 17:57:43 +0000 Message-ID: References: <1620137248-203174-1-git-send-email-vladimir.medvedkin@intel.com> <1620138304-203463-1-git-send-email-vladimir.medvedkin@intel.com> In-Reply-To: <1620138304-203463-1-git-send-email-vladimir.medvedkin@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [108.161.24.24] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0ed95d97-5bb7-4bbc-7733-08d90fef486a x-ms-traffictypediagnostic: CO1PR11MB4899: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1923; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CROLsxYIf3Aw1x+WPSehqttPOMXwUGP2uGTcahW2JOORRvhJ8iQ2Eqgvld4mV94Vu8DzjjadbdA/Ysr/AtVuxLj3eSQrliNoY7lvueEss/Ndd+LPdnpF2J1B9kE/74sUwAea5JgfzAR430pNv2ofT+A3H46AaTNz3qcAJyeYu6zyqu+ogsDMROJVUysxHc7HDEKhFLdWmv577Af9w+NgRlKvGy5Y0k5GDRpVRrTiyeDRXwWj78qF/DEnfA7vpQnZGyYq6sGfqFL17vJ+B8s7ZiVfZ5LY1hqlNydY4xhuV6vOmYwGcqta66EnSr7JMxFk1Vb8oeYCpRJ2IrN6iy7sx5spbPTfOJ4KbykdiLsMC7aXuiLlbaQ9l6jCuDn4Cg0QO2xT67rWPv8feVNuunAwYRg3r6eYAgdeTpbBmk4kLe3sww/L34m/ByChXz9vDivMk8A8Z0M9AzY5Q2ljZDUknEo+LEXRJ5AD/OZm8WinIb2NoYI4FkE4Ls1NMnl8CtMndQ5JKmtm19g/EYOMbcpeE8A5NvZnulZ5JDSxdb7hqRNJtpTEaYIEkuKy7CbURjm17LSrOzW8Sn+eugLo/R4Z2Ka0wwPqAdYBjmhGOze1e7o= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB5172.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(346002)(396003)(376002)(366004)(136003)(4744005)(478600001)(71200400001)(122000001)(6506007)(5660300002)(66946007)(8936002)(4326008)(53546011)(2906002)(83380400001)(66476007)(66446008)(26005)(8676002)(76116006)(9686003)(86362001)(110136005)(38100700002)(54906003)(55016002)(186003)(7696005)(52536014)(33656002)(66556008)(64756008)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?rrgloewM6t+hGnjzmSLawoewgjaiAwlZKSPOQj/J2+qClo5UMnVXISDNQZNK?= =?us-ascii?Q?IEEBdr0QPGBmJRPq7D9lL9mk9cbem98w7Jkpndp8rAbYe+RHT/4+Os73vQV8?= =?us-ascii?Q?U/NvHsyphMAOdyMYOciXpHCl6mS6i9YMlqWTdOf7z+qbYmrkMnhGSyvDi57y?= =?us-ascii?Q?HOV/NXi1Mo/ed0uLMfyUTTqn4AnYdVp4tuAX7S2OBYKP9EgtvXt5L+asJxzV?= =?us-ascii?Q?YI69F6qkQNwWFZxWZPyQKwVPBYnot0siaAHtl1WvUdNcrNcNeSiVYMqfXHgX?= =?us-ascii?Q?7iZPDEgaKwj7CCAhcmh9FghJDB0YcNS0U03G6KB87XkIrWwYMUvto8In9JCg?= =?us-ascii?Q?EiMxxIGj5Ix6bV1A6pPu7OknFl51fbpZ0m18acZzL4kCX3mX+Hv0QfdKZAZ3?= =?us-ascii?Q?vMS0CHAvsiJzU/jzKOFdLMnqyZX+8LjmYxl3Ri2g0l1VM2EzCp8LkAVPOW/n?= =?us-ascii?Q?B7/fa/FQ1fDNDlFcisffK+d0X47iYdQ4H+HbiZFu9d+vDsO2uQKKAmDXA7JH?= =?us-ascii?Q?VczZ1MAL+y6Uj7FQ0WluwzTGcPIuNO+9he4n7Kc7TYeByH2Z6W9EDLNMK0CA?= =?us-ascii?Q?ycSdXTjB6nuNCJh0tb2OY2CvA+oPOr/3ZPUotEQ8fZ21A/MqzIV52F5fGqmF?= =?us-ascii?Q?5AeaePy46evwsdUrkOu2S9HKKQ7aGapQolDYnRnnv0NUdW7fLFbhDXCVaUUy?= =?us-ascii?Q?5B7Wv9s9OrsXkwg3VzR8G+Jf/z1sh217oRGAuj3D/TQeVOxT/dRWUljWBMGr?= =?us-ascii?Q?ymXp468LZd6AqclOvKsuwp1gHA1yASB7ay/oDdDRd23oW++32rbCd9YgBQqv?= =?us-ascii?Q?sgcNva5NRLciNfl5xGKmT/tUg5UOF6/TNdjEuiiuoNgiRI0eehpeF4VgXVQn?= =?us-ascii?Q?Y5LWBDv/Oa5K64iEfZkwbz9q8tj2qyZ3TL9h+w6P9enqQ5IQnXUg4ZN/aSbn?= =?us-ascii?Q?Xp5KhrVNrrDo9oV5UJ5wUDEoDmUFDjyaPhfwEd5BSPajEfo6/4cIiABNKYqx?= =?us-ascii?Q?EQwkTfjA05LbpM8mhBcf+mleb+bQQAYbpBIhrHX5mfjOdlMoStlOWM6MT4pH?= =?us-ascii?Q?yXt04OQNCrA/d2/sEwFWKVSAyzlUuYUJVqa99zpp8MWXhQ4TWKMlQ09irXuU?= =?us-ascii?Q?MdRBTk1493TtBDxVE8o0lBkB9mnS7x/GvHLOw8J+fjnnXwJaqH1km95GXA4I?= =?us-ascii?Q?yeA07qGmQkD622vquUAUGzsCLvA2IStPWRp7hmu+5auicUtRW4CqukSPnSKo?= =?us-ascii?Q?cODRL/p/54MEu9fWTsj5wZcx6cIIoVwSNtXTs4vE3HpBmAizH8BuPYCX/hB3?= =?us-ascii?Q?dIGQEW+wv2iUlRSOSEaiO2zQ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5172.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ed95d97-5bb7-4bbc-7733-08d90fef486a X-MS-Exchange-CrossTenant-originalarrivaltime: 05 May 2021 17:57:43.4580 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0Fg73kCW6p0Ur7SrDkAiMrA4yeSo1KwjDiHdSGaynfujKzgO6cwCpUUv0rWOWnSeGPWXJNx5eroPO640PVDWhA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4899 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] hash: fix tuple adjustment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Medvedkin, Vladimir > Sent: Tuesday, May 4, 2021 7:25 AM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Chilikin, Andrey > ; Kinsella, Ray ; Wang= , > Yipeng1 ; Gobriel, Sameh > ; Richardson, Bruce > ; david.marchand@redhat.com; > kda@semihalf.com; Medvedkin, Vladimir > Subject: [PATCH v2] hash: fix tuple adjustment >=20 > rte_thash_adjust_tuple() uses random to generate a new subtuple if > fn() callback reports about collision. In some cases random changes the > subtuple in a way that after complementary bits are applied the original = tuple > is obtained. This patch replaces random with subtuple increment. >=20 > Fixes: 28ebff11c2dc ("hash: add predictable RSS") > Cc: vladimir.medvedkin@intel.com >=20 > Signed-off-by: Vladimir Medvedkin > --- Acked-by: Yipeng Wang