From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C404A0C4B; Thu, 14 Oct 2021 03:54:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA40A40042; Thu, 14 Oct 2021 03:54:38 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 80F6240041 for <dev@dpdk.org>; Thu, 14 Oct 2021 03:54:37 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10136"; a="227477558" X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="227477558" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 18:54:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="548164351" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga004.fm.intel.com with ESMTP; 13 Oct 2021 18:54:36 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 18:54:35 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 18:54:35 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 13 Oct 2021 18:54:35 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 13 Oct 2021 18:54:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oLuiT1X7Bn2gmS1wEpZRUKzaR74QddHNlIHby7x7NBVbIg0yxQyYZNgo/AKOOxhj6aKxaZNbFknM7rFyfacCLnOQbUirlzIvKDvJy8eW+pVK+OCxZLutNL666ECJm+v9o0qh9cn9YZbeynu1J7m73MiE86UGtRgjgJYjBvgREge/MrN99XTn1lhwq9OPXGZkWgp5C2YcoMajw0x883OBs6azI+XgiU46Q23AD1RzHq7ibukuphOAYhgkfIIgu16H/2nbo7hxixNPFfV6s5jd2zvxA4CgCAeIyCn9hU7/P6EtqwofDSFkRaOef0gnTjwg8OZXZDSDjV7Bty9YL5zpLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vnapuCLpzpUqkvZJJxIpIb0RQ4umVShdkUvF3mEFpJU=; b=J9Av16j1v0tjEmxMRGO9V+zpl2HhujS6dS4l31o9cS1eh4kaOcHqvBUZIud9kBlC0QEBEbSHkPtjLJjdAV3HEEGPPpAu+W+wS1rsiLxdn7mPnUDuTjuheVzJFJOMoBY4vLUKSTgVrPvN1DJ7CO8ZQ0u1w77ea0vS910qQU8Xex04ECGAFxjIzC7MzYO9Qv2pE5lpYKaprE81X93tAIzdSjLxu0613G5zxd67izXmv4eZ6E1nYIMSNN9ntg0ZqQtz/7oIUw+WCYc6GgKr40GcsKbXKd+s3IBMuulP2LxxlS36ULyV/a8GGf72oPutZ58Tq/l8tpKYlHps3vDMFA7tPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vnapuCLpzpUqkvZJJxIpIb0RQ4umVShdkUvF3mEFpJU=; b=JnixjrruMvYshvy3hBQpjnWWVhvVlimT5VP7tiGGvdUeRRH2CT0Pycs6hu4+iYE2apZdtjnq4PgHe0zew7G6s1bA+j8A/SrfGmn8ZsWmWyJWeJ5nR+KE5Pw63mddjqEBS5jM91EsvxandSTCOdZfOqUNaVS0tAlVnfnE5S34r2Q= Received: from CO1PR11MB5172.namprd11.prod.outlook.com (2603:10b6:303:95::12) by MWHPR11MB1952.namprd11.prod.outlook.com (2603:10b6:300:111::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24; Thu, 14 Oct 2021 01:54:30 +0000 Received: from CO1PR11MB5172.namprd11.prod.outlook.com ([fe80::d10:15e6:c08c:4a9e]) by CO1PR11MB5172.namprd11.prod.outlook.com ([fe80::d10:15e6:c08c:4a9e%7]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021 01:54:30 +0000 From: "Wang, Yipeng1" <yipeng1.wang@intel.com> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, Stephen Hemminger <stephen@networkplumber.org> CC: "dev@dpdk.org" <dev@dpdk.org>, "mdr@ashroe.eu" <mdr@ashroe.eu>, "Dharmik Thakkar" <Dharmik.Thakkar@arm.com>, nd <nd@arm.com>, "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>, nd <nd@arm.com> Thread-Topic: [dpdk-dev] [PATCH] hash: promote APIs to stable Thread-Index: AQHXwHrFDG4QqM14yUSg2EceD/RUcavRhhkAgAAbPYCAABpUQA== Date: Thu, 14 Oct 2021 01:54:30 +0000 Message-ID: <CO1PR11MB5172FDEEF9823FD59B527125C3B89@CO1PR11MB5172.namprd11.prod.outlook.com> References: <20211013213858.16200-1-honnappa.nagarahalli@arm.com> <20211013154158.280d5db8@hermes.local> <DBAPR08MB5814BF7F347F539E236D2C7198B89@DBAPR08MB5814.eurprd08.prod.outlook.com> In-Reply-To: <DBAPR08MB5814BF7F347F539E236D2C7198B89@DBAPR08MB5814.eurprd08.prod.outlook.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aabe6922-ea2d-4ba4-3de2-08d98eb59027 x-ms-traffictypediagnostic: MWHPR11MB1952: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <MWHPR11MB19520F9BFB5988AA95AC9C0BC3B89@MWHPR11MB1952.namprd11.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ADGQtI28pu22Cn1bchHAOeR7RQELWmfghXp+a6iJAQyQDpwGLv+o0v/VSs1/bL5ukK+r69rZRXvoMC9izTgOtylIYmutBPs+GM98Vlay3qfJqASCHUuF4zXKVSoGXjK3994uqVS04H6KuVuz2v0sAtNg9lRHDAuleYbC4iZQMp8O1w6/CuJRNvGO8IhMMBIqUUMBWuQucE9fqNWPivIDITh5FTgf6AeGkVmS3KH4MmP62E5cKbNUr4mkk5IlB4CJT+GHjuQ9D1Htv/qPOkUYyy7fD2PUtNHa24iRXExZEVbSvOZoDEDMd8AxrydwD+3hBedNOK0nsxEOf+tNOgA0osKqlAh+enC21yrmLu2TtGumgHh8JDbBl2NJ96GMoMH73PrSKU9u6QjlQtOeN3Tb/5yH0N+0nQUy7CC/6hEJtbdI/36+sqgMvR0XADM1xeNcEUsEbEUH/wK7bu6ZuqNQYemKo80jFqm/xBURGEZipTcNXOs0k+FzFP0innTYRGrbWrm1WvaK6D6ymPg1vQNKBdjS/Z2RqfFcWhDhiz4fvbxvmIqhDkuHju3KFKSgugK0hWWIJPn9XKLCheYN3G3zeby6RiWcFJsAt89pg1HAaozDaTIuui3qQ8SrFePsdqzmIS/Reel10B2ud+HpHj7n1ysxL1K8p+MWm9GaukMEclBo+zRXd1azp/zkRM0/SdDXeSJqL0G8HsV8bkKoHbnRyA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB5172.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(86362001)(76116006)(2906002)(8676002)(55016002)(83380400001)(186003)(9686003)(4326008)(66946007)(5660300002)(26005)(53546011)(6506007)(52536014)(66556008)(38070700005)(508600001)(122000001)(8936002)(110136005)(7696005)(316002)(54906003)(38100700002)(33656002)(82960400001)(66446008)(66476007)(64756008)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?N30WKdeht7rI6pjxdHolqc77E5nX+VDPidBTCT5LB6vuKGrodAlxuaWNF/dr?= =?us-ascii?Q?AByPKPo8iwPHpXQeDj66bWbgZ/HE4Q9p5EKtLjWz7l29+BEUfIy3Xp+6KWfO?= =?us-ascii?Q?8j7LzgkwwrmCpmDZ+lh5IZGJK1c2OpfGpLfHCYJa6yQeEWDwvTj716T32fco?= =?us-ascii?Q?WV0DraAlLR9ATNLfj3a45o90cZRVHhL+vciihjqFOz9jC0ib7Hlik/xIWPsS?= =?us-ascii?Q?AgEAsEx+jN9yTa+/u6xHBgT7wJYs+08IRh1Fsr4wKipzd7arMiA567shPsPb?= =?us-ascii?Q?g6TKdRaybgHmNGHz4hGLo5qL/N0EvV+GcMnoooI4xhhz/TzdnDx5j+j2T0jP?= =?us-ascii?Q?tBRLY5HjzNtoRVesJCzW9l4wbRQiFuzuTV6YG0jCYyD2juFH6fJxuZTfqFet?= =?us-ascii?Q?BBWTkPsiJ9PsxVWG1UiO58kuY5HM96KNSvF1QoCLY3NZQ2swDlD68WFJo6I3?= =?us-ascii?Q?lnaS65LrYwHpJl2lNsnLDODXqz/5OvLtKn2pAHqeFsE2rL9u7OMpmHpQLyJm?= =?us-ascii?Q?Mx7poEie9gpCm896ADrp3xtsVMfKR4bJmbkCIrXKC+Q5s5jLdhWdiJop6u1g?= =?us-ascii?Q?LXZUGVuHMa6kHKG7yXmNMD3dz3Vm2FcJiCsdAD54P4EG1KeaO8VkAPzqZp5i?= =?us-ascii?Q?yuhaEX53R3SfRAcHFK1CgEY1OzIlpAoQdy+OZ50OxLA152oiAW9KC9Bpg1aD?= =?us-ascii?Q?tAVTrd2StACpGqSQOh+PgpRJBSV6l1d/S4YFx7RJItAJpx7RpB2MJv4yrIly?= =?us-ascii?Q?2FGMtSIQ3sgv7MIobBli8h9eY3D6LMOYeB3LGNFA7xRYAY2h5kL13eviTfT2?= =?us-ascii?Q?EAo3y2bR02R26eLwvNc3q/SO4f3OPs7vU1KKK//RKl+PUeoDtSUJ3tqiP/XT?= =?us-ascii?Q?LfBX929ctaqNKzh2oHkLFOnrcNfda0dnh/kfFO1C1Cg+ejP/cyoyMXiOp+7w?= =?us-ascii?Q?/lKG2eKyRkCSREJXZb1icr2WoMDkjoXqtwCszFEzCoAc0vLh5EPGyqqXvd9W?= =?us-ascii?Q?nm2FCXIon5ZWd3xxc4oMR2PK1Syxbd+8iRhC/ljfo5otIpYASeUcB5AVmFpO?= =?us-ascii?Q?zXrhuhv5k+dplnTF9pxLIRE2DQniyMeDyCPTP7FZQxgr0zmgEauTFfnQ6ar+?= =?us-ascii?Q?xfKhjs+rWrqdHS12RRsUfKvSHHJC6kN6S6pxHerckF/qbGYjPiQYDi7uvMCS?= =?us-ascii?Q?sikmu3z3VLSYI/pGCFBlSc74nSGqwgWPUkw2eBltkFXaO65CB2qeKrmiPkOP?= =?us-ascii?Q?/6kUTNZan4CJ2eqpOBEmKGqD+Tp4dDOQT9kQtvn5qUf05u5QA7dNHhfMD46u?= =?us-ascii?Q?tbHeqaCYRdwaLcWG4KSY0rd0?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5172.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aabe6922-ea2d-4ba4-3de2-08d98eb59027 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2021 01:54:30.7196 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XIPfWkLWen/Ss1NS+k1i6XAyUw1LfU73ofJ3zJ5WJs95i97+eyk6qxX4hLOsCf1mfgwuz3xj/6bFpIwA3n9vZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1952 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] hash: promote APIs to stable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > -----Original Message----- > From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> > Sent: Wednesday, October 13, 2021 5:19 PM > To: Stephen Hemminger <stephen@networkplumber.org> > Cc: dev@dpdk.org; mdr@ashroe.eu; Wang, Yipeng1 > <yipeng1.wang@intel.com>; Dharmik Thakkar <Dharmik.Thakkar@arm.com>; > nd <nd@arm.com>; Medvedkin, Vladimir <vladimir.medvedkin@intel.com>; > nd <nd@arm.com> > Subject: RE: [dpdk-dev] [PATCH] hash: promote APIs to stable >=20 > <snip> >=20 > > > > On Wed, 13 Oct 2021 16:38:58 -0500 > > Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> wrote: > > > > > --- a/lib/hash/rte_hash.h > > > +++ b/lib/hash/rte_hash.h > > > @@ -430,7 +430,6 @@ rte_hash_get_key_with_position(const struct > > rte_hash *h, const int32_t position, > > > * - 0 if freed successfully > > > * - -EINVAL if the parameters are invalid. > > > */ > > > -__rte_experimental > > > int > > > rte_hash_free_key_with_position(const struct rte_hash *h, > > > const int32_t position); > > > > > > Need to remove @warning EXPERIMENTAL in comment. > Agreed >=20 > > > > > > What about all the other experimental functions in here? > > It looks like all of them should be promoted. > I just changed the symbol that was reported by the tool. > rte_thash_*** were added on 4/19/2021. Vladimir, are you ok with > promoting them? >=20 > Yipeng, if you are fine, I can promote rte_hash_lookup_with_hash_bulk, > rte_hash_lookup_with_hash_bulk_data and rte_hash_max_key_id. These > are around more than a year. [Wang, Yipeng]=20 Thanks Honnappa, please go ahead and have them in your patch. Thanks a lot!