From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02FDCA0544; Tue, 7 Jun 2022 12:57:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB1BF4069C; Tue, 7 Jun 2022 12:57:25 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id D476B40156 for ; Tue, 7 Jun 2022 12:57:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654599444; x=1686135444; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=alZ1PZXhSX17tHjoLRunJqHOBtCgqrWsl80SdSk2fcQ=; b=FbxctVDJkwabVyHDne3uYK59rKSmZIjyeMNP6jjn9+6VLHyKizpnZ2fz ovv3i4FgjjBdK4c47lcJodPGFyHAmF839LGsbMoPjA44uWoGldMFDLLmx eYxTSvc3txVBtlCkrpkHrN/p2aZPkh+48NIlbuRCbRXoFI655ETnIGEaR Gb+WWOb+F4qttl2ZaxkvVBStS10hXIr2hByNzO41QVIXzYsXt+ezoQhms 093gKAtE9JWh+AAQe4KiWfc1IDdmL1clkDaSnU9dX8jXZe3LJXuIcDY1c df5RivmmGl8X5jPiQM5wZBLY5gagTdozkqw8UOEBdGl7uEbLq4Z/IC2kH w==; X-IronPort-AV: E=McAfee;i="6400,9594,10370"; a="265083401" X-IronPort-AV: E=Sophos;i="5.91,283,1647327600"; d="scan'208";a="265083401" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2022 03:57:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,283,1647327600"; d="scan'208";a="636076805" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga008.fm.intel.com with ESMTP; 07 Jun 2022 03:57:01 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 7 Jun 2022 03:57:01 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 7 Jun 2022 03:57:01 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.103) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 7 Jun 2022 03:57:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O0e2uNTylsF1kotidootWogSqrzqiWK2ZVYxarHbH6V/wKekxYD8fCPnXeuWptKbse8GuDf+IcfRpV0GGnK6bba2VqOzL2wPSZI4HskKEvSnmSVQD5LjUsGSlz6lICa24Pb/xyzPJHyIweM49DPBXjRPMg+XAcbectyZi3A0iLi/yTMfyALfsPg2oqZh4u4tLtfN/s/ib8jwD4VXfLwQWxK4Jz0Nc6XPMeVhO02XwH/B3IvOTl8az/IQ8CFkYNNUOga0i52b6x+sY9vX7e+YC/KEPbnLJ1wDJrMGJDdMOxnyR0bJgVjPAxp8v46vD2deox/qOOApLR+blrev2m/u2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=alZ1PZXhSX17tHjoLRunJqHOBtCgqrWsl80SdSk2fcQ=; b=Sk5M10ta0knQtTCVp8j0EKUp4mixlQ+2g1jg84aIdurzwMDbeusfjXRJDrsfM+hVOTUpwma/YO2YF+THAEerTKdCuCyS191lvnI5VFetKq6hyqHGZYJ7z7nR2hoMw7sPOnRV21HL8co0BGQq5HIvU4N63yHBa30Wwdr3mnvcdPLPA1NBjpomIPZTCU8zMT8kbB63hv8O1vWFDrjwd8Pz3qwOPM4FC1LwDvuGxBny6bqNNHaMeY25MXfPdkNqRpbZQHE9AxmkZWVKEirzfujt6MaMHxKw7gCEAXUaqHYJx6HUMXh19nUL37+XJGADm8uDq9O+oVa3K5nwMYzFe7iKIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB5201.namprd11.prod.outlook.com (2603:10b6:303:95::22) by CH0PR11MB5281.namprd11.prod.outlook.com (2603:10b6:610:bc::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.13; Tue, 7 Jun 2022 10:56:59 +0000 Received: from CO1PR11MB5201.namprd11.prod.outlook.com ([fe80::7112:17ca:9fa1:e9e7]) by CO1PR11MB5201.namprd11.prod.outlook.com ([fe80::7112:17ca:9fa1:e9e7%9]) with mapi id 15.20.5314.019; Tue, 7 Jun 2022 10:56:59 +0000 From: "Walsh, Conor" To: "Laatz, Kevin" , "dev@dpdk.org" CC: "Laatz, Kevin" , "Richardson, Bruce" Subject: RE: [PATCH] dma/idxd: fix return value for pci device commands Thread-Topic: [PATCH] dma/idxd: fix return value for pci device commands Thread-Index: AQHYS1NqIcZdKjVgREGzGUOE6ZdkUK1EI7dA Date: Tue, 7 Jun 2022 10:56:59 +0000 Message-ID: References: <20220408141655.1320288-1-kevin.laatz@intel.com> In-Reply-To: <20220408141655.1320288-1-kevin.laatz@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aa4c2bad-c441-496c-be3a-08da4874724f x-ms-traffictypediagnostic: CH0PR11MB5281:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OjzIWU7rtpRGFnVWjFn6FzW87ckSoNxsii6P0C+s6hQ55M78wj83PYSDi3npBdeiF4GoW2NFpDd6BDG24uUoT5hfHZ6yaNiadrCXvItXrQeNhJshoBRN0ilBDucFiAblu4hk8Ps/oEQSUOrUeabiy1VLZqTZ7ZnP8DciIxl+8cIIz2gP+wMD6WU4BMi2b7mr8z0TWxQgKpU0FrzD686M5SkNP8uDmTByVpI2CfpEaqkEQ6GTLE7B8+sQF9KlJNJVezT4BQpsVWYBzY8KXzhWJvpEC9vYgNypg+AsjOkQiCLpRM+DCmdtT0wuz2ERTXT9kGPAI/9zZarJZxw9fhB3eiFGUHkj9QJ1Ha4W6WIs/vvDYzX5iBiLibNULH1ghhUQWwT7IKFef6ILqVfeXh0XSczFwrT+DFHhJbLJnm0gzvFcAZxHeEpYcm4uo5EMF0TRqGpsqh9TgvaoQBWccH+yEz9BUViK1KfpzFTVHIBFU1W0kPudkFiAtqcaWddLCqpp8My/Z6/ZQ2I3ujn8HJT4TnPRIA8o8XuNKLHKAuKi3WRIkt3qydLSe7LKmGmSZSZRc5f1VJ+CDlPhAzRw0Qt1Rg/eUHgHFwGposrIZDEjB0Yn52lrePYP1AgrOFKD+wOviVrOpGUFR6QlZzdUkPkzy7IZgmG6Am0ko0osmbaKpvxpBrcdHb3V51mu0h7z7xHqTGXuTGYp69RKtZrxLayFWg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB5201.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2906002)(508600001)(5660300002)(66556008)(66446008)(55016003)(52536014)(107886003)(8936002)(8676002)(186003)(26005)(316002)(38070700005)(122000001)(82960400001)(9686003)(110136005)(54906003)(4744005)(71200400001)(33656002)(38100700002)(66476007)(66946007)(6506007)(64756008)(7696005)(86362001)(4326008)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?L17ZGec4/GOBlp3BXbfRXaVUM/DCIOaKkhvml9Gp+IXjcOposBZk4V1DS0pk?= =?us-ascii?Q?1OGsf3nB/FqcmTQrNBRMjw/jPipyhH2kSlt6RG07+37+M8ERatn8xAUene2l?= =?us-ascii?Q?xzoMR4FByeczGz9RHF6czXazC6pQZcg+xrmMeO3WBRhTZ6IKnDc3M8plNY1A?= =?us-ascii?Q?1W7cpZ7IN4ztwgdCwMJtuWXug5LHrfZ5ApnqQOFk2gaibHy2Svkc5qhUkF+V?= =?us-ascii?Q?FUZToo8+sJcRfIGORB1u2aHhnG1H65DdecfOthuAJe+0BsroWK5Fh9TycLJy?= =?us-ascii?Q?kuiOMfNkhjDKx/TkmETYPXab483cBOlOPpX2dZzPBffoYOXOhLZv6dRivwKa?= =?us-ascii?Q?li8YJcG+dVwtEm12NAiNBi/YBmQXysjk/ZnbMes1ZxDk2ER0ALKe96u1D9o9?= =?us-ascii?Q?h2K24BQtj689UwL2WGSON/CV8njXWzRpL0TsIwES7gDOiJMDrF3f2a453/yx?= =?us-ascii?Q?2Y1NX/UMxk6mxwv7/GzXFJsVNoFeq+U7bTJpHi0Z1ZBa3a7SSw/wBPZcZ73B?= =?us-ascii?Q?XV2MTTcIk14IdcpJAJJTDBuXOQEt8g+LDfkM7jS23SwK0HQ3SxlAp7PSA4l0?= =?us-ascii?Q?Rt6Y5bSBXI6lPkS9pCzrBWHHlte8j/IGQCBN3JGlatgZt3+judQEHQEBXokb?= =?us-ascii?Q?ptg/1/se7D0pve60SJDOkNZIKHnNd+kOUPKhL67W/OxWXKHEepuG3EDXnMK8?= =?us-ascii?Q?5C5xKdqdM6AuuXSkEdXsCf5uvJY0Ud1lKid7GwcfGpkrN7Md2jiS651hzT1r?= =?us-ascii?Q?gjoZnBoxKB2I8X/n6M2rYz/ETX2Jk7tdqLsu++HgLzZ2pOHqJ0dC33OjJVdt?= =?us-ascii?Q?cMznAiSV3aUJ186nW5wFwlWWk1tweGjr2OqbLV31ZHytHLN/X9tlG/qVCWDp?= =?us-ascii?Q?+XMP3QqW8hNffujCp8xhsLDUXwi60bNRilsuLFEPcXik1PqKth6v/wIGWubw?= =?us-ascii?Q?DPzbuTaXpex4CY3SHbUWTwpCsiZRvsyl/XB9eLs27nQS3qqwKo2kf5mv83I+?= =?us-ascii?Q?vx2L74lbuh4GtGbZ/DO6O7dRY9rTPGwW03+l8vDSeM6ixS6+UYwjIMiMkkIZ?= =?us-ascii?Q?abWIATOPNp2ZcTRntcbQcZAVOICalJFSmoL8fxP+VqAM8DjmzLCHI/sENl5C?= =?us-ascii?Q?CE4jo4ndDJf/tFTkcrweaLdDnoqALhEQ559+8N25rYF+oxPaJjsb1eNYTtXj?= =?us-ascii?Q?4njZjXv1eUsGW/WT0Y9vyUKG7lJOQ0rz8waf980VWHpx7KUbr9frWJ6yn2vo?= =?us-ascii?Q?fNF81N8OkO31E+uDnCHcLGgkwn8OnUitq2RM8fegKuGNau8UVFf7C612x6F7?= =?us-ascii?Q?MjGyRx0Qcbt42tZ0eMo9jDlUm52tX+s+tCEde+KLFajD9696DAqQb+lejMVU?= =?us-ascii?Q?+thWzhxaWpwOmKk1VwtKwLZS6AlxFi4js/oPu5wvntpL25aNT6we4XvmjL9n?= =?us-ascii?Q?TutxeI9yg0m5fsAXqzXJfXXqHU5ec9FYk2i7Bb8kE+/PNtfmOPdjIBX4d03U?= =?us-ascii?Q?3/qOVyFXWDLEeT7HRETp7orz6p1Ah9sfTWkkz68sK/qxpchLjR5u19FFLcQL?= =?us-ascii?Q?nIA33U+1K6KqukQNlNoPQXs+xhxbe0YnZt3raSb9kh2RFsdPsCRUnYB6xsv4?= =?us-ascii?Q?QMAch5ULs6v8BGqB7FRTFLY6to6OHcTiHP8PwPzX/9vI7LCbSgfaIA4nL+Lr?= =?us-ascii?Q?oxH7B156Gox9wpo4iCNL08GtDZXn5xTVLebSqMnvwMa/8xFUrSh1PgJYxlKi?= =?us-ascii?Q?xlvaxCtmMg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5201.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa4c2bad-c441-496c-be3a-08da4874724f X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2022 10:56:59.7268 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QhqZQ0rPQlRjgMLrDqVYsRhadro1LlpHaikvPpvucO1nBmoJbLi7CiwMkk0EyOBW6NsF3xta0CDnchezbb1aHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5281 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Subject: [PATCH] dma/idxd: fix return value for pci device commands >=20 > When sending a command to an idxd device via pci bar, the response from > HW is checked to ensure it was successful. The response was incorrectly > being negated before being returned by the function, meaning error codes > cannot be checked against the HW specification. >=20 > This patch fixes the return values of the function by removing the > negation. >=20 > Signed-off-by: Kevin Laatz > --- Acked-by: Conor Walsh