RE: [PATCH] crypto/ipsec_mb: enable compilation for non x86 arch

[Ashwin Sekhar Thalakalath Kottilveetil <asekhar@marvell.com>]

Hi Fan,

There is an ARM64 port for IPSEC-MB https://gitlab.arm.com/arm-reference-solutions/ipsec-mb .

When we compile DPDK with this IPSEC-MB port for ARM64, the vector_mode value doesn't matter. 

And the cpuflag #defines RTE_CPUFLAG_AVX512F, RTE_CPUFLAG_AVX2 etc. are not available in ARM64. So these need to be made x86 specific.

Thank  you
Ashwin

Ashwin Sekhar T K 

> -----Original Message-----
> From: Zhang, Roy Fan <roy.fan.zhang@intel.com>
> Sent: Friday, June 17, 2022 3:53 PM
> To: Ashwin Sekhar Thalakalath Kottilveetil <asekhar@marvell.com>;
> dev@dpdk.org
> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Sunil Kumar Kori
> <skori@marvell.com>; Satha Koteswara Rao Kottidi
> <skoteshwar@marvell.com>; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>; Kiran Kumar Kokkilagadda
> <kirankumark@marvell.com>; Satheesh Paul Antonysamy
> <psatheesh@marvell.com>; Anoob Joseph <anoobj@marvell.com>; Akhil
> Goyal <gakhil@marvell.com>; Harman Kalra <hkalra@marvell.com>; Nithin
> Kumar Dabilpuram <ndabilpuram@marvell.com>
> Subject: [EXT] RE: [PATCH] crypto/ipsec_mb: enable compilation for non x86
> arch
> 
> External Email
> 
> ----------------------------------------------------------------------
> Hi,
> 
> IPsec-mb PMD should not be built at all if the library is not installed.
> Also, the code you are warping with macro only prevents initializing the
> vector mode param to SSE which is later used to add feature flag bits. To me
> this change does not make much sense.
> Can you share with me the purpose of this change?
> 
> Regards,
> Fan
> 
> > -----Original Message-----
> > From: Ashwin Sekhar T K <asekhar@marvell.com>
> > Sent: Friday, June 10, 2022 5:21 PM
> > To: dev@dpdk.org
> > Cc: jerinj@marvell.com; skori@marvell.com; skoteshwar@marvell.com;
> > pbhagavatula@marvell.com; kirankumark@marvell.com;
> > psatheesh@marvell.com; asekhar@marvell.com; anoobj@marvell.com;
> > gakhil@marvell.com; hkalra@marvell.com; ndabilpuram@marvell.com
> > Subject: [PATCH] crypto/ipsec_mb: enable compilation for non x86 arch
> >
> > Enable compilation for non x86 architectures by conditionally
> > compiling x86 specific code.
> >
> > Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
> > ---
> >  drivers/crypto/ipsec_mb/ipsec_mb_private.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_private.c
> > b/drivers/crypto/ipsec_mb/ipsec_mb_private.c
> > index aab42c360c..9ea1110aaf 100644
> > --- a/drivers/crypto/ipsec_mb/ipsec_mb_private.c
> > +++ b/drivers/crypto/ipsec_mb/ipsec_mb_private.c
> > @@ -53,6 +53,7 @@ ipsec_mb_create(struct rte_vdev_device *vdev,
> >  	const char *name, *args;
> >  	int retval;
> >
> > +#ifdef RTE_ARCH_X86_64
> >  	if (vector_mode == IPSEC_MB_NOT_SUPPORTED) {
> >  		/* Check CPU for supported vector instruction set */
> >  		if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F))
> > @@ -64,6 +65,7 @@ ipsec_mb_create(struct rte_vdev_device *vdev,
> >  		else
> >  			vector_mode = IPSEC_MB_SSE;
> >  	}
> > +#endif
> >
> >  	init_params.private_data_size = sizeof(struct
> ipsec_mb_dev_private) +
> >  		pmd_data->internals_priv_size;
> > --
> > 2.25.1