From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78F0DA0093; Fri, 17 Jun 2022 12:33:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1EAA540DDD; Fri, 17 Jun 2022 12:33:55 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 4AC3240698 for ; Fri, 17 Jun 2022 12:33:53 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25H3v4gO006665; Fri, 17 Jun 2022 03:33:52 -0700 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2046.outbound.protection.outlook.com [104.47.66.46]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3grj5h9ce8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Jun 2022 03:33:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LXNvV/qZNh0OnPNSed+xzaFyK+YLzgVNsra2cZWJgTECWXQ2oQYqDk5pbuct9QQPuUv9AO6nN3owzb4GZamzGYp7+vP4qmGjJNBzodgEHlO2ImnvZ2exTy4drnXI1rdakTzlF6ycgMbLcQUSfk+kU6y6BZVTQc7wFhUASjxCb3jvbBhaBVIRhRHHMoXWKEP9XVb8tmIcnuZ1QJo31fXWIq3kikF9ZzYaq3ydb2tERIIWnappVHV49G0UGTfR+c1eLUAIy0xjZqy/8jmjg7Z9N/8lBWHIZl7BYrUbDS9aRYO+0OxpH+idZZn6MpjS/XMgSbGkB/hKUxUMMsYkTTMkjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8Z+5Qd+e/x9w4RO4GStOwBtaJVa6QCQ2oAA1H+6NWl8=; b=CMvq/FWPOY8CNVfS0vi7fvbgdPdnNo9I4lZ32MsFShH3mmKpgYYYk3rAsgTMpOQx6x07lZPEZSEKejT40jpHiN31h18Dx9jZ2ToryzGNooPlVz6bRXRmq6d/K3aMqI8Kt/4PsIEBfEBZbdzLnJZyOaQyC9D0iHAwI7gKqDE4s0DDNzVq64ulgdDfDveHT9zTvjj359il0kY/BC+AUGQC1K5HtNYGiPzayKVsV0rzqX7qbkzYsKofY5qagv9CIGQgjMa51eSYe5QVMxOtCaljV+KgEQMqlEw27tiSjko7XDZTH8sSBKYdZNE8exnW4Yrv85NYB0OXHCaVC9r9IuRFsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8Z+5Qd+e/x9w4RO4GStOwBtaJVa6QCQ2oAA1H+6NWl8=; b=HYfxGWtlyYTXCsl4acGSD5makFIEXHb2SrAzhLpDtt5zwSbjfOe8+i3qU33HzH/AnlKyjmuQRlI8yuDm/HneZo+2+TKIev5EaXMLoSehFn9ZqdLj1e2Wno1HpAiBWj1J+4WN5LaFeVg0JhK4YapU12Q1YOfu4fz+g1pDGYB70qY= Received: from CO1PR18MB4540.namprd18.prod.outlook.com (2603:10b6:303:ff::13) by BYAPR18MB2838.namprd18.prod.outlook.com (2603:10b6:a03:10a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.20; Fri, 17 Jun 2022 10:33:49 +0000 Received: from CO1PR18MB4540.namprd18.prod.outlook.com ([fe80::b9ff:495f:c723:fd01]) by CO1PR18MB4540.namprd18.prod.outlook.com ([fe80::b9ff:495f:c723:fd01%3]) with mapi id 15.20.5353.017; Fri, 17 Jun 2022 10:33:49 +0000 From: Ashwin Sekhar Thalakalath Kottilveetil To: "Zhang, Roy Fan" , "dev@dpdk.org" CC: Jerin Jacob Kollanukkaran , Sunil Kumar Kori , Satha Koteswara Rao Kottidi , Pavan Nikhilesh Bhagavatula , Kiran Kumar Kokkilagadda , Satheesh Paul Antonysamy , Anoob Joseph , Akhil Goyal , Harman Kalra , Nithin Kumar Dabilpuram Subject: RE: [PATCH] crypto/ipsec_mb: enable compilation for non x86 arch Thread-Topic: [PATCH] crypto/ipsec_mb: enable compilation for non x86 arch Thread-Index: AQHYfOYmUngef0sZQk6y+YPUyoS3Nq1TbsMAgAAAXVA= Date: Fri, 17 Jun 2022 10:33:49 +0000 Message-ID: References: <20220610162113.1827884-1-asekhar@marvell.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 10426320-f4d4-4bb5-e529-08da504cdddd x-ms-traffictypediagnostic: BYAPR18MB2838:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VLudIUYwMRlJ82Mz3OAxlcJYc1BSsVlCiwak/UDg0SYp2/yal0d2LNsoNVzhKPUNtarRQhv4470aevYJoM7kkGcMwWXgHCd/3r+CRaq1xh3SeR8oEyOmrtMaGJq+BmuZeTOIFkDM00oBzyazdtDdUes6fAiSRmxoaTAbr3cJMTeUE4RuhtFURYdcJdNBuZFE4cvgo3zppus5+kMnshR02CAwIoKyEQvf5p9ylTkPChqyPfdz/K75LKV52n3hrVloMdsDTTIf6kZ79lq0wWKehW6vMTMeK/6Ar3+EU7KNovMWG1yTXjTK82fMTrDCicEcQwicNBXAJVewps8GtUnTpIy/iZw4uUu/1LZ9dOalZ05BUYmuyEieIArcD8t2SDLZiqrDVkfoGrtqom6bJJn80DKFDhx8+XuU9w372Tkplpxd3LLTB3ntXSnpXZehHg4H7HK14LO9gFXdCorHP3syUC0hZ+r2HWuML/TVBU4b8TPn31WZgCh6W/abN60uyCQ2FsoCyipOoXPHVxfrRByKMGry8T6m5P+aPZgYnqDUnm2/bbb+BXmzxidYDPVxJ9J8o3wNFpNUOQ5+7WOvmXY23ZEF5zkThS7XrA6tTIC3Q340pwUCJXlU9eFqgCW/cii+dRLocnmJZugcCv6b9nFuUyZgyEWLOKGRh/pcXQxeLgPZROLEaNmf5zE48T9GEsFwIUC5tOdnBMWXkKutBAyNzIsdrrnnH/sk4cYrs/eIoFVOI/Q0KbVnY1+b1nqGQzWSX+yEtx26x3GDDIW590AQo8BtAJmXZJFgRCM3GM7ddqM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR18MB4540.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(122000001)(66476007)(64756008)(52536014)(76116006)(4326008)(2906002)(8936002)(107886003)(66556008)(66446008)(38070700005)(966005)(55016003)(498600001)(66946007)(8676002)(71200400001)(186003)(33656002)(54906003)(110136005)(316002)(5660300002)(83380400001)(26005)(86362001)(9686003)(7696005)(38100700002)(53546011)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3VVANVG22L3dyqYnzBnbtEe5XM2jGx2mDgg/9SWJ9HSfPoGxYj99hDpDEP4F?= =?us-ascii?Q?AE5CjoJR1ULjLdpZwNUIH9o30S/KI/WZtp7cGrOlkkLUJbI0uI27Vo8GF63g?= =?us-ascii?Q?VSZ18Yhibk9hisvr0Leh3ZwT6pG4Qrn6FDq3mVkVkGJFEvl7WLisBVisiKGE?= =?us-ascii?Q?JktVX1wYT85D/fd20i96pZit43ktZpMsfa2+YAjTM1cFGvmEi6G/eFEgNA0r?= =?us-ascii?Q?uYs1fFm2gCejAzMZG0syss0FkFN1HUvVEMAYVDEf8a7nb30B6E1l9CqRjrgS?= =?us-ascii?Q?9Y/MaUtA3Y20bDT3VrJLBLW4ZCxQPbSrHYKrj3M0KsTvJFekBQJTGn2B2Zee?= =?us-ascii?Q?Tbg9INTgiMqUl+l5TJod64jf4kpcJZp4Hm12WOCNSS4TdXuTsiFT5r6YnjXj?= =?us-ascii?Q?teBs3VbOGbBbepdPzsdNwDaeeGR91rDJH6lOTsZrT8lpUj1G4AFbh9yw6qL0?= =?us-ascii?Q?K0v+FIxUGU93R8wmbJGrbA2pS5bzvRu9CFDb3M3dh5zTeuOG4VRmXBcIgOzL?= =?us-ascii?Q?B1jvyPyoD3m/sLgKeCpb/CTlTj3t7J4ygo/qi6KV/5+GyzJ2pfjqV5ZTPFJ2?= =?us-ascii?Q?vFc6n6Nt9LcjjLDK0U20BktWyRbmcbjdlSWnHltyq/lPl/SMP2HXAh6xjXut?= =?us-ascii?Q?3VchBEcm6lR+dEMJFQB5DpPp9Vvg2PoiYYq6FMZiKJWrm1PTZehqnoT3ZSoR?= =?us-ascii?Q?ZIxYmGN0gon3aPtFNAvGnU5mEiQYdBOmGdZLyhoAM11oBPrhjV6Y4cfqFfz+?= =?us-ascii?Q?+5mFZUF8EXb5VgyTnJEREm9svGg4Fb/oLKGRdHsSgw1fnskU7qPebfIgqYiX?= =?us-ascii?Q?vjNNxoX/ZsLtCzCtQHq5iatPhOt76gz82my7j2CDAE74fKxxpwuYiLP/hvHl?= =?us-ascii?Q?xiVt0t1/aQM3AUronj6DzdHQIrdKaOGYgBLwbNoLdtq7ReI5O/NAiyVWx5Bg?= =?us-ascii?Q?Ld2kLD4HzO3/dOamcztD5LVPkmVDYeK1LuLgeqNiN43+blQ577OgH+gSLsaG?= =?us-ascii?Q?QlmaIQgVezy1BuSvxu2wNWzAdBJr2fsxmLe94eoYCHbaWX2U0OV4GPqmSUgc?= =?us-ascii?Q?LFZUxMG6Aqeo89D7hCy/ekqWG8iZagrWlRq6bjdADcmE/i2D7Z4xDZsarPWx?= =?us-ascii?Q?moNz3cErl8eqGaiVl2oSene0yI/KsOFJk1FvR6UP6AUtd946u+dAqlktESym?= =?us-ascii?Q?EIeY8F4DcWq9ZzDSfoXasKSEKwEUq+sUK/u8F/26s+7mFeSlbUe/wM7S00nK?= =?us-ascii?Q?Fyw+CTxNPWCmLBRKpkOrzopex4RPMGCFY8SLU/yI4p9SyBZYPCmCds/g/tWb?= =?us-ascii?Q?hpJPIJaZ8o7o8XV2JU4OVt20t8AxVyAMoJRX5/C98B6wi+KGb/aC5/xPuM9H?= =?us-ascii?Q?wkDnrVN1bB7kf3yHw5Ayw1tACh6dB6s2lecxtZVsQLT8m1PCt7poIFyMQsCh?= =?us-ascii?Q?LbPlsYBtWPp4BjdE0GnTIYGyBsqAFiR5tGEC+QEZcSUYJ47RjxG6TGOACv1m?= =?us-ascii?Q?I1OvjHL+rNoJSEY5/2FPNixEck2fXQWGGnv3lAbrDr52dsTrsDVR4T45vL1O?= =?us-ascii?Q?+8OxHLgR27SzvuxQrsqO/r8GG8ZORcofCpXrxfDKy4q7tzldokswqb0VsfCz?= =?us-ascii?Q?NBlEuS85tsBk6oGk/wYg9d4H8710/NK3W4jj/3wHAwxkBOIivMRFphXO5bdT?= =?us-ascii?Q?tg3vgd26XgYdb8tbCMW52hjoih/4lv7Q3u6ZY+PcDRbLmxc/6D1bePSMHA9G?= =?us-ascii?Q?Sv88C97DDg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR18MB4540.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10426320-f4d4-4bb5-e529-08da504cdddd X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2022 10:33:49.5765 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MFWX82+wJBKpCHFoegyTvfRh14t9pwnysU9KRkBNFwtMZmKOHy1TSxcvBoddV+jqZwzLM1U8mz86Qwjg5PeVrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2838 X-Proofpoint-GUID: 0iduT7SCLUU7sAxvhzRN31VDj1Kigngn X-Proofpoint-ORIG-GUID: 0iduT7SCLUU7sAxvhzRN31VDj1Kigngn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-06-17_08,2022-06-16_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Fan, There is an ARM64 port for IPSEC-MB https://gitlab.arm.com/arm-reference-so= lutions/ipsec-mb . When we compile DPDK with this IPSEC-MB port for ARM64, the vector_mode val= ue doesn't matter.=20 And the cpuflag #defines RTE_CPUFLAG_AVX512F, RTE_CPUFLAG_AVX2 etc. are not= available in ARM64. So these need to be made x86 specific. Thank you Ashwin Ashwin Sekhar T K=20 > -----Original Message----- > From: Zhang, Roy Fan > Sent: Friday, June 17, 2022 3:53 PM > To: Ashwin Sekhar Thalakalath Kottilveetil ; > dev@dpdk.org > Cc: Jerin Jacob Kollanukkaran ; Sunil Kumar Kori > ; Satha Koteswara Rao Kottidi > ; Pavan Nikhilesh Bhagavatula > ; Kiran Kumar Kokkilagadda > ; Satheesh Paul Antonysamy > ; Anoob Joseph ; Akhil > Goyal ; Harman Kalra ; Nithin > Kumar Dabilpuram > Subject: [EXT] RE: [PATCH] crypto/ipsec_mb: enable compilation for non x8= 6 > arch >=20 > External Email >=20 > ---------------------------------------------------------------------- > Hi, >=20 > IPsec-mb PMD should not be built at all if the library is not installed. > Also, the code you are warping with macro only prevents initializing the > vector mode param to SSE which is later used to add feature flag bits. To= me > this change does not make much sense. > Can you share with me the purpose of this change? >=20 > Regards, > Fan >=20 > > -----Original Message----- > > From: Ashwin Sekhar T K > > Sent: Friday, June 10, 2022 5:21 PM > > To: dev@dpdk.org > > Cc: jerinj@marvell.com; skori@marvell.com; skoteshwar@marvell.com; > > pbhagavatula@marvell.com; kirankumark@marvell.com; > > psatheesh@marvell.com; asekhar@marvell.com; anoobj@marvell.com; > > gakhil@marvell.com; hkalra@marvell.com; ndabilpuram@marvell.com > > Subject: [PATCH] crypto/ipsec_mb: enable compilation for non x86 arch > > > > Enable compilation for non x86 architectures by conditionally > > compiling x86 specific code. > > > > Signed-off-by: Ashwin Sekhar T K > > --- > > drivers/crypto/ipsec_mb/ipsec_mb_private.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_private.c > > b/drivers/crypto/ipsec_mb/ipsec_mb_private.c > > index aab42c360c..9ea1110aaf 100644 > > --- a/drivers/crypto/ipsec_mb/ipsec_mb_private.c > > +++ b/drivers/crypto/ipsec_mb/ipsec_mb_private.c > > @@ -53,6 +53,7 @@ ipsec_mb_create(struct rte_vdev_device *vdev, > > const char *name, *args; > > int retval; > > > > +#ifdef RTE_ARCH_X86_64 > > if (vector_mode =3D=3D IPSEC_MB_NOT_SUPPORTED) { > > /* Check CPU for supported vector instruction set */ > > if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F)) > > @@ -64,6 +65,7 @@ ipsec_mb_create(struct rte_vdev_device *vdev, > > else > > vector_mode =3D IPSEC_MB_SSE; > > } > > +#endif > > > > init_params.private_data_size =3D sizeof(struct > ipsec_mb_dev_private) + > > pmd_data->internals_priv_size; > > -- > > 2.25.1