From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 315D4A0093; Thu, 23 Jun 2022 15:26:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C4F4E40146; Thu, 23 Jun 2022 15:26:26 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 8300B40042 for ; Thu, 23 Jun 2022 15:26:25 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25N9wYMH025916; Thu, 23 Jun 2022 06:26:24 -0700 Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2168.outbound.protection.outlook.com [104.47.58.168]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3gvp0uru63-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Jun 2022 06:26:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jWtCr4rAr3Eqi7OgvS/5MsCMOE9m6MMqI/TW4N7xFwwYJzZQrScsJzN3I+IW+7mTHy1zH5Q2WWBWwOVMcpCcmltc1H1YfpeJUfCcGd4mGowD+HMMkvOoO9Iv4+g0GCzXDV5EvzAIZtEC3q1eD6bhz17Phdd/yH+C9aW3RyMjNYBFCQIbhf7LM+QYLrYmt0KxNeiP976uN5s8zGpoAiW42bvRrPObu8BjAtSAvaZeEidnafEARzbu0Pf6swROUXdAK05Lhf8lLXeKDSbW8u7eY08v/CpU6JQbEtz+RZAqtBMV5uq5b1W7gkwod51adlJdttolVnIlqXFwuapi2XYVaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+689Ell9X6j4jI+A9pzizJGuf/JKiZCjIuFGqUQn208=; b=fwy0VT3GN+g4FR33pzdgRjZXk8XNq5uDF/lib4yybXClaZcuho1DF6WzuDUx8BbkOUgXots7ayHKaFSns6U0QuJHyOh11aaZdz3BLZAqGJRe1QpJZxSAsSLwdQWlH70Jgx2dPUHnV9SVKPBXIKb/YgZstOJNuz1B5WEQTksoLUStIBqlOh4O3MzUfXC5aOl378i7KKoYjsXG7OQPuqw5SYyFrVBLFiUOl3ucrXVq4kC2EYGOPV1gihPcwQjfFC4O7mb4xHKR/mnIGjApb8slbupklr2eKtgObM6OX9YN1+j1nbG7RuH5yBqUvdQ0BJWiHO5h//bVc6VAVprN+7PzXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+689Ell9X6j4jI+A9pzizJGuf/JKiZCjIuFGqUQn208=; b=l9ocKi1SUlZ/lHczOyMhk1Mv7rUlY/u0GVG6VwigJjL+7SLDRJIp4LBeW9/yBUjdOJGc2TrT3e9nVQwTW9ucjbsb6BU6LFc1QsDxprVlJEWoK2lbIBU3kWSsN2bCWrXvb+IFqTz0PWEaDqN1/8nzYJj6CFgPwEQXMbXVCkT+RpQ= Received: from CO1PR18MB4540.namprd18.prod.outlook.com (2603:10b6:303:ff::13) by DM6PR18MB3099.namprd18.prod.outlook.com (2603:10b6:5:1ce::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.22; Thu, 23 Jun 2022 13:26:10 +0000 Received: from CO1PR18MB4540.namprd18.prod.outlook.com ([fe80::5051:220f:e832:b72]) by CO1PR18MB4540.namprd18.prod.outlook.com ([fe80::5051:220f:e832:b72%7]) with mapi id 15.20.5373.015; Thu, 23 Jun 2022 13:26:09 +0000 From: Ashwin Sekhar Thalakalath Kottilveetil To: "Zhang, Roy Fan" , "dev@dpdk.org" CC: Jerin Jacob Kollanukkaran , Sunil Kumar Kori , Satha Koteswara Rao Kottidi , Pavan Nikhilesh Bhagavatula , Kiran Kumar Kokkilagadda , Satheesh Paul Antonysamy , Anoob Joseph , Akhil Goyal , Harman Kalra , Nithin Kumar Dabilpuram , "De Lara Guarch, Pablo" Subject: RE: [PATCH] crypto/ipsec_mb: enable compilation for non x86 arch Thread-Topic: [PATCH] crypto/ipsec_mb: enable compilation for non x86 arch Thread-Index: AQHYfOYmUngef0sZQk6y+YPUyoS3Nq1TbsMAgAAAXVCABO1wAIABGjmwgANM0oCAAEvGsA== Date: Thu, 23 Jun 2022 13:26:09 +0000 Message-ID: References: <20220610162113.1827884-1-asekhar@marvell.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7f422d49-6b98-4e2c-5c17-08da551bef6d x-ms-traffictypediagnostic: DM6PR18MB3099:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6mqNITJAJsaehJhKSn/0jIXWGroRry8hlS7laQq28BX+3PTqVNjvb0k8l5q9Z9VKVlBIq8KpoACGwAEYAHHiqlzI2nOsBxTvQX5sfPWmzR5sldpeSFV3FOYX6mZHuBACwueGCX8Iab1QnD2a9DTnAu2UgyHMEAfxGFflf/5dqHf3QGRVbwA1oNGb/KEtLmFMQY8elKcp86RIl1i4UlwXySb2JYjxtTJhJCLpg2pMEkWDriKPmDgo+KQYUucrw6qTvNQTF2ansup453/I5gbWJFXEYhPJt/wLUme50Xzblu68AMOsBCLrDPz+v4WlQMjnXNvyIhrfVnsuCdseKeP3oZGOECfnyO/jXqC4CcRH70r2A22C2yTW3t4Q1o/KqEvBvHoyCLa7bfLvcKYjymIFDRr1eWGYFuBtYg+mAA80dpZz3gD1O70vbGGQXOJLX1USHlP7lWmoghbkmg7FnBgmdkC/XQSjpGuNF1HzoNN/DDBUkTp/lVlgPwWILD64H8neFrcaBztmqFsD3XXawSUqfEVQbUJ4/wTc8ZKEiJFXdsYjwQK+F+IgpT5SSccCe1IRS/7ZMMSU0LR1QcBP8/oXB5sXQKGraSiy2aWV8YEwa2DDjGNu46qAwcHWT6tJO5DSrCCYZ4RiPyoyFoSMjiFHfUwx1ub3af7ihFnFSmoCQMn2ZRFA31jppVvQZhDfbMqvRgChlLOszzEjMWo7ZizJxne/cwfQrGykryhPU+To9Mj67X0Z1T0I2EcjgBBbwe6v7RPweDMOng2bYpNhK8wMPwc9GviG3/EQYxFe3oJNKz8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR18MB4540.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(376002)(366004)(39860400002)(396003)(346002)(136003)(41300700001)(8676002)(83380400001)(55016003)(7696005)(478600001)(122000001)(966005)(5660300002)(8936002)(53546011)(86362001)(71200400001)(33656002)(52536014)(9686003)(26005)(6506007)(64756008)(66946007)(38070700005)(66556008)(2906002)(66446008)(38100700002)(110136005)(4326008)(186003)(19627235002)(76116006)(66476007)(316002)(54906003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KBJQz74GrZCVZelpIbMxNP6+z7mefxibgiP1Lzrag82nseeEXosEKUtbpbwU?= =?us-ascii?Q?OB1OGTkRKb8qmZ05/eP4o+gP2ZvC31do0S6Qyuh9IYoHjKx9NuOkzwK0Phq3?= =?us-ascii?Q?YpRILmMoByggiTdur8/9/HCO2CjI6lsSFV3Wb5sQgzLmN+r+la0rZtor6lMJ?= =?us-ascii?Q?Q3diEexReeRxSZhzmb5EE4eE+bwKzG6mvMRTe7UNphXC5WKRvoqOJ8y/WriY?= =?us-ascii?Q?MVOz+foXys/aL3rwEzdJz8ZFvZaiFAIC3DY2FnhxNbLoeq+3UyhNAYDSQYL4?= =?us-ascii?Q?5zWuZxCGHrLI25KicsaOK2JPSxXj8npqPSiFiLXM8sGqegOXVlr6YwxO+aZ2?= =?us-ascii?Q?nqZEz/sxLvIjlzogofmJsQZLpxoqB3lLhtuBy8b9wZDmezIedHxZiYKXeHCu?= =?us-ascii?Q?MFJtgjOTA+ZcurLBUy3c9sOzYfmhwzgkMG9EJI+Lq8xGdcNubeWq7nfX0aq/?= =?us-ascii?Q?7lz2SBvTdD6QQHKDipMZF6RvUW/UxliKL8GNSHfw/JQQTD1kNUQn4DmFYNEW?= =?us-ascii?Q?FiDRh2RcdXANG1qY6F3yUrQc9zy0Oo1vqJQ4VA9fY95kaF4okpb26nZAdjO1?= =?us-ascii?Q?gLPI7zs1tWb7nSD+kuA+Og6eiqAPAcpQYASY4kv/ADvoanZAVKrt4dNPGqK8?= =?us-ascii?Q?SmubeqUFmDnFnyXJxM7jKSn7EoYf7emdOJw3vqUEy4r4jmpH7By0t8Goneu8?= =?us-ascii?Q?ZiB5XrZfkZqTv0LCcv/G2BdCdbYiNRH+VuIodVmRqMWXs4jLS78CPckEbP8L?= =?us-ascii?Q?3HmRihP/DclxRUVp258/0Wnlx+wv6CtpryrJ4eSJ/ZiVZUzOGOoVoeVdfOc+?= =?us-ascii?Q?nie/MShigzM1/X/WEhhnMYyLAtsqJ+7xi9+ou8ZUMQW10RDGchuXP1oK4o9d?= =?us-ascii?Q?L/uQ+BmgFJFFZ3tD4dy1VjZbfWieiToYsVrqCqyA8FpB8qa9ttB0+rCVkvrD?= =?us-ascii?Q?koUljkSEo9dasuLRJ/UBjxHEo777iA1h2QVWKfT1WimsO3OiCjTkDAwSmo2k?= =?us-ascii?Q?4MoplbEoU2wEFqoOTsYLVczffJseK/M41ILmjs/ldmQfk06er+3LsQ9Nrqql?= =?us-ascii?Q?HmTsxuFhm290HICOxS5UqQ/Cv5lslaANo30igOrw40AjzKTZwae4yjoNTMys?= =?us-ascii?Q?ZPZ7hng45p2cbobMgd4l8elWgFQfGpE50ljKPC8U1xnOf1K868QcF41AWLBd?= =?us-ascii?Q?q0gWoUCGH4Qom9j1gAD+82jYhnJlF4K1dzyYwmzFlJi419F+ZV1MsZqTZBCG?= =?us-ascii?Q?CCco18vy+vHU2OfAJW9rVQ109C84IKkt6sZf7kACUZD9cUbc5z9XIZSk0rpP?= =?us-ascii?Q?dwT2tG1q4h3NwYvwDbgTWRT1hOm1UnbU9qOwNQfVALv0rC7t53mY+FL641m/?= =?us-ascii?Q?ryhE7YsLPvKuEay6nkcGr7s4nCpbP89i4HyDbHyXhKf7OBATluWqzAuSCgPH?= =?us-ascii?Q?rqgFTMLVAf3PzTe5++kgFzUdBGZQmwLsdk2yZC84cb/sX/mQMmeggRge3g4C?= =?us-ascii?Q?ew8BPxNUrov73Id3abwYOJnuIfYWowzAeROydA8s36Fkprix9ttRhSiUA8De?= =?us-ascii?Q?3EduKvmAM9DUz5q/LLKxXsTjPLwMBnDYLUT0zniy?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR18MB4540.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f422d49-6b98-4e2c-5c17-08da551bef6d X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2022 13:26:09.5277 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sYal36fXOL6ZNY44TlEWfJK2C2QBonpXOGWOfp9ZphujxB27bGzA2NLjQcrwP+4mmPWQNinXcxyPM/pa7/Pcaw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3099 X-Proofpoint-GUID: aQw78vXnponM990uloavqbm66sQui8ON X-Proofpoint-ORIG-GUID: aQw78vXnponM990uloavqbm66sQui8ON X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-06-23_05,2022-06-23_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Fan, I will make the changes as you suggested. Regards, Ashwin Sekhar T K=20 > -----Original Message----- > From: Zhang, Roy Fan > Sent: Thursday, June 23, 2022 2:23 PM > To: Ashwin Sekhar Thalakalath Kottilveetil ; > dev@dpdk.org > Cc: Jerin Jacob Kollanukkaran ; Sunil Kumar Kori > ; Satha Koteswara Rao Kottidi > ; Pavan Nikhilesh Bhagavatula > ; Kiran Kumar Kokkilagadda > ; Satheesh Paul Antonysamy > ; Anoob Joseph ; Akhil > Goyal ; Harman Kalra ; Nithin > Kumar Dabilpuram ; De Lara Guarch, Pablo > > Subject: [EXT] RE: [PATCH] crypto/ipsec_mb: enable compilation for non x8= 6 > arch >=20 > External Email >=20 > ---------------------------------------------------------------------- > Hi, >=20 > Yes you are right - > Maybe with this way? >=20 > #if defined(RTE_ARCH_ARM64) > vector_mode =3D IPSEC_MB_ARM64; > #elif defined(RTE_ARCH_X86_64) > if (vector_mode =3D=3D IPSEC_MB_NOT_SUPPORTED) { > /* Check CPU for supported vector instruction set */ > if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F)) > vector_mode =3D IPSEC_MB_AVX512; > else if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2)) > vector_mode =3D IPSEC_MB_AVX2; > else if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX)) > vector_mode =3D IPSEC_MB_AVX; > else > vector_mode =3D IPSEC_MB_SSE; > #else > /* error return */ > #endif >=20 > The only reason I suggest this is to avoid forgetting why it is implement= ed this > way in the future... >=20 > Regards, > Fan >=20 > > -----Original Message----- > > From: Ashwin Sekhar Thalakalath Kottilveetil > > Sent: Tuesday, June 21, 2022 7:38 AM > > To: Zhang, Roy Fan ; dev@dpdk.org > > Cc: Jerin Jacob Kollanukkaran ; Sunil Kumar Kori > > ; Satha Koteswara Rao Kottidi > > ; Pavan Nikhilesh Bhagavatula > > ; Kiran Kumar Kokkilagadda > > ; Satheesh Paul Antonysamy > > ; Anoob Joseph ; Akhil > > Goyal ; Harman Kalra ; Nithin > > Kumar Dabilpuram ; De Lara Guarch, Pablo > > > > Subject: RE: [PATCH] crypto/ipsec_mb: enable compilation for non x86 > > arch > > > > Hi Fan, > > > > Thanks for the suggestion. However that will not work for ARM64. > > > > Please note that the #defines RTE_CPUFLAG_AVX512F, > RTE_CPUFLAG_AVX2 > > and RTE_CPUFLAG_AVX are not available for ARM64. So the compilation > > will break. > > > > I can introduce IPSEC_MB_ARM64, but still the current branch needs to > > be completely wrapped under #ifdef to avoid compilation failure. > > > > Does the below code look OK ? > > > > if (vector_mode =3D=3D IPSEC_MB_NOT_SUPPORTED) { #if > > defined(RTE_ARCH_X86_64) > > /* Check CPU for supported vector instruction set */ > > if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F)) > > vector_mode =3D IPSEC_MB_AVX512; > > else if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2)) > > vector_mode =3D IPSEC_MB_AVX2; > > else if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX)) > > vector_mode =3D IPSEC_MB_AVX; > > else > > vector_mode =3D IPSEC_MB_SSE; > > #elif defined(RTE_ARCH_ARM64) > > vector_mode =3D IPSEC_MB_ARM64; > > #else > > /* error return */ > > #endif > > } > > > > Ashwin Sekhar T K > > > > > -----Original Message----- > > > From: Zhang, Roy Fan > > > Sent: Monday, June 20, 2022 7:10 PM > > > To: Ashwin Sekhar Thalakalath Kottilveetil ; > > > dev@dpdk.org > > > Cc: Jerin Jacob Kollanukkaran ; Sunil Kumar Kori > > > ; Satha Koteswara Rao Kottidi > > > ; Pavan Nikhilesh Bhagavatula > > > ; Kiran Kumar Kokkilagadda > > > ; Satheesh Paul Antonysamy > > > ; Anoob Joseph ; > Akhil > > > Goyal ; Harman Kalra ; > > > Nithin Kumar Dabilpuram ; De Lara Guarch, > > > Pablo > > > Subject: [EXT] RE: [PATCH] crypto/ipsec_mb: enable compilation for > > > non x86 arch > > > > > > External Email > > > > > > -------------------------------------------------------------------- > > > -- > > > Hi, > > > > > > Thank you for the explanation. > > > In that case I'd suggest instead of warping the branches completely > > > with macro, wrapping on the last "else" instead. > > > Something like > > > > > > if (vector_mode =3D=3D IPSEC_MB_NOT_SUPPORTED) { > > > /* Check CPU for supported vector instruction set */ > > > if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F)) > > > vector_mode =3D IPSEC_MB_AVX512; > > > else if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2)) > > > vector_mode =3D IPSEC_MB_AVX2; > > > else if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX)) > > > vector_mode =3D IPSEC_MB_AVX; > > > else > > > #ifdef RTE_ARCH_X86_64 > > > vector_mode =3D IPSEC_MB_SSE; > > > #elif RTE_ARCH_ARM64 ? > > > Vector_mode =3D IPSEC_MB_ARM64; /* newly > introduced ARM vector mode > > > */ #else > > > /* error return */ > > > #endif > > > } > > > > > > This should also help setting RTE_CRYPTODEV_FF_CPU_ARM_CE in > device > > > feature flag bitmap later. > > > > > > Regards, > > > Fan > > > > > > > -----Original Message----- > > > > From: Ashwin Sekhar Thalakalath Kottilveetil > > > > Sent: Friday, June 17, 2022 11:34 AM > > > > To: Zhang, Roy Fan ; dev@dpdk.org > > > > Cc: Jerin Jacob Kollanukkaran ; Sunil Kumar > > > > Kori ; Satha Koteswara Rao Kottidi > > > > ; Pavan Nikhilesh Bhagavatula > > > > ; Kiran Kumar Kokkilagadda > > > > ; Satheesh Paul Antonysamy > > > > ; Anoob Joseph ; > Akhil > > > > Goyal ; Harman Kalra ; > > > > Nithin Kumar Dabilpuram > > > > Subject: RE: [PATCH] crypto/ipsec_mb: enable compilation for non > > > > x86 arch > > > > > > > > Hi Fan, > > > > > > > > There is an ARM64 port for IPSEC-MB > > > > https://urldefense.proofpoint.com/v2/url?u=3Dhttps- > > > 3A__gitlab.arm.com_ar > > > > m-2Dreference-2D&d=3DDwIF-g&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DpYk- > > > QOhvnkU-_75y0 > > > > > > > > NKSn535ZotEGI_E69Py3Ppondk&m=3DhJ5ewsPh0KMcvMFylomkCk_hiNsuTm- > > > HfHad1UoQy > > > > K7MHqUyXvJSwSgyAQQThWyj&s=3DmL8bOzY63JQ- > > > 6CBhruqHv9bE5sEWT5PfXRFv4zbI6mw& > > > > e=3D > > > > solutions/ipsec-mb . > > > > > > > > When we compile DPDK with this IPSEC-MB port for ARM64, the > > > > vector_mode value doesn't matter. > > > > > > > > And the cpuflag #defines RTE_CPUFLAG_AVX512F, > RTE_CPUFLAG_AVX2 > > > etc. > > > > are not available in ARM64. So these need to be made x86 specific. > > > > > > > > Thank you > > > > Ashwin > > > > > > > > Ashwin Sekhar T K > > > > > > > > > -----Original Message----- > > > > > From: Zhang, Roy Fan > > > > > Sent: Friday, June 17, 2022 3:53 PM > > > > > To: Ashwin Sekhar Thalakalath Kottilveetil > > > > > ; dev@dpdk.org > > > > > Cc: Jerin Jacob Kollanukkaran ; Sunil Kumar > > > > > Kori ; Satha Koteswara Rao Kottidi > > > > > ; Pavan Nikhilesh Bhagavatula > > > > > ; Kiran Kumar Kokkilagadda > > > > > ; Satheesh Paul Antonysamy > > > > > ; Anoob Joseph ; > > > Akhil > > > > > Goyal ; Harman Kalra ; > > > > > Nithin Kumar Dabilpuram > > > > > Subject: [EXT] RE: [PATCH] crypto/ipsec_mb: enable compilation > > > > > for non x86 arch > > > > > > > > > > External Email > > > > > > > > > > ---------------------------------------------------------------- > > > > > ---- > > > > > -- > > > > > Hi, > > > > > > > > > > IPsec-mb PMD should not be built at all if the library is not ins= talled. > > > > > Also, the code you are warping with macro only prevents > > > > > initializing the vector mode param to SSE which is later used to > > > > > add feature flag bits. To me this change does not make much sense= . > > > > > Can you share with me the purpose of this change? > > > > > > > > > > Regards, > > > > > Fan > > > > > > > > > > > -----Original Message----- > > > > > > From: Ashwin Sekhar T K > > > > > > Sent: Friday, June 10, 2022 5:21 PM > > > > > > To: dev@dpdk.org > > > > > > Cc: jerinj@marvell.com; skori@marvell.com; > > > > > > skoteshwar@marvell.com; pbhagavatula@marvell.com; > > > > > > kirankumark@marvell.com; psatheesh@marvell.com; > > > > > > asekhar@marvell.com; anoobj@marvell.com; gakhil@marvell.com; > > > > > > hkalra@marvell.com; ndabilpuram@marvell.com > > > > > > Subject: [PATCH] crypto/ipsec_mb: enable compilation for non > > > > > > x86 arch > > > > > > > > > > > > Enable compilation for non x86 architectures by conditionally > > > > > > compiling x86 specific code. > > > > > > > > > > > > Signed-off-by: Ashwin Sekhar T K > > > > > > --- > > > > > > drivers/crypto/ipsec_mb/ipsec_mb_private.c | 2 ++ > > > > > > 1 file changed, 2 insertions(+) > > > > > > > > > > > > diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_private.c > > > > > > b/drivers/crypto/ipsec_mb/ipsec_mb_private.c > > > > > > index aab42c360c..9ea1110aaf 100644 > > > > > > --- a/drivers/crypto/ipsec_mb/ipsec_mb_private.c > > > > > > +++ b/drivers/crypto/ipsec_mb/ipsec_mb_private.c > > > > > > @@ -53,6 +53,7 @@ ipsec_mb_create(struct rte_vdev_device > *vdev, > > > > > > const char *name, *args; > > > > > > int retval; > > > > > > > > > > > > +#ifdef RTE_ARCH_X86_64 > > > > > > if (vector_mode =3D=3D IPSEC_MB_NOT_SUPPORTED) { > > > > > > /* Check CPU for supported vector instruction set */ > > > > > > if > (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F)) > > > > > > @@ -64,6 +65,7 @@ ipsec_mb_create(struct rte_vdev_device > *vdev, > > > > > > else > > > > > > vector_mode =3D IPSEC_MB_SSE; > > > > > > } > > > > > > +#endif > > > > > > > > > > > > init_params.private_data_size =3D sizeof(struct > > > > > ipsec_mb_dev_private) + > > > > > > pmd_data->internals_priv_size; > > > > > > -- > > > > > > 2.25.1