From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D40E9A0503; Thu, 19 May 2022 07:30:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7DC7240150; Thu, 19 May 2022 07:30:14 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 530B840140 for ; Thu, 19 May 2022 07:30:13 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24ILMP2m010292; Wed, 18 May 2022 22:30:11 -0700 Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2103.outbound.protection.outlook.com [104.47.70.103]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3g50as3p4s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 18 May 2022 22:30:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bb5dmJoh00Bvl8egdTzedm/uHrOlX5V7j1zJAiHA3x/yVuwvvMTaqSt7NjnyjGQ6+u/0RTtQnP7glOMySXZrat0Upq0BsGAU1xDR9U6ZmUOb4kVMtkS3Wzxf5jNW+b0/T3MHlu2wtkNq3TjxV6LzMym1mhW6C/aVFhzKgEXChDHXc6AHThLjZjtBTLl2sP8ilFtxqgaaQd7+fCDfYCkQRyNPxTSrEyQ5PdZbrD4jwIGS00guHAgVO1kyPx3uYhScLGBonLB9Z17cmgoNfh4LaCUwpZWcDdMQiIw5sbd1vT6jofOen5rdVWENcmknh+zWnxhg0dXdh/lbpH0RnC4rNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MjVkhMG9ff4xBc7SOB9KYTGhcofEerwrWJe2xWeYSMs=; b=mzyIcSgzy+4MmZLvq0c+eUCZQ4PZTAQ4M9jaMtqqJzNAPyAAnoFx7Ejqu9P8soOupjxdmKHo+tj8lQdliGSLAb/mkZ2GDfZhdlbeRwtrwG11y+tANJ6Nq1asfLYqF7YWkPeyVq1YxcZZ0RNrNLyKVvqGy5rj4cAiX0mCSuEQFHY921R3wK0Jj+iV5O3UIBnc1M1KW1pQrB1XnT8T6snDNU3ia6XGk769s8wH9woTH+xQgnC82ZFRjbgc/8xW01tDTtblxwop3fyuHvzrmXqRp+t2VrNO2kbGUnbi/j9SceiYGzpUaNJMdxFC//BpuBJGGid09jY5QEOSy/sd+AOVVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MjVkhMG9ff4xBc7SOB9KYTGhcofEerwrWJe2xWeYSMs=; b=f2wHqhDfqhP7/YFwjqsa+gnAyVETlCEGFOEND8ZnQqiUIa5v/T8Wx6rvjKeC95rVYP06Jxc3ZVvoaWxqCyR8uu/R8mqYOVpHMsfjxRBwTvDbBUpctD2incqtLkbNXM7ylNX2FLAJiSN6nc03bncE2yO4MYy04d35S218tXbiqck= Received: from CO1PR18MB4714.namprd18.prod.outlook.com (2603:10b6:303:e9::18) by CH2PR18MB3399.namprd18.prod.outlook.com (2603:10b6:610:27::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Thu, 19 May 2022 05:30:09 +0000 Received: from CO1PR18MB4714.namprd18.prod.outlook.com ([fe80::f83c:2654:ed5:fd1f]) by CO1PR18MB4714.namprd18.prod.outlook.com ([fe80::f83c:2654:ed5:fd1f%6]) with mapi id 15.20.5273.014; Thu, 19 May 2022 05:30:09 +0000 From: Gowrishankar Muthukrishnan To: Brandon Lo , "roy.fan.zhang@intel.com" , "ciara.power@intel.com" CC: "dev@dpdk.org" Subject: RE: [EXT] [PATCH v4 4/8] examples/fips_validation: allow json file as input Thread-Topic: [EXT] [PATCH v4 4/8] examples/fips_validation: allow json file as input Thread-Index: AQHYW+SAc7uUd7I0/kCaTUnV728KmK0lyhIQ Date: Thu, 19 May 2022 05:30:09 +0000 Message-ID: References: <20220129175514.746925-1-blo@iol.unh.edu> <20220429161559.415645-1-blo@iol.unh.edu> <20220429161559.415645-5-blo@iol.unh.edu> In-Reply-To: <20220429161559.415645-5-blo@iol.unh.edu> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2525e824-635c-41ef-4b55-08da3958a39e x-ms-traffictypediagnostic: CH2PR18MB3399:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Hw9RoYeKFiYxtcbuLoFN/FtSnyFCgZrG9+ZVpR6jKuAUkw27Err5bjIJm6UkmTzTOxUN10S6cp3vKPkkNAYLgIx0qu5N0/Bya5t1UD1sNkijTOAVfqB38n4WtDxSImyitw+nIaO5udXSmFBOPFDL702nqyu5ur+yojxB3vC4uJhnz/i+MbgZtsCrtVDjr2VIadLuRKZh4usnfKMCcq62plo+bkgcSwejloFG3DW2NpSPSKoI4a7eA5sTlo10lwoWnt4XXwRLLYP4T3s82XuSiFJD8g7WHL6FIiEPHYYtsLtL2ildOzEyWjsHcq15txDybkyDW3Y0r7MV+elDIyNgGGhhuHbMiB1Yjal9VgjzHboHJOkWSb+B4gkwsYG5Le3jD9+AI0m9tgZI56UEWdVCnafnrD6s0T8jAM6SQ4i4PDa3DzoYMzlAEIbfuaBEuX6cMKoHNk1fWB+9BY4Log2K6qqJpVeXeMx4uuHWHTZVkPh3yU6VW24eFKN3Oit0ZVbznB0D1v8xqUn5CIyxI9C3UYUc+Vm84lh161oTANxUUdi1GilxIz1Qsc5uvn/H7t0rfaoViLAmSY8900dwbhfQcpyZh34tCFeVNt5cXCxXW2dBZBv3zgqj3pFc2KeuU5FZgHmDZR7zRRey+80hDbg7f8yV+aB3NB1SvyIvMWHKNbceuuMz3dyiGQmfBIJvSXLe+TE35qg/aNDusDPablp84w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR18MB4714.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(38070700005)(122000001)(186003)(83380400001)(86362001)(38100700002)(55016003)(8676002)(508600001)(76116006)(66946007)(66556008)(66476007)(66446008)(64756008)(26005)(6506007)(7696005)(9686003)(110136005)(316002)(71200400001)(2906002)(33656002)(8936002)(4326008)(52536014)(4744005)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2u29p7ET7JLgz3rI2vCaQF8cWTOVLbKIKCyLoOMd8zLwEBUdyTLRO0hE/IDX?= =?us-ascii?Q?RPxgfYfr87sM7Sai5pZ7IkF1Eoz3LSIYDd2/eM1tNPGPM4HbnoQfhLXVREy2?= =?us-ascii?Q?cWYgqjhZtkixNfKywZdCgybvvTosF+W85ETzkFBnZBAOX933ZzIXj7p0jXGf?= =?us-ascii?Q?9Py8TZRnY6UYP5U7Tx4MMTUmj2ew11COOuo8pVvboX4OICfMFnyM7siZvxOk?= =?us-ascii?Q?OuvYrod358xriOvN0LWpBo2wwlP/V87mGDyCt/2dpYfSaFmbIRX3+PWH/wUC?= =?us-ascii?Q?48weQOP7cyLUyh9DUgR/Z3SDKgV24pXoNLI9S28+Weo/kuRSD+I4X3PtmA+A?= =?us-ascii?Q?S73m7H01+O2n1uKz/T0VejiwLYzGLXGFdDzpzA364VC6PRZu/hPCz4XZnZdy?= =?us-ascii?Q?o6N7AuvzirFWGSfweBrrFy77aI8n2UEVJ6LADlx3yVTWnK/njcoCv4EGNWKW?= =?us-ascii?Q?4aT9UOllxofrHARQHnudDlx/0tuV2V7IWB8IY/H0Z8orE5ShOg37nSrOQnFh?= =?us-ascii?Q?w9GX2vRaVNjlDZ3mvONuBxGUvpDNEvsyCOLydOjI27Ltwzgm5/n5D132sn9k?= =?us-ascii?Q?AlhdWL0blOpezK3K9whw8m5DI6hVPR2BLBOIGe1Fv0dmxSRh6sBut4LXoDTu?= =?us-ascii?Q?nlJgslIYsHn9YjBzFrzvMpOCVyRRJFaagNRFEglKnEEMqPA2CZtZFrF27/Le?= =?us-ascii?Q?l84YcV7Lx+ZILU/sbrxqnechfzjtQy3asOVc9KmEw2LW2ClajQQyMbkj8Au1?= =?us-ascii?Q?kFWcgzRd7H1g7gqSodc3dFES5DTM+DOM53szY4l1x3UVdbyQH23bqMSrrv2Q?= =?us-ascii?Q?+27Z59ktibKYi5b9DEekDNrhv3Z0axJh0mh0F6v+djMxMlSmMBzKWnIwiYez?= =?us-ascii?Q?9LVp3ANMNHcBppD9qihPNc+ve57vre1AL89GZOgPKXLuzyCX6tCEORmZA+Hd?= =?us-ascii?Q?zzv6e/p6kEUgdSiBfGFmeldFokaE+cJpSb5W2rattJG+0YsBJC584kM6Sbv+?= =?us-ascii?Q?rd/TS5fL84uCO39RrBU3YIDuA2/R6+gKP+KcpOHa04hx0C76meMhjtBvqb+V?= =?us-ascii?Q?RfF6dvBy82VXKJrMY3TvFSXIV9RTAz3LZvuIY9AQffX6TgOKreOVkFJNJvZz?= =?us-ascii?Q?txek434lz6zdZzsuQnXOJ+92z0bwNERM40XgpdmkfapndVDqt74bBuxCXB/K?= =?us-ascii?Q?LSJOFmL19slP271we6HmEw1lm4lFlrYi00XR2HW07Zjgj8S5fLKNTRCM9xmt?= =?us-ascii?Q?Zg9Ac11bQ9IQ8lGp4d4AW62lbfpjeFY00JNAitmXzfyrPEyc6vqMI/z50UJG?= =?us-ascii?Q?ZI1DERD/YsdK+BPKAkVMYCpgs1ODeWDiTzrH7moZrrJJ2ncWLEAZ+t/ofpio?= =?us-ascii?Q?qcHFny7iLS+kBy47fILFcShBSy4B0L55T8agCNbYHlB59BCWQTtbn7MKIxru?= =?us-ascii?Q?ZiEbPjDbDRTiZ+TyFqq6+SFGuVylVLC8VsKbsnrfByRZTMbdG+jXzfkj/BFr?= =?us-ascii?Q?Ns70+hc2x/7zGO8sx78PjbFjNOx+hLjLQyrpiR2hjyVLr2DDRDwf+YsZHbew?= =?us-ascii?Q?CokCbjQjanQhM+J+vYWFBtFEV/akKUNIGW/t5g2o9xhdddXYqw8520aamTBt?= =?us-ascii?Q?hvQhRzlBMX2YQWJtuW2bCLXOjTaZAzd9itEU3x0mwt+StrjPJ+xI2S7jXwcq?= =?us-ascii?Q?DLIpYXcGnthqUIO79Ld+Kir7LsHXztZ/x/dk53CYGEFNlTmzj0ap0oLmicMY?= =?us-ascii?Q?CAF2MHBIXPW0CoVXbH+niQqUVWFERXg=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR18MB4714.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2525e824-635c-41ef-4b55-08da3958a39e X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2022 05:30:09.0842 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hS8fpQ4ZOzR3inqWQO4R2QHRAwTxtF3yDB602Uii5enMK/ENpglwFXb+7UR4+QiWfsVBrIvw3c6hTuJa94lZHHhYvLUYPdVTrInYiJ4Zurg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR18MB3399 X-Proofpoint-ORIG-GUID: H_m9GVp4Lsreu7wzZKfccj3O-Z02hZbJ X-Proofpoint-GUID: H_m9GVp4Lsreu7wzZKfccj3O-Z02hZbJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-18_09,2022-05-17_02,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Please find comments inline from CI point of view. > -----Original Message----- .... .... > main(int argc, char *argv[]) > { > int ret; > + char use_json; >=20 > ret =3D rte_eal_init(argc, argv); > if (ret < 0) { > @@ -424,9 +436,17 @@ main(int argc, char *argv[]) > ret, env.req_path); > goto exit; > } > - > - > + use_json =3D info.file_type =3D=3D FIPS_TYPE_JSON; use_json is not required apart from setting info.file_type. Some CI build f= ails for unused use_json (when !RTE_HAS_JANSSON). Can this be removed ?. Thanks, Gowrishankar