From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2EA55A0503; Thu, 19 May 2022 11:11:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 22ACB4114A; Thu, 19 May 2022 11:11:56 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id F0ECC40140 for ; Thu, 19 May 2022 11:11:53 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24J5AP4p008585; Thu, 19 May 2022 02:11:53 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2176.outbound.protection.outlook.com [104.47.55.176]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3g4m6f74fx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 May 2022 02:11:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VGas784r6HkIbbfSb5UCWESz8IJwVsJR32WEVqybpT6t9tYPhojIvMo9kVgd1mNJd2WldNRna9ZWIhtFq/N0MbOUzRhCVIKiXLMwe1NIi+w5P5rhjJoxhuqbjvf9kdV6loWcZ8pUPAmECktwnE1i++ZxaSDX1e418jhA+D6TjiF1MrHZIVdyWSdLcfhwdk4tlfvjeZZcFOnnL90wHWY5FppOQWyJnkVW2bcEr+LgSQVkgJOHDauBdf+lNlqmNsvDtMnHE2Cmq5aoGCydyzwfz33uXyDv99xUaD7RsGxrvx+VQ1lku5kCw9UG6ppnrDV+Z/nZvjVfDjy3dTYgqW2WWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wc4WN6/84AW4zJ/K/U4GWMaD7AQJ83rwfFXzAJ/7vK8=; b=Wp544KCDzAwhrDuUcfXTtPgP4QwGpoe86bbOtjisSMHod/Isk4U+K02Kk/VXAE5Eqn8ILVsMO0MexBhOJBPoK+hs6uIdZ7puQYfw+RemWD/G/5c7G3JkL60WxEDXngz40GOE0OmUhXU6m56Btfvsd1QA9M8z4U9A7W8Wm35AorMG0jyTGU4RCRt3bL24x70WBardA0W029XqYuLrJnrFOnskMvADFSqNWczdkoBw2KosquvGE0AU3Kc2GPjGAKa4fHF4K/jOcsHHp0Y3N5c5nUhtrCqZkLC04JCELcoDIMuf2DtoQlIe8ObNsLChWGA5bU78AmCE/LtAqNLSpFNOFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wc4WN6/84AW4zJ/K/U4GWMaD7AQJ83rwfFXzAJ/7vK8=; b=PEJ8McExPdoPvBRROlDkDg+8Z6KQaSqXOyUDn8NboEBlyc94sJFW/S6zIv83ZIixmVaP/jdj1MaIfWB7fC97+RE5TyWSW8YTaxJOYe8951pYAWI4EJl/ZR/QzVFF7ceUSOKxVQ4wmPw63J24KSTYsO0y1qwC3BN/elk9tSDtArE= Received: from CO1PR18MB4714.namprd18.prod.outlook.com (2603:10b6:303:e9::18) by BYAPR18MB2917.namprd18.prod.outlook.com (2603:10b6:a03:105::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Thu, 19 May 2022 09:11:49 +0000 Received: from CO1PR18MB4714.namprd18.prod.outlook.com ([fe80::f83c:2654:ed5:fd1f]) by CO1PR18MB4714.namprd18.prod.outlook.com ([fe80::f83c:2654:ed5:fd1f%6]) with mapi id 15.20.5273.014; Thu, 19 May 2022 09:11:48 +0000 From: Gowrishankar Muthukrishnan To: Brandon Lo , "roy.fan.zhang@intel.com" , "ciara.power@intel.com" , "lylavoie@iol.unh.edu" CC: "dev@dpdk.org" Subject: RE: [EXT] [PATCH v4 8/8] examples/fips_validation: add parsing for cmac Thread-Topic: [EXT] [PATCH v4 8/8] examples/fips_validation: add parsing for cmac Thread-Index: AQHYW+SQFV82Z3l360yi4iPZ5GC1Z60lyHCggABAQ1A= Date: Thu, 19 May 2022 09:11:48 +0000 Message-ID: References: <20220129175514.746925-1-blo@iol.unh.edu> <20220429161559.415645-1-blo@iol.unh.edu> <20220429161559.415645-9-blo@iol.unh.edu> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d9ab1298-f1b8-4dbb-c5a9-08da39779ad7 x-ms-traffictypediagnostic: BYAPR18MB2917:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eSa9jSc4n2NaWBfJyUb3H6xSpQ8fFuaj2ZnTHvypk3kQnnTN/gJcNSFuR4RjdH7rjoy/as7cR1OTqVg849aLsBjKOGSM1FQLw/k4fqmHb+OlpNu2iWraU27GCOOHiciPvpHyuYEYrshMkDNbGZDJkWhL9+YQhqV2WkA424e17Y3mbTZ2hgSDKCL+usN1mNB5mW87FJOOr738GmAS1z6vhENt3OHG49BEKjMq6LOOMyvH2D6xGR+HTVL6lBgNLUAkP9x91vhJvVDF9ohZcZUjnWF+rgFQe6n4oZ/1t/L/e1g7qJmTxVBCNAdXvakvYG5q3s8ephIGbm7gwj2igcbY5M0yqQvjuh/sNhfp++0vSyI6AcLNuP5F0plZXLdK5AofXw9rcT1MnEahzL590CC4+BhYRGI8Gm9j64etYddkNZ1qqfonMjMEy/DRcq+0HJV7UjSclULsiUr7KpGm18s08DTgHzSMxxq/MJx9IewAQOhu8qjD1zzOSux82iukYg9DWn8fOvok9vMOU50fnwwc8G6u9pee1DOAGXaJ1/2/ebNH5YRkkaJtuf7UKVB7sks2+JKQKFyRUz/B0agvYxl/y1HqBJ/4WVAvY7VbgPlBtFBoIR0SUUVhipCTweleV4B06W9NxpV/slUD2Qp5BmnogzshvBCrvkf7Ct4VdK98+QClQRE9JNGYRoaG7i/YpwCnpFsYlY5pHqJErlKmlwLO/w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR18MB4714.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(76116006)(186003)(122000001)(38100700002)(86362001)(4326008)(38070700005)(71200400001)(52536014)(66476007)(64756008)(26005)(110136005)(508600001)(316002)(8676002)(2906002)(7696005)(8936002)(55016003)(9686003)(2940100002)(6506007)(53546011)(5660300002)(66946007)(66446008)(66556008)(83380400001)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?L75oIcVz702JrQwIRYnFLqo3wH1l81o5geQuz7PTYL305EOQhZafdhlyARwf?= =?us-ascii?Q?7Y5aqyxZPKpfio0Liytq9APDmrpLSjhv+PpwUEjKtv6wExt24+keaqpULsCW?= =?us-ascii?Q?7vmHiRC18ROh0c1bh/tfriqFf1gv/gaJXGUPeYMLE8Q9LBWKRy0Cwb0qE7xs?= =?us-ascii?Q?bgffkkR+TBTCTJ7N4x45aUFnivzrge8y1tHTmyG69uoWa+vmU0vIPozVd1Ym?= =?us-ascii?Q?OaueP3EJvjvM1EF5TWSyvkJmG1CjPwcN3pOqsMfyBrdtJqSaSC2jrpVCDHlG?= =?us-ascii?Q?aXkJkM97HVES3GWfPkNP55FcDkvOw+XChDPA9DmpX9mfOgVto/HUg78vQamI?= =?us-ascii?Q?AoOTmbBNDhPX9nGLR0734hbChhJAay5fDdVRE2ZVQMj4W3Zrt9UuEInX2AfJ?= =?us-ascii?Q?/zhV6AbqUcWVDo3fPvWsSLlnedaXWFYX4ADxRJhYkmQHBbj1WkWYpSvbDBJ8?= =?us-ascii?Q?tjXpWGjh2h8UcXqWMdrIVaR3psSibXSo2P2RZQXvVm2OwTXLp73JMdcBbxnm?= =?us-ascii?Q?fXfqCrVdsWI8iJKtT3FvzmWemNjuGO+TlIqRY8VLaC2er5YAsl0ck/E2pXmS?= =?us-ascii?Q?nAgopakt5L0j91YnbD6l7l/nzcoFUO7x2KkBNPKb9Vt2t8bZf3t0Z6LKIkE0?= =?us-ascii?Q?/SamLM1QWsY5TDlsOjLgsW/PY/mQxSfnuPe5NU1pI3bzuhscMR2eJLPSNq5A?= =?us-ascii?Q?v2rE00Ht7/GWBWC2rFVi8g5NSToxSn/GzK16WbZQ7XIzV/EQf0s3KzrOnENM?= =?us-ascii?Q?rgxx1YvXQ6pCKJN2O3np02ZJQ02hwSaF1V5en50Jz5/3c6ZQQtNtp59O8p4B?= =?us-ascii?Q?zGSyJ+v9Z2c5tDkzBgS1IwbIuu84EnT8ClsvPDrK/puOTzi+ktT5Vib41LLl?= =?us-ascii?Q?jCP23tl7hxMthLi/4mP5xojJeJ3GZLU7WTOT1SkV6HufjX/LwSsxmzNm8g3I?= =?us-ascii?Q?7NYMofu/wr1cZDM3SawBkHHCEubLD1OTNzTJAgWNw3jeioI1JCb+eC02N8A7?= =?us-ascii?Q?UWgoLihJArBH3o11907nu3rc0w1QdwdnnyMKtvm6fnMiVebHgvHyykdsZKP9?= =?us-ascii?Q?cf465gg2dAV3gztbDBach63rRavU4mxkua5FhDcCCf+eQiHufgIW38xQy4UT?= =?us-ascii?Q?APdp2DuUCo+diM25GHAeOj4vUbA2YBepPa2LhEMY0pj16ew+vvbJOyTq4NO5?= =?us-ascii?Q?Ju+Lmf634LijiVGnv3YZbAoB/YaXGwoyQOLGMrBx7/rbDiboqiUCNq+6lvS2?= =?us-ascii?Q?c1n9lSXLtMSNQ4gPGIIUTduLSr+K125XruRrO7ae6hieJ8O71KJU4E97RJiK?= =?us-ascii?Q?Cxn1y389dFeI6kt3pW89758SOXrROZnazHTEqUyQKFqsosgil5Dz+GiOl8ro?= =?us-ascii?Q?Q941q3gMsQpfHUiC7zXgsrdk393nQjEXNkIREJ0QjdfTuQCSXBZCGw3+9b/I?= =?us-ascii?Q?QbOji2F7iNsoTRABx6IHe8TUQmgXlEj7Szu5LTiMKD7F7NO9AMoqfdsOjp40?= =?us-ascii?Q?YxlU0ps9SJNLhrqMjCJ7kPemxEtEYMed4MAiVeYZyACrG+H18qlov+B4JR/X?= =?us-ascii?Q?fPpAl7nd7YxRAVX/AQ3yUoYRxIQBEaxBChVp5kEhLF3HchbiWZDhSzVyKQ9d?= =?us-ascii?Q?b+SrmmFmtmsdZ1+6F0au66n6LPeAUJB25nhmsx54QwjiCVOIES0a8COiBcI0?= =?us-ascii?Q?Tqm+Eya7mxURnB8AJHumQ/27SPo3wRASjUk83kxo7JpMj3c9wf40hLeGRgIb?= =?us-ascii?Q?al3Rr+S3TToIW7wP4rObvN+95Z+yCes=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR18MB4714.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9ab1298-f1b8-4dbb-c5a9-08da39779ad7 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2022 09:11:48.7445 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XW3PfpHDiqndHsf6vP/cmYn7k4tGOwtIMYfOLjFbD74L7WV7rnI1QjEjwWUQTnAi6PBjFmYnWlTzyvGzXdE3p1g3gftavnoc8pul/RoDDYA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2917 X-Proofpoint-GUID: R_xyo3q7HphV8bPiDOb59P_LrvTqekOy X-Proofpoint-ORIG-GUID: R_xyo3q7HphV8bPiDOb59P_LrvTqekOy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-19_02,2022-05-19_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org + lylavoie@iol.unh.edu=20 > -----Original Message----- > From: Gowrishankar Muthukrishnan > Sent: Thursday, May 19, 2022 11:01 AM > To: Brandon Lo ; roy.fan.zhang@intel.com; > ciara.power@intel.com > Cc: dev@dpdk.org > Subject: RE: [EXT] [PATCH v4 8/8] examples/fips_validation: add parsing f= or > cmac >=20 > Please find comments inline from CI point of view. >=20 > > -----Original Message----- > > From: Brandon Lo > > Sent: Friday, April 29, 2022 9:46 PM > > To: roy.fan.zhang@intel.com; ciara.power@intel.com > > Cc: dev@dpdk.org; Brandon Lo > > Subject: [EXT] [PATCH v4 8/8] examples/fips_validation: add parsing for > cmac > > > > External Email > > > > ---------------------------------------------------------------------- > > Added function to parse algorithm for CMAC test. > > > > Signed-off-by: Brandon Lo > > --- > > examples/fips_validation/fips_validation.c | 31 +++++++++++++++++++--- > > examples/fips_validation/main.c | 3 +++ > > 2 files changed, 31 insertions(+), 3 deletions(-) > > > > diff --git a/examples/fips_validation/fips_validation.c > > b/examples/fips_validation/fips_validation.c > > index 04dfb85262..8e0a55c624 100644 > > --- a/examples/fips_validation/fips_validation.c > > +++ b/examples/fips_validation/fips_validation.c > > @@ -460,6 +460,8 @@ fips_test_parse_one_json_vector_set(void) > > info.algo =3D FIPS_TEST_ALGO_AES_GCM; > ...... > ...... > > > > +int > > +parser_read_cmac_direction_str(__rte_unused const char *key, char > *src, > > + __rte_unused struct fips_val *val) >=20 > Can this function be static in fips_validation_cmac.c which is more > appropriate also ?. >=20 > Thanks, > Gowrishankar