From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
To: Kai Ji <kai.ji@intel.com>
Cc: Anoob Joseph <anoobj@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>,
Akhil Goyal <gakhil@marvell.com>,
Fan Zhang <fanzhang.oss@gmail.com>,
Shally Verma <shallyv@marvell.com>,
Kanaka Durga Kotamarthy <kkotamarthy@marvell.com>,
Ayuj Verma <ayverma@marvell.com>,
Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
Subject: RE: [PATCH] test/crypto: fix RSA decrypt op validation
Date: Thu, 12 Jun 2025 10:33:55 +0000 [thread overview]
Message-ID: <CO1PR18MB471468B21DE770926E149839CB74A@CO1PR18MB4714.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20250510104452.2186-1-gmuthukrishn@marvell.com>
Hi Kai Ji,
This patch adds a check on cop status after DECRYPT in existing RSA test.There are
few CI failures for this patch and the failures are very specific to Openssl 1.1.1 variants
used in below platforms:
* Ubuntu 20.04 - Openssl 1.1.1f
* RHEL 8 - Openssl 1.1.1k
When I manually build these Openssl variants in the above platforms (using
Docker images) and execute tests using respective openssl shared libraries,
all tests PASS. If I use Openssl library that is shipped within the above
distributions, the test in patch FAIL.
I would like to get your opinion first to proceed on getting these patches CI acked.
In my debug, I don't see any issue with the patch and the patch adds better
Validation indeed. May be that, it has uncovered a potential failure in above
Distros. Can you check on your end if these failures disappear in manual try.
What would you suggest to go forward, for openssl PMD ?
If required, I can start filing a Bugzilla as well.
Thanks,
Gowrishankar
>
> Following RSA encrypt op, same plaintext buffer is used as output buffer for
> decrypt op, hence comparing plaintext buffer against same buffer pointer in
> crypto op always succeed irrespective of whether decrypt op succeeds or not.
> This patch fixes this issue with a local buffer for crypto op.
>
> Fixes: 5ae36995f10 ("test/crypto: move RSA enqueue/dequeue into
> functions")
> Cc: stable@dpdk.org
>
> Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
prev parent reply other threads:[~2025-06-12 10:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-10 10:44 Gowrishankar Muthukrishnan
2025-05-28 8:38 ` Gowrishankar Muthukrishnan
2025-06-12 10:33 ` Gowrishankar Muthukrishnan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR18MB471468B21DE770926E149839CB74A@CO1PR18MB4714.namprd18.prod.outlook.com \
--to=gmuthukrishn@marvell.com \
--cc=anoobj@marvell.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=ayverma@marvell.com \
--cc=dev@dpdk.org \
--cc=fanzhang.oss@gmail.com \
--cc=gakhil@marvell.com \
--cc=kai.ji@intel.com \
--cc=kkotamarthy@marvell.com \
--cc=shallyv@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).