From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
To: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>, Akhil Goyal <gakhil@marvell.com>,
Fan Zhang <fanzhang.oss@gmail.com>,
Ankur Dwivedi <adwivedi@marvell.com>,
Anoob Joseph <anoobj@marvell.com>,
Tejasree Kondoj <ktejasree@marvell.com>,
"Ji, Kai" <kai.ji@intel.com>
Cc: "FanZhangfanzhang.oss@gmail.com" <FanZhangfanzhang.oss@gmail.com>,
Jerin Jacob <jerinj@marvell.com>
Subject: RE: [PATCH v2] cryptodev: add asymmetric operational capability
Date: Wed, 9 Oct 2024 03:38:38 +0000 [thread overview]
Message-ID: <CO1PR18MB4714B88A3D50AF5B6F18D128CB7F2@CO1PR18MB4714.namprd18.prod.outlook.com> (raw)
In-Reply-To: <PH0PR11MB501373AD1DEBF9989F21EC4A9F7E2@PH0PR11MB5013.namprd11.prod.outlook.com>
> Acked-by: Arkadiusz Kusztal <arkadiuszx. kusztal@ intel. com>
Thanks.
> With some comments.
>
<cut>
> > diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> > b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> > index b7b612fc57..6f81bcb110 100644
> > --- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> > +++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> > @@ -598,15 +598,22 @@ static const struct rte_cryptodev_capabilities
> > openssl_pmd_capabilities[] = {
> > {.asym = {
> > .xform_capa = {
> > .xform_type =
> > RTE_CRYPTO_ASYM_XFORM_SM2,
> > - .hash_algos = (1 <<
> RTE_CRYPTO_AUTH_SM3),
> > .op_types =
> > - ((1<<RTE_CRYPTO_ASYM_OP_SIGN) |
> > + ((1 << RTE_CRYPTO_ASYM_OP_SIGN) |
> > (1 << RTE_CRYPTO_ASYM_OP_VERIFY) |
> > (1 << RTE_CRYPTO_ASYM_OP_ENCRYPT) |
> > (1 << RTE_CRYPTO_ASYM_OP_DECRYPT)),
> > - {.internal_rng = 1
> > - }
> > - }
> Designated initializers could probably help with readability.
> > + .op_capa = {
> > +
> [RTE_CRYPTO_ASYM_OP_ENCRYPT] = (1 << RTE_CRYPTO_SM2_RNG) |
> > + (1 << RTE_CRYPTO_SM2_PKE_KDF),
> > +
> [RTE_CRYPTO_ASYM_OP_DECRYPT] = (1 << RTE_CRYPTO_SM2_RNG) |
> > + (1 << RTE_CRYPTO_SM2_PKE_KDF),
> > +
> [RTE_CRYPTO_ASYM_OP_SIGN] = (1 << RTE_CRYPTO_SM2_RNG) |
> > + (1 << RTE_CRYPTO_SM2_PH),
> > +
> [RTE_CRYPTO_ASYM_OP_VERIFY] = (1 << RTE_CRYPTO_SM2_RNG) |
> > + (1 << RTE_CRYPTO_SM2_PH)
> > + },
> > + },
> > }
>
Ack.
> Probably driver/test changes should be in different patches.
>
Ack.
Regards,
Gowrishankar
next prev parent reply other threads:[~2024-10-09 3:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 18:17 [PATCH] " Gowrishankar Muthukrishnan
2024-10-04 18:12 ` [PATCH v2] " Gowrishankar Muthukrishnan
2024-10-08 17:06 ` Kusztal, ArkadiuszX
2024-10-09 3:38 ` Gowrishankar Muthukrishnan [this message]
2024-10-09 7:11 ` [PATCH v3 1/3] " Gowrishankar Muthukrishnan
2024-10-09 7:11 ` [PATCH v3 2/3] test/crypto: check op capabilities in SM2 tests Gowrishankar Muthukrishnan
2024-10-09 7:11 ` [PATCH v3 3/3] crypto/openssl: include op capabilities for SM2 Gowrishankar Muthukrishnan
2024-10-09 20:29 ` [PATCH v3 1/3] cryptodev: add asymmetric operational capability Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR18MB4714B88A3D50AF5B6F18D128CB7F2@CO1PR18MB4714.namprd18.prod.outlook.com \
--to=gmuthukrishn@marvell.com \
--cc=FanZhangfanzhang.oss@gmail.com \
--cc=adwivedi@marvell.com \
--cc=anoobj@marvell.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=dev@dpdk.org \
--cc=fanzhang.oss@gmail.com \
--cc=gakhil@marvell.com \
--cc=jerinj@marvell.com \
--cc=kai.ji@intel.com \
--cc=ktejasree@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).