From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A119FA0547; Fri, 30 Jul 2021 14:08:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6DFBF40042; Fri, 30 Jul 2021 14:08:12 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 179C64003F for ; Fri, 30 Jul 2021 14:08:10 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16UC6fn1026208; Fri, 30 Jul 2021 05:08:10 -0700 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2102.outbound.protection.outlook.com [104.47.58.102]) by mx0a-0016f401.pphosted.com with ESMTP id 3a4866sxk8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Jul 2021 05:08:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j0F2VSGkMtILPqwX5NRCYRw/zZFRPZg7cXs6SxmohCrn1ZsAlctdzbYBQ13bBHn9J2+ectewZKOGHvvDO5NLkWmXm4imfIDTJnXy0gts7eGLfJE/84mNJiNQy8RaoKq+F54HY9WfTenFUpWYwXt27NXENmxZQcS8P15ufyoi75BpvIgiJ/O9iUh7p6sCDxJuvxOAooEWE/BpNh4I7XspziU984qJ1p4ovB/WnJZvNK3a1bnhizCggLEMVUCwSqnTloRkSKuWQGm+fHsBWaKExwGT3qwFkvfuc70nA8dlh4eZ4NoY4ZtxztHdcYTegU5b79NDFh6phVRWqqVWoUWcOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Komt5i8ylxOSMvPaDGxIh0KI8HebOruffxNrcHtKrXk=; b=KpPZTzwQKLjVrzgxDn8GuXUw6GtZ2Q5z7tbB4Y4DlGuF76ELHP/HjjweEY2+tybWYdW/dLOKnBZyc5i0Dy5ytWjcwsmk2r3akm3aLZbl0jyNxAdgOaOvP6vgdW8pd4d/sJHMzYPMuo3FSUn8l489HDhGA4UoKOn7hXF5PdLev8Jmql5ePlxM33GSKqN4Zzr4KHFaH2/HBn0+ikm7XPVBrCDr5H1QPoIoHMDegjL0r8szuF9vJ0bEaeU818wFZWzOOYoXKsuS+9A6XQwK4YKrCBri4uFe9kcATVvlwPw7JiAOju4Fs7wZ8LJ9ryL3I7ALSwTMy/8tXHld5yhGs0icBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Komt5i8ylxOSMvPaDGxIh0KI8HebOruffxNrcHtKrXk=; b=Ab3oqlaRC8kdeOYAwytE5r7eofnjEc0X1/RAKSpJZoPQ4w22wByUWD1m5sf4gLJqFpsz0vv/fDoRJ2hgsi13MwgN67zdNFjjE9eMBHl16cFxDtBCm0EieZVnQc1csRxvBaN8CMKXnW/sD9ZeYUmy8NH1r3xu8mKe7dvm/uwGd9A= Received: from CO1PR18MB4714.namprd18.prod.outlook.com (2603:10b6:303:e9::18) by CO1PR18MB4668.namprd18.prod.outlook.com (2603:10b6:303:e7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18; Fri, 30 Jul 2021 12:08:07 +0000 Received: from CO1PR18MB4714.namprd18.prod.outlook.com ([fe80::c515:b091:df51:cc6c]) by CO1PR18MB4714.namprd18.prod.outlook.com ([fe80::c515:b091:df51:cc6c%2]) with mapi id 15.20.4373.025; Fri, 30 Jul 2021 12:08:07 +0000 From: Gowrishankar Muthukrishnan To: Bruce Richardson CC: "dev@dpdk.org" , "ciara.power@intel.com" , Jerin Jacob Kollanukkaran , Kiran Kumar Kokkilagadda , Nithin Kumar Dabilpuram , Sunil Kumar Kori , Satha Koteswara Rao Kottidi Thread-Topic: [EXT] Re: [dpdk-dev] [v1, 1/3] telemetry: enable storing pointer value Thread-Index: AQHXhI2AKJ2wPvhwj06DD4n2aCqto6taGU4AgAEzaGA= Date: Fri, 30 Jul 2021 12:08:06 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c92296b9-13b6-4a8f-fcce-08d95352b103 x-ms-traffictypediagnostic: CO1PR18MB4668: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jarkbFrmh0koIi2vs00iaS9XQQXcsC/Rkfwykc/Ili+2jc3GW/33aDSOHKuBxLwvxW//6hREAV/itcLz6ntO5+8mUM8KVMHQlec3jhpguJ+K4D6JPI5XNtSd9bccPMaxRbPVpu/+gbJJ23SG7kwBCGnG0kPAvjmTn1l0eANnLT1OxpgsKV9YVhbzDbEZRxI5lTHKt+Jdcg24BLjcfjyVWDHhTgVlqsk3/ocWWXcpukYa8wdzor+QaLDNuuJO9z5JM//wtU5PdOOwZGDShUCoHmCsRB4DAfReVzNTtGUTl5m1Kn+xfqaGuDGKlChagChTpzO1hOchFT8ou2BPKZgCWa1Tb2JqwB95W6Ij0YB2TMDB5gaOosykQMmoS8a6MQX4WU70PzREng7yPEqyyDz6Ab31uiWBAwuvqFyxaUh/hvQQr5T2wg3lyP10Xkai5cyFueCHWBCTG0kpLpk+xzU20m60t/90PhTt4YKObHOVOPWeyqzTWVfIh3R2KakomYyF96xzPhC+fxOcPSxd3RT7RmHL4L5iifzMYiPUp6VkCO31W7dcdT3DPwEVwS0cJu6YMET46jqgR4R63uJ5gSvNdR1MCSFPKx9Ga5yYqHkT9gBe+9i8vFtFD91Rludd5Bb1tlHHVdKOQQukuJp3iXvUCdg9//letGe0TPMqyETtXZchvPxr7J2fAvnIoSMtpFYA x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR18MB4714.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(38100700002)(83380400001)(26005)(6506007)(54906003)(122000001)(4326008)(86362001)(71200400001)(66476007)(6916009)(76116006)(316002)(66446008)(186003)(52536014)(66946007)(107886003)(66556008)(64756008)(33656002)(8676002)(8936002)(38070700005)(508600001)(2906002)(7696005)(9686003)(55016002)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LW/Oe3FVac1FEx2SgWsz+i1+W+aiqBLqu4A63KcameZdj+GA61yX4n05RnFp?= =?us-ascii?Q?cr22cn9PnA0Xyo4PEp46TVRm2KxhSpJcmpLIUsXYTkqanJQlGYLL4n+3gpJA?= =?us-ascii?Q?xr1WpkUaZWnBI2iNcUyWAnLxmnr0PfXUtNUUHB7e3Gngq7iliJVfk1XWvqe1?= =?us-ascii?Q?JsqE+ZO4QXlSBjLLA3RGl2xtmWPIUE8G+8zt+McTDtXBSZEeR3qiWdZoF6uf?= =?us-ascii?Q?lhTPI08097Vm2r8erhzA43s4NGrPUZXl2K+EscQsqQiD8AMB6B3MVfki9eRI?= =?us-ascii?Q?t4QZg0LZAUX476mnpCECWCjpNuc7VQweo9lTXS9yNg+/ZBs+TiA840kY6uoD?= =?us-ascii?Q?RrpR1JH2vM6uCB+FoCRkBAgqBDH/0uItmyejkpg85q492U5JdotOXGUVNz4U?= =?us-ascii?Q?m0dJ79zPht+CitVy+UIBa8gBFIJZlmgtkvwzRZ6PhrQeohl2E0XpdYb5emTV?= =?us-ascii?Q?d3PMDAzjxcLL8sYZG6MZZxcCOkTU8wZwmIcFoj2dhenkqMJABPVebQlPrEDz?= =?us-ascii?Q?NafCe/GmSXMrNH+aHMFxNx5+HrZHNwo6WUKHXXLNKe17rgJ4x9LCb8hhZcEp?= =?us-ascii?Q?qcLnqOKo7DkM1pVXJoDXT6M+ipruiiXbr0T6o68GTpBsemAnKVP85oOYhUzl?= =?us-ascii?Q?RoETD0MtC0NjcXjbNeWq/IcDJIYFRxFnNETFe+mxF2zr9KqYowYwisadnagb?= =?us-ascii?Q?p7QLAsBgMXZLpQ5NHuZfaiGkqznVWK23a4B8bNge648Cr6FBBbm6A4wrNFyF?= =?us-ascii?Q?OTgt+CaN0YWlpSpRKNl/py+GNVbTzAE/zPf5k9tv0KGlpKNwuNKrPI16dPWu?= =?us-ascii?Q?b6Dn2AKQNZgqi5ZQawAxnfCl/cVhKqBp/ide9pQUjlAgnSA6ad5ZTcbve89W?= =?us-ascii?Q?CYUCwKExvU3/SS10IL/2f7NJBCBNgWZpD8Z1LuWjNx805I1d5lH0om9b1WCS?= =?us-ascii?Q?/iODI8EVIpeVsuaV5CvvVzSl5YTU75mLHajfJzZaqkAi+IffxC9g1hevlh35?= =?us-ascii?Q?GUOJxxHh2/GHlQvXz0i7eOI3i+1IUtKpwUFM+qwIwbtC8HRRf7+gkZo8D0yt?= =?us-ascii?Q?GM+L952qXKF4GPPVqu7nbyWyHQ4NEsvkBVNZgpqur3KiGgRgRHVq3W001Aq7?= =?us-ascii?Q?JeWu6+DF6M8TpObG4qPTvF3Dep0a1Q9LxYhfFEt8u31hxTGnvpjtOtUiF2Gj?= =?us-ascii?Q?6smtVq0DP68ffyUMv7TpBcA1Qy4Wm8YWt779u47pEeI4zB7GfYout21gDLkw?= =?us-ascii?Q?mkwBcMYh88mDRgbMEwGA/9c5FNzpdRQ0eYThpUsyIwP54TgUR2Ka3fLdDi6r?= =?us-ascii?Q?WpspOXQ2P6rllkN3IR3ipyzR?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR18MB4714.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c92296b9-13b6-4a8f-fcce-08d95352b103 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jul 2021 12:08:06.8891 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0lKTK6MUpzxWQ91IlXEC+XYuvppZqoFSscYHlAwkN903vXz0FBnBcBvCvz1mdyNpz0r4PYWkydWie/1P13jJ7kEsBH+SAKVWA+9kVPdtDMI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4668 X-Proofpoint-GUID: hTcgJHJVFYa10Tp0eo7vZf0OGpl7ZapU X-Proofpoint-ORIG-GUID: hTcgJHJVFYa10Tp0eo7vZf0OGpl7ZapU X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-30_05:2021-07-30, 2021-07-30 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [v1, 1/3] telemetry: enable storing pointer value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Bruce, > I'm a little curious as to the usefulness of having a pointer value in te= lemetry > output? How would a telemetry user be expected to use pointer information > returned? Printing pointers seems something more useful for a debugging o= r > tracing interface than a telemetry one. >=20 Thanks for the quick review. I enabled _ptr API keeping few things in mind: 1. User need to explicitly type cast pointer value (ie address) to uint64_t which otherwise can cause compiler warning (Wint-conversion). Although u64 is large enough for holding address as value, type casting is probl= ematic for non-64 bit machines (eg 32 bit). One other option is to use uintptr= _t as a holder. 2. With this API, code walk could be easier as user can interpret the acces= sed data better (ie ptr is address value). _ptr API is meant for pointer v= ariables, though it is up to user to choose. 3. Also while debugging telemetry date using script like usertools/dpdk-tel= emetry.py, perceiving address as hex is quicker than same as u64. Answering on returned data, user needs to convert stringified hex to pointe= r value. Regards, Gowrishankar