From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60B39A0503; Thu, 19 May 2022 11:12:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 55B7640150; Thu, 19 May 2022 11:12:11 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 9101140140 for ; Thu, 19 May 2022 11:12:09 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24J5AP4s008585; Thu, 19 May 2022 02:12:08 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3g4m6f74h4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 May 2022 02:12:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dfd/CNR0mvyy5CIM36PJiCAm5LXvUpPwpMyBoqUexy4ORLEWchkkgrPJLwHNPzaqsW6CD0CmSM1NHeVNSkQMPNlU3mCi/FejIwvbWdzuDphXr98dexLhmDFJCgCKUpurNxh5Mg04cfMZrVcqRhm06/wV9vYc6ypYOWixjJMRCXVXw0Pa98cIIj2kCA+5qDz+Wj5oh8TAzrk14An5PbOCxfaRXskDbrAESC1mrPwTuKxURVt9/ZdmKI1IDDZ8dRNme5qkunZRNHyTjqfrEub01ko1XKJ/HO1GvQ8MnjYEXHojYlUMAuica4uXw6iDAfCHar83nq7bwcx5MlFD3Vmh7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JBEp1l7NRzCfCg2Wp5njCxMGXAhgUqNWUmxcI1NHZl0=; b=oFy/R3dbqzhyJHZJG786W1Xw+2FYaKpwkXbF86tNZWvo3Xc691IevY1VV/bSNY73vdM/AIFbZLdWllisKai5Q3n5vFNg7SDoLGt0yYiLq20or67W39ekwj+rtGSRbyOSVMQkbX+DjJ5HjO8BU97Y4qcfQ7vI/yysYPRRp/73GFAhUgkk+UR9OROMpJ2YhNo8r7q5Omwm4d0hMOdJG2EIwt5zkfn9tIjlIchtCYvgp/cNhv/F0OvYQz5M863MzQlWYjffM41EYPxNgCUjYdLgjb/aTySEkx7xJvxcCSOGzSl5E1JBa5OXKh2R1iNXIhWrovPrgPK/BbHYdDPkg2o0Xg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JBEp1l7NRzCfCg2Wp5njCxMGXAhgUqNWUmxcI1NHZl0=; b=l1YU0zNkplwCAMpXan7gTzEwpiiVfPwXbaoQfPmYGBVlmr9x1jO94rmAADmEoywcYQO6g2F8BNjzDmLFgzqMs3QAHlKRQ+IUZA/TSnateBVIw1gG0NS8gvFU11oR4ZW4ZraO0sJuX/3QUGqDWQTV+rsDnd8cyyH91p/mEyssqXE= Received: from CO1PR18MB4714.namprd18.prod.outlook.com (2603:10b6:303:e9::18) by BYAPR18MB2917.namprd18.prod.outlook.com (2603:10b6:a03:105::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Thu, 19 May 2022 09:12:02 +0000 Received: from CO1PR18MB4714.namprd18.prod.outlook.com ([fe80::f83c:2654:ed5:fd1f]) by CO1PR18MB4714.namprd18.prod.outlook.com ([fe80::f83c:2654:ed5:fd1f%6]) with mapi id 15.20.5273.014; Thu, 19 May 2022 09:12:01 +0000 From: Gowrishankar Muthukrishnan To: Brandon Lo , "roy.fan.zhang@intel.com" , "ciara.power@intel.com" , "lylavoie@iol.unh.edu" CC: "dev@dpdk.org" Subject: RE: [EXT] [PATCH v4 4/8] examples/fips_validation: allow json file as input Thread-Topic: [EXT] [PATCH v4 4/8] examples/fips_validation: allow json file as input Thread-Index: AQHYW+SAc7uUd7I0/kCaTUnV728KmK0lyhIQgAA/GFA= Date: Thu, 19 May 2022 09:12:01 +0000 Message-ID: References: <20220129175514.746925-1-blo@iol.unh.edu> <20220429161559.415645-1-blo@iol.unh.edu> <20220429161559.415645-5-blo@iol.unh.edu> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 619b4eb6-d529-4fcc-2887-08da3977a2ab x-ms-traffictypediagnostic: BYAPR18MB2917:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: q5uepGVOdk63RGfG1It9iilFTosNFhe8xW30re+M9cBB4Ms5pOGIzRbufUttfqKW73AHwIwOPwHQCMya8C6tRATncaP1/OUKQ0/A6X3NPtLd0L8hvu5j4Ng8SvWypwav57V5jbFLqrs0//462vFkkyKrzF++9RRfI2NKa8LTj6wiyxKH/t/50GSJehHCmHCMgeZmt4vzzhLXs5319g18IXI5+47nuA13aEvinMIKg5Y6XUyVBltBBX/t5MPfV9wUPCM7C1SbvZqXtX+D+Z5dLZIgttZUCZkFd4mHjCQZLhf1VZqgM5/SYhbxIW8Pc9JIPQqWUAzjorIDBSZ1VPfAsN+KxVaU6sbcGG6z155wE65PqhA7HA1E601ZlNr8q+cG2k8R9yBByiqD9IdhgJF2p2awFNxi9FUFV2Ojn9Z4mqhCKNnesBIrFwTxxErSoXnkrD/3c0i2S8qOE4mmishq+wWW9Yf+oriREEIwPvXIXYo25qfVM2zZAMYLEKW5w2oNWfUQYH9IvsTbs005o950952haUT81yuwgArGGk8BlqigM7pKvWNrfRSWTCDebQld+A1f6Y8zHrW4Zlttw6DJML81Q6teh1lPKHuCDl/BKEM1b2hfByB63g5UxI8kPcBFVaAmCfM1hSLW58nI/J1TQ1oIt1IIYosxEh9TdfkQ9vjBYS+PdWDT9N8W2areHHgiRBYZYncCDWTwF6o3a4f9+w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR18MB4714.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(76116006)(186003)(122000001)(38100700002)(86362001)(4326008)(38070700005)(71200400001)(52536014)(66476007)(64756008)(26005)(110136005)(508600001)(316002)(8676002)(2906002)(7696005)(8936002)(55016003)(9686003)(2940100002)(6506007)(53546011)(5660300002)(66946007)(66446008)(66556008)(4744005)(83380400001)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FKBFsT2SrfSIZBR11AAG21MT7nLXPh6UF0GEQzlxPpIzQaajhOe/Ge5wJB2M?= =?us-ascii?Q?6B/mdcIeyTFDfQusrZazyX2GkO1TJldJGMxzOl9CsPZ3tprEXXizZkabVDl9?= =?us-ascii?Q?0rmCOiSBpZ9QzI4G/qcj2YCgtbApJFYrrkjMSnWOhgAyzKMAJAMJODYFftHC?= =?us-ascii?Q?twZX7BN6XlZP9kNuFWuHMrhW1gZBoU6UGTx/jhJ5CBhrG0AxANDOwvAf4Arh?= =?us-ascii?Q?Id2vOANwwPwBGQ7gozRAZtfLhGp4PMpJcHWp7I08Xx5IwlL+CkMBtA+aHLVA?= =?us-ascii?Q?GjadtIn2zqnz29CCffSJG45FxM2NJOlIRgPLyII0y0EeP3A/DgdNjSSkIkJk?= =?us-ascii?Q?0rhRshpzyzZs6T/CaEfHgE7dczmt3HHnw9VmNloYMcokcEXvAdW32HT4Gd6r?= =?us-ascii?Q?uAJ2oZOLxM48tBrIjv3457WqyzFE4NoAth2rQARWBRGFZYdv1dCXfbHeedzM?= =?us-ascii?Q?Y+eyglv3J2XNyMnpY9mpOQKjfRiNRdhMwWXrdGFxbQrrOUW+tQlG6YoIuDvl?= =?us-ascii?Q?JTxmfbbzaJKRDdafgeiW8oqD5JrS9deTagtpv3ERsXgjikc2XbEwlWnfAIT9?= =?us-ascii?Q?QKF4EvWq9YkLX2c/anas9rnPXzVti+FerVKISI1iTrOVinK8oleG14Yc1LaR?= =?us-ascii?Q?aKt+8DZQRjWoh3p2iSGWkN4xb4shF0I/QmdRQclJswUOK3ZGn0JKzlo3veiP?= =?us-ascii?Q?wMrZ3fzvscREw78aLxwjMF5CNPGEQbfBsyAO1A8ljmfx5m01wq9AStfcXBWk?= =?us-ascii?Q?5eFR7WKvzTdnotLJlsz5SmPe/oTBvCwAHH2uBaxy6tQIiX1mnmVKx0xhMOvB?= =?us-ascii?Q?g9MBQX1T+wGRoWhvz8ZyXJZOGQL04ontWGOz8IcbQtq50dP41gpi+kyt1d+4?= =?us-ascii?Q?JB9unfcp+/Mp6gIpFiU+N7l0DeKdgQRECesaDm3JeBYjD2DUScIQ9ci7CMtl?= =?us-ascii?Q?xRV5OsxMpgccxANR+Nrri37VtPPY+bzkrziynU1hvKQSvymZ2wKu+kCVkBQg?= =?us-ascii?Q?b4XNOajJ9VvCpPW477v4l8G9BqobbnJJLm6ePx9/nplMbiclFNh9ft6BTXyO?= =?us-ascii?Q?Eg18TsfSscZdluSKz7W7hc/tC+lZUv/RNeJvZFZXquKHh3btE6TqQDaB4TEP?= =?us-ascii?Q?3H4SgYYGl4BJG9SJqvVToEnJerXUfXU2NEFBRgg+mQI7chW3i1lXYeXikBam?= =?us-ascii?Q?rikL65KENlf8BuUHkWQyIHtfZVO0JPglliR9pkE982C+2xdIxc8bk6+y3EPP?= =?us-ascii?Q?gKIsHS40PaQG1yrX/o1NDNuRkVbzk5+riv9Hlbdd2W/T9WpJh1UMQ7SM8zhd?= =?us-ascii?Q?hEbZg/0JJJ9tObKIu5QKGrW40Bk3pKSe7F2XeeJsk/dO65+syn/VXGga/XSd?= =?us-ascii?Q?SdFcDi//UeaIICRvCYcrTJyn90YThGbIH7lx6KkK0EN+rMUYj6JyCB5iAznJ?= =?us-ascii?Q?MfV/ZbqW1A1veigoEU49yEL7E8T2yW6NDRr8NDhz7c09RkUXbpPhs+8kMTKn?= =?us-ascii?Q?5W9NSncviC4vOp78Rr4omI/wBFLoGFS/DQhDZDt7TDv7oSI0KZyPZQjbXN3s?= =?us-ascii?Q?6zCz1RBd7/zHBU4+RfKLgI+/P5TEIl5HV946RkKX/JB6YMYpeIriEsrJZ55c?= =?us-ascii?Q?6hea6lqjN+q/6Q2btFMsSMTT4SxmRBjeJV3YhqOZris6ovAK+veTcDEtMhCY?= =?us-ascii?Q?3hmBSn/8QJnwdoK8GrKTv4fTM5oZ5KNh4maNreRjPSK4g+RLugKxupSsTeEB?= =?us-ascii?Q?8G7ko02WZNCC+WTzQlphEPcqHyvqh/w=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR18MB4714.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 619b4eb6-d529-4fcc-2887-08da3977a2ab X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2022 09:12:01.8895 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1E7Isrq7jP9OOT+MwUMe9S0Gul00KCxt+VBoYnZhhd3p+YZygLuZVYztx1EDVRRcbBh2oZy82uaRzNcLdBwzpWJWp6cSV8odGzRyW9nPQtM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2917 X-Proofpoint-GUID: HrIYE4g548LPgjLWnjTCrzoMebrHpOM2 X-Proofpoint-ORIG-GUID: HrIYE4g548LPgjLWnjTCrzoMebrHpOM2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-19_02,2022-05-19_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org +lylavoie@iol.unh.edu > -----Original Message----- > From: Gowrishankar Muthukrishnan > Sent: Thursday, May 19, 2022 11:00 AM > To: Brandon Lo ; roy.fan.zhang@intel.com; > ciara.power@intel.com > Cc: dev@dpdk.org > Subject: RE: [EXT] [PATCH v4 4/8] examples/fips_validation: allow json fi= le as > input >=20 > Please find comments inline from CI point of view. >=20 > > -----Original Message----- > .... > .... > > main(int argc, char *argv[]) > > { > > int ret; > > + char use_json; > > > > ret =3D rte_eal_init(argc, argv); > > if (ret < 0) { > > @@ -424,9 +436,17 @@ main(int argc, char *argv[]) > > ret, env.req_path); > > goto exit; > > } > > - > > - > > + use_json =3D info.file_type =3D=3D FIPS_TYPE_JSON; >=20 > use_json is not required apart from setting info.file_type. Some CI build= fails > for unused use_json (when !RTE_HAS_JANSSON). Can this be removed ?. >=20 > Thanks, > Gowrishankar