From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A76BA0543; Wed, 12 Oct 2022 17:16:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 88F87430AB; Wed, 12 Oct 2022 17:16:48 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 91332430A9 for ; Wed, 12 Oct 2022 17:16:47 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29CCcRDs027121; Wed, 12 Oct 2022 08:16:46 -0700 Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2109.outbound.protection.outlook.com [104.47.55.109]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3k5mjg2rf6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Oct 2022 08:16:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CwxnHN8hE2IfgPIM3V43ZzeazmdFwPIrdzOCg0UrxvsXq00gFpPql32FVRIbiLBIi9uJhYDbJZAYvWBEwTShuZISS4NZgCe0CRLRTAQFbGYBKG6dtXLXd8BQ/bJp+Xs5haiQ+HCbDGY9UA2PEzZvp0XT+bPeAqrTIJPeQNZOAH9rLXRyCkpivA0BMbMf4/o8lW512zilhsP+chKRtOFS/Pxxl3/WtSX7Nwl2AkiZnyQpeFHbSzcHx0VisFwfCbhmizCJXrmm39V1EDuNMIRFfau3tJHbJquA2+RXK13EHxBw1qQ7/1EQLYtRoQP/sEqBWn2xiMwxFvOXJk/PZOk6kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uRwDb6KE0GHJosuh23W+QUa3ItB4HPhAaYhsI7nY4gk=; b=GOARES5ZSL596YCFWKLxP1+SrvVz4jaEr17ZjdXfq/94nJly6DsPrbpoRB6cXzDbqRwrmee+tnts9jb6rgRfr2BlPeGObEqyaJA0BnRsNWfnP6P+kS4Tfy+nPqfWXtzUcr/XuShOYiKmBJURNQK35INdWqMHK3nrEmQG53LaWdq0sQ7hFKfvFfS7cNSb6gg5+aWI9st28nWPRd9OdLfEPQovK7NxzNHsc87b1LXg1sxrGM1gVXqYC/X3j9ZkaPp0oP3nql2Ul6hRQh4ohjQk4s7BxciYcam/4CKYswUZpABBAZhy5ilc9chMfM6f7CogKplQYfq0vJrdD6vPv+wGlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uRwDb6KE0GHJosuh23W+QUa3ItB4HPhAaYhsI7nY4gk=; b=chKPe9qnpyYrHFaLTL1AyOe5HCSiYj5j+OG+CbswXYOD9WiMug1LAuokUFtZw7L+isGiIDwA2+C6dW27f1pJNnridYgWU2e293yLuMJ2AQfNyHBV8r2R/F0I8o2/+RoANzGn4ZvKXcWadSzFNIcZYQe6Uy2pRJt7kDyP7OmQJXc= Received: from CO3PR18MB5005.namprd18.prod.outlook.com (2603:10b6:303:17e::22) by PH0PR18MB4607.namprd18.prod.outlook.com (2603:10b6:510:c2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Wed, 12 Oct 2022 15:16:43 +0000 Received: from CO3PR18MB5005.namprd18.prod.outlook.com ([fe80::47a4:5a17:ac8c:d138]) by CO3PR18MB5005.namprd18.prod.outlook.com ([fe80::47a4:5a17:ac8c:d138%5]) with mapi id 15.20.5709.021; Wed, 12 Oct 2022 15:16:43 +0000 From: Ankur Dwivedi To: Thomas Monjalon CC: "dev@dpdk.org" , Akhil Goyal , "royzhang1980@gmail.com" , Amit Prakash Shukla , Jerin Jacob Kollanukkaran , "david.marchand@redhat.com" Subject: RE: [EXT] Re: [PATCH v2] devtools: add tracepoint check in checkpatch Thread-Topic: [EXT] Re: [PATCH v2] devtools: add tracepoint check in checkpatch Thread-Index: AQHY3jAquSKz9r+4702CfHBdy9m1gq4KuyoAgAAFxeA= Date: Wed, 12 Oct 2022 15:16:43 +0000 Message-ID: References: <20221012092337.5988-1-adwivedi@marvell.com> <20221012114525.12220-1-adwivedi@marvell.com> <6793875.kQq0lBPeGt@thomas> In-Reply-To: <6793875.kQq0lBPeGt@thomas> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO3PR18MB5005:EE_|PH0PR18MB4607:EE_ x-ms-office365-filtering-correlation-id: d15bab8b-69f7-437b-b101-08daac64c537 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gBKZD5irSBY/3m68s2BTjqYazVnBg1P26yfCluPwh+LNlynsvlMt8Msr/7u2mURllwX4v+IIzfzcMSea5WfLAJ6a1uPvJc0NPW7URvkLZDBUVSJ+PHRY7HJji7zi6awsOwCJzytO4amQiSwQl/B2xNOY+mhdHNstuDqmGCDGzD5RUh/cgf5lM2B4j/den+XC4DB8aoyw0Gs3GDkR8slILhX/6/zi47H4bdOUmhd9sgw6OfHRuyYPJmfMPiEIslI0Y7VLBRFLKiXbe27WY9ZPyle7Mldb1qyelQOYHeLv5j1TQeavUpPjKtec/oSpEfJytQN7LIpsVhslEWNvBgBNnhSlPPE1Dznw+dzETNBrhEMnShwr/j0WfZKm/rAb3ZmbsOSJRrcYqKTwm/x2VbwL4mwXcCZL7NLu05reRg8jAKJEETXxF4k56z0sJPFeJ1YtvuChwsLA+oGQUpmvDJZuTkTdkCNRrO+za8ZNmsTIgX3OcB1VDTwJ3AfCejvOE3qKRddWdOw0ocDPWobQ3wlYsXomcpuRe9EHGccPghO5TIrEn0bOFowvX3W7EPsZnScDxiBj7K9WC0ypLxmzYPTcTCN1C3s86juQ7f0A+AinKOukazR5DjnOrQKkkkLPP0a22Lr73dpH69L5vXxgthQH8Gu0m+zOrh50oCY81CYcyHcXJydsbqfuLrLHraN6kM7FEmRE2jPZU+MgOVD6fKBmj6UFwVpcmybuMyRLCK79WTz98I1/uGfLaOEakM4lNrY543YGXkjdHrrX0l58YqX85w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO3PR18MB5005.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(396003)(366004)(376002)(346002)(39860400002)(451199015)(6916009)(54906003)(71200400001)(33656002)(478600001)(8936002)(41300700001)(5660300002)(52536014)(316002)(4326008)(8676002)(76116006)(66946007)(66556008)(66476007)(66446008)(64756008)(122000001)(6506007)(38070700005)(38100700002)(55016003)(7696005)(86362001)(9686003)(26005)(83380400001)(186003)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tUfex9m4Si7bl4qvuGgAnWoLbYCN2HRv5OE9OdwjJALV7FYhcUdCtS5k5/nC?= =?us-ascii?Q?O6wnQpUJ8mEcg+FRFZN6wy/aXc3IbLdllj/XYyjTg5qiQVZ80Ba7psj6mNkl?= =?us-ascii?Q?riAgJKxVgLpSAAyct0a8hgXQHVlxeC7OB2QICBaj0O7ra9qqPqM9mjTxapDU?= =?us-ascii?Q?a/EMN9ZxXI0NUVXQPvbOTiigbSSL4hzesYPuynANqKwxSpbdUIx+1ghKqrOs?= =?us-ascii?Q?9t6N05FYHRfRkLgKdeZUIB9bt5yMjijocMnaXyb1BsdO82fPOPpB/q5ytIq7?= =?us-ascii?Q?4Z73CAgDW+ZmOc2rIu/d+yFYLrA7/V7tdGqZ+etD2ieLmFEnStl0PDe+bp3h?= =?us-ascii?Q?eGXEgWmgKWH3BrUh3nNeCKsWp44EwXMJfCEX04v8OmM9tX0G0XfDHrFtgEjr?= =?us-ascii?Q?x2RAp5egOjdD7Hs0pUneJBySW1YlV5SjKqam8i7u+D4W0UQevIIMd4u02CaL?= =?us-ascii?Q?gGA4FV1QF2uxv649M3Klqp6Cd5TOuCU896J+sR884QPLIrdtCtGzMmV+Whh+?= =?us-ascii?Q?MsvhyYBNbXHX1F5aWWFEcLtD2cB3UVeryN65MbwLO9brCaoJn6BK/oiUUoRZ?= =?us-ascii?Q?BjdAwxNNpshZMLuD+T8qxzw2Wnx07GvSCHdXRdV/5HZs3O44TIx05Z6nlTFz?= =?us-ascii?Q?Qn5SBiTnkjq/7aWL62OYZY9aMBc9ldozfnShHhneVuTSoZjBTnUYDK83SyWW?= =?us-ascii?Q?wm7DEKkuITz9UMfEUVuS02TSA7qA+pvPVxbStAKFDteh5258V+7Kh2E4fOtq?= =?us-ascii?Q?dCJ9OjYA+m8/DJREmIlW3bE/25dyn0zUG+C2lkhhZQjVixKvspBMgCbYsEAf?= =?us-ascii?Q?a9BlhaL9uBxbJPH8fYAbip01Vpe1mDrW8ygal4YCWn6he/7MR4tszF/PXGQB?= =?us-ascii?Q?gF1s0mGQzv1L5IPmm2arD5Qz4k/OYRHER4TDvOX7Mh6KhoN+S9/oubxJjcfX?= =?us-ascii?Q?ua/9EDbjTW0lG1DydKiS9bsEHozf05EFfDwWvPkVX4MWu2RoD2kKLTILlZe6?= =?us-ascii?Q?6c4ilZgMzFbtZSCaUWAIUAB/qQMLSjvShIgG71zri8Z+jzdcjET4ksgvB15w?= =?us-ascii?Q?BOD6rwU9oBGT8D5uH/LoB9MyLeZ6WdzMiGHVByihvDA7Vt+lyY4spw3mKXNT?= =?us-ascii?Q?N4T4xEcOoAfW2T8bOmC3I/Vcv+NlnbatVnLk7unR5TtGHSEGPNnRL5NICQqr?= =?us-ascii?Q?4g+IcNf6PXKUigp88a3Wbawmt/Q0uM+GqfQmPrcJ+yWUFCZvjm/fxcGhJ9kk?= =?us-ascii?Q?i/qMdjSe5mNztZCwvdoNgyl0kqLtu0msDA7L7d2zg3KwP6iV0dlnCphsgQvh?= =?us-ascii?Q?2NFyCTUylRqaLibkh0oC7INeQDBOPHrWnK7+973DVI1Ms7kA33CJm/Iaqnj+?= =?us-ascii?Q?oqOCcB5+e40uAJxmU6/9wtvYk0qoYJdRFQC9REsSbK0zgOscQIEhu8jD/u05?= =?us-ascii?Q?EkHQlHjekfV6FjHrekiDga3WiOsipvZSp/FNkzRrqFA1wh6mN+rzrqEzC/MX?= =?us-ascii?Q?V2xMbJ7rRUcgy/EKXXdebrjdYJLJoTzi3hRa0MDKNF79uRws+0Mo+4blbLaH?= =?us-ascii?Q?yUUQP01lJDIyBVpvIFkH16M5vn0D3NV0pKxF/9nZ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO3PR18MB5005.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d15bab8b-69f7-437b-b101-08daac64c537 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2022 15:16:43.1658 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: K20hN9ju5XzSFy/jAVfxj7bC2PEK/toQE3HBA7KDxp78m2Oswn4pCz1YM7Fv/dIE8J8lMfgr7PNJiNFfq34Qdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4607 X-Proofpoint-ORIG-GUID: fCJy661RuLzpkeZUtRwWqrXnAfpt133v X-Proofpoint-GUID: fCJy661RuLzpkeZUtRwWqrXnAfpt133v X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-12_07,2022-10-12_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >-----Original Message----- >From: Thomas Monjalon >Sent: Wednesday, October 12, 2022 6:39 PM >To: Ankur Dwivedi >Cc: dev@dpdk.org; Akhil Goyal ; >royzhang1980@gmail.com; Amit Prakash Shukla ; >Jerin Jacob Kollanukkaran ; Ankur Dwivedi >; david.marchand@redhat.com >Subject: [EXT] Re: [PATCH v2] devtools: add tracepoint check in checkpatch > >External Email > >---------------------------------------------------------------------- >12/10/2022 13:45, Ankur Dwivedi: >> devtools/check-symbol-change.sh | 76 +------------------------------- >> devtools/check-tracepoint.py | 52 ++++++++++++++++++++++ >> devtools/check-tracepoint.sh | 66 ++++++++++++++++++++++++++++ >> devtools/checkpatches.sh | 9 ++++ >> devtools/common-func.sh | 77 +++++++++++++++++++++++++++++++++ >> devtools/trace-skiplist.txt | 0 > >Before diving into this proposal, >I would like a split of the patch for the rework (and move) of check-symbo= l- >change.sh alone. Will split the patch in next version. > >In general I see too many files added: > check-tracepoint.py and check-tracepoint.sh common-func.sh is >probably a bad name. Regarding common-func.sh name, I am thinking of renaming it to common.sh or= helper.sh, considering there may be more common shell routines in future. = Otherwise it can be renamed to build-map.sh considering it will contain onl= y build_map_changes() function.=20 Please suggest a suitable name if my suggested names are bad. Will try to combine check-tracepoint.py and check-tracepoint.sh. >