From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C81A442D40; Sun, 25 Jun 2023 04:35:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 572E840EDC; Sun, 25 Jun 2023 04:35:39 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id E2D1D40A7F for ; Sun, 25 Jun 2023 04:35:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687660537; x=1719196537; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=W8JlfWuRR9bTQUi2jXYtNxZjPhAY/pvQ+kPeg/vDZzU=; b=gubd0b/0125t3RHlS6KYxeX9eTQ2kr7MafVNWFX77/o20WSj/hKstzjW HbrwqTDorLinZAYMYm6lM4uY3WJt4mUNJJQ10Sthl8n0TPilQIluVnuS/ HXhaSAmlJ4ksrTSakwYg3TFP+ZHXMotncmwA+uemibtzRXiUEy+q4XkNO 9NU0o7DiguWKflZWvk//RiUukepTrKGIcq8FgHi8AtmzCkfgckdNUQChI fq6arR4KRxaZGgrtAVXmCq3yK8+aScApDRYrvXDHkYieU5LiYSlyznfz1 6svoTNUiOrUFC5BjJbTS4KqAC3V1o3zhlGEhWVpGi9DxQ//LmKtAKDMy9 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10751"; a="424687635" X-IronPort-AV: E=Sophos;i="6.01,156,1684825200"; d="scan'208";a="424687635" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2023 19:35:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10751"; a="889869645" X-IronPort-AV: E=Sophos;i="6.01,156,1684825200"; d="scan'208";a="889869645" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga005.jf.intel.com with ESMTP; 24 Jun 2023 19:35:35 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sat, 24 Jun 2023 19:35:35 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Sat, 24 Jun 2023 19:35:35 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Sat, 24 Jun 2023 19:35:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TTpxWnnd23ufhaUH57w3OmgmIYMX9jP+wWeE2R6veXQfoQ1+01EVXHRGsrc8niWYif1uvnxTsPWyfp1MbciNkgshjzZ3HIDFo4g9aDvxvb1/ZaDuyF+1DraphT9OJW7rc7LvaTX4d34L/21jwlK4XUa4GtcO6dtIyOAzKdQ9lQwivGrgYoibUXvRT1DWwfIndh+d2XjCS/tBcWfSjQm8Dbc49orw11DIxbmTXTJ7ecAHP7NFCX0FB7oISvdtkYpnYZgYqkujmKtWP4ML6V4+A8umgapLNahNHHZy2Wtz3mgj7oDPJzgOBidt5g6A8goNKadhbAAWSdtBKcDyIAnLZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=esIOi3J4rEy8hzYrlrW4cuxONyevNNwF7kjyp/7UMf0=; b=ZxhT088iYrLJkw1Et2rWu93W7X22M+NC568lSpzhTheYiSsgcFIEZOxAXXWzpz4e6DTbnIZG5qDvNo2jUVAs3Q8lqBYHdz70VKzzrSSw6qVIpYV50/9GJvJV+gw/GrKXEXdFiZ4hKIR6IoJ0ob1Xm0ic68IGwg7gscxv7AF0y5KOSEmNPYzM4IlAUaHvdgW5pHhSZHzHQ2E2BoIXiO9eR1EkbkX2aGsxk8Fqc9PXyc0d/iU6XaihpYcHr18xfzHwvCJvNJU4RQpR3qStdUzncmYxqjtk3lYHOE89CNCfDi6/AK7tnuJbVEhPWRruVsYqiPmH2I9O6nGnPhUGVipinw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO6PR11MB5602.namprd11.prod.outlook.com (2603:10b6:303:13a::5) by CY8PR11MB7196.namprd11.prod.outlook.com (2603:10b6:930:94::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.23; Sun, 25 Jun 2023 02:35:33 +0000 Received: from CO6PR11MB5602.namprd11.prod.outlook.com ([fe80::b504:c7a0:9ce8:6f17]) by CO6PR11MB5602.namprd11.prod.outlook.com ([fe80::b504:c7a0:9ce8:6f17%3]) with mapi id 15.20.6521.023; Sun, 25 Jun 2023 02:35:33 +0000 From: "Zeng, ZhichaoX" To: "Yan, Zhirun" , "dev@dpdk.org" CC: "Zhang, Qi Z" , "Yang, Qiming" Subject: RE: [PATCH] net/ice: revert mark action in switch filter Thread-Topic: [PATCH] net/ice: revert mark action in switch filter Thread-Index: AQHZpCPAldsNOM3llkisyPBI+m8q/q+azreAgAAC1FA= Date: Sun, 25 Jun 2023 02:35:33 +0000 Message-ID: References: <20230621094125.3071251-1-zhichaox.zeng@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR11MB5602:EE_|CY8PR11MB7196:EE_ x-ms-office365-filtering-correlation-id: fab486d2-b2c9-43cc-18bb-08db7524d9a6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CNcfu1oQamXGCWP/31tm2SE5prwG556Rvg9mCGOyxPFc7w/DTkL6pHWobS1rXheDO5KjHxYJ8w+uM5LwRL9mty5UanJYXi3e2v6e3ZhbdGDnWuYvddYjcllbIUy124Ns1JkZvLCpv6HGNwpHP0aVQ1LaSgf09W5KaLeL1rv7zvE9MIma3Inc3QyfbiTWm//DIYrT7dw0LHEyLyv5oAIY1uRs+uB5//m0mhJlheyoyec1nd6mBcbpkgxDtEU2ckVLtX4EuMAJmIXzNlXzzT6sN3X7Wy7Y2rWZuTFrUGhzhyXurPBNbme+zZlaaZVQs/iRxTwHNiqeH21hFlCDSJPGhEVJHyJYWr9HXe6M5B/a8ySANy7NSql0ugYzU3XpIg2zE8OaO3NLUA5/LS8oupgBWyQ3JJzve6prvbthFAf7z1z1PXI/NbfFuoRIeK5pwz5kH/Fsj+3Y4MV5wbI/R58rgETtYjSxshMVRa5gnGH9sHBGxuc6d1AR+ERvQlOnZ3FZgTfUFyr1bfoxc5/R+ATVAgPrNuL4b/ve1SHJRIEEzDdqX8Z3bLUSjhD6E6C6E3MNvFvjRcRvNZqcQOWlT5jQuneYd+docLMcQC0ZAyYbXufE0tpBGNI6jXU0hqsrqVWv x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR11MB5602.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(366004)(376002)(346002)(136003)(396003)(451199021)(2906002)(186003)(26005)(71200400001)(38100700002)(122000001)(107886003)(53546011)(9686003)(6506007)(52536014)(5660300002)(41300700001)(66446008)(66556008)(83380400001)(66946007)(76116006)(64756008)(66476007)(8936002)(8676002)(33656002)(55016003)(38070700005)(82960400001)(54906003)(7696005)(86362001)(110136005)(4326008)(478600001)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fvbddqeYlqZunmY4jFzX++cQy+EOaAweDlrPgcUljMOpMKsIPkcjafDH6H3v?= =?us-ascii?Q?V9CwxJCQIWhoBNyjfkAD9HnZXjPDXRX3olzDtjyom4af7BzuKquctnYHPDaT?= =?us-ascii?Q?uu3dPb41CRPp49r0vNdbVqlDLowKNFVziL3ksQbb3AqRBJg6sMWoCEDgG5Ez?= =?us-ascii?Q?8Uz//Ianv+5dqwuVw8XZnRSDn/SvKeGtX++YDpuUKCrKBaH8JdAsTc6pE2aH?= =?us-ascii?Q?7GMETcjfWI7/Yy/L50o3BlX1HrIgK/55fhuXiy56JGppzuiRdYHjEtzXG4uc?= =?us-ascii?Q?xg+NJOkFYSWBQQmLdXG5C80HOWF8k1fuppcetaDQFc4kcfeu+7n7i5MZaOnh?= =?us-ascii?Q?b+O38nZ24UqDdb3HNTvXRibSLU6OWhAnOGWs5cfX2Wa52BcGN+iwpBnJbKDs?= =?us-ascii?Q?fBmtAMrfZ/FGX8FZePeBrreNypvQN0PXzeBWV/RtDJgo0ZHuSW4lPJ9X+OqQ?= =?us-ascii?Q?tgpn2utNdPVXpnqVfK7o2OOmgejAAzuzA1t31VqUuDLGBQlVmW1vMLd5DxZ1?= =?us-ascii?Q?tddrVWwU8q9CKNYLG0T5KEmrZaolBfCiYSIf55488uB+knlaXjQ+1Sd8+aMf?= =?us-ascii?Q?CyhXVRhej34280TETn96N5Z4mEq5uMu6se/qbxpwLXM2r43SZEhLw5rXa3xS?= =?us-ascii?Q?s63MVsThaiHQT/H7sbZ5uQg2oDuFQoI/CPibDT+ZT/8kP4NmzK/AjP+cX644?= =?us-ascii?Q?QUG6c/3cekv7vsDyzt4YPbQW33FA2lWCa+TV/yF+D3A6HRtyk+jub4y5AVwT?= =?us-ascii?Q?r2rGS3WGyqh2MzKUWzRglbSZcDIpEIdIPTbsKTFZYCDOpDI80adDA+vP2h2v?= =?us-ascii?Q?rrBrrhQEmlKh10JA3UsGF6Id9wiA08LI5Re/pCnJ0xJtlK7UM6SvxhIr5+rT?= =?us-ascii?Q?XoYgs1Gp16x2u2VXK3pywSkpUj1Xzi6IArgz5oHgiX8fuhUrcEw/A0oIkcfm?= =?us-ascii?Q?O/nH/nOXCSOtJ8vItyjx0hMUGw8Flz/97IBdzeQL/IPyZs+u7oOQ/8Vl/zJi?= =?us-ascii?Q?tYPpGGedermjcwGLIE9Zt9fl2zDXQY/rnAWYnxG+EFJHyFnaNhTjTLe2lXPE?= =?us-ascii?Q?VHCBEVYrprPy7tikLMJP1pLk6kwMJRxLkuTxtO7Ms4iNqpUX99Cd747nKR6v?= =?us-ascii?Q?owKBLPCKGa5Toa2Mim/ikpEDpLKHkxvoPy7d7KtX86YVPCY7BbxvBP+jLAgE?= =?us-ascii?Q?xEq/1Q445nm3dpYCw7QVjYGOTGzUIseWo5xF6qp+5KTOwZdvO+T90EqPwXc/?= =?us-ascii?Q?mA9MS6drlSeCjVRBvTkddFR0RXYoH7Qo+YZjN/yCOwVX5WVPTlMHg+HRMOJ2?= =?us-ascii?Q?P3NLqbV3dnZ4ScLvmTLLm+gsXSGmv25izOeB3mUhEUfGZAGaouS5F3JwDwBm?= =?us-ascii?Q?9aZr/G9lgnzVOWYAk9QFCpWIWrLRwDocxeyjEnAQIRBbMRDtY48UYHD1Ti/R?= =?us-ascii?Q?rUk/MrhykZg1qX2fwCX3XVSxzLMytD8Uq6MpzTM5nYEhjKDjPvKJ2Zj27gwj?= =?us-ascii?Q?/A70jwHVsVOI64CQEX/12lbTQopocnM2sNz8WoEb/eXBEaJaEkTmK9n0yFDf?= =?us-ascii?Q?zburakJvDDEto8jaTVMobr1btoUqN1vkHvPKIm0G?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5602.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fab486d2-b2c9-43cc-18bb-08db7524d9a6 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jun 2023 02:35:33.3346 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: N8L77RvNbWU7QnJ7bhNfeWbDblqx4HgOlsrA46cnlpwp40lUPieXThKE0GAiCdPx7oZWlDDOvgCO7Dfv0xUicw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7196 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Zhirun, > -----Original Message----- > From: Yan, Zhirun > Sent: Sunday, June 25, 2023 10:20 AM > To: Zeng, ZhichaoX ; dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > > Subject: RE: [PATCH] net/ice: revert mark action in switch filter >=20 >=20 >=20 > > -----Original Message----- > > From: Zeng, ZhichaoX > > Sent: Wednesday, June 21, 2023 5:41 PM > > To: dev@dpdk.org > > Cc: Zhang, Qi Z ; Zeng, ZhichaoX > > ; Yang, Qiming ; Yan, > > Zhirun > > Subject: [PATCH] net/ice: revert mark action in switch filter > > > > This implementation has some problem, the function did not work > > properly, and it broke the mark action in FDir filter, so revert this c= ommit. > > > Hi Zhichao, >=20 > Actually, I think it is better to describe a functional impact in commit = message. > It could make it easier to understand the issue. >=20 > It could be: > Revert this part to disable mark action in switch and recover the mark ac= tion > hit in FDIR by default. For current impl, switch filter missed the consum= ption > part of mark id for app. > And switch filter capture the rules first rather than FDIR which makes FD= IR > rules lost. >=20 > Does it sound OK to you? > Thanks for your comments, I will submit v2 with detailed commit log as your= advice. =20 > > Fixes: e24f43f2c824 ("net/ice: support flow mark action in switch") > > Signed-off-by: Zhichao Zeng > > --- > > drivers/net/ice/ice_switch_filter.c | 9 --------- > > 1 file changed, 9 deletions(-) > > > > diff --git a/drivers/net/ice/ice_switch_filter.c > > b/drivers/net/ice/ice_switch_filter.c > > index 1ff4b1afda..110d8895fe 100644 > > --- a/drivers/net/ice/ice_switch_filter.c > > +++ b/drivers/net/ice/ice_switch_filter.c > > @@ -1715,7 +1715,6 @@ ice_switch_parse_action(struct ice_pf *pf, > > struct rte_eth_dev_data *dev_data =3D pf->adapter->pf.dev_data; > > const struct rte_flow_action_queue *act_q; > > const struct rte_flow_action_rss *act_qgrop; > > - const struct rte_flow_action_mark *act_mark; > > uint16_t base_queue, i; > > const struct rte_flow_action *action; > > enum rte_flow_action_type action_type; @@ -1768,13 +1767,6 @@ > > ice_switch_parse_action(struct ice_pf *pf, > > ICE_DROP_PACKET; > > break; > > > > - case RTE_FLOW_ACTION_TYPE_MARK: > > - act_mark =3D action->conf; > > - rule_info->sw_act.fltr_act =3D > > - ICE_SET_MARK; > > - rule_info->sw_act.markid =3D act_mark->id; > > - break; > > - > > case RTE_FLOW_ACTION_TYPE_VOID: > > break; > > > > @@ -1830,7 +1822,6 @@ ice_switch_check_action(const struct > > rte_flow_action *actions, > > case RTE_FLOW_ACTION_TYPE_RSS: > > case RTE_FLOW_ACTION_TYPE_QUEUE: > > case RTE_FLOW_ACTION_TYPE_DROP: > > - case RTE_FLOW_ACTION_TYPE_MARK: > > case RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT: > > case RTE_FLOW_ACTION_TYPE_PORT_REPRESENTOR: > > actions_num++; > > -- > > 2.34.1