From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5378945886; Wed, 28 Aug 2024 10:53:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE8D641132; Wed, 28 Aug 2024 10:53:12 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by mails.dpdk.org (Postfix) with ESMTP id 237BD40150 for ; Wed, 28 Aug 2024 10:53:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724835192; x=1756371192; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=FGN23cqbIaxnrlwl9Tj75j64dS7ZkVKL6jtNCLtNdlo=; b=XnXRyxuu+I0mDcmnLLXBqEyhh1Ca3vXKHaUOyzJwa818w8i+Tx70EcA7 x+Q0YHyNt7WabAuKchMwF2M0kNJGdAfShn38HvzoO/DXU1u0zU8M0733l eVvsxi0i71b8SznlAOT9X6xV352aXOuMZbyrOHn+R9itQsFfRZVeqDW/I itqWWCKAhDo6WVndQ2Igc5iDWEIf12uniGXPGPE5HtP+w07Ho/BjitX67 ThB3BNqZ6Vuoknz6VYeGGvFICuNvfs6vJwQbgld1+7J0fcNWaxJPGoUef rveySPtxyn9oF+ZjliKqnuc2obnzvsuUWjU6OWcYDWDNZ/uVBjocG/Gw/ A==; X-CSE-ConnectionGUID: xQdDficvToWH0QRik0r98A== X-CSE-MsgGUID: jrXDqkOtTpyXJIO2LT6jLA== X-IronPort-AV: E=McAfee;i="6700,10204,11177"; a="23514241" X-IronPort-AV: E=Sophos;i="6.10,182,1719903600"; d="scan'208";a="23514241" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2024 01:53:08 -0700 X-CSE-ConnectionGUID: Q31RCDLtQqWulqAhwl2O2w== X-CSE-MsgGUID: bk0xD1CyRwqsXcV7JG8aQA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,182,1719903600"; d="scan'208";a="67833642" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 Aug 2024 01:53:09 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 28 Aug 2024 01:53:07 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 28 Aug 2024 01:53:07 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 28 Aug 2024 01:53:07 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.42) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 28 Aug 2024 01:53:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NU5d4NgirKcI9OfPg+WJLNIvsp4ve2L6GYh4jOgj+jhDZc5dkhdTmXlY3BHQVqKwGVaIL0obV0kAr1JXgVddJ/+TLVk2TNWQBM5EyDtidzsTmZGUhEwsNA1ZPaVwAZwJB7psgGrQ6TB652PLcPh30E67w5mJrWI7f+n1XiF30Sc9uuBnL4SmhdLCP12v4J0K4q+2RQYYhfjczTjhBi8WohFTOH7zay98dhnOLJCUCY4FP9eCHxvN2q3v4VFegyDtmlbnjInplmZuhi4DAR3xuKcJCw5VrMlZ3iGLX/A91ar8+1Uu+We1aD0BmFyKxh6N7HaV+d0qUCq9BmNl2eWfkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mzMm4fX4x41UbydGZJpkN4qOBu/Is8bEVq1M+BKO2Ik=; b=b1rbuyiDaZUWz8JCveTTjbqlQuabXW/Hoaqg92eyjjkt06ezVikzgGzEhXob6E6gzK1azdbVSCqC/ajWc6a+V/NK2AXmMWR5LS9AlxvOt2r3UiXUHprhp9eBGt/ukWfJVzVj4sf7x8+zYV07INeK04K3Pf49P8FMMDdf2snqaOfAsvXtYf2+je3LOZ5PWEoDwUId/vTJumwIc5GyGQ3+VkFo2Hn+WCL6bo92AeL+J7kHWBw/g5xSxENZVxMthksWcvpFsb9bwqALFUR2vDXGgMnPwnCG9/m2PLlVgTQfjLZGxnCv7chZAZaN1rKi2ekIMOvTxPY9KBaYYDCVjLdIpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO6PR11MB5602.namprd11.prod.outlook.com (2603:10b6:303:13a::5) by IA1PR11MB7387.namprd11.prod.outlook.com (2603:10b6:208:421::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.27; Wed, 28 Aug 2024 08:53:05 +0000 Received: from CO6PR11MB5602.namprd11.prod.outlook.com ([fe80::a7e3:721d:9cec:6093]) by CO6PR11MB5602.namprd11.prod.outlook.com ([fe80::a7e3:721d:9cec:6093%6]) with mapi id 15.20.7897.027; Wed, 28 Aug 2024 08:53:05 +0000 From: "Zeng, ZhichaoX" To: "Richardson, Bruce" CC: "dev@dpdk.org" , "Cui, KaixinX" Subject: RE: [PATCH] net/ice: support for more flexible loading of DDP package Thread-Topic: [PATCH] net/ice: support for more flexible loading of DDP package Thread-Index: AQHa+Pvr9LMl+s6wG06UVxgin1v5sLI8TUuAgAANfxA= Date: Wed, 28 Aug 2024 08:53:05 +0000 Message-ID: References: <20240828035335.1069153-1-zhichaox.zeng@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR11MB5602:EE_|IA1PR11MB7387:EE_ x-ms-office365-filtering-correlation-id: db845dbd-8922-4f92-0ebe-08dcc73ed4b7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|1800799024|366016|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?HwmHxKfLEVL7NUlfWmyjUypeRtd6xwKwMcyUm2VMgdpvTxPxSwVPRlmWFCc0?= =?us-ascii?Q?irnDMwqOHgcddfC3CYFcHWTp7UPys0oX0ZiEGN0JhekhSEfdS9cWP5gU1kyK?= =?us-ascii?Q?ImIC93ebaKu6WSbRGy+Z7VU1hZj9ZWsX3rZQ2vuYFMZMa91sJeNtXmsMICTc?= =?us-ascii?Q?sfoAqYZEs988E7UZ0QDn3BCh/UG4l2bne+V6h/PFt15g4tt6bwRSlFu3zcPn?= =?us-ascii?Q?pdemZ38L759qgBbkw6nityYDEyVEXPkIvu9xExgN3uvPvNDh55AUhUNbfAm5?= =?us-ascii?Q?Sj6WELIfueR6MhCG3T2WV1gY1L/+EeiCtgKAoAOvenbUphgIL1M5Qq+BUMXo?= =?us-ascii?Q?0yQbHPhWcLDVdLTv7Z361pKkj9jan+HqaDGHGF5Kr+swZfD/mjNEaq7wdeeZ?= =?us-ascii?Q?Z9+SH9LHwVEt1JQ5pxdoZ36D4TAez8CXJbWYoXhq4ACQU8G/E5uweGLVeidI?= =?us-ascii?Q?yeNBdYiwGjBULzoTOmqGIQH9ck9WjcwB6soIZbpkU5aErDZ5pkfE+F+i63Ls?= =?us-ascii?Q?/Qzc2RmCKpfjmRVRmvPBD4jfrX2m/K/y5iBDwT9N6oe7CY3LstMPti5kQlgc?= =?us-ascii?Q?mq/cUqOspICc9syiOu5WH0RIwY0qScHdV5h19Oc4H2ykZBQ5w4NQNANwy1Gq?= =?us-ascii?Q?Mz8IfhzDQCHsGTLMA9uvIecCKrad39mplnDu0urXWZV5es8ZeXc96ikq24hQ?= =?us-ascii?Q?OSIUIoZABv5zQGkTMxdELNHBticTic86jKup/yFFsIt927YCiqyNfGlECyP+?= =?us-ascii?Q?Rdk7WM1QAlrkDewVMqF7m/WHHF+n+WyTiDNVNGRKh6HWrWDBOqkdveqwaxtR?= =?us-ascii?Q?YuBlGkVtnWprMXkRftfQ5qlbjuC1338lRSQKVpH4rWmb6tgIz6R4ALlEVHTS?= =?us-ascii?Q?XH4UJ0tXJ8+ojbUPIPXmLRcW5O09TC7YcuITFYrQAN9zo9I/JQ03vvXRH3WF?= =?us-ascii?Q?zg7mnsTlesc3+2cViACN5R+mTzM4vikdYUec1twFpncUCqW+Z16J0UAHc4on?= =?us-ascii?Q?jY77PZW4IposRg3WjITerE3qxAMnaFAzuVI7iewcoEIMypC2PIcLOUTAi8rB?= =?us-ascii?Q?xXBTRzlPp4gWlNnJoFPqW2/HSnTR8qK35SCEtkVzwLC2pN/O1Gj+eS5gIThJ?= =?us-ascii?Q?H18erdApQJeKQ+ufwHDq4gJTM2IDUFFb7Vb5MzyB6BKdqXWLmSHlO/K5/ilq?= =?us-ascii?Q?1oe7sVjGqgUDTh0z1YpDF4lWeFvYBSWUmBuLXe1Q0jNNUNdp6l/+0+fAb6cs?= =?us-ascii?Q?hMvWTUqF0D3lBXfM1DC6m+Af3eeBG1n4XFeFKLGYfguqnSqNXwJf44SRjqLr?= =?us-ascii?Q?nxi6ZAEDNfJrwY0GBVwcI+gAthEeW9tgWq/E0JYwVQ81j9GMC9MxYPGE0mCh?= =?us-ascii?Q?R2JPkG4=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR11MB5602.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PqHjbK+82Sp01dhCW4TsUfvRCtFAIh8u4yydHrPxYawK7CZbGR4GyFv50MZk?= =?us-ascii?Q?LD7TvaCw0xVCnWxVTZnyMrPZ2cjCqHMCvJ0e2qPh/977ayeYjmyh0cBhHF33?= =?us-ascii?Q?Hv1EdJNd9aEHU0f3HUMHKmig6FZSIWGho+2wOtLogT9KArzHuIb20d614ioO?= =?us-ascii?Q?qIUSvUQqWOqD9nmfHOEIbmp6pEUqzetlv/yTVHaQyjqqYZjOgT3QFs1pfK/+?= =?us-ascii?Q?6LSRel1eQUjosT2IiF3QKiqxhmgRo+0v2edwThtWlMCQ/jKWDb8aesb163gW?= =?us-ascii?Q?7jUrjJ1TEy8BlqRAmJ4laomoJg1KvHHDPCsT9Krk6i6AMJgpvF4XS8KR22Z5?= =?us-ascii?Q?xSdgGQ1oNDdgVC8p5MchRNU0t0Gjg067ckTUReNNIOtWczCdJl3Sf/Tx3t4e?= =?us-ascii?Q?zs29thHDCRn83YOxwWCV/ZeI/+toFAiUcJ2N8rNp+tE7OHk1uua1P+frZE3K?= =?us-ascii?Q?EU3W0I9Qd96CgLv3PegS0TUbM9yovcM+zbXlYXWHD7lA1rplnrxGVbMHw4G2?= =?us-ascii?Q?r55IixdhedcqYLZ0B+mab4jw+AQnlaa7ECiAgtQLhsVlLiJVxUr/JbKioTq5?= =?us-ascii?Q?wGi7zeQKKp7hfk/rILOcGTzAw+jlo/n9FgaU4p95+z6rO+kvoX+dOkK/kWsI?= =?us-ascii?Q?l3p/Wb+US89yfk+sjkc/QhEu0NY9bRwflx7ot6dVSOwwGJ0cylhiFQM9e8qr?= =?us-ascii?Q?pT3bB4Asnjqr9TQUQ6KFVvScUrZkjaIN/+xrdvqCodKyvjRYV+ifRT65KF1p?= =?us-ascii?Q?4rmwJO9JfWRwsDIUVfUylPFiCm5VEy/4uns1TTftwa0OulFdBNJC/xaHCT9c?= =?us-ascii?Q?+XbjHHzZZrzEbLGJdpo17t90EVX95jvdMetU3/CbTLSuEIA0QIEmz7zNnpaE?= =?us-ascii?Q?EXrLE+pK0pu6v8WnmvQFLSzIDfqdRcxbtIdQtyEsWVwmD1/9KK9feVTqROG4?= =?us-ascii?Q?3gafHKqFeeI2TNS1wUFD9MiwGx26MwnizxA0w7PBW59EdFbZSNqLxBLfPnwf?= =?us-ascii?Q?FXVITmAeNgxU8UdWHqkusa6U7HH++4pMB7fkO9trFhgTGgbpfsMTGFuGFOIU?= =?us-ascii?Q?3rRlOtl0ugNpGkBLoJB7WBtx2M1QhK819MmH2nv1jQB4OzdYxKSMAi8HxpUu?= =?us-ascii?Q?EBJYufhenaMZf2xe1OEi9f9P8Ojp5uHIzlhbu4lc3myAOKcFnjo5/AGK2JrU?= =?us-ascii?Q?rEr80+EvIIZdbpnremMXGIEUgjGeIBl9/C0RXzYkkNLKdisHOGOlLgZhKTQV?= =?us-ascii?Q?Tcjw90w2zYy+/eeZNDeKdGmOUBV0OuO0GaeBJibIzDhGPXhgNMk5lkev5ptB?= =?us-ascii?Q?9PhuLvWuPifxybFlr3QZgda+FItl2Dzi/X6dZx9QZFCRxizpJ4KtuDHUj0HA?= =?us-ascii?Q?ojPgUH3j7Gm75PLOho+9PicP+N6sKX9zNOUVB9XYbv8nHXXhVR8Ii88WsbYF?= =?us-ascii?Q?aBGK4fuzh7/a5xRLmB9DWS9MbQw+BiwxADhTj3yjZx1apAAdgf4YfkSRtORE?= =?us-ascii?Q?zQMniRuPl5kFL5OIllcMLUYWgayWWcyCeqIuj/UdKuQt4v/trty75PHuNN/A?= =?us-ascii?Q?JfvHTk7EcSINY7EIMSR/77tiG1fFHsd6U6tJHBG1?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5602.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: db845dbd-8922-4f92-0ebe-08dcc73ed4b7 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Aug 2024 08:53:05.0279 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zL50dkJUhoTelT4sFsYaztsIjSQysnohholWbt3DWGgHN8W+nPD+EwwUgIeOV4e1LChIweZzHZwmpepAps/a6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7387 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Richardson, Bruce > Sent: Wednesday, August 28, 2024 3:55 PM > To: Zeng, ZhichaoX > Cc: dev@dpdk.org > Subject: Re: [PATCH] net/ice: support for more flexible loading of DDP pa= ckage >=20 > On Wed, Aug 28, 2024 at 11:53:35AM +0800, Zhichao Zeng wrote: > > The "Dynamic Device Personalization" package is loaded at > > initialization time by the driver, but the specific package file > > loaded depends upon what package file is found first by searching > > through a hard-coded list of firmware paths. > > > > To enable greater control over the package loading, this commit two > > ways to support custom DDP packages: > > 1. Add device option to choose a specific DDP package file to load. > > For example: > > -a 80:00.0,ddp_pkg_file=3D/path/to/ice-version.pkg > > 2. Read firmware search path from > > "/sys/module/firmware_class/parameters/path" like the kernel behavio= r. > > > > Signed-off-by: Bruce Richardson > > Signed-off-by: Zhichao Zeng >=20 > Hi Zhichao, >=20 > since there are two different methods being supported for picking a DDP > package this patch would be better split into two, one for each method ad= ded. >=20 > The support for #1 above is already on-list as a standalone patch[1], so = you > really only need to do a new patch for #2 above. However, I'm ok for you = to > take my patch and include it in a 2-patch set for this if you prefer, sin= ce both > patches will be related to choosing a DDP file. I'll leave it up to you w= hether v2 > is a single patch for the search path, or a 2-patch set including [1]. >=20 > Regards, > /Bruce >=20 > [1] > https://patches.dpdk.org/project/dpdk/patch/20240812152815.1132697- > 5-bruce.richardson@intel.com/ >=20 Hi Bruce, Thanks for your comments, sorry I didn't check the patchwork and didn't not= ice that #1 had been submitted, I'll rework the patch for #2 separately, th= anks. Regards Zhichao > > --- > > doc/guides/nics/ice.rst | 12 +++++++ > > drivers/net/ice/ice_ethdev.c | 61 > > ++++++++++++++++++++++++++++++++++++ > > drivers/net/ice/ice_ethdev.h | 2 ++ > > 3 files changed, 75 insertions(+) > >