From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90442A0093; Tue, 23 Aug 2022 11:16:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 33FE1406A2; Tue, 23 Aug 2022 11:16:15 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id B4406400D6 for ; Tue, 23 Aug 2022 11:16:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661246173; x=1692782173; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=U6a36vKSvu9CYYYhKSDmtL5uEOIuiJx6EljKyWCVvgw=; b=TXz+fY2/0rQPsbub7bYA9q4IMiqQBpmMt2yWn96mMvaQrqDjop0gM9DO 1WLLCTCYhEeymjDg4cRvGL8eq6GRMKYU7Tixs1xilxhUDDWkCHThnlpvN VGSgUJ6EnbKcxhwUZq7euQKyQbVY6nboikOKsnhzsE/wdM0y3IrlvPZJp STkIId34XNMRjpOFU5JAmAl8TjY4H8OvvujplUv8tPLcKzAdtnsIW9Ut2 uFYUM1DKiQ0D8U1Og474BAsprkXJnXsqBx7PDrbGGB4S3iB8UumKj8RUp J0DOgILaEV2OctujOGAGcZMmlxkoU/KJC2NjBd1le9G/uuZvEtROLJdtv w==; X-IronPort-AV: E=McAfee;i="6500,9779,10447"; a="379927671" X-IronPort-AV: E=Sophos;i="5.93,257,1654585200"; d="scan'208";a="379927671" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2022 02:16:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,257,1654585200"; d="scan'208";a="785175966" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga005.jf.intel.com with ESMTP; 23 Aug 2022 02:16:04 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 23 Aug 2022 02:16:04 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 23 Aug 2022 02:16:03 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 23 Aug 2022 02:16:03 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 23 Aug 2022 02:16:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UhQHji0U7OpHC4HpR/0Vkl/YRh5YOAYvKLeSbq6/gidpym76ij1Kqhkx0NqmhyTZZHC7OQzYoG0oRJHYq+r0g3rXgSTae7AkQPXAluDSZV4cqvPFqzp4WCvDOJSw0SAPeS2+n85pdT3LwunwlKR0XYHfFQRGrF88wC35li7gLWAMtmLYOKmdSvlo9Yn2AqTdh/MwGLzToGMbq1bAPHxvCqbe7M1DQb4F5XhgHjBHKt2UVCVEogvtuvDKWI8gyCpdRJGylHgZChbRvuC/AODq+lLknroL10UQmKB5OjWYFfa52GX5i/3n6jPebApXgq1nQkyeLb2VdPTK4uVeA2ly/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9gwfBeJj26jyFR7K2gupSPwN6nqikQw9lpJkjza24Ig=; b=fk2aRYa992CB6BGofHMgVoyu3DdvpSMMB7onna/LeLSnkrR1tFhrAWsdP2pB8si9+bjkwJ6V/cLfL58eFr/SQKqnmRaVazipAjzFeStMG2g+HJksrFxIeUGiUExj99AWl91R9PidWCw1MfWBATXBIFKk6ukGTvuYp0XHmOraMraAHIZRQUIIx6YoASNI7SmgaaO4uA61VfwtHoqTSPxsgWI11UrAxOlpS1rE0wa09TkC4++3Jzb0G4hVi73xBw7HvGz0CEqFziqO/AYqpW4HyY3rGNZkltEfcyI03V2GYdFWRofFPJxvUzbc7Lu6fZDne3ZrC3w2MPZcpa5bEo6xrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO6PR11MB5602.namprd11.prod.outlook.com (2603:10b6:303:13a::5) by PH8PR11MB6707.namprd11.prod.outlook.com (2603:10b6:510:1c6::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.21; Tue, 23 Aug 2022 09:16:01 +0000 Received: from CO6PR11MB5602.namprd11.prod.outlook.com ([fe80::c112:6e86:1bdf:66ed]) by CO6PR11MB5602.namprd11.prod.outlook.com ([fe80::c112:6e86:1bdf:66ed%3]) with mapi id 15.20.5546.024; Tue, 23 Aug 2022 09:16:01 +0000 From: "Zeng, ZhichaoX" To: "Yang, Qiming" , "dev@dpdk.org" CC: "Zhang, Qi Z" Subject: RE: [PATCH v2] net/ice: support disabling ACL engine in DCF via devargs Thread-Topic: [PATCH v2] net/ice: support disabling ACL engine in DCF via devargs Thread-Index: AQHYshOkb53bYVqlEEC1RL5A42rUqa28ISAAgAAVh3A= Date: Tue, 23 Aug 2022 09:16:01 +0000 Message-ID: References: <20220725031524.4063028-1-zhichaox.zeng@intel.com> <20220817082117.176980-1-zhichaox.zeng@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2586b282-99b1-4dbe-4c8e-08da84e81919 x-ms-traffictypediagnostic: PH8PR11MB6707:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4CXk2PqaXrbIfIXmeqoVtVcv0GNIBzeAMsj8F33QwxvFvGuSHSyOtXRFp6l1WkYY1PFq+uGhJNpqkw0bBpfJ7Mx+UW0GBEzqx9JkSzU6e37yczwFOO/DzYdlhZ1COzLUBKenxHu5spR6nWc20+jR0hD7IqaEew8dnXcNMoEooHbkxd0kVViIWpfxqRSfLr+y4uTzsAjNX2jTmVxYaKlsxxuNJ3rxTNBi3mngu89nspn/KW0trydvvKzbA3mQdRhhtEx3Qxpd1hidsepbYExMzN6Lghf9+AHP79Dt98TDuo1zKP4B4HaiERCoBxJAuGr/KGFZzOSyhm+WMb7Hw44B0Fq/OW6pPvuvCObSJLY2RrF31+4kpbXHWUfTnDaUdRjRd9D/TlkESxup7BmpLZXoIOT+ZM4r3H395o8tjiDZ6BVsFhKyefn2UQ0yZf0PTU6BXcFBeQsqrGPYVtyUYRqIttqchtsjNnBJ4XyJXquUerZLbeNSlihi0J6GmJBC3Net/eGONuS6ZeDK1JfdRJytOW14Ol3lbPR0Gz6nTh0q5wmRAf3DgNB0pyp0owUY1svcdc1wQfsftU/0MZj4kuiqxqm+/pQKShfZoQJUuQ9wwcuSwcL9h7F8rhXX3c6AhHIwFoSSpk8H9l7NS9hQJrsnhJnEwf0So04xwyDMVMMHQgFfFgN9rlPUZr/ehkozSYqephUvfBS2R/FihMZURbxScEqFCR4jShb+YPhu1KgiVvBaEYy3QQfdfhAV38qHLLgvCleriEcrYaqMsMZzD8XLUg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR11MB5602.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(39860400002)(346002)(396003)(136003)(366004)(55016003)(66946007)(86362001)(76116006)(8676002)(110136005)(71200400001)(83380400001)(82960400001)(316002)(107886003)(38070700005)(6506007)(26005)(186003)(7696005)(9686003)(38100700002)(53546011)(41300700001)(122000001)(478600001)(66556008)(2906002)(64756008)(4326008)(33656002)(8936002)(5660300002)(52536014)(66476007)(66446008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wqGnyAWyw7aCJhgfYESPmKhcZae+Ni7lkTI0nQtus0ZgR8/XmzIybsUsHAHQ?= =?us-ascii?Q?9Ewos7FpIrh4Dc7EAWo5gFaPF1ZdDk3YdYHYgZGt5IgMwIIecbZ7yO1jWNcC?= =?us-ascii?Q?TJ6dTZZsWNKsn15Q+2s5qb8okk6uvg3GCrQLDyUvLTeZ2WdyrWSXbEJ/gOpE?= =?us-ascii?Q?j84LhUe2OB9hovTseNQRgpcp/KpSWL+HhzWFurRvXa5hFvc4HRXitGWz80LZ?= =?us-ascii?Q?0/BGd7NgL8/xXtQ0WlbuioBZ0V+f+mUa3Bc7atXy0feNIYOeKfAjHXgSs2lv?= =?us-ascii?Q?f9FouSe3SZi7JCkD8oykkZ6PL/cxos0iFCJB8I/M5lasK3QSU7ctWpwmJkK8?= =?us-ascii?Q?Xv0cpgGDGoiDuPQDNK74yMx8isUmPqw4H3y/h8OxSbtST+ciMZw9iM7SZUjt?= =?us-ascii?Q?RiG4w4BWjqMyiqMFRp7b0Cx01KqDMyy/xP/kTWFqcFf6ImZbbpgc+CDmBSZi?= =?us-ascii?Q?4qVedxWzQdfInTL2P65i+GxBgTC+gIUZz18GFg62bbLtM6RL3O/Y1jAz43N0?= =?us-ascii?Q?24uP5gr8pDQNx5s92l383f6mGpGHPArUtBhq8DSawS0DU8Wh5ghDG6uwYu0X?= =?us-ascii?Q?O7xereHe3buIj/cO31UURKzcmyaOKbKFKkEkipT6VJfqqFqlHUrP+l+jKFU4?= =?us-ascii?Q?ubboOWZ21N6XHN3JwS+7aBAmv/9oa36lt9HXLhRn/5RkGMQb8JTnQBb/+mA2?= =?us-ascii?Q?fsg5BrTc71CZ1I8u0IPFUCoak0ZHGNWsLtkZVJmHksqXOza4p5idnubbb9Sc?= =?us-ascii?Q?hXI3tCnKsETtORilpBEbipByiWZRmJ/rMi2kV7o0bsGaaqUt8BYl3QqrO7XL?= =?us-ascii?Q?VdL1CUJQX5BsoICIv4vV00VcB7GDupp7yPv4UiJeZhYS9p8p4jR6F9fY8SY0?= =?us-ascii?Q?3KNpKsHlN4jQFRF+wQf0kFuLWLZvrQdwMNgJecw0yh/VHN2dSlDsyQMQbJoN?= =?us-ascii?Q?dkLibcm0xFJCC3OX+5ZNZNABeVnmiBdu8q6L/0l95T0yrtt3DdYDR6Ow+otJ?= =?us-ascii?Q?0psG01Dk075MEO/icZZFEWpjhmUZXSeZFh1RauukpqbTV7yw/hAEBt5OQmUB?= =?us-ascii?Q?F6ePplVdi9jx2y8D7itc28poqlGa2fe75oVs00hzwDCMAhBt3reFxeIJQe5o?= =?us-ascii?Q?m8OLGyLg/6T+kb97kPKfkPcadqLxa1pMPtqMvs9St9wg4ZORjPfJHIHXPyyW?= =?us-ascii?Q?2xlnsZscia/s9TJsbYnGw9T2hXA8ZoZEgkLjCDlPPmBEtUFiCTB3W7t9r+2t?= =?us-ascii?Q?4hvXWKTtEDVOV6VcBXjZwk43hUPz7bRz59l0vR/Avd6X/BI7JB1gBOUcuwFY?= =?us-ascii?Q?DB9zwFk2TPEIaAgzJVOulPPaZTfJum6YfJ2CwxqiY9S9yOIFKbbJK+pFkbVS?= =?us-ascii?Q?1d0Xmp0Hnlu1L8oE/vXuc6oawojiMF2TiGY46pQ8RQDhgpXFCU1oU2yxmvtP?= =?us-ascii?Q?AbQ4RoYQl96XC8sai9sTiV2Mv76dxCcHGb7yhhJLrIrm5i+1OZZISeYXOopL?= =?us-ascii?Q?/l4yHp4nsSPx5cvX6PABtd20xz3YKYagamqh9O4eZ9hzz5i6kXQ58OitRstI?= =?us-ascii?Q?BseO0mnWFHaFn56OOAyVW9YvhlLpeYoAzNsDCghy?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5602.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2586b282-99b1-4dbe-4c8e-08da84e81919 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2022 09:16:01.4089 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nYzuRBUlOtYhwpaaG0WEaGQ5oVwPg2+PGDkvbqxOBZ5plQ9DnXzJOvwbFcwAFqGWv17ABBjcpK0W4b3pwN2r7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6707 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Qiming > -----Original Message----- > From: Yang, Qiming > Sent: Tuesday, August 23, 2022 3:34 PM > To: Zeng, ZhichaoX ; dev@dpdk.org > Cc: Zhang, Qi Z > Subject: RE: [PATCH v2] net/ice: support disabling ACL engine in DCF via > devargs >=20 > > -----Original Message----- > > From: Zeng, ZhichaoX > > Sent: Wednesday, August 17, 2022 4:21 PM > > To: dev@dpdk.org > > Cc: Yang, Qiming ; Zeng, ZhichaoX > > ; Zhang, Qi Z > > Subject: [PATCH v2] net/ice: support disabling ACL engine in DCF via > > devargs > > > > From: Zhichao Zeng >=20 > One line more Thanks for reminding, I'll be careful next time. > > > > Support disabling DCF ACL engine via devarg "acl=3Doff" in cmdline, > > aiming to shorten the DCF startup time. > > > > Signed-off-by: Zhichao Zeng > > > > --- > > v2: add document for the new devarg > > --- > > > > +static int > > +ice_dcf_engine_disabled_handler(__rte_unused const char *key, > > + const char *value, __rte_unused void *opaque) { > > + if (strcmp(value, "off")) > > + return -1; > > + > > + return 0; > > +} > > + > > static int > > ice_dcf_cap_check_handler(__rte_unused const char *key, > > const char *value, __rte_unused void *opaque) > @@ > > -1919,11 +1949,11 @@ ice_dcf_cap_check_handler(__rte_unused const > char > > *key, > > return 0; > > } > > > > ð_da); diff --git a/drivers/net/ice/ice_dcf_ethdev.h > > b/drivers/net/ice/ice_dcf_ethdev.h > > index 27f6402786..4baaec4b8b 100644 > > --- a/drivers/net/ice/ice_dcf_ethdev.h > > +++ b/drivers/net/ice/ice_dcf_ethdev.h > > @@ -64,12 +64,18 @@ struct ice_dcf_vf_repr { > > struct ice_dcf_vlan outer_vlan_info; /* DCF always handle outer > VLAN > > */ }; > > > > +enum ice_dcf_devrarg { > > + ICE_DCF_DEVARG_CAP, >=20 > Does ICE_DCF_DEVARG_CAP means no ACL? >=20 ICE_DCF_DEVARG_CAP means to check whether DCF enabled with the ice_dcf_cap_check_handler. Similarly, ICE_DCF_DEVARG_ACL means to check ACL status. Thanks Zhichao > > + ICE_DCF_DEVARG_ACL, > > +}; > > + > > extern const struct rte_tm_ops ice_dcf_tm_ops; void > > ice_dcf_handle_pf_event_msg(struct ice_dcf_hw *dcf_hw, > > uint8_t *msg, uint16_t msglen); > > int ice_dcf_init_parent_adapter(struct rte_eth_dev *eth_dev); void > > ice_dcf_uninit_parent_adapter(struct rte_eth_dev *eth_dev); > > > > +int ice_devargs_check(struct rte_devargs *devargs, enum > > +ice_dcf_devrarg devarg_type); > > int ice_dcf_vf_repr_init(struct rte_eth_dev *vf_rep_eth_dev, void > > *init_param); int ice_dcf_vf_repr_uninit(struct rte_eth_dev > > *vf_rep_eth_dev); int ice_dcf_vf_repr_init_vlan(struct rte_eth_dev > > *vf_rep_eth_dev); diff --git a/drivers/net/ice/ice_dcf_parent.c > > b/drivers/net/ice/ice_dcf_parent.c > > index 2f96dedcce..c67c865d8e 100644