From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C2B4A0032; Mon, 15 Nov 2021 16:30:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B7F074113F; Mon, 15 Nov 2021 16:30:18 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2074.outbound.protection.outlook.com [40.107.223.74]) by mails.dpdk.org (Postfix) with ESMTP id D7FD840E25 for ; Mon, 15 Nov 2021 16:30:17 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U2vsaQybhwIqNykzTQDX5ftQuLFylT/+hEmk2PwhftAX026mqhlzl/j7rI1u5cYG1qQYQ82/cyltIBB0B0xAnKkTJQWb0xrw5NMz0l9kJQwwD+SS0Ct13EaXOhozUPY3zat+DTaLpaSJ8as72qmtkFCfC9veQh+/b47Df0cx6S+hofehFfZHY9UWj/PPaFtOFMgtH2fZSUlsQP3z1khnR+If1H6npjtdJ9QpjkphwXgkCa53ypFP+2xnn5wTGFZw4LXLg/HU0d100vnX7hgTJS0t/IC5LOSHkCdfFPS6eMSQYiiqmHL3NPFxb910K5Q/KNgu3n6sDV8LzdwozylB4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xhjYivlWvgDMgBm2TbKQavOTwCoL6trF6xJGKIgHAXE=; b=bRhsumgotGYJIzQEg6FMtEjLSr6q2AmYqKisAxOB/paJM9Viz1vPi9tmzE5dzrfXCZubsctLw3EjaVLcJZgTcF373YsOEx/UJof99ltPFPD05KW5CoPWwHxj7qiJY191BP218Q1Db4wEwcrmsYSTdvfT66SzaW8wS6j7aU+Kmk91Of2hvwGFX7TapMAK1uoUL/RuaBhj8pJF0Iyj80wI03pIcu6xZHVDT2qcGJ7aLCSgZ+vA0JcvmCHGwhvHQ0/+E57QfnGrHzxN42XqjgCRjQSDJc/S+5srfsC1aFdiyEX5Kl1T3AHwXlpBxWp3c+hvKKOB1nNtgYv8L6pcS+7Kyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xhjYivlWvgDMgBm2TbKQavOTwCoL6trF6xJGKIgHAXE=; b=g8AQ1EgAS4LaAv7cT/zjvAhp/HH88x86J/jKyQll15fIzA9R8itjT+RGhGGXvS1A/rqdWhgGt0VaKFW5Dhv1MZBoQBXGIipk2I0oUohX4mH5yN25p3gzyrxGPy4YZXjeWXQwIXBwtCsuxlwH3gUJldWM3AGM4Dw9rb2FXABgbk8cKsW14vtTdkDQBCyQkB+wjQ/uaFLa2KDQTxgtcbdWjJFFaJV3FIxszYIz58pCD9O+CQX2STqpAZcZ0kgjMWMF6bJnLcM2/Kj13sfeJmehT3yiWJO3CbWt4oQCQTlhKHzbeRVnNn1V/zLX8KApGj42DXnEAKzu++eDKT3VTHh0TA== Received: from CO6PR12MB5393.namprd12.prod.outlook.com (2603:10b6:5:356::9) by CO6PR12MB5458.namprd12.prod.outlook.com (2603:10b6:5:35b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15; Mon, 15 Nov 2021 15:30:15 +0000 Received: from CO6PR12MB5393.namprd12.prod.outlook.com ([fe80::b0dc:428e:598e:f55a]) by CO6PR12MB5393.namprd12.prod.outlook.com ([fe80::b0dc:428e:598e:f55a%3]) with mapi id 15.20.4669.016; Mon, 15 Nov 2021 15:30:15 +0000 From: Ori Kam To: NBU-Contact-Thomas Monjalon , Ferruh Yigit , Ivan Malov CC: David Marchand , Andrew Rybchenko , Ivan Malov , dev Subject: RE: [dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick transfer proxy API Thread-Topic: [dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick transfer proxy API Thread-Index: AQHX0AKS4vF8wykpDE6GkM6wG4+3Uqvwd1iAgAxlEICAB9oNAIAADwYAgAAFxTA= Date: Mon, 15 Nov 2021 15:30:15 +0000 Message-ID: References: <20211027090003.14556-1-ivan.malov@oktetlabs.ru> <815a9fc9-747f-46f8-c9cf-766fa71a9ecb@intel.com> <4177995.KZ5Ilm2TE0@thomas> In-Reply-To: <4177995.KZ5Ilm2TE0@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 03bb531e-90cc-4400-1925-08d9a84cd2e9 x-ms-traffictypediagnostic: CO6PR12MB5458: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8UPcU9pvx8+XEssALsUAW2pe9xvJ9oj0EGnmQ+8MU6lhWVmUpJlGd8WJucpD/l5yWSgJRUJj+1wxcVOCTjY4B9W7T0495SJQ22b2X81CVIpmQ73XS6SIh6+SXQA+JV+Kd3xb4DSKkRslq+Bk7M/k7Ke8fCfJ3ZCJsIWG/FB9GlGl5heS/jbBoikVm9pmpS1XsVR9W94QMr/ZE0J+Z7IbGFp84PKusjTkMw3pD7ta1VmENqEIRi6Pcjm43tX8WEQi4bANq+243GOBuVkRERf3QW8gjbw5RXlxiwkark971XxQDRR21f7JmdOdpE8qv67n0ed6oUlmHjngAw0TBG7eaGsJyJZpzRw7vUzQcGt0MhI8k6lq6XDsx53yOQKvVbmrQUijpZPkyXZCjx0cvGRqaq9CUY+UiKTapkdYaDZqeijZx/SOaBLukBd7+MFJIFvwlNsYtsXnaka18BxkdY1biaL3sGC4+jS/T3on61O04AyTFgzldLtn15y/p38HbNtolH5jRN8gYziObJMoBcguYmxCXor2onDj84Pb2fgvzhYKVnaBeRphnPHQGrK1SruV52tHdsUPxT3qqcwIMBQmaGLGRHZ2fx7J60bjgfqEjhT9CmxTAcEnKlp9dQvdSQpKfL3Ya/aRY6a0t+ySS9Fwpcm2xM6kI9Va8u2YHwFmWClgXSDmpR5x/tjwoGsAlgIKZS6uAS08ysA86VjFSRHM6Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR12MB5393.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(9686003)(38070700005)(38100700002)(66556008)(4326008)(83380400001)(122000001)(33656002)(55016002)(64756008)(26005)(86362001)(71200400001)(508600001)(66946007)(5660300002)(76116006)(2906002)(7696005)(54906003)(110136005)(8676002)(6506007)(66476007)(186003)(52536014)(8936002)(316002)(53546011)(66446008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5oAa91I6dfj16bzpdkVexpr0Kx5JDPyhd6mMdWnlWW7QvkBrYrT0W7lyQzka?= =?us-ascii?Q?gv2w3hEEtZ6YnGa0MDIqcpZeTFvzpwTYVem4H31KO179gLoGaHUV+AKM4sMl?= =?us-ascii?Q?QPCC6EfYbF0mYiJ19CKIxOMPbq/rntJjKg85XR3J55J0M3HZRWA358Th10PC?= =?us-ascii?Q?xaHwCrwl5P0srxUcZvMRkdX4OB85Mu2uvVOaqmlz3ukBDVuNpoRbARdBT7nW?= =?us-ascii?Q?VrD3TbDm+GcQiefPnQUEpqxOcpCIlWVk1uRpkHHIub7zUxjgpw2hWHNrmU5M?= =?us-ascii?Q?lPCyCLRKLayIb+El6ZhhUd/laK3j9Ospc6jdEcLfbFAdA3nLpFFOirT5jy7v?= =?us-ascii?Q?QfUHFAslzNipQxs1j4mgHSkMGVh1aMCLBCp/qKCeIYF8m4yUEQ46dVrbMuYm?= =?us-ascii?Q?o8kQgofU070NlV4Zz7qeb4L6MN1gMVu+7Cf+WLf08pLgNJkUUQl6B/E6EQox?= =?us-ascii?Q?8jEjsIbslaP1cITQoxsR+uy2DLpyDITvCZgimL4xNRT8fbSMCCzQQH/VMZsW?= =?us-ascii?Q?zSgaB7GzPZ79EdNe2GGqtyRdqnIsUvLekgXl+Ov28CVmNOidKaWvgiNY9iqH?= =?us-ascii?Q?cozmlLw5GMFvBLIhsM4wDa0hAT7OmJCaMQP1dTB4TVQNUPl/luIKeHm1zX01?= =?us-ascii?Q?xsrrjF955Y4Z1NTh7+lCtEc1n4GZQE0px/0Urd/JwxJbb6qg1fKtqdJTnAAr?= =?us-ascii?Q?M8Ywdx5oQMI+3FxGelk70eTvLrZXcoggx8dUukCpNMvVWgVwZgf/9qQ3L4Wr?= =?us-ascii?Q?etXAejHkEKOUy8ndwAw3HmFZd6R9OLATcL4KKFXl3h8YcQkiBNPAtRj7rSDL?= =?us-ascii?Q?rYJ//Eb1uuyAbXs8A9C8ifccZBxgfqqMyLibi1ZW6wsWZ/E1LZeD2xDOPx/z?= =?us-ascii?Q?LvReosBNA7OSvLm/vnNLC8IF3pt+Uc4/64CXiw31jqWyj7kQbOcrO6YhjO5t?= =?us-ascii?Q?nQes+YpOPh7CUl1j8K1I66sL/AlY+ie08fuhzjpeq+JB1XC3fmcwVjC34XR+?= =?us-ascii?Q?lt1OmkfFM0XIqdWCAJOlS/dbHvICgZDnrX3QmFvual9TI3EfsUSutNzjiPZx?= =?us-ascii?Q?D/x/9XlqanU8rsJWk8bJOFGlrQGhkE5Yta0dfMsOV21OWlwe0ZCBX1hW5pPn?= =?us-ascii?Q?oSasm8w7NRNEYci25ZwGb2XdUPyQLcbtNa45bSv8JuTKclTtQdTTw8hSMXV4?= =?us-ascii?Q?WMt1SkbbMG0ME6P9rBHkk02zBEAag3lQgCbzpamDAilLmzVS6Ir0vMHyEd6n?= =?us-ascii?Q?ENnSyOW7Xyy7amqemb0oIELFqqeBXAIEeHU24GDtCzKVZbJbSDmZNniIJgnI?= =?us-ascii?Q?LE3tF2/25h7mvanpMd7t6HR5V/X+ICN4RoS3U7aot/n3TV2fNztXd5dnWMF3?= =?us-ascii?Q?pgBAcqGUIaca2SyPjNJWncEyshQPaO3KEfr+0JgveosyN8o/X2P1qS/FfrQT?= =?us-ascii?Q?ajeD/Rt80RHdTWkCD5ZCQCXqZL46xK2XU9pmedyXVz+yzQ7RdnaEBKw26cSK?= =?us-ascii?Q?+r+xTyewtcS3BN6eo+uSeXN5rD4vMNjxb0qpVJsBlBBjNfIvh97aL85beJgs?= =?us-ascii?Q?dMMI2n+Vr8OpP4MuXsU0/Fzd8y39+bJ9UquJQpc3r3hAT6MCaO4RCUhEjrkI?= =?us-ascii?Q?ww=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5393.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 03bb531e-90cc-4400-1925-08d9a84cd2e9 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Nov 2021 15:30:15.8112 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eULA4PBYMTCfrvrQmz0XpHXy3Tf8x7OQdTN3yJcOLgWG1ErJHI9jQJijPiCqz5HjCCSef/KSlZTnUBaSa7Of5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5458 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, November 15, 2021 5:09 PM > Subject: Re: [dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick= transfer proxy API >=20 > 15/11/2021 15:15, Ivan Malov: > > On Wed, 10 Nov 2021, Ferruh Yigit wrote: > > > > > On 11/2/2021 5:04 PM, David Marchand wrote: > > >> On Tue, Nov 2, 2021 at 4:59 PM Andrew Rybchenko > > >> wrote: > > >>>>> IMHO, spamming of testpmd logs in described case should be fixed > > >>>>> in testpmd itself to avoid logs in the case of ENOTSUP. That's it= . > > >>>> > > >>>> I think we should not call this API in testpmd > > >>>> if not doing rte_flow transfer rule. > > >>>> > > >>> > > >>> Since testpmd does not pursue top flow insertion rate etc, > > >>> I tend to agree. For debugging purposes (testpmd main goal) > > >>> the best way is to pick proxy just before usage without any > > >>> caching etc. > > >> > > >> +1. > > >> > > > > > > +1 to not call this API when not doing rte_flow transfer rule, > > > and get rid of this testpmd logs.. > > > > > > > Hi all, > > > > I apologise for the delay. These arguments make sense. Thanks. > > > > However, the idea to hide the proxy port request inside flow > > command handlers might be wrong in fact. It is too much code > > churn. And it is easy to overlook this part when adding new > > indirect action handlers that are also suited for use in > > transfer flows. To code maintainers, it is very vague. > > > > Now you mention it, testpmd is indeed scenario-dependent. Its > > workings should be explicitly controllable by the user. That > > means, the proxy thing should be exposed via an explicit > > command: "show port flow_transfer_proxy". > > > > As testpmd is a debug tool, it should simply do what the user > > says. Suppose, the user wants to create transfer flows. They > > realise that doing so may require proxy. Hence, they request > > the proxy and then use the resulting port ID in all commands > > which have something to do with transfer flows. Very robust. > > > > And, of course, this way, the request is done only when the > > user needs it, and spamming the log is also gone. Let the > > user query the proxy themselves, and things become simple. > > > > Please vote in favor of my motion. It will not break anything. > > Right now, in this release cycle, nobody supports the proxy > > thing, so the existing flow use cases should work as normal. > > > > Opinions are welcome. >=20 > I'm fine with this proposal. >=20 +1 Ori