From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DEC3A0C49; Tue, 20 Jul 2021 10:22:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BC3F54068F; Tue, 20 Jul 2021 10:22:11 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2054.outbound.protection.outlook.com [40.107.237.54]) by mails.dpdk.org (Postfix) with ESMTP id AF6FD4068B for ; Tue, 20 Jul 2021 10:22:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FghBEHqjJLQFBh81C/I/hFtjcEcf70QeMo5rvI4RKZZMQTEdQ3n6HlB6xk5WBB34bWZcBRovAp47yOGAOE9MslQcOZUSC1SA2Xoe25cVrnCaVSkbDwVUNDKlA9gTVMAuO3M5laBiH6/Z31JejXEUxAHrhfpz7KziLF2UD6WUAa3XS65kqjQTK3FY605kGd7HMMELa+va++IBkawNXVJwGwP7lGl+G8DnprsFTdIiTSXRPjYxPsNo1tAovFi8r8H314xEin2bBIWOhA4sTz1UEJgJKzYDMa0CizSQ3NjGqlKx38AqgXErhnWZPwAoN0/UUBnNpCDODopG9Ko5OMjDVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SmyjB0jrlz1YbUbu0l0k4oRpuDSPJcoSkt5kPQ0Ty8c=; b=E6sW53pTpBpFwAaNsC+5QYD5Q7vTfiDxsW5HNjEVTmt5ZRl3qzNWnys0OudW/D+iycbMRbPel87K/CXONECkbKiNjuCcz1Jl2ahx1+YHP2WjgAsM0cq7BQleCMhjI52Y8RcmGnxW5da7iWNGdEzq52K4gO1o/SoH2qAS7FrBL4rH3kEOUAeOYB8WNfKUrVkrZSr6OJbK0Vegh2vzJu9JN+bmB/JOpj3RrXeUElkcIxEKO1OrKIb4oeyZORC5jxZp034RAZ8bLEUfFfKjUqXL8Cp/8rg19pAVAUaWC9YW0QWYAGjyySr9AQS/LHegy808vUMXiUUG60gCAgQ7cQFrSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SmyjB0jrlz1YbUbu0l0k4oRpuDSPJcoSkt5kPQ0Ty8c=; b=qMV4v830sM7LrtJB10KO/5+T+b4DTc6iDV5plwUAtA0rdVsrYtoVrzRJyo1CB1bD0+af6OMIkqZHBfapJb9+7ylXD2b2LWhayeAn8IbTAjSfWPLQIUl3+DdoYy+LLGjFhLE9u/EX6XslXXnCvkJau8UppUD6PKgxlQAlU4LAFeWEJcabu/TDcK8eQrDrY9HoDpfQS1U5h1q62IMoB8k9NU9nUGMCvg64CzwYxUOsovQM/bH1Uuv1wrmUlwBdm/le1XmqpBvMFpX5fnRvHCMPt7BseWw1bZPEZyxvI3e04fikgh5lPvcBWnCvU5YedhmqNhfzJa+a81V1BzfMQHhXTw== Received: from CO6PR12MB5396.namprd12.prod.outlook.com (2603:10b6:303:139::8) by CO6PR12MB5458.namprd12.prod.outlook.com (2603:10b6:5:35b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21; Tue, 20 Jul 2021 08:22:09 +0000 Received: from CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::3dfc:6b6a:662:7f51]) by CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::3dfc:6b6a:662:7f51%8]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 08:22:08 +0000 From: Suanming Mou To: Akhil Goyal , Shiri Kuzin , NBU-Contact-Thomas Monjalon , Matan Azrad CC: "david.marchand@redhat.com" , "dev@dpdk.org" Thread-Topic: [EXT] [PATCH v8 00/16] drivers: introduce mlx5 crypto PMD Thread-Index: AQHXeZhaYIC+LmpHyEO3U5DUjN0c3KtF99MAgAAUGwCABX8jAIAAAC8w Date: Tue, 20 Jul 2021 08:22:08 +0000 Message-ID: References: <20210715150817.51485-1-shirik@nvidia.com> <20210715164126.54073-1-shirik@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 56c95066-6e0b-4494-18b5-08d94b577788 x-ms-traffictypediagnostic: CO6PR12MB5458: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HXH7O7dzxBdpRmbwI5mR3/RQjFPLszy/SA6k2L4i/N3wByt+En0H+WaEgRakea0vMy7ewEJ0sN1PlN+aMab4m596MW85cRZA/eIjf39Z4zqnQj8E48egVkM3DylSc1ixVxAjx9bS8DhQLbW8sibqvtaO9dQy0uNZ+E+ge8ch8EPUbUeoUaYa1M2hl0t9AEpkBFTbVvwmEGFrh+34cLU7h3UwltvYnjfU5YaUGkczwb3Bc43hEouhaH/VcEPOr/qMMEqGCDUaT2E1MsOiPMdXn85XbE5zZQgabj8fl7uKwbVikC4cWlfDjmlOZ5zs469EeofKFIX8Q+L1CUbYYRkV2f8ybganhZoe2hvJZq+SbWUw9sxJ1Y9dYdGqASAj0rK96vEqKoBEnw67wS5UK+Js82i0qH0bhiRwOu2utMF8lKyaYiMh1AkVWyxkgroqrDVBYIN9DVcu4xRVWXSI768JOxm9laRnQsfeyr5yOHAW+GA3Hpn4u7UBp/944XyH2ct/pmR3jIw/NOnuc69y7/hgK0Koh25Q0IKqZpzJF2PYTLAoIvLcLLiPnbIR1fop8svOaQJEYj3X+98Ki/tYBZa0RKDX+6mrCEQpfhq7xJY9E13XHJ+B6+kkfYQIN1j0RDZj6fKbk12VHftFUzbNnNs55YV4jBrHMY+p/DObbk1P4ZbStTBoU2QuE0LE07cW/BwPRzgpMf6tFDn70H1QSNHoDOfbEPWFwfO5H1w8MfoqcJkzfKVp4tQUwlvU9dzkQtlfE+S4n3227q9CP9DySw7zMVFOF0xN8eQx0lMRP4Oxano= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR12MB5396.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(52536014)(83380400001)(4326008)(110136005)(966005)(66476007)(8676002)(122000001)(9686003)(5660300002)(26005)(54906003)(66556008)(7696005)(64756008)(86362001)(316002)(66446008)(186003)(33656002)(6506007)(2906002)(76116006)(55016002)(6636002)(508600001)(71200400001)(53546011)(66946007)(8936002)(38100700002)(38070700004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AsrkS9fw7ZqxcQSo7ndTHaliSZWnRGxUuOsTZ+XSVHq5BWn36SmaWRnKVMKi?= =?us-ascii?Q?lz42ivm+SeC8aUgU50dEaTssPE3H+CwE9iH0T/zhGtjkALNPDYqTrDE3YrFo?= =?us-ascii?Q?V0mDQgVeg+o/aYSU1TbvTYWDpEQhiR8Ue5y1GCoKFJboSVHsiu3RUD9gepbx?= =?us-ascii?Q?BtIZL7jGqTuwENswAVD0DOsIzsiPQj/rqNfS4cHNLIs2K19qaVEBr1pieNKW?= =?us-ascii?Q?61abFQ65JyQNtEpdWGse1GOutJG02tRa4wpUJ9jPyJFyOzqvsLakJiiE5P50?= =?us-ascii?Q?b5sD9Jm5tptTxEf6u39CL5YzuiSTDS/8zcxFf6T9IW8YSU0WR7IaTf+hpVxF?= =?us-ascii?Q?Dt1jXogODM6TlpAh5Y7dI0OyoaPYc47fip9PlshGYuuL5eiHf7sNm3QwH1I/?= =?us-ascii?Q?fUlv4FkfR/+gkbDcydGemu+G27IKb/0wQrEOLvBEl0nIyBVIgmMj5rA0vczU?= =?us-ascii?Q?8mY8DBUEvwwPTNDTMK9F+BtsSN5rCG6GS4mA4SXhW6aIEIkfeEpr3S9kNS7X?= =?us-ascii?Q?/Z2RjHilSxsPhADwOKiC2KEGr2pEu+bRXCa3tbd1AMLrCGtuHwcqArSIg6Mg?= =?us-ascii?Q?KvrMIR/OJfNwIJzNRzFapoV5LuAOnVJr/5sZyutsOLptvs+36V4xroLKJxOE?= =?us-ascii?Q?2MEOHeE926lNPEs8WebcLV/eUBGQ4R3ng6W8nXlkvNFDKzUFlk5IlHF4gYUO?= =?us-ascii?Q?nVL2gBt6JwzzKo0Ljqys292u5/KqxREjv/J55t79G1a5furKkGI7SYoi6L8U?= =?us-ascii?Q?AqQl9rHAFRiYYd3KKIafdaQ8OiupOv9TWYyMVlSiuZy189ggtPzZ3nQ+2x9U?= =?us-ascii?Q?uak1L7KOmd5cFQUyzxmf7Ok/uQIPlBM/8kC39JA1TmrXbp/RhYZ6b3C5h7V+?= =?us-ascii?Q?CCOYIg5473UtpY0uyAjfz9uSi2ycwLBZviit6NVUUISuVW9hzQ2LWyrF4LlI?= =?us-ascii?Q?B+pOLm7kUA+o5xJmWvulJERlEQ9rNibXa8j28XOwK9OtE3OX7AbMlVqT8Q9M?= =?us-ascii?Q?bB/tV6giF3TGl7aJTPOJWfpybGnOhYkDi1ey/iHaYR+9JLT9f/Nod8BbT9oz?= =?us-ascii?Q?kMj4opX8KyY2pHZhur4mInYdHLcW6PIEVxryUyg/CNOYI+HQzE0sPHcN2gjg?= =?us-ascii?Q?165Ai+DjR4Yl8tyDCI77KcE4/AMwPP7mr2Lju8aJjxLHLA9j0LyZPaxPONyg?= =?us-ascii?Q?6CTZY1UWXeWKHhbQlbiVbgn0HhkPlvgZ2qJru+KsflZ6+cne2v8ZGckxLgse?= =?us-ascii?Q?dmC5fLbytlDNMqrCUn5U7kc64yc+NFgShnkGMhHelUhmMYYrFuwZ4nwolkGD?= =?us-ascii?Q?+yfpu0emUaTXFaswgKyfN2GN?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5396.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 56c95066-6e0b-4494-18b5-08d94b577788 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2021 08:22:08.8385 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bjQj5eLfOyhAOvil2D5mmzEAZb2Gdk7D4Pdu9z1XVy/RJUXsuWBjnzA1VCYetkqu0EuSwO9FHMFcuGjAnhJVXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5458 Subject: Re: [dpdk-dev] [EXT] [PATCH v8 00/16] drivers: introduce mlx5 crypto PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, > -----Original Message----- > From: Akhil Goyal > Sent: Tuesday, July 20, 2021 4:14 PM > To: Shiri Kuzin ; NBU-Contact-Thomas Monjalon > ; Matan Azrad ; Suanming Mou > > Cc: david.marchand@redhat.com; dev@dpdk.org > Subject: RE: [EXT] [PATCH v8 00/16] drivers: introduce mlx5 crypto PMD >=20 >=20 > > > > > > v2: > > > > - Add data-path part. > > > > > > > > v3: > > > > - Rebase. > > > > > > > > v4: > > > > - Rebase + Address the following Akhil comments: > > > > - Set HW feature flag in the capability patch. > > > > - Fix mp object release in session clear. > > > > - Some spelling and word missing in doc. > > > > - Squash data-unit adjustment to the session operations commit. > > > > - Wording: device argument -> devarg. > > > > > > > > v5: > > > > - Add mlx5 crypto tests into test library. > > > > - Update documentation according to Akhil comments. > > > > - Fix memory region management. > > > > - Fix multi segment case in data-path code. > > > > - Split documentation to the correct commits according to Akhil > > comments. > > > > - Rebase to new version. > > > > - Change license to Nvidia license. > > > > > > > > v6: > > > > - Rebase to new version. > > > > - Address David's comment and update log accordingly. > > > > - Update testing app commits as suggested by Akhil. > > > > > > > > v7: > > > > - Rebase to new version. > > > > - Add scatter gather and OOP test cases. > > > > > > > > v8: > > > > - Add a test case that was removed by error. > > > > > > > > > > > > > > > > Shiri Kuzin (11): > > > > drivers: introduce mlx5 crypto PMD > > > > crypto/mlx5: add DEK object management > > > > > > This is really bad, I was planning to apply this series today, It > > > had small issues, so was planning to fix them while applying. > > > But when I applied the 2/16, it does not compile. > > > Please fix this, we are into v8 and compilation is broken. > > > > > > I am adding few more comments, please fix them too in your next > > > version As soon as possible. I was planning to close RC2 during > > > weekend, but it > > looks > > > It will fall over next week. > > > > > Please review this patchset thoroughly within Nvidia before sending > > next version. > > Take reference to other crypto PMDs for patch splitting and sequencing. >=20 > Are we expecting next version today? > This is the only major patchset left for RC2. > Any update? Sorry for the late reply, Shiri is not available these days, so I'm trying= to follow up the status and update the new version later today. Regarding the compilation failure, it's due to the crypto patch series depe= nds on some mlx5 common code.=20 The mlx5 common code has some changes and I assume Shiri rebased the versio= n with the dpdk-next-mlx and meanwhile the dpdk-next-crypto branch still di= d not get the latest mlx5 common code. I just checked the dpdk-next-crypto branch, seems the mlx5 part is still no= t updated yet. So will you also sync up the crypto branch today? If no, the= n the failure will come again. I'm not so familiar with the branch update procedure, but we will need the = branch to be updated to the version below: http://git.dpdk.org/next/dpdk-next-net-mlx/commit/?id=3D7e1cf892711b9ba2375= 63b6c876382caaec434f7 Thanks, SuanmingMou