From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5393FA0C49; Tue, 20 Jul 2021 11:08:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CBE0F4068B; Tue, 20 Jul 2021 11:07:59 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2042.outbound.protection.outlook.com [40.107.96.42]) by mails.dpdk.org (Postfix) with ESMTP id A3F9640689 for ; Tue, 20 Jul 2021 11:07:58 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M7ZuRnFterZiFHjLvr309kj+mZZC5lXO3fWKKLo/BwNX/01ezdIyv06gD2iMvtfMTW/GulGh1oVgqeTwLuiXQ5uje5cR994cGXNdrF6+eXdrMbMYCeNRBpM+vrdryd+QhwhiKve3kJFMjVNk318QDw6W6y0mD07a+R2lZG9+kP7JNgfRPvsWQKKVXqR7hSOHmhmEcGZKUWOX/HHQw+a0IQatH66EaFCzfDHNPt424D+OOcheRWkYvFhBe409sY7DXC+g8G2KjHUUDqLDTFPIlxw3WZlomtpjXUaWFr7/xLhB7WJNBqDHj4Cn9/L3E+oCJjIa8OWGG+hvSDq+NbrIBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nPbyWSfqjQhGqOaTtVvYBImhHtbtHeK4JJ6Sw3mDUtA=; b=jrHjfn8QteLmWDxhtqEotIN77fK+AfCM4DIQO2M9pl01pAKIiQrh+sJZrh+y2RxQWKqK5n5rZeBbG2oDVPEPkVgzv8uRhrY9Uf50g6GMu482g7G6WPZzLFkQSSWA5bR7r8Cdp4Rmtf4lYCx9FMTzrBRxrWRrSDf9NokIUwmuiOWn/dWlrPygH9YIdsrpTNjCxttM+cyX5QLJJ8YWDZOrGEsCiY8kRTFcqM2cHKxk3Ps2ISNPzfB7BOZNIu+PAjvU9JLI8Uq98Vng4tgm9gbmDsdv/sv0R+A7Omb5Rbxc2zRnY/1c740cJ1FhpXD3iEQ6uNc36U1ZDi+q3snXlpeRhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nPbyWSfqjQhGqOaTtVvYBImhHtbtHeK4JJ6Sw3mDUtA=; b=LCfAVKC2SWGdpr68gukw+gPOzGM6IvtcYoPNQ6ToE2J0QYR3yM+jb90Sr8BIYu87DKY4LDjpoEMwUmZ8RlFoXIl1HuqWNSkpF418s9YtUcb5FV9gAZG4PWTpAX5mxWKMRKCikfHWrszocU6cHnjZvR7F/1iBv5y0rjC1oJLxDQteHivO0Uo+08hNDWuacr6/ZTffKSkLZt+8sU/cD1/tys+6lCgc2hIMPN2KDVJ5p/xWOfD3KWl/Bi49zRZpmN76hTFEoeAUi9z+ASOK49wtbofce4gZ533kaztFhtDfUQAe2ALYYCi06xPcIkIP0eRVbgjCUD6qQq8TplNaWdPvjQ== Received: from CO6PR12MB5396.namprd12.prod.outlook.com (2603:10b6:303:139::8) by CO6PR12MB5457.namprd12.prod.outlook.com (2603:10b6:5:355::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.22; Tue, 20 Jul 2021 09:07:57 +0000 Received: from CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::3dfc:6b6a:662:7f51]) by CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::3dfc:6b6a:662:7f51%8]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 09:07:57 +0000 From: Suanming Mou To: Akhil Goyal , Shiri Kuzin , "dev@dpdk.org" CC: Matan Azrad , "david.marchand@redhat.com" Thread-Topic: [EXT] [PATCH v8 03/16] crypto/mlx5: add session operations Thread-Index: AQHXeZhehBeRlcOankWwytuyDSIWSqtGAoYAgAWXGtA= Date: Tue, 20 Jul 2021 09:07:56 +0000 Message-ID: References: <20210715150817.51485-1-shirik@nvidia.com> <20210715164126.54073-1-shirik@nvidia.com> <20210715164126.54073-4-shirik@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: af14984f-4ec7-4a25-e010-08d94b5ddd89 x-ms-traffictypediagnostic: CO6PR12MB5457: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UcZqrZnL6SrOPFy8zGC0QaZ7LT+I+TAtXQT7k+BjVr38NBOZKyw1l+XCWIS8BFivL6diQRgIJM23qNMz/wUktQfYXL3vbNhW+di4SILVcAoMxkfP/0JpmKEfCjFY/vvidY7iJSq3xC/8sDuPUW/fxd7jfIMEIgMinVkY4E3xF9HE6WvxPNBv24NjMkY0RcXm2ceZ0NoCApxs0EZbw8VqWAyfhcy8wwWkZCzzzd8/Nvctr+6HhqJ0nUCl5RtBmSYdHqOFzvHFPKSbcDhWpy9xSDJC4CaBBRRCJ5dwglKMgPKMGaT0mTSAdGrD7gx4c7Y3drPZEjKWCX8MaOdiz0HtQgjYLmBRu0WQAm9jqsMZYul5k7KA8aEFLn9L+hEfu9CbBZGXQ1zCbPFhxKeZVv47WyG7UPHy90zZ6jVkHP1WaIl+HQ8mJ5TJzPvAOCa+SQIQcFzTcfVt3PlhhnFVWzZCrzDz8VmcsYjDXtbaZmpo8/iJaQ0wfZypfMC1m9C/uH+/xSDYY161HAvt/7iQxxERhh3730WNvpAlsb+cdGODFoCvvPRtERT+Nd+D/q0lQygVi0xrfuHwFCHPiJyZO3/rcbNZ55897yWFWyg943AM3myrQe7XRpofdAeOpl042T7nXAsAeLiuPcGopM316PPCVox0D1D8uT2e/19xPQntP/JGNl5hEQPi6drmcpT0eqADrmUdNpBso+jyA9mBZme05w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR12MB5396.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(396003)(376002)(346002)(136003)(366004)(64756008)(186003)(316002)(2906002)(9686003)(66446008)(33656002)(55016002)(52536014)(110136005)(26005)(7696005)(66556008)(54906003)(6506007)(53546011)(71200400001)(38100700002)(5660300002)(8936002)(66946007)(66476007)(86362001)(83380400001)(8676002)(4326008)(76116006)(478600001)(122000001)(38070700004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hx8Gj+bUHDMjGPzTK1arsiKRvxuyDzErLmP3EYdW7GeYoEpSKjPSiBE9YSvk?= =?us-ascii?Q?KrS+2IVUqpBmYbZlZPKrpWrnVFc6xxkxLyolwL1vMgs+EFqk7FOEVISS/vrc?= =?us-ascii?Q?o/2lfQYbrZxHFVgZP3EUjx+3CbbK9dUgznxxkzh6pheb0LsglFGmY3lO8pSS?= =?us-ascii?Q?I0V/T2ZEAzor3ZVYh3ZvQiq5QEC4n3o+ehR9YiSbUZ03txtjkc1SwDn+Umkl?= =?us-ascii?Q?lq1Xk5pOmErRm7XIT6s51LxyvAftO0hBs7zMv8oflalqrcnXkj/1hS++YFqv?= =?us-ascii?Q?iJe0z2b/ME9rJt6n6/a8OLc4fUxhaNofFLYE/qbDpGgj2bwDoygcdyUkFRX6?= =?us-ascii?Q?1vwTsEXUTDo3Ajkr1tUx5kbZSATdKA8Tw0jZ76CsJYZYcm0uNBFjYk1S2TLa?= =?us-ascii?Q?UggC3p9m+ls1fpKEKnvD5RmZvwYzLRTRK3+ljcw7hikI/fPwRs8Romy6mi5h?= =?us-ascii?Q?u4Zsjbszikev+cSkGo9u6EsUkz+jxs+j7vrI7sblVVQCVS/DELXmEoN8cryv?= =?us-ascii?Q?BhSwsENu/01wZ257RCSXTbLf7lCkvbpmgq3zSCVqXT9zZEKGCNU4/rilFVf8?= =?us-ascii?Q?FuYrlaSVhtaxx1v4hgzo4yweTIUalL259jAl/4k2izFQWG0s+ZptyvW3EA8v?= =?us-ascii?Q?CDiDd785/EY7+y47H3eS3RoFQoVR2dzgBL6z3drspLXe0GQ+ro/XfozfgC3D?= =?us-ascii?Q?9nsyaCBh39FBryPO+3MouIzIHh6AfHMUGfF23oiFEZPYJ9s0ZqmTUfnvu4NP?= =?us-ascii?Q?Xchf7CHlxS9e7wqwlDu5yPtMiJLbNkndPLNTV+jaqELsUPhDPHmAIF5GhN7p?= =?us-ascii?Q?DiY2DnUKrAiso3UDTr88CsSns0soBe2JLTV982CIAzTJHfYG5DJ5Fk453FN5?= =?us-ascii?Q?1IPOrUH6/1CLo9U5IsspTXi4de2PKTYZQpKbTopgVpAf+54Gm8tOkcy5zxgo?= =?us-ascii?Q?Y8x0aH3pi3Oil36Bt8vn01X7QmCQU5Uj1LXBd047sZuAPhG/o8ChFZsK8BTf?= =?us-ascii?Q?STMZRgTAFuY5VP4dj+VjfpSzj0UX6hk73fH10xQSP5UnbrzpoOV6Jo5PLh++?= =?us-ascii?Q?u67YGkzzmzDVVFdh2JV7G/oZPgMwsUVp8tsRtEwbL8U29hNK0dgD2j7gDdKa?= =?us-ascii?Q?2k2j3xyXzWsm2MkW48ZeMpY7dXDqiXFmFvP51vKNYuIlqQBGtGwtTeJ/sTDP?= =?us-ascii?Q?SN1gyEECMHjEn3f41G8h09Mptt5EfLk9s2lg/EXYdbHEbrDcN38iwAV4pZY5?= =?us-ascii?Q?Fjy31EGz5kF7io/P54Jufmc/uL0fCgwVJrNL6oya67aUZ3poQJThfO2riL5T?= =?us-ascii?Q?yP+bfkBBsk4DiBt/PtST6qaN?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5396.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: af14984f-4ec7-4a25-e010-08d94b5ddd89 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2021 09:07:56.9791 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: U0Ylhd0T0lpd+6+BPkHNo3ez4xW2EqSyMZR2hfizXE/5GTU+IJ++0SPEI8dxOiRjb3dNUD6kf8thoiGLaLzrpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5457 Subject: Re: [dpdk-dev] [EXT] [PATCH v8 03/16] crypto/mlx5: add session operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Akhil Goyal > Sent: Saturday, July 17, 2021 3:44 AM > To: Shiri Kuzin ; dev@dpdk.org > Cc: Matan Azrad ; Suanming Mou > ; david.marchand@redhat.com > Subject: RE: [EXT] [PATCH v8 03/16] crypto/mlx5: add session operations >=20 > > Sessions are used in symmetric transformations in order to prepare > > objects and data for packet processing stage. > > > > A mlx5 session includes iv_offset, pointer to mlx5_crypto_dek struct, > > bsf_size, bsf_p_type, block size index, encryption_order and > > encryption standard. > > > > Implement the next session operations: > > mlx5_crypto_sym_session_get_size- returns the size of the mlx5 > > session struct. > > mlx5_crypto_sym_session_configure- prepares the DEK hash-list > > and saves all the session data. > > mlx5_crypto_sym_session_clear - destroys the DEK hash-list. > > > > Signed-off-by: Shiri Kuzin > > Acked-by: Matan Azrad > > --- > > doc/guides/cryptodevs/features/mlx5.ini | 5 + > > doc/guides/cryptodevs/mlx5.rst | 10 ++ >=20 > Documentation update is done in 3/16 which means the feature is complete. > But basic operations and queue pair initialization is done later. > This is not good. Please move this patch after QP additions. > Please take reference of other drivers for sequence of patches. I'm not sure what was discussed before for suitable documentation places, b= ut as you suggested here and in other patches, can we be aligned to put all= this documentation related pieces to the (13/16) final PMD patch? >=20 > > drivers/crypto/mlx5/mlx5_crypto.c | 172 +++++++++++++++++++++++- > > 3 files changed, 182 insertions(+), 5 deletions(-) > >