From: Suanming Mou <suanmingm@nvidia.com>
To: Akhil Goyal <gakhil@marvell.com>,
"ciara.power@intel.com" <ciara.power@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: crypto decryption support in test-crypto-perf pmd-cycle-count test
Date: Fri, 21 Jul 2023 12:09:09 +0000 [thread overview]
Message-ID: <CO6PR12MB539627757F099BD00B5DBD37C13FA@CO6PR12MB5396.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CO6PR18MB448464C9EB6FA1C99C60BCE0D83FA@CO6PR18MB4484.namprd18.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 2925 bytes --]
Sure, in fact I also find throughput testing with decryption and in-place-mode will override the cipher data in the single mbuf as well. So I assume out-of-place mode is valid in that case.
I will try to deliver some patches when have effort. Thank you!
From: Akhil Goyal <gakhil@marvell.com>
Sent: Friday, July 21, 2023 8:04 PM
To: Suanming Mou <suanmingm@nvidia.com>; ciara.power@intel.com
Cc: dev@dpdk.org
Subject: RE: crypto decryption support in test-crypto-perf pmd-cycle-count test
Yes, for auth cases, the PMD may give errors. However, cipher only cases would work without issues.
You can send a patch to fix this. But make sure not to add that inside the time keeping loop.
From: Suanming Mou <suanmingm@nvidia.com<mailto:suanmingm@nvidia.com>>
Sent: Friday, July 21, 2023 5:23 PM
To: Akhil Goyal <gakhil@marvell.com<mailto:gakhil@marvell.com>>; ciara.power@intel.com<mailto:ciara.power@intel.com>
Cc: dev@dpdk.org<mailto:dev@dpdk.org>
Subject: [EXT] RE: crypto decryption support in test-crypto-perf pmd-cycle-count test
External Email
________________________________
Thanks Akhil.
Yes, I see.
But for decryption, we should prepare the correct cipher data, right? Or that test does not make any sense.
I assume decryption with incorrect data will cause PMD reject work properly.
From: Akhil Goyal <gakhil@marvell.com<mailto:gakhil@marvell.com>>
Sent: Friday, July 21, 2023 7:49 PM
To: Suanming Mou <suanmingm@nvidia.com<mailto:suanmingm@nvidia.com>>; ciara.power@intel.com<mailto:ciara.power@intel.com>
Cc: dev@dpdk.org<mailto:dev@dpdk.org>
Subject: RE: crypto decryption support in test-crypto-perf pmd-cycle-count test
Hi Suanming,
The pmd-cycle-count mode is for counting the cycles for enqueue and dequeue.
It does not matter what is the content of the packet, as we are not validating the content
after dequeue of the packet. PMD/Hw will assume it as plain/encrypted payload and
will process it as per the session attached.
Hence, doing memcpy to mbuf is not required.
Regards,
Akhil
From: Suanming Mou <suanmingm@nvidia.com<mailto:suanmingm@nvidia.com>>
Sent: Friday, July 21, 2023 4:06 PM
To: ciara.power@intel.com<mailto:ciara.power@intel.com>; Akhil Goyal <gakhil@marvell.com<mailto:gakhil@marvell.com>>
Cc: dev@dpdk.org<mailto:dev@dpdk.org>
Subject: [EXT] crypto decryption support in test-crypto-perf pmd-cycle-count test
External Email
________________________________
Hi Guys,
Sorry for the inconvenience.
I have one small question with pmd-cycle-count test in test-crypto-perf application.
As in pmd-cycle-count run code, I don't see the cperf_mbuf_set() function is called to fill the test data.
So for decryption, I assume it will always fails. Feel like pmd-cycle-count test does not expect to support decryption. Or is it a bug?
I have no idea with the application design background, is it expected?
Thanks,
Suanming Mou
[-- Attachment #2: Type: text/html, Size: 8430 bytes --]
prev parent reply other threads:[~2023-07-21 12:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 10:36 Suanming Mou
2023-07-21 11:48 ` Akhil Goyal
2023-07-21 11:52 ` Suanming Mou
2023-07-21 12:03 ` Akhil Goyal
2023-07-21 12:09 ` Suanming Mou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR12MB539627757F099BD00B5DBD37C13FA@CO6PR12MB5396.namprd12.prod.outlook.com \
--to=suanmingm@nvidia.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).