From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 231B441E19; Wed, 8 Mar 2023 04:01:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B512D40FAE; Wed, 8 Mar 2023 04:01:37 +0100 (CET) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2068.outbound.protection.outlook.com [40.107.101.68]) by mails.dpdk.org (Postfix) with ESMTP id 5DAFC40ED6 for ; Wed, 8 Mar 2023 04:01:36 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ztv732devdaZhjJaqW/508iSvKApHxvdL2Ijsl0YM4QyRVL5rTj/lVP2+OopRfDwsCv7Bmdcthcq+ZhnY9kcxeT8AGEZVdk+d10ecZM1UVxb7A+WJgyFP3r2LPl9geVsSZfNrX3cW+BLshWcxSYOj7738WAt9/cyaywgg+KErHBdUieQySmQYApB65tTDHMAJuXWiCax18NpmXqWIpuauxxLgoS7eoCQ1NcBqE75bdTMPkJngq0Pj1wXl/ssRnTXIAa5xZfLeCmsQmjJaKzhuuGJrLTYwBM7Ir1mTKzr90PSDsgwSzh3Q5JypGxQNzi4y0j5Bm4+KH/GDVS2GvIcfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ab/0xYwmF/gFCeG/pzPaPSicMkFNPFIBc+DrQIFdRP4=; b=NaT7AWcqpn4cjCrVkSaMYa0Oo9JXYd2ufD61jkkAx3AqiI7lFIrA5s9duJiSZutx3PCDimNZ/SjX9itXCBx+ce6Sj1d9I4040I8p4IrMmQfajf2UFwGyCPeX38qtFzDJY1XVw9ZpXxS900Ksuwxb9/pah8eCuznvgqTqu85ZwMMV7LZbgegmJdf19IIdoXb3RSCK5Mt+numr+j9X9Mx6ERDnDk7jvEoN2SDsmguiUmyvNs0BVcuQIRSWd4abJDRP30q9aHEzW9obGN3J2dRju8VNTp0FREXBwr84pOvmmKePP8cR8/l+Cao/D7Wpyk/qzsVcIyUgAnvPwyo+BCcqDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ab/0xYwmF/gFCeG/pzPaPSicMkFNPFIBc+DrQIFdRP4=; b=Enw+Aqo9PnNcY8YcUsan+2gjUW0DArNYc5vWmMn0EU3leLhUx09xQJygo9/Chb1aRJD2717UH/ET9lj35YYSKSxRDUQPEoDOJozXhlVJPOtmcj/7w+KMWOUpYq7lFRfSsSuoqMG7T0aC/Y1z/pXJ0r8EhcR7P0aTkywW54NC9CVj/2LuoKnu8lsmYmdan6FZaIYRFxyOXdPHYSzxQqdG6CkO15/+W8RY5Vp7/ODZi6BmHMlkNJxBUSaSZpJS0Bb71mBvdW/oKjr8YcQ/k/91mhmz42WY+COvOBCbbFcIZrZHyDMvF2EHd8dwyzMPkEPL05tOAckgW+5RgPp/Xj06Vw== Received: from CO6PR12MB5396.namprd12.prod.outlook.com (2603:10b6:303:139::8) by BL1PR12MB5191.namprd12.prod.outlook.com (2603:10b6:208:318::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.29; Wed, 8 Mar 2023 03:01:34 +0000 Received: from CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::e1dc:525:d45b:94d3]) by CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::e1dc:525:d45b:94d3%8]) with mapi id 15.20.6156.029; Wed, 8 Mar 2023 03:01:34 +0000 From: Suanming Mou To: Dariusz Sosnowski , Matan Azrad , Slava Ovsiienko CC: "dev@dpdk.org" Subject: RE: [PATCH] net/mlx5: reject flow template API reconfiguration Thread-Topic: [PATCH] net/mlx5: reject flow template API reconfiguration Thread-Index: AQHZSVOO9bb8SSla40CNYzAzeHe7967wQaFQ Date: Wed, 8 Mar 2023 03:01:33 +0000 Message-ID: References: <20230225195804.3581-1-dsosnowski@nvidia.com> In-Reply-To: <20230225195804.3581-1-dsosnowski@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR12MB5396:EE_|BL1PR12MB5191:EE_ x-ms-office365-filtering-correlation-id: 56ccc789-a58b-454f-2f52-08db1f816ccb x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fOPvzW5iMipdOOIOs2XnMli7K+OLfFSErmFD6PLvCLylVsaVzB5W4GUjuWM5Xo+R36v7O1PCBCL6i/bq+o+FHKG1AJyAbIB5rMwkfx4tXU+6wJCMBdHDx3Ahf2aXbnYl3NEKNDyFmU4OGfyYZrGni4dRHwbICThoDZixZZUa8koRaDE7I6xGccYu6ojbfT0Mov7/AJl8S7hFyBIGZZconp5mjfKfNyFAoS/tiVUlYD6DQaRZrsiFsQNz2mCQu8UzpRAp00h/4qVE8BCBTXtw5Oa1yO2h0/OpguGxOaXma51tN532vxRPX5htCciOc9Qq5fKdgeuAgdtilD8qxZvgxbxajs7+o9KHhcob+xlgOvPDBAZ6gUQ2gB/9K6sFqyCMIYnyD8gAFlWlv4M9ei7Cj4gjufVhxTq1ExDiK7isomHMg+8qZp/fekXIVPtTx8SlZZf3xlwPDR/q6izeyXo9HIAq4IdMroCr3S0rlDUgXCdIUCL7rkJcOFxW9WqE3s6a1aGSnMyCbaPI+D10UFFtlxNjopgtAFTF8sbSyi5s1BvK+t+bRCJItwIUpkBtdpJj/DrMwI9YlUAstM2rxrixgduttV6ibP3oXRs6m0eBJd8it9eCIuGD68vSefkhxJesT4AenLpALKs+qG57cryRSI3XkaeWcp0xEE5oxkluGNUE0/LnxnfOkmylPm/QqutpregmH3s8H6eApvgyCHb9wQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR12MB5396.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(376002)(136003)(39860400002)(346002)(366004)(396003)(451199018)(2906002)(5660300002)(8936002)(52536014)(41300700001)(8676002)(76116006)(4326008)(66446008)(66556008)(66476007)(83380400001)(64756008)(66946007)(6636002)(33656002)(316002)(53546011)(110136005)(478600001)(6506007)(71200400001)(7696005)(26005)(55016003)(86362001)(186003)(9686003)(122000001)(38070700005)(38100700002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RaWRFEtbJ2ichGegZJTBrJe+rQM7GhQryHr4YA+3e7EqsY2K8TvIqD49MUB3?= =?us-ascii?Q?oAq8A3YWyzSMiwRBwS9JJZbSRHlilgpAMcNSbUN5x9Bk50+BIgy6DJFq4dF7?= =?us-ascii?Q?DBGDWyKynVY2pl8lbtEU6rfMFqVFp6zGZiz5uZmplKmOuV2L8TzfkiyHh3CZ?= =?us-ascii?Q?xp5YBw+1w6MhYMgOa7uqCzi9GIEgDTuQPMDHFyZNqNT3OliQIXHA9N/rad38?= =?us-ascii?Q?nqTYTOtvT4wjLjYbJzAnvxSLr+BDJ6Wv1LYBmAF7mEaUslyluov5wzKH67Eo?= =?us-ascii?Q?wWIJDycu+KbsKQl/v1VFnhMfDMUJjlF3/6V1grqh2z4qa5BDgvHZ3bTEucyw?= =?us-ascii?Q?N7cciCvKoTz4Ub0zB3Egbv7EHroAroANnY513tRK5xr9dvp7rt/edI5xLkV8?= =?us-ascii?Q?Q5E/dzxNBjUycjs6hyYGH4QD9HJJy9qaBcyD80h7CYz/Yt8+C79SGGw8442N?= =?us-ascii?Q?GTS7QG3wMPHNWBtDeU+CNWui54wPK30KbpVGX0iG7ottS2A7Ksupbah3mZcC?= =?us-ascii?Q?ywuUqLpGMte7YK/mhxti8+qnMhTYFQQR+k+pVGxStVElLTsJZI04r5iI9/Zc?= =?us-ascii?Q?4KqJmfvytsq+94ROBLt3bhBAb4L13fGpdOxlgzeiBGCnVwSt/EKEq8g8htzS?= =?us-ascii?Q?ZkMC80efYM5zOREP/G+BEt/FGcMSCBDBTznEh+YEiVhBm4qjVqGVbvmLyQY1?= =?us-ascii?Q?0RbfF9gk8Z4Dg82/kTKODJ1C24C7KH8fIWLPzkoCQ6qtk+8Rax0aHpLM+JZP?= =?us-ascii?Q?9se7TftSW/biiDBxRpRc6m2haakJoH1LDheN9wcoHQwtKBY7ySc/9/rxytyB?= =?us-ascii?Q?qq2yNLo+nlw0PfKkSuPqNrMgM+wfgfcacOBLhj1V1cECkczYhdREw6Utpov5?= =?us-ascii?Q?uKbPxSXwAC77giZHvfmhR4jPGVdrhAZgdznHrZuIdak0498BW3UCJV16Wz22?= =?us-ascii?Q?kNGfEIuvLHRDPV9EuIq0SL0wxURo+1R7CyZph8PbtlLty1uWscoA4dj/hmQf?= =?us-ascii?Q?rqCE/y8yHpIWABxDCxx02kprNmqrBtwc4c3MusnU0L0uWHXI6+Gsiob4sFla?= =?us-ascii?Q?Bi9VbQl4iUAZw++WmISG5yJFFzVVfjXCahErZRYRHnLVCETWFX0emB2xQEWG?= =?us-ascii?Q?Q3iB8OPmD1NAWYy+e5Ga/0l+NM+XqPxQ0uV5U1/1LAxgrp/X2ioLJTPRvOnr?= =?us-ascii?Q?kT4gmcItmwTLy5PXb+Hff8OGxOFYhezVhGYLrHOQ/6YEpHbYYS6+Hv0+N1W3?= =?us-ascii?Q?tuo30dtnzeuZEoC1cskq+tSLOqqIwe9fNSn/UF+zaOj9nRa8l5Y8rxJUZ6+F?= =?us-ascii?Q?jmwDC2mC3FQolTtesaZd8sD/0yzP0nlcQOJXmiS86T6xIWrkueuF9r/SS+09?= =?us-ascii?Q?AnEiFwAdT3QWCxqw8/aLBECeyfpF/GdFLowGGYW+ZgQU2G+XPcaf2cA5Zk5R?= =?us-ascii?Q?+eVvk7qJjRDd3sgtf02vhWOumsAkYHOD3VZqOurMwrrTarXxCdaqf7ggGqgW?= =?us-ascii?Q?2zD8I3z11u4CCrg4/M0HtR2Ocul2MIxVujiVWE9xw9rDcOr6bxySOmhuOLqs?= =?us-ascii?Q?99JWT6BUgTzuNclAjaZWI3VjfsMEXrNwdG71yQJb?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5396.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 56ccc789-a58b-454f-2f52-08db1f816ccb X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2023 03:01:33.9085 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: M6tssoB1Sa/RO6TQvduyhe8DD6dvrbh7bRm9RHuLwXjwKZPDsh3hOo4+3ymCmmmGA1sbwgwrn9PrTF6Zg/NugA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5191 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Dariusz Sosnowski > Sent: Sunday, February 26, 2023 3:58 AM > To: Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org > Subject: [PATCH] net/mlx5: reject flow template API reconfiguration >=20 > Flow Template API allows rte_flow_configure() to be called more than once= , to > allow applications to dynamically reconfigure the amount of resources ava= ilable > for flow table and flow rule creation. > PMDs can reject the change in configuration and keep the old configuratio= n. >=20 > Before this patch, during Flow Template API reconfiguration in mlx5 PMD, = all the > allocated resources (HW/FW object pools, flow rules, pattern and actions > templates) were released and reallocated according to the new configurati= on. > This however leads to undefined behavior, since all references to templat= es, > flows or indirect actions, which are held by the user, are now invalidate= d. >=20 > This patch changes the reconfiguration behavior. > Configuration provided to rte_flow_configure() is stored in port's privat= e data > structure. On any subsequent call to rte_flow_configure(), the provided > configuration is compared against the stored configuration. > If both are equal, rte_flow_configure() reports a success and configurati= on is > unaffected. Otherwise, (-ENOTSUP) is returned. >=20 > Signed-off-by: Dariusz Sosnowski Acked-by: Suanming Mou