From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58D3943CFA; Tue, 19 Mar 2024 12:43:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4313F402D1; Tue, 19 Mar 2024 12:43:09 +0100 (CET) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2130.outbound.protection.outlook.com [40.107.100.130]) by mails.dpdk.org (Postfix) with ESMTP id C5AEB40298 for ; Tue, 19 Mar 2024 12:43:07 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gcQUJAtMVai9JqkrII2+WxFU+YPwGenKgrntGOBwIHRvzXoj1sJlRk2q7yWG0Lz1NfWJQXr2bBIYXH+oAd9UIwFgg99id0sKqc63zAeVCeRcj+PvnJn1Vq80Pp1xi2nnP30x8DWg9e0+Nv+07rEbmrnW2CwqB0l8fnSaUEfQcn7xAQQLfEUCQ/wt7ycrphDk/5hqpRWmsNg658368IEc1aqgICRVNEncYDoFSt9ekCKF1KIc0nJsfBSOmNx/QpOPnx/Ro8W0PgJtGh/utJNuXqpPS9urm3knIWNWwAjyi3up2c/P4iOz8xvKLBK1d11Mz8vYhCDBUUnkT5puRkmMTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SHCoI6GkLkTG06oqtPnw8u2k6oK2i6leBSto4v9cR14=; b=IQukAhyiypNlyS/0wH0m1xSqGn8u0zPTi1XxMINcxqhMkl7sK7yrm3iqBvKOBVeGMDz0I7YQd5gcz97MQq/6VXIy7MQJCSOXJ3B+gUZGEbsmAfhYm4e+ToZr0AC3sFKMmiWmmqrfnw9k3QuwE1L6c1OOcT155OA16J+UsSGFfG5yYhCAJ6pm0fBMlJRq6sbCpnzalktzbPmWUlq1PadDYPxtgMp+jviTHtmKxBpVM2q0bGX/MbJ5VRKyNqnHWGf2N3UJf86rCvr7vzz1/iQeBfY0N2vWxEmdpzJmRL28iDjajj0HzisAVk8hOe0+AGh3WS1XWeM3+qhrB6BUuIns8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SHCoI6GkLkTG06oqtPnw8u2k6oK2i6leBSto4v9cR14=; b=V3PzQk25zYutFpycLkwebi+EbrdF3XxYh0EIavGlMTTiuTxXv9v8P1TdYHTkPb1I0s6zVErLVXeUiBAH3lW4LN6EEYV6Fm3rakNkZUghK86bNA/oLhKROuIFZw0puxEqao78hatR4yxR8pfN2rOmJbbhf7y/8307ZH1nVP2eSrNgH10QGnLhYm+PtaMqRTBkOMk7IdM48JiXu64eNvmtnacqxPFkysypMCKC3/T7Dm5EZKGu8paxcdjU8yL+/oBIHUk32feO4VRYFhoIptrS0N+40dZFvApJ07Ane6xeVCpvaGKfa/GWALeerD9yZB9s/rWmhOZNV7dyiejUjO6WgA== Received: from CO6PR12MB5396.namprd12.prod.outlook.com (2603:10b6:303:139::8) by DM4PR12MB5748.namprd12.prod.outlook.com (2603:10b6:8:5f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.27; Tue, 19 Mar 2024 11:43:05 +0000 Received: from CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::8911:190e:1f1b:9d96]) by CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::8911:190e:1f1b:9d96%5]) with mapi id 15.20.7386.025; Tue, 19 Mar 2024 11:43:05 +0000 From: Suanming Mou To: Akhil Goyal , Anoob Joseph , "ciara.power@intel.com" CC: "dev@dpdk.org" Subject: RE: [EXT] [PATCH] app/test-crypto-perf: add throughput OOP decryption Thread-Topic: [EXT] [PATCH] app/test-crypto-perf: add throughput OOP decryption Thread-Index: AQHaP741fQ9w9f68TEG7BEM2I7WNn7E3/9sAgAbByvCAAGxGgIAACv5ggAAINwCAACLPoA== Date: Tue, 19 Mar 2024 11:43:04 +0000 Message-ID: References: <20240105100104.908543-1-suanmingm@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR12MB5396:EE_|DM4PR12MB5748:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WHch/Yg50fl+u6+gsQX4ep/uo/wInIEG9PFsBwrTLW79ZGdhCiNvRqvrP4zj1p+CoD1fDlXuzKjel7UiPZc1A7FyxLI2Acve3IzojYJZEil70IxdbTYY43eht99X35Rsylg40if3XHCSXnk87z+wkze1THLVuV9DVWSQpM4554dMc3Q4cdb6nNS2EmaFRSo3ltMC0tsIYV4sERFD7f6rgqcRo+yRUIeeD6MonT0cC2nFaWjAHpo8KIUQM/deZjj2Ni85HDwiIqYzOiJVuYyi2f1Hi1XgJ8esy7wNxbyTdivTMYLy5vnRWyjmQxUF5R1UqPlNbw5186Qsrub4heOWDxZe01q70ozsnEQISXBFBhXmcznZ5WxuxOEWy9VgjrAO/juiIs+1LgXpslTZKqeohJJOJLtzRP9E6pGjwRwXOK2P1OBm2XfXxdbVTXE28UxDXWej7cv2vgrVP4PKWxg5KTLO4N2fvmECRT+C71m5/kjia4fjSw7Hulj0+hIwbkw3d17XkCkIlEZuSx1Oad+7b04trMb7L9UtZPzfQqsmcKNmurSZBa+tj0T4u3F+Hj7hm9l2g3OvpMha+YaQRvB1QeNrVbqr9+839+htP0UVdyh2a1RAu8W4ujD2CANMM7KIV/b7Os2QN9+L/m2VDmAs0bThNfc5yo8ThVm0XVXZBWs= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR12MB5396.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(366007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ji1xNuFw4I0uUXrGtXdPOBF5F/E3vGkm+RFE39yS6+d8g8W/ZplGyq2et8bd?= =?us-ascii?Q?a/8mU4zMw7Vv4gaV39FejvC2SxDUf3ZwO0U7veg1O+HUuKfT9STu0k8pAIm7?= =?us-ascii?Q?b29CjFuGK5cmjWHjksSTLzEZLCGQLkCAPIgtUs8oIUy0k2E0PvikcaEEqtqX?= =?us-ascii?Q?tqvZLJ2U/euv/o8uxkmAX4t9eW11CG4P0n2NEQidZpiY3lFOveO1wAOIRw9h?= =?us-ascii?Q?qTW/l8MkFhQEd9VZeKbQGaMrAiEPoY9gDZdhUpgpJtXGK+sHZyZwPlkq1bCU?= =?us-ascii?Q?yurUQUEwqHvU0/iU2/EYP1ebvaSrmc0gsi/eEij7tK+4meEtvjON2tMy4nMQ?= =?us-ascii?Q?rFYWSbkMX/2wcRtAa93hSgolE1W+J2hGGUaB65XKbFvD4cUUzRpd9kIdu2xM?= =?us-ascii?Q?2oKOIrZ3lNLzVVNFepbdNavjLytj4LBh/gIQl96JFqsLg0begOjimoLJFDV0?= =?us-ascii?Q?Jxn560mepOkCdQ5uXaQbPmhLrcoeAACKwUOp2mKNQuW1hAMj5irVnf91Kajz?= =?us-ascii?Q?8J49/U8guU4oS+jue/X7JZmlEgTCH1uDI6WZVLYvyAZ0ggNUZGj8yXRZRxvl?= =?us-ascii?Q?/w4+435h0GZFem+0R2U8vc57zOc8uBzghGBYRQj4X6mTidVgflQGe+Ahr2xh?= =?us-ascii?Q?0DnONT9pXFALMlgyNmRyLGI2L85OD4Pb9V4TAkCxPTDy/rg2sHcYLQoqSlFU?= =?us-ascii?Q?cuOYl+9weGU/xszLs1/YZ0uIKcbzEowELNrzh2gHtH8zOJJePsLHHbp/KjhP?= =?us-ascii?Q?3nIYClCuBWvrqOMivDS8e9RvfVvmwxcgQwDx8kA4Ce3uBgDjKDlvxJn274Di?= =?us-ascii?Q?o9J/KRsq0HTdn10SEr1vA0gDzn2S0/zhNTTUAHJX0okmGqvjdq8swotXIxAM?= =?us-ascii?Q?NFfdBco2iRUsDbil4bwKUcl4hx9ZUUramv+/dz/NNbo3fAaF9X7+RKD04adx?= =?us-ascii?Q?kHZ/VUhY+KgESSq5I6MjxaYM5Kn3UMt5lJF1oSHkczKyQ/X+skSLeZmpOEUo?= =?us-ascii?Q?fQYl2cTEXDSNezhe9/BrNtq+jk6nCB9rEweNGtE699/EEdpc5VOsbNzX3l3t?= =?us-ascii?Q?QQsUOW65rH4EFXKDx1e/JocTIn9tCfWBhZw8+L4+rCxgUa6iSfcGSTx9Vndj?= =?us-ascii?Q?cFGXxTp0MfyaANI66PKTBNkXhM7zMjcOrYR+ZM+Mg9dVYST3MHZ0qyOEKAeT?= =?us-ascii?Q?6p3fLSs5k/E1Ulm6iv3ELGYeqPbDSm7HqGV55E4EywCVRfNyWKqT0YLXiOWg?= =?us-ascii?Q?V3wXB5kagymeL30Lv2yARrbkFST9dtdao/LFAb5qvtPF7cvAKcwssQwLxcDt?= =?us-ascii?Q?ayeWc2yvrnxpuMn4+SgRu+2E+HOO3yfnxRCtaXmSgTnMmn7j4rIMT7Ei9skO?= =?us-ascii?Q?kR/8mAfWBInKN3movOVJ2J+/Opz3FH9dMIMmFtCuMX2n5Lcrx4Ve+1BA11cR?= =?us-ascii?Q?XSwwE+CJ8OVC4k4vY29gIOwBcBLLGRjc+1lfOjr7R95T7wwwEgtz+lCRZn1X?= =?us-ascii?Q?hKq7NoWYiQ6tMmO3O+lKM0GlD8F7113DPm64TnzbkVXg+kbPxnse5pphZXvu?= =?us-ascii?Q?ufzMidFrK2uYnKU2syoPjp5Q2o0gD4GQWzbEgM4c?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5396.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31bbdbd9-32d0-4ed4-0de0-08dc4809bd77 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Mar 2024 11:43:04.9975 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1DouPTr1RLILYvT90WvsaP4MyWCUCPM0ulqsg0YyZxXP5pi/lp9vd+DaxTvMDs2j3ZnzC5VlxF9GnLjDrp82aw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5748 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Tuesday, March 19, 2024 5:32 PM > To: Suanming Mou ; Anoob Joseph > ; ciara.power@intel.com > Cc: dev@dpdk.org > Subject: RE: [EXT] [PATCH] app/test-crypto-perf: add throughput OOP decry= ption >=20 > > > Subject: RE: [EXT] [PATCH] app/test-crypto-perf: add throughput OOP > > decryption > > > > > > > > > + if (options->test =3D=3D CPERF_TEST_TYPE_THROUGHPUT && > > > > > > + (options->aead_op =3D=3D RTE_CRYPTO_AEAD_OP_DECRYPT || > > > > > > + options->cipher_op =3D=3D RTE_CRYPTO_CIPHER_OP_DECRYPT) > > && > > > > > > + !options->out_of_place) { > > > > > > + RTE_LOG(ERR, USER1, "Only out-of-place is allowed in > > > > > > throughput decryption.\n"); > > > > > > + return -EINVAL; > > > > > > + } > > > > > > > > > > This check is blocking cipher_only decryption which should pass > > > > > irrespective of inplace/oop and Data correct/incorrect. > > > > > > > > Sorry, in that case I will remove "options->cipher_op =3D=3D > > > > RTE_CRYPTO_CIPHER_OP_DECRYPT" and only kept " options->aead_op =3D= =3D > > > > RTE_CRYPTO_AEAD_OP_DECRYPT ", what do you think? > > > > > > I would suggest to check for "auth_op =3D=3D RTE_CRYPTO_AUTH_OP_VERIF= Y" > > > Instead of cipher_op. > > > > I'm not sure. Since in AEAD OP, auth_op will always be > > RTE_CRYPTO_AUTH_OP_VERIFY, in that case even in place encrypt will be > > rejected. > > If the combination here is too complicated, what about just remove > > that limits and let user to decide? If the input is not correct, PMD wi= ll reject it as > well. >=20 > The problematic cases are where auth data (ICV) is not correct. > i.e. AEAD, AUTH_ONLY and CIPHER_AUTH. >=20 > Hence following check should be ok. > if (options->test =3D=3D CPERF_TEST_TYPE_THROUGHPUT && > (options->aead_op =3D=3D RTE_CRYPTO_AEAD_OP_DECRYPT || > options->auth_op =3D=3D RTE_CRYPTO_AUTH_OP_VERIFY) && > !options->out_of_place) { OK, that make sense. Will update, thanks. >=20 > Yes PMD will report error if the input data is not correct, but we cannot= just fail in > that case just because the app is intentionally not filling the data. > It should report unsupported case. > > > > > > > > Ciara, What do you suggest? You were also seeing some issues in this = patch.