From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE7CFA0C49; Tue, 20 Jul 2021 11:24:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9AF7E4068B; Tue, 20 Jul 2021 11:24:35 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2058.outbound.protection.outlook.com [40.107.220.58]) by mails.dpdk.org (Postfix) with ESMTP id 4642640689 for ; Tue, 20 Jul 2021 11:24:34 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TWBb2QEOGo3Hj3TDMbWcxVUqcY5HhBFzH+XErsgNSyR5uCQqpLOIo6B8LQAsJXnV/ZMNVohdtsPHFqmIdLstTE/VHGmj66+HVZwndYygJfPZWyl+iNB6IC4BHuLNZd7GA0ovwUaz9djaM+tYtVLjglv7jz0UtBAAo7eem+hHJx3s9mRO2u4hiJpLDjXeRkjGwVf6fPm/QjhFE2reKaNzUsf7N2bDt8YklC3VhNNoFjVLsmCt3RiCyL8VjzXlrmNHBR+CJJbqStCKA3qBLkEyyLdfOVOMVF/wfljd42FwHBqHVQDS4cC+CrTWVfHZqaQvCGcn/0+5UV5QowDF2Y6rnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HNc96XgX/VamE2sNZ2Hunq7TZQsv/LMy2GHCQII6I/o=; b=RKhYIvpdKFwqOjjHMEt3qmyXi8BDuvAUgeuX4g5GhSVjLvtdpPRkRUxW1sDvd3HZ2u4ob/dhH7IL4tSPd8ZdBUwv6DDD5jfzI8KqwVr7v6OyZ4zdkQwU+z/JJqqv7KoZGxfGrYsGdiVX1oY/OMFxLmU5E91HCaID16wDv1Mo4Y9z+KDbzG05PMEmVlBzQ12lH2or9Ho151SaKxDPBchcClVlkbi7N+uIgBq/SZvwL7XHYaLW84dXjYpbmb8WloOFv+bWYW/hflHqgQjbmucw/dz5lN6bPS1knxawKzVQzuObtwBSyjzwm0SdqYCWTFsFuPF+MjOg+BOSAATLgFJG+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HNc96XgX/VamE2sNZ2Hunq7TZQsv/LMy2GHCQII6I/o=; b=crcs4wwrEBbxp1iGgmq+ZAi/9nm8oBfUG1mbwvtvxWOAWpFglXJqn0fTpOtbEI5Z0tr1lQ9oI9NBw8GU1y1yNQJVgAotP8334Tp+Ws+JM/KkNaESm4hfH4N4p3zU6OPeXxPWDk8FsF+pPzRH4snbSgeneg2Bzne8ibALenebU3NKEklomFev6D7qh+HR7YHstroHYeFNSC5aDy5vUNn3136SxC7j82ro71oq/shHWGmOpI1d+lbGKboHC1reJZ+a35Cd3YgeA23Az4N/CFH8phRhiqSDdVI9OqtW9WAv29zHC0xtiR7HKMeDYm9eOBpz3Mfo3AeUBah4qOwMQPUaOQ== Received: from CO6PR12MB5396.namprd12.prod.outlook.com (2603:10b6:303:139::8) by CO6PR12MB5441.namprd12.prod.outlook.com (2603:10b6:303:13b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.23; Tue, 20 Jul 2021 09:24:32 +0000 Received: from CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::3dfc:6b6a:662:7f51]) by CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::3dfc:6b6a:662:7f51%8]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 09:24:32 +0000 From: Suanming Mou To: Akhil Goyal , Shiri Kuzin , "dev@dpdk.org" CC: Matan Azrad , "david.marchand@redhat.com" Thread-Topic: [EXT] [PATCH v8 15/16] test/crypto: add data-unit and wrapped vectors Thread-Index: AQHXeZhr+Q0qEo3fl0+uJQXxZwT0p6tGCOiAgAWVFHA= Date: Tue, 20 Jul 2021 09:24:32 +0000 Message-ID: References: <20210715150817.51485-1-shirik@nvidia.com> <20210715164126.54073-1-shirik@nvidia.com> <20210715164126.54073-16-shirik@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: de286dc8-aedc-438b-aae0-08d94b602ee9 x-ms-traffictypediagnostic: CO6PR12MB5441: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZRygkoV7EbNRoDd8CEdolc3s7/HQPnQGA2o6OGhDL6FPWBOyBEXLd73noJVbbNMTTQ3qV+mEONmdLly/SXwxXdhA6ztAQ1sacxZJ7hU0tSHeQC+SqVV4M4SZlePQv5SAQ3xkbRdzvflMxOFHj3WwqSkVYY/t7FLswEdZiH7MmozdBWsuHhq8ZbOWsh1PAqiEp3N11wY/9WfHPC0RWImCvucdhm9GHmr8UrfxEpwgQZTGj81843CAgcQejUMJ8mPCjhceFE0/36Hqr747+KkVSbnNE0SKm8q0CeniPEif72hxdzdGN+98LP74WFj+7Qtt43RmBVERCuBk4EytWVru7MIDD76bKot5+CzqMvb14f7NskGtfy2PgWVp0J1ezYJoCN4eQlsxDBHBPqOl+snuTvGyw4YHMOpwY2NVvOrUXRm17vat9emVzL7w3dgZdhTvoRX31/ph+Tq0ZMbu1t6xSR2jfYDQwIbPMuiCM4dE27W4q70QvixMVMIt+sduXsFLWbbE6jTFzMbw8uyzzks35Qp7mXEdHb5L59pk/wICQSe0W9yrrw7WKxXXMZ9n6tO6kP2dvqn66Jp4NEAlLi9HmAiWIpeLVe/3BblUGDEL0E2cRJoseu2gZlyBEKvkMZSyPQfjYhglJAyC3tK6zpSG70oc9GdV7aGWfJjH9wfvqlb/qh67/ggJvSfPRWwx9GolezKSqyRS7gsWy6T7vRk3Kw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR12MB5396.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(396003)(136003)(366004)(376002)(346002)(110136005)(54906003)(6506007)(8936002)(2906002)(316002)(7696005)(71200400001)(26005)(38100700002)(186003)(66946007)(122000001)(4326008)(66446008)(66476007)(52536014)(8676002)(64756008)(53546011)(66556008)(5660300002)(76116006)(83380400001)(55016002)(478600001)(33656002)(86362001)(9686003)(38070700004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tG5V85SmCSs3iQtp0xCpc6XNLaCpukXq0SDYdBKzWloY7pwXVCwF/4SJIh/p?= =?us-ascii?Q?jz0EUGv6ndIWZBuQR6WjC1DpHV9HUdNtQ8YMlQbrtjfvfLnaV7vumVG7O17e?= =?us-ascii?Q?pMuvYc6rhm2qRXyUX6fBQxG+hHHNKtG0CdHurt+r7Kv32GkvltZvuyBxlcen?= =?us-ascii?Q?oQUCYBPZES6YRQdc7K8U5kZgj6HMz9V9KAndmONyyvFNA6KDheIcC4CM7wiJ?= =?us-ascii?Q?ERziBav2w3e8kKXaStRCda6aASO6irTKqTTCnIJceyqvocV/C3v4Vcyb4900?= =?us-ascii?Q?Eg18F5WGOosuSY8GS7Bv4Ou5MGa1p2ZfSMoBBlB8IG+cr7Khy6/mWhGhRaJr?= =?us-ascii?Q?ll/wPvPV6e2+ZQrJtJWmd7Rhus1QEYjNweKe+ndC8Ae4gYuxUjMYZXxkBKbh?= =?us-ascii?Q?HtY2ijG8r4HtA8YHGb8sW6yz6fCfzDyuLTUaSf13IM0HZakKK9jWscY2Zkr2?= =?us-ascii?Q?jzcMYIysW+yhktzzb8MMlq8Vt19mO71sWgP70a8B9RW6Kaj5Fv2EXCbR9Gv5?= =?us-ascii?Q?T8ctcCOe23tv+jVaiKfECOXYLkJP0ANgZYNPjFSVqxazcp05u3KuotEQzIUl?= =?us-ascii?Q?5apB+Wgucn3gGXbnE9V47MgaA3GomKZOmuMWBP+UUD7I6fSlSb9U1FEM+V51?= =?us-ascii?Q?YCruKH2kiWlJQiKPlikabOwa0mJB94YF5N8NIuPZPENOWFT1fYPrUBlCct3r?= =?us-ascii?Q?qEZeLCiI/pX01sfa/mfXtQxEGpydTC/HpPORlPetZAXBcdr9j+95qRM121U7?= =?us-ascii?Q?Bd3HdNGph6EHVCOo2PNyen7icIz4v6JuTbA8UaZjP/vizhvDa2rSBKkyOaeB?= =?us-ascii?Q?G3Wl5+UcvepLKWtJxC33T0Dvpr39kTN5VH2mNQsGR9A5SlEd6X3kiatWUt0h?= =?us-ascii?Q?FAEODz2ESA4XYOTpD4yyNhYTrJ46rJSAEA31PQ6w9r0dgcIVH1AdwO42sRXP?= =?us-ascii?Q?IOgF8Y6tVoClwhZNYEBklY/evoEGy7k+5GLGhP1EGlI+JTUzycjF62KnhBS0?= =?us-ascii?Q?zsJ/W67DLcUla+MreS5SKgDFGPZxn3b6ioE9Xb4MnhgJiMs8JyIZLCFZjKjW?= =?us-ascii?Q?uJz2qPU+XfzMG0Q9usHxAvZvwd12PLTeLAz+zepSfmq6QZEcI68le10j7mqy?= =?us-ascii?Q?usKshpxIA0mgD3HrxxLwYxhL+Spg3oYwZochbmZdc3h4Z1kFuzyepOsXvZM5?= =?us-ascii?Q?XXrly8OYqb6Ld9+3JRr+UDq35oeAA5MLWa7fa5Pbrb5NooB3BlueIbDudaj6?= =?us-ascii?Q?q0OI/XYube/zfDhbxtLf0LZxU8qeHNQRVRG5wa4NrsVn1Ca0sYMpDE+NghmT?= =?us-ascii?Q?LYUllfqgmz1jcoKko/heHhRN?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5396.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: de286dc8-aedc-438b-aae0-08d94b602ee9 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2021 09:24:32.4510 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kQEr0FwWNMgEP/zxrKQix4SBz5AtIA97aoCUz1Km6Q2EbyJd87tn0eCByuytf81tWLkl5jOAF9dNDDoKdBQqLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5441 Subject: Re: [dpdk-dev] [EXT] [PATCH v8 15/16] test/crypto: add data-unit and wrapped vectors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Akhil Goyal > Sent: Saturday, July 17, 2021 4:06 AM > To: Shiri Kuzin ; dev@dpdk.org > Cc: Matan Azrad ; Suanming Mou > ; david.marchand@redhat.com > Subject: RE: [EXT] [PATCH v8 15/16] test/crypto: add data-unit and wrappe= d > vectors >=20 > > The AES-XTS algorithm supports using a wrapped key. > > In AES-XTS the data-unit defines the data block size to be > > encrypted\decrypted. > > > > Add AES-XTS vectors with a wrapped key. > > Add a variable stating whether the key is wrapped or not. > > Add the AES-XTS data-unit. > > > > Signed-off-by: Shiri Kuzin > > Acked-by: Matan Azrad > > --- > > app/test/test_cryptodev.h | 2 +- > > app/test/test_cryptodev_aes_test_vectors.h | 1340 ++++++++++++++++++++ > > app/test/test_cryptodev_blockcipher.c | 10 +- > > app/test/test_cryptodev_blockcipher.h | 2 + > > 4 files changed, 1352 insertions(+), 2 deletions(-) > > > > diff --git a/app/test/test_cryptodev.h b/app/test/test_cryptodev.h > > index 262e545ee6..f35dba6837 100644 > > --- a/app/test/test_cryptodev.h > > +++ b/app/test/test_cryptodev.h > > @@ -19,7 +19,7 @@ > > #define DEFAULT_NUM_XFORMS (2) > > #define NUM_MBUFS (8191) > > #define MBUF_CACHE_SIZE (256) > > -#define MBUF_DATAPAYLOAD_SIZE (2048 + > > DIGEST_BYTE_LENGTH_SHA512) > > +#define MBUF_DATAPAYLOAD_SIZE (4096 + > > DIGEST_BYTE_LENGTH_SHA512) >=20 > Any specific reason this size is increased. It may negatively impact on o= ther > platforms Which have lesser memory available. > We need a reason to change the existing MACROS which affect all drivers. The reason here is that mlx device can support up to 4K data payload size, = I assume even we haven't changed it, there will still be other vendor can = support more big value later. After the rebase today, please try the patches on other platforms in case e= verything is still good. >=20 > Please rebase, I will need to test these patches on other platforms to en= sure it is > not Broken.