RE: [PATCH 1/2] net/mlx5: support match with switch manager

[Suanming Mou <suanmingm@nvidia.com>]

Hi,

> -----Original Message-----
> From: Dariusz Sosnowski <dsosnowski@nvidia.com>
> Sent: Wednesday, June 5, 2024 4:34 PM
> To: Suanming Mou <suanmingm@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; Matan Azrad
> <matan@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> Subject: RE: [PATCH 1/2] net/mlx5: support match with switch manager
> 
> > -----Original Message-----
> > From: Suanming Mou <suanmingm@nvidia.com>
> > Sent: Friday, May 31, 2024 05:52
> > To: Dariusz Sosnowski <dsosnowski@nvidia.com>; Slava Ovsiienko
> > <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; Matan Azrad
> > <matan@nvidia.com>
> > Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> > Subject: [PATCH 1/2] net/mlx5: support match with switch manager
> >
> > Currently, in switch mode, mlx5 PMD only supports match with dedicate vport.
> 
> Typo: s/dedicate/dedicated/
OK.

> 
> > There is a usercase which user may want to offload the rules only to
> > match with all the pkt sent by application not from vport.
> 
> Typo: s/usercase/use case/
OK.

> 
> > Since the port_id info of pkt sent by application is switch manager,
> > and kernel driver has exposed the switch manager register value, this
> > commit adds the support of register matching for switch manager.
> 
> Let's expand pkt to packet and I think it would be better to use E-Switch Manager,
> instead of switch manager, since it's an already established name in the doca.
Good suggestion.

> 
> > @@ -84,6 +84,7 @@ New Features
> >  * **Updated NVIDIA mlx5 driver.**
> >
> >    * Added match with Tx queue.
> > +  * Added match with switch manager.
> 
> s/switch manager/E-Switch manager/
> 
> Could you also please expand in mlx5 docs what the feature allows to achieve and
> how to use it?
> 
> And I think that both patches in these series can be squashed into one. What do
> you think?

Agree.

> 
> Best regards,
> Dariusz Sosnowski