From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9131643A77; Mon, 5 Feb 2024 13:54:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1D2FD402BE; Mon, 5 Feb 2024 13:54:00 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2081.outbound.protection.outlook.com [40.107.220.81]) by mails.dpdk.org (Postfix) with ESMTP id EBB9A402A2 for ; Mon, 5 Feb 2024 13:53:58 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z51+RZmHGDOOS4IHxrAWNocTlVql2RQHwahLt6qe6+Bx/RqikZioWCj4T0kmxUc3tf73BV0LvLpxjuzCS+0u7BPiZYEweEhTeuy7QJCXo5ZsUQGnA3Yz9NVDoiHrwh6TNmf4CR+qcfDrIQVnEyOOalNrSiUhap/7DMDcr1U/etTbho3gBfBPVEtg4rok4CaUUnlEO9fNwsUGp7TSi773Y5hrqr1HCueGi/NZrhWB8sKafrwpv8uKMU/bnF+mcNoHx8ViHeVrE+7TcYl+eImXMloB5JZbDyLvGhCR/3Lt9/CtXOh61e8F0aKmF+bILG+4vvHSqlrqE4YsM0scFGwMDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w7hEa5w3uEsPzZngBBzYDJct74Y8YM14vmB87+sqHmw=; b=itGBrbFy/q1N1QUqAuqioGByG0ERZSr9HaHPB1eTPI9KKUEZFkO1cgBympZoU7KC6J/oxeIA6IyjmGt7uY2DMR1QFE1PwwQB7F2OVzKP5QUp/dcVXjhWe2WZwlUqhEXBOHhSMwNIXYF2ckbamSkyPVBXFohhN9NxL809UwL/aHiAgCk9NNNXP69gvTue70QWj8PJw4MwXmEAUNwPUeB9knjfH4Bveg1aCsHUiSFSCwPS2A19pHUK+/nDo4lPBxnI92/G8iDIQvT5IUYkaik6nTNRll5H7bVX++xZLy7afWIexHuNK7aQKTp/HEVqMXxae35PQCTHpPlUm/QijiblQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w7hEa5w3uEsPzZngBBzYDJct74Y8YM14vmB87+sqHmw=; b=fGXSHO3yNFYoVUG3iT+MjJ2ZQQvFLHHSHyUsXhMOGjnLiVTCYRSP8pPIVRf6zTpMIfKCFVf87g2repi/ze3z6n9kytphysn70KmYbxTNVHLIF6qT4OU2PqxTEpsr3enqEa10BL+LinSe4svgQrjJwcC6yHsaOkCQhAK9smnlrqoA4W6pndaJBxBlk4ZFQFjdgu4SI4uMsxAoM8jneQp2FQ04mUq/I68yjX2K5PIdpYGwaB7GBXHbON4BCmvAUYzMHn/qCc1v/Qu/Iaita1VIt1cfl5T/kVznsSPn2brd6Pt2wsC16m01q5TEn5zCeNzLi2yXwjm76dexTjEXLPDn1w== Received: from CO6PR12MB5396.namprd12.prod.outlook.com (2603:10b6:303:139::8) by CH2PR12MB4199.namprd12.prod.outlook.com (2603:10b6:610:a7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.24; Mon, 5 Feb 2024 12:53:55 +0000 Received: from CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::df56:6290:5b5a:e018]) by CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::df56:6290:5b5a:e018%7]) with mapi id 15.20.7270.016; Mon, 5 Feb 2024 12:53:54 +0000 From: Suanming Mou To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" CC: "dev@dpdk.org" , "ferruh.yigit@amd.com" , Ori Kam , Aman Singh , Yuying Zhang , Dariusz Sosnowski , Slava Ovsiienko , Matan Azrad , Andrew Rybchenko , "dev@dpdk.org" Subject: RE: [PATCH v6 1/3] ethdev: rename action modify field data structure Thread-Topic: [PATCH v6 1/3] ethdev: rename action modify field data structure Thread-Index: AQHaVXDTzfKj1kOrVU6QywO0hkyH57D7oIsAgAAGo3CAAA6WAIAAAP0w Date: Mon, 5 Feb 2024 12:53:54 +0000 Message-ID: References: <20231214031227.363911-1-suanmingm@nvidia.com> <3279240.44csPzL39Z@thomas> <2254754.iZASKD2KPV@thomas> In-Reply-To: <2254754.iZASKD2KPV@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR12MB5396:EE_|CH2PR12MB4199:EE_ x-ms-office365-filtering-correlation-id: afe17143-ef50-488d-6f8c-08dc264982d5 x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: p5W8AWSxAoqMHBh8QSd8OvRZ+yZgfw1+e8iplQ1kserA9KBpN+kWF9UU6pjoNfC/SY/nFDPekkmdjBxbIe3sgd/Aw7vcfJuCW0u6YOkLWQMd5WObQYzGwjtx8vOMUtuLzfCnBW230vWZPpasuCkal1LuE/gOrLEHVXWgL3QMdLXQZSOhDeKlRIMQ8FcZcK6Xcfc/XGKHSk2+XingcWk8fxVWqx88wx6YpnnoUZ/ODeYcnrD23JAXA0UVMXItD+jA3+rkP6+x6XvAK2ifkwukepIdlnEyttNlwqkGf2tkhOUXE4YqmeGZfWsIs8YrE/ixdMiQ8Q3E/b42tphg57+fMGVWAiFnpG9EnaWkUjS6yuDzztkgFMNt817en9Ws0Es8jPWZFUIGBb0BU2vhI4N+oCkCrXSr3TgWFyaV/FV8ex+aP4qECWUDj++pZk2Wj2SFWdiHOmGJCq6sCOlHoDzwIOZOmoE/9ulNx6tC37Qp+n9af9UBs7IwH6l6JZKTTqPOM9lhLywPcMH6F/Y+R+QBTiOB9WSB4hhzJMBxPVU3U9O8jd/j0NUlMP8QPqngL02+AXMixrYkk0cUn2aoDEhC/bXvr67K0DC/IOazSfG272khgeAZl4GG08o6n2wXAFCL x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR12MB5396.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(136003)(39860400002)(366004)(396003)(376002)(230922051799003)(64100799003)(186009)(451199024)(1800799012)(26005)(55016003)(316002)(38070700009)(54906003)(478600001)(64756008)(71200400001)(66556008)(6916009)(7696005)(6506007)(53546011)(122000001)(38100700002)(9686003)(66476007)(41300700001)(66946007)(66446008)(5660300002)(8936002)(33656002)(4326008)(86362001)(52536014)(8676002)(2906002)(76116006)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?k6otGR81vGa6yGSe0iVsVySQLn+l9jWP7fdjJWKr0yru4Pb7VNSwrRtcBTYP?= =?us-ascii?Q?DqMk5XLXzDKOwdFwAHrdHO3iBrjGgaYvOVRNE5uiD7ZiZ6p80DKDI1tr8s1p?= =?us-ascii?Q?fPy7UHPktEEL+cFMoKAygy4Gv2o5lQDzgm9mw9wEAgplS3NUuKO0K5GDxQO7?= =?us-ascii?Q?JZRF4So1a5TPtJGrUrDJ8dFBCPJFRf8sGGv5KwnqbP3LdT142cKPKuLjoFYT?= =?us-ascii?Q?JHJJqB5RO+9gIf6IP6GahbM9Ysvr7kgARXAnQ5++n1SGYH1NY1wQMSHyvqHM?= =?us-ascii?Q?bk4K8MrL53Isu6fvXe7jpGlJJ9oPQEmw8IrRNJCv7nuzAvzoOoPCADShfKqy?= =?us-ascii?Q?Bzjz8YOCa4eRrTTfpIbciEeQLT0qjvnDP9/row89yoAKoEIUaa808Cz5E54G?= =?us-ascii?Q?pEcJtWKKRRncPekGP9Sgy+mbnkTFINX94X+b6KypQ7cH6CtXK/t2TpF3LSho?= =?us-ascii?Q?ukdiM62Xwuuq5/+WpNCVet4u3PMwTLN5ODI/peG8IRdUHoNWUNCp8BNCDYBy?= =?us-ascii?Q?sM6ngGD8Gb2uPbEqyjPviqXQlh8DQanwimXs0cJSTqKQpQ8goKbu9wX5ihSF?= =?us-ascii?Q?2FP2VhmpDii9GNVHqU0uir7WP1mbjb3+cp6FKqHhDcFbuKrMhbSOlXixrGmH?= =?us-ascii?Q?oN2cSZn3WsUaa5shYWv8XOKaS4adzIbM0p+UFRounXhditts4Pi7M6i2SswN?= =?us-ascii?Q?t9wDPNpKbhDzAb9tITmbBZpnVi/mRDAqsnkC91fzfWDMxJjBxmmQA9q02n3s?= =?us-ascii?Q?VP2RCNOtMb4DoGPcfM/Mso9c7CcYRHhm47kIh137YZK8Nsi7PlBC0lsn4Z3l?= =?us-ascii?Q?vHdBAIirQ6XTma95RiwmJ9VUJF3dAuwWjA8UCRVoan9osYv4u9bhRcAc6KH5?= =?us-ascii?Q?PjvNgUUuoOOYhgr/8bBNDqqh5aPgrB1zlDraKKi5Xr7s4SUeHI2vCyb8Gez0?= =?us-ascii?Q?TgR++kthOtl5nbes4FPjKwWZQwd/eEP4/esGyFDZnlgBskmDaUnTB3Of9sa9?= =?us-ascii?Q?CMYsezY6tttKDai5qOGqR5ydXUxQnTpMfdggAYlrtk6yNRKlFfKMDqGaRX5W?= =?us-ascii?Q?aVkmOulq2wfRMqFTuY7clOE7d+9hyHMOSnLL8bbUJkYnU8xWNAb8EDfUFsEB?= =?us-ascii?Q?+5IfKKAVmRxV+RNUnVPCUQIPen1KTlVqMvxcP5I2YDNP72bRekifiJTBoFzi?= =?us-ascii?Q?uoFI1SEyxSOB6j88QOAIQMDopoN2i7G+0VonI1JTUfp6Kv93LXnG/76jiVwa?= =?us-ascii?Q?r5Ha4HZjAs8PiRT8OWlq2NPt6ZX3UAoIB7YJc+1vyFQyikzcuIau+PwjzvDo?= =?us-ascii?Q?GHWH073lS+a7NzrpXOm5jne+LVrv7anIL4YHDU712HBtEdSUmF1R1kVPzZg4?= =?us-ascii?Q?dqngI4BRke8VsEfoXWbGhmGvc66ipTRytPaQ0j9ccJqAJLehIMk+xmFh9zbd?= =?us-ascii?Q?xGcuiuUU8tdtNSFw77uEiMEgKIj+BxsbyyI2uDSDgxMP1LwDkOATdOYLDs7m?= =?us-ascii?Q?jEWgMit16oEj2vhBQYeLpIT3R8qXHAqj4cpLsPu2ALB9X97iLQjiKYsFJdm+?= =?us-ascii?Q?zcFBL0YzHKUZAoFbab4eFzKINuj7OZZcodVXSJ85?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5396.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: afe17143-ef50-488d-6f8c-08dc264982d5 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2024 12:53:54.8818 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yapdnFF4FopEnHC8k9Cr+wMAwZIFLWQLyjKkgeg4d5g7DB3SmDfP6DYf3+hGvRG9eVajI6AfHvuDhlBcAOmqpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4199 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, February 5, 2024 8:39 PM > To: Suanming Mou > Cc: dev@dpdk.org; ferruh.yigit@amd.com; Ori Kam ; Aman > Singh ; Yuying Zhang ; > Dariusz Sosnowski ; Slava Ovsiienko > ; Matan Azrad ; Andrew > Rybchenko ; dev@dpdk.org > Subject: Re: [PATCH v6 1/3] ethdev: rename action modify field data struc= ture >=20 > > > > --- a/lib/ethdev/rte_flow.h > > > > +++ b/lib/ethdev/rte_flow.h > > > > @@ -3894,6 +3894,7 @@ struct rte_flow_action_ethdev { > > > > > > > > /** > > > > * Field IDs for MODIFY_FIELD action. > > > > + * e.g. the packet field IDs used in > RTE_FLOW_ACTION_TYPE_MODIFY_FIELD. > > > > > > Better to give the full name in the first line, so no need to add a > > > second line of comment. > > > > So maybe " Field IDs for packet field, used by > RTE_FLOW_ACTION_TYPE_MODIFY_FIELD."? >=20 > Yes, or just > "Packet header field IDs, used by RTE_FLOW_ACTION_TYPE_MODIFY_FIELD." >=20 > > But when COMPARE item to be added. It will be " Field IDs for packet fi= eld, used > by RTE_FLOW_ACTION_TYPE_MODIFY_FIELD and > RTE_FLOW_ITEM_TYPE_COMPARE." And I assume that will still need a second > line since it is too long. >=20 > Yes no problem, I'm just trying to have something concise while being exp= licit and > easy to read. Got it, thanks. Will update. >=20 >=20