From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 432E5A0C49;
Tue, 20 Jul 2021 10:59:10 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 047814068F;
Tue, 20 Jul 2021 10:59:10 +0200 (CEST)
Received: from NAM11-DM6-obe.outbound.protection.outlook.com
(mail-dm6nam11on2086.outbound.protection.outlook.com [40.107.223.86])
by mails.dpdk.org (Postfix) with ESMTP id D9C714068B
for <dev@dpdk.org>; Tue, 20 Jul 2021 10:59:08 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=ni/rGpK2VWLF90QwiP4ooib8gfiYGtttOylqX0QeXLvxPTa/mmC0XZsWGOeFQUcRp0cirHO2oS66YQmp3BumaFoyW+k/8OdGl7euWTCICWDDYsZP5HZL4wcNPDtRst10gJoHJJWOiCV1wOomRAlFLsSUP3Q7iKCbr/HO/w3hChzH9IkpA4nGUa6r1vEBciP014oGNs+MpoIfyDPEI4jrkyJmf1IZ6oECXLPCshWcDYHQVF0CsH+U6vCKsZhqKHIpGWiMEv2O5tD9x/Zbm8G5suckeC1IwgkRW+F/MBRm2XfNixdAHxxq21JEoaP+2EDCDNCsTRU5qUEW1HOiYqR9fg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=j6AmS/jVhLuZfy2eCMX0dFwzuI/D9tTJkZMmM7oEGC4=;
b=LsihtVqYP1SM+lUyUiFMvYJJzeOngB84MowCchEdeHiy4qnbLVrupYyjRdZSr5v7vF0aVrN/s675vfH9obqLHMGD/L46xDHuPAXhaTEvcNnXbLI831VQDbpijCjNlHKjZBRUzW3Wn5ULi2DA2gCdrjcqRi62Lo08p6BTtdzMtxUs41w4F8jHwbcGgZY8ZeEJFbO3d2668aCe29Kki4z5juHrf+o5e5dNJCWhUsGQvAZUdcFg84J87Oq3siVzBIKKcu4Hdsd4Lpjjr/H/JDrqBgnZXevx97ZZwTDnwRAo3jGX5Hr/mSDDYbLS5ZN36TYnQaxm2UhVFgK+0qeY4L91Og==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
dkim=pass header.d=nvidia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
s=selector2;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=j6AmS/jVhLuZfy2eCMX0dFwzuI/D9tTJkZMmM7oEGC4=;
b=kOFPHxn7/Qz5Uh2EoKWlU5QZkOVlC9nmM+IbieQpx4cvLIsASQk7ix6JFf+vxsXFSt3qeDJO9PhxNKu8tLvwfA4HOzwU2bK6xS4Ta19brx10u3kIpFTf2gYU6Uck+Fl1fQEK8HP3NyXnELJO9yOnErWFIN5nke8S9dQ6mUkhEffg8hrYxyG6rrAbUwfZA5i35VXIV1W31iiaLYhxKZ8HtPHQ1utN/hYGauUStCDWCpqw8dqox5JTTH3SrH+f0rE9YrKUxRuCQG6qOFcjBBUghd9R+r9nVQeCK54vNPWm6jEcAbpTepG2OtkqIO/mKJxikE84lQWCBU9or3qXFsTCXA==
Received: from CO6PR12MB5396.namprd12.prod.outlook.com (2603:10b6:303:139::8)
by CO6PR12MB5489.namprd12.prod.outlook.com (2603:10b6:303:139::18)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.22; Tue, 20 Jul
2021 08:59:07 +0000
Received: from CO6PR12MB5396.namprd12.prod.outlook.com
([fe80::3dfc:6b6a:662:7f51]) by CO6PR12MB5396.namprd12.prod.outlook.com
([fe80::3dfc:6b6a:662:7f51%8]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021
08:59:07 +0000
From: Suanming Mou <suanmingm@nvidia.com>
To: Akhil Goyal <gakhil@marvell.com>, Shiri Kuzin <shirik@nvidia.com>,
"dev@dpdk.org" <dev@dpdk.org>
CC: Matan Azrad <matan@nvidia.com>, "david.marchand@redhat.com"
<david.marchand@redhat.com>
Thread-Topic: [EXT] [PATCH v8 03/16] crypto/mlx5: add session operations
Thread-Index: AQHXeZhehBeRlcOankWwytuyDSIWSqtGAamAgAWTnHA=
Date: Tue, 20 Jul 2021 08:59:06 +0000
Message-ID: <CO6PR12MB5396A60B497A071B745CB0C2C1E29@CO6PR12MB5396.namprd12.prod.outlook.com>
References: <20210715150817.51485-1-shirik@nvidia.com>
<20210715164126.54073-1-shirik@nvidia.com>
<20210715164126.54073-4-shirik@nvidia.com>
<CO6PR18MB44844DD48372464298F51DF4D8119@CO6PR18MB4484.namprd18.prod.outlook.com>
In-Reply-To: <CO6PR18MB44844DD48372464298F51DF4D8119@CO6PR18MB4484.namprd18.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: marvell.com; dkim=none (message not signed)
header.d=none;marvell.com; dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: c65cb613-7fa7-4033-2418-08d94b5ca1a9
x-ms-traffictypediagnostic: CO6PR12MB5489:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <CO6PR12MB548979D82163A380B635D319C1E29@CO6PR12MB5489.namprd12.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:3968;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 4n4OYFd5TR5pXzSbdhbyeSspVqcS+23pedyyRxilc+3ZRJII3GIqgRqiiW595zbHdXfi9nUb0kujz5U2r0lw8gPbi+kVqL1Jq9agZfnkpst79mPKyarkVrUBUKvJUHQwYUEw3yTa0VzqCP2xWVEz3HkKXNyjZ0Wz/JmdMOEFqqtlYsc53aPCjCdFQ1Fxof3OGbNUs1PQpwdEnbgZaDPwdOB74BfTGqcLwmJQdCuDzJwwcUcyE9x6kn5M49MbcV0YSsPGjnOznPZbbPuqcf56mf9Bppc0kS3OSWFSy3OE7DipnDw3j/ITcBkuGUmlXDuDPD6dXcvNxyefbxksMknvZ8Lk5/nQSHnofc4PEcTWkPT1K3jeSJbpyIeBNse6znz95ZjmqcpK1HcFxkxyAa5q50f4VWm3vOCGvD6jsX9T4Z25XPs6kEwRO4pvhJl9VR7DmF/xQeEB8+5uGM8iDlumpGAzuRHhfdkZDW4nmCLUzjmYu0v/CcVmgE3HJGPJGzC0zB4sZ215qRlzHBJgBVsm+eN+aH6qOgbiUH2DT0lACWnwXWki6dUwPcgQilM5pKIFxTDSyOrxByO6HhroprvBeIP0joIhPPmRX6MFOUdo54U5dGBFfJ43Xz6dJTn9bpdKjFdKCAf1XzW1W7I+OowcZu27wBRGOzO0zjt94SFycFLWSDSWMsOV2ejJVlTvQrvNVqCzXFhwGql8/4OHKbXTKw==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:CO6PR12MB5396.namprd12.prod.outlook.com; PTR:; CAT:NONE;
SFS:(4636009)(396003)(366004)(346002)(39860400002)(136003)(376002)(8676002)(71200400001)(4326008)(83380400001)(33656002)(66556008)(64756008)(66476007)(66946007)(8936002)(122000001)(5660300002)(76116006)(66446008)(478600001)(2906002)(6506007)(53546011)(7696005)(186003)(54906003)(316002)(110136005)(86362001)(55016002)(52536014)(9686003)(26005)(38100700002)(38070700004);
DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gp2QyAL0BNoc1+n+f0uF9YUqZV8OaNVbeQUXTj+zV/9UZFgFqdfEGtXyw1v2?=
=?us-ascii?Q?N0zz1GA5hcH8DzUY/sarClzxno+vIB3JVHKs9GTsFDn+hFJm+JHw4QDk9/wv?=
=?us-ascii?Q?lhjwWAYpmNP4pCfo5AQM1NNwsw8BXFX99Hg/6YwoG2TZfEth0DguJxt+NeDm?=
=?us-ascii?Q?SWpZouyCoBRCYYZ+ZU38Jgh0pPKNyH0wSZpSnG2lFr5LxAKEc6kfDyRJLj6h?=
=?us-ascii?Q?g/PTwrc8NN4J/dFnOl2Mj/xQubywPNKvWFNtKQj5SMTAgUxR5+m9Oabeq0TK?=
=?us-ascii?Q?nR7hSLyWkGmN0cxq6ziOvky6bI6zJlxWreJUIM2QIfSx6APuriJfajSgcXVT?=
=?us-ascii?Q?SSKPuDWWGLmXh4kv3NQk3PfZ0urqJth7W/uLUi8hyJSRA5q/Z1iBEHVGbXRW?=
=?us-ascii?Q?33NY2mHBV+57hAttl2e0hMoog9KAevOERr80e+wGk6Q7D6IKrx6Z8z+RDDyp?=
=?us-ascii?Q?W8/mhoK5/ByYtR8JQahWXLT6nMWhmm4b/+nI9j2pPQ5Q1t2CS1ImefoldkrN?=
=?us-ascii?Q?bWLhSAm4KlZL4EaXCc26Ivwb3o4kfLnZYNpFY39KOd+DhpeZRACow5jonKV5?=
=?us-ascii?Q?ZVUAbWjsu81sIm5tHDLmiDhx/IGihw2bg5+7IB9Ht7UhorcE60ET35yX3vi0?=
=?us-ascii?Q?DYDCruTGLkHqLFfHBDctAt5R4AOSB+sX6ZS6vA05uNot9GKgF3GCzBNBJgNT?=
=?us-ascii?Q?AJRFgBjvM60SNIGe1O3njiaP12ogrLFgeTQn3fja/fi227FetVwlMXWCg7Wr?=
=?us-ascii?Q?GQ3KrSuyceYVIG5/ZRptZWnbmjobna9I/QnY+Nlyc2+jB0FhUUjXHSOlO120?=
=?us-ascii?Q?0e3h/dvxJkuAPn+P4eyegzeE3C3Pc7w1YZ2B4Keu19RWZeehLUQnikhegk+t?=
=?us-ascii?Q?Ys7UMlAGrLMH1uv8NN2eR7r+xIJVs8dnGsfSv/JUY2iAYIZ+Pn3x1CbETCMo?=
=?us-ascii?Q?aNXhFqSCQUyU5aId+xmmmzl3T93eAxWjZtHmGEql4yilvkJs75Ol8h3P7Qop?=
=?us-ascii?Q?molH0UQ0xw6vmFteo5Gsx4dn9Qn1FP0JzjWTExecVXvra+IKGkgDEGdQLs9M?=
=?us-ascii?Q?DbOCgsbfbEwyjqop7yPoMcfzqC45/9sk3TJHwoaC58AsNcKEnVQ5PNHmV2gM?=
=?us-ascii?Q?PDdDR3GrWoYUffjgoEDepsOKGvV5DIjOlRQpjK4iXiSVoSRgVayruam5oF7C?=
=?us-ascii?Q?0RceczfgjpPtbMfKPsaIPoQ9cXTITnQcxy9w7vmkembdsXmVP9QjUq3/gcAK?=
=?us-ascii?Q?1yVdQa9LldPLEDAlZHr/zXRabV3CpmyRDF3kvJ5MiYbYfjeZ3u3rdM2QH+Er?=
=?us-ascii?Q?EX7ml46LaYZbn+3K97Isood8?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5396.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c65cb613-7fa7-4033-2418-08d94b5ca1a9
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2021 08:59:06.9961 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DlDDK1LEPx5WdJDd37YHLaLO2pIj7W4nzsiqcuCoYfWDtgAVfUZgVs9ejcgXuezxsVWPoMC0wCXE+DuU3kKzKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5489
Subject: Re: [dpdk-dev] [EXT] [PATCH v8 03/16] crypto/mlx5: add session
operations
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Saturday, July 17, 2021 3:40 AM
> To: Shiri Kuzin <shirik@nvidia.com>; dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Suanming Mou
> <suanmingm@nvidia.com>; david.marchand@redhat.com
> Subject: RE: [EXT] [PATCH v8 03/16] crypto/mlx5: add session operations
> > doc/guides/cryptodevs/mlx5.rst | 10 ++
> > drivers/crypto/mlx5/mlx5_crypto.c | 172 +++++++++++++++++++++++-
> > 3 files changed, 182 insertions(+), 5 deletions(-)
> >
> > static const struct rte_driver mlx5_drv =3D { @@ -39,6 +68,49 @@ stati=
c
> > const struct rte_driver mlx5_drv =3D {
> >
> > static struct cryptodev_driver mlx5_cryptodev_driver;
> >
> > +struct mlx5_crypto_session {
> > + uint32_t bs_bpt_eo_es;
> > + /*
> > + * bsf_size, bsf_p_type, encryption_order and encryption standard,
> > + * saved in big endian format.
> > + */
>=20
> Normally the comments are added before the variable. Or add /**< for post
> comment.
Yes, you are right for the "normal" case, I think the main reason here is t=
hat all the mlx related PMDs are putting the comment after the variable, so=
in fact put the comments after the variable is the normal case for mlx PMD=
s.
Let's try to keep it in normal case to not make other mlx PMD familiar deve=
lopers confusing.
>=20
> > + uint32_t bsp_res;
> > + /*
> > + * crypto_block_size_pointer and reserved 24 bits saved in big endian
> > + * format.
> > + */
> > + uint32_t iv_offset:16;
> > + /* Starting point for Initialisation Vector. */
> > + struct mlx5_crypto_dek *dek; /* Pointer to dek struct. */
> > + uint32_t dek_id; /* DEK ID */
> > +} __rte_packed;
> > +
> > --
> > 2.27.0