From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41C4041E19; Wed, 8 Mar 2023 04:04:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 365E340FAE; Wed, 8 Mar 2023 04:04:40 +0100 (CET) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2084.outbound.protection.outlook.com [40.107.101.84]) by mails.dpdk.org (Postfix) with ESMTP id 28FAC40E03; Wed, 8 Mar 2023 04:04:39 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OxGGr/01M0QaJbXrITzokOIZrkL08Hatg2ig6fXyHmsfey/4uVAD2Fxd9zzsT9xm3X9V4aJv19y/qwBSFFWwhhvltxIuXAoJEH0nZ5/W1b336Uy6mgsZmuSp4KvFTHDJuCU24kMqYwvbb1EWKeqn0TxTOb4ElU3syb+cNAjLwL3ffFvqTx5qT06DtDudEzo3EIzuLack7gmbNoFMfTo2+Kg1/10kA0pn/ijrUrtbxGgMeea/Oyyuj2R1/9p1246MidDrHX2gpttESDGLx4lbKe9KI0VKWiEJo3AWN5HE67vk6yTsWyUWZfvs4/qzrvFJN7w4YzGwDdj3a5NWtJ38xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EDHHraQvRPJats9iZrLh9h2yWDGSpWXG7xCZYm02WqU=; b=Oeicc/O6B2luMnXpid8wXzNFGfs7EVCU6LTfxJ2AHziy+apKwfwXhIUFrlP/7sSdFA9crljgwzJEdTMDebvGYrFxb/xgJdGW/fdyVkrwo0EfQoASKmcPrIjKhWiEd8IvG+JbCVrvCiieszLbMGQwJgmgToC2DvyCf3Di8n51AR+eQUPNxrwT8/sdLlCkaVilf2wgfyP4xcSTyGbd02aeFl4nu+LTzs3BCAQHJoKZQU2dWaKM4sxliGulThN2nTG3bQLb/g30JqtLSC/FIClWlfPTb5+dwyxgYEKat3TQosIWZ2tPNZwXl4Y9GcZ8A5qvlmoaErNVrLx4qpKR4vY8uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EDHHraQvRPJats9iZrLh9h2yWDGSpWXG7xCZYm02WqU=; b=H/GkeFhmYYI7n3kxIhdOknQsrNOgMRCcAfsnd4nAxyJ+Xu8BIxoV4rDzKSYtU3Vn8vMHGntI0FtXkRuspFUan5IB1Ftvphn3j1Um1+RD4jXE3MVtU07GJwQhQV371WFINM01erOAHxY4ZK/LksCpG45nqgT08CH1DEnTeGx2o3A3xKKPZYOvja6FXzIUveGfo2Q/iWVxSif7NAt+RqsW3ywgOhXg+eBSfXRe5/Uw+NfUNXAAWnsOCqWc9VhNtGGgWbaVP89eQ2jAduBO9pbONlvlGGeXfy0TDHyXYaA7OK4DKdvtDmzPetXiYUP9daNSmu79tdJDO1JC5A50A9dlMg== Received: from CO6PR12MB5396.namprd12.prod.outlook.com (2603:10b6:303:139::8) by SJ0PR12MB5487.namprd12.prod.outlook.com (2603:10b6:a03:301::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.17; Wed, 8 Mar 2023 03:04:37 +0000 Received: from CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::e1dc:525:d45b:94d3]) by CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::e1dc:525:d45b:94d3%8]) with mapi id 15.20.6156.029; Wed, 8 Mar 2023 03:04:37 +0000 From: Suanming Mou To: Dariusz Sosnowski , Matan Azrad , Slava Ovsiienko CC: "dev@dpdk.org" , "stable@dpdk.org" , Ori Kam Subject: RE: [PATCH 2/2] net/mlx5: fix isolated mode when repr matching is disabled Thread-Topic: [PATCH 2/2] net/mlx5: fix isolated mode when repr matching is disabled Thread-Index: AQHZSVZ0P/F7z5PjE0+3+cdJlgW02K7wQpaA Date: Wed, 8 Mar 2023 03:04:37 +0000 Message-ID: References: <20230225201810.10838-1-dsosnowski@nvidia.com> <20230225201810.10838-3-dsosnowski@nvidia.com> In-Reply-To: <20230225201810.10838-3-dsosnowski@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR12MB5396:EE_|SJ0PR12MB5487:EE_ x-ms-office365-filtering-correlation-id: 032debc4-9dda-4fc0-1a3c-08db1f81d9f4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 540D26jFVrpQMDN+kqYsZdtkQot4RVZn1fGEe3MxJIOA/9x5PfmAHelsrS94wOmVr49oheosSm9wkhuCK0vEXqCDhtcqqcH/xpdKYoLIU9eeuk20eNHt+4b6U+Ov8DqfL73NnxgftOKpgoWKXo4K/aOFSdjkTwkkvHgQPFygzl+FthxlOCOLDkZE7IPDF8x9UGd+BDOgfZMgX2uxvNuW+PW78UVgjGZPMDhDm2ucIztouuqUs9AOkrc+uMK+pIfC+/lJA0rW2i9hTDegM1jz0gdHj7PlO0V5QQhrk8MwphwHRV+d4G+s2jBnvWPkGdll5fGLik2Zl4i/HKnIZBFqLyB7lsZymRh3YzWGPR8Vv5OUWIqVKbGKZJK0yHNsjC61ND3S6r9KAc21jwekf+m50MUdY9kXLbF4atwmtvEDF1LHSAIZV0luuUqbuE9biQTuNX26tCErFGJvg3clWsG/++nog9C0y486D2zE848rJ3WtNVaS0osUNXpbUA+IzrDrRV+Au3aMpZuV5kJ7hD/8g3ALYQsvB6Ob5pFsi8J0XtaLcsSFMD4KWIudXfcroNAYstKVW+rNlvqv5p4LOQBB1wjifoLVK3C1ggph8YTb+czgBjlGXPuQOG46hEbRbJYI1h50yiv/BsvpTyQYRrvYAOl8aHbdqs7VfH0Y/4Mvs3XskPIXTRLeczbwTOJB1oe670qEAjEig/DImctibskjfQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR12MB5396.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(376002)(136003)(396003)(366004)(39860400002)(346002)(451199018)(2906002)(186003)(9686003)(38100700002)(26005)(38070700005)(122000001)(6506007)(53546011)(5660300002)(107886003)(8936002)(52536014)(41300700001)(110136005)(33656002)(86362001)(66556008)(8676002)(64756008)(66446008)(66476007)(66946007)(4326008)(76116006)(55016003)(450100002)(71200400001)(478600001)(316002)(7696005)(83380400001)(54906003)(6636002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ONjvu6reYBAdXBC2ZNNooizjfz42sLxiOmo00cWu78uB8w+YMqtiePBOEJDX?= =?us-ascii?Q?vUBPr7PaBAft272HzoZQagc3S+ahpzBJ83ohsCWaWDux397VD8DY6I1zN7rJ?= =?us-ascii?Q?ywtLSpsUTDyDQ4c++etqkZ7A8X8TEwGbJAVNtnbx/PxxPHQTUOldKvutBCss?= =?us-ascii?Q?stInO/drjjpB6SRDLX/eT8ohB5iFkhx8XOVT6oAIHH3WsdcZvnOVu+jQzLj9?= =?us-ascii?Q?cYlssjJesQ2ArhNIBDrW1lgHhp5B1UWZUe29HEEGhO+wC6QgKaBbqkxvwWqE?= =?us-ascii?Q?UMY0RZ1s27q3Bk/qHQZAvxm6rw4JVRp7aVf5Kn0Anb15XMf1Lz7fmCLlObUE?= =?us-ascii?Q?eBo3AMoYP8z13PHfxUB82WjM9qzM0F2D8Xz76D0SgydQISgeFi+TT4bfxGd7?= =?us-ascii?Q?veeaXO/uKi790s8sgrE1xntteDHMVYrI1DWjPiQOB96XWeEtKg1i912Pd63l?= =?us-ascii?Q?lb8j+MeAyxCRZCama7kpmjpyactUgtnAlQtiIehWekLJBKDXWvdb1kqugrRI?= =?us-ascii?Q?P/o7Xak/3RCv+fIxtb47dVcAwtPfHi/xySWsfQdpNG8lGGK6+GMMsyBKxa6w?= =?us-ascii?Q?O1XrnXebXl6lAcHNiiSLDFbDg+qDemP9IhzWFIIfXHF6142pXjzaMgOHk+K4?= =?us-ascii?Q?dz8ppdxrOS5jo23iKcwq9+2IcdiFotSZ2mHN6JH2l83tAF68lo3BjF9A1wzQ?= =?us-ascii?Q?9Q3WZYLOoQyVMugxdS5TYYKzGedlhkb8Yq4BzPaTkXs3RY5J2JdyKUy7SHv9?= =?us-ascii?Q?vbcRqg/JwNaaYC4DUFWH1wIwznvBuCuftuBxIhTOB5R+pUXyZr62LRpGTKgM?= =?us-ascii?Q?0HdUNc8QrZmwo3ViLOe7ojjPfdLFLr4Kr8o5svtBfUp8hGKw+vRTh0gv4iVC?= =?us-ascii?Q?/GDhym2qsmTz9Q0sokoRekKOToh9YVoyFvY0ImG8wB1PQFDUutCKiPSDNglU?= =?us-ascii?Q?rJoN7oPZzTTmvNAtPpnjW7rcyuObeE+pyYPbqsuHEnw8MV6QsfvblU2pcr4x?= =?us-ascii?Q?dRAxeh5LbSmgYSsA8TJ3Xlrt6FRrALktWDw9GfY4xPWAkqiFb6xxOdyMpXih?= =?us-ascii?Q?o3QB18g4dhG8BUm+yAK/KIEdi0P7ZPE5PwIQbt7//zO2NlTX12uSnlBAhJxX?= =?us-ascii?Q?1PaDH0Q6EwlRECXyS5+NDTQvUC/HAPJrDQLm8YkXPfjFtWDZr9rAXDXPemrv?= =?us-ascii?Q?T8A4PQpQTvCokhVfMeYv2MdWHSsNKE+dXVddkuHsXm4isVSA7M13tFtuOn0q?= =?us-ascii?Q?CfjyLP6cZwuvFDbQl7U7HJ9IajPdTETzbP5+6ATTn+VP/nwH4I6v6ZfiH7RJ?= =?us-ascii?Q?qcANFKw6PO2ZkCNnM6AFVOgvnFdSHo3Ip7y9rXF9fQz+zp6DMecWkhVqPTRn?= =?us-ascii?Q?aP/MJKmuUhnlFK/kyfBQqB0/DDRI8PP0GIwvjeGdL/DYFCZQo3312rhoPARD?= =?us-ascii?Q?MSNZuO45xDUPXAWwAmZA/lGTWdnzU1KhKqcoTODypfhEDLfcqOcQXCDpUB7o?= =?us-ascii?Q?Mv8hEwd1K3HtRMP3pd0EHQKkzfGOIlX0VHg7EqJhU7kzMlRqplx0lOIgkDzr?= =?us-ascii?Q?73tGISN7enuq1vkPKN8aVGCHezMUIPRKIMUtIYhx?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5396.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 032debc4-9dda-4fc0-1a3c-08db1f81d9f4 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2023 03:04:37.0640 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zjjTqE9s+26cfEbPvTdaFPX9nFrEzGEI1yhlewoxZIsPK/+eYnHT/w68opYmIrDN3rPrdkgjxGJ68vpJ4O3OmA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5487 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Dariusz Sosnowski > Sent: Sunday, February 26, 2023 4:18 AM > To: Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org; stable@dpdk.org; Ori Kam > Subject: [PATCH 2/2] net/mlx5: fix isolated mode when repr matching is di= sabled >=20 > In HW steering mode, when running on an E-Switch setup, > mlx5 PMD provides an ability to enable or disable representor matching (t= hrough > `repr_matching_en` device argument). > If representor matching is enabled, any ingress or egress flow rule, crea= ted on > any port representor will match traffic related to that specific port. > If it is disabled, flow rule created on one of the ports, will match traf= fic related > to all ports. >=20 > As a result, when representor matching is disabled, PMD cannot correctly = create > control flow rules for receiving default traffic according to port config= uration. > Since each port representor in the same switch domain, can have different= port > configuration and flow rules do not differentiate between ports, these fl= ow > rules cannot be correctly applied. > In that case, each port works in de facto isolated mode. >=20 > This patch makes sure that if representor matching is disabled, port is f= orced > into isolated mode. Disabling flow isolated is forbidden. >=20 > Fixes: 483181f7b6dd ("net/mlx5: support device control of representor > matching") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dariusz Sosnowski > Acked-by: Ori Kam Acked-by: Suanming Mou Thanks.