From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57D8942B25; Wed, 17 May 2023 09:51:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 25E2A4114A; Wed, 17 May 2023 09:51:56 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2051.outbound.protection.outlook.com [40.107.237.51]) by mails.dpdk.org (Postfix) with ESMTP id 9B7C24067B for ; Wed, 17 May 2023 09:51:54 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SZV0mbLWeaiCEGx8W/Qzt/Rko4spuRvsF/c3G4LyXym/9tFYVocBWIyBSM6r2LugsB1jjps8v73v6QFCmhtkfNRpLSTKoYq7s8xfCDXjoi02eoLhsf/gQga0xXC3aul7B3pzNnre7SizO6EMXb5YG6jNZUuBEnG6M636niu6LSRic2Tu4nuCZbThPlQtpEchqm7iLtg53+F6PMFVWdGuTwJKlDzvCEYmC9qa9vWya4SBhIYc9Yo7DRDUsM6O7h8EFGravf4rRigO8h3H1U/CVjactjfoyFA0OIVB33vDtBUviApI7DdKspjhDlpIcQwJeBxTfivO+0xyoycpK+rOMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2yx7fD3dtVfVSSBBOnQgeFjCEZ/+AF9GHcqjbey5gvo=; b=BBL3d0Uv27fZDOQuM5D/3PZo2OAX1+8ZgMlVwwTvrh5dbzsfPyKaKBDQ/sffqhKp/9jMV4KMN+iG1fJOmGSBH1x+C9x2oSqUG7F+BcZ8BtRn8Zx8IL6zYtDLnpy4813fGc9IYaDG3614vCDqUVYMi6Il29rD+GOHM6VHdGq8AomxXGqKpqON8bKDv/mEpEJ+MYG/way5OOVFUY6eAnfeebfpjitopt1vHHLAJOIT9NuHVmXiKUsqN7fHDn20DmPYdQW4T0btNscqgnWA+Po7UXcjrWvtZJ8qWVdqsDynmKfQGTAlLfM3BboVD73SNSlbwmRqQWUpQPYlt7Bg1L2/bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2yx7fD3dtVfVSSBBOnQgeFjCEZ/+AF9GHcqjbey5gvo=; b=qAn2Sz2T/c1OZJAP3ZfI7ysrIIjp3gJVYKPMe4Hfm+GPc8PcYB1pzFDnCOOFTS9IBjkf3P6fwzch3GUgVyZuKzBhdsJqVAfIiXLgyiNPTCZqTp2NiSQYZ9BaT93VzHEDMGPop6Iyl1Ztus9OFht6DUT91SsMjFC1AIokjGlubAK9Fnwq9AQvAyzCjmYNLMcQWmnVQr2r+NOBZTlKsY7q+5zXrgbxJcFbh9N5AWeVRrjDcKBgNyWRS/XASkQ40YnBUIfxFUYvArj3/pZ1QhvPyatH2U8A96lMh1/uB+3WAP91U2SiY4v1SJ9tbuelK6awkZuwXfNn3E3YxLnuChDZRA== Received: from CO6PR12MB5396.namprd12.prod.outlook.com (2603:10b6:303:139::8) by DS7PR12MB6287.namprd12.prod.outlook.com (2603:10b6:8:94::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.17; Wed, 17 May 2023 07:51:52 +0000 Received: from CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::1ff3:30ef:e7d1:8596]) by CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::1ff3:30ef:e7d1:8596%6]) with mapi id 15.20.6387.029; Wed, 17 May 2023 07:51:52 +0000 From: Suanming Mou To: Akhil Goyal , Matan Azrad CC: Raslan Darawsheh , Maayan Kashani , "dev@dpdk.org" , "NBU-Contact-Thomas Monjalon (EXTERNAL)" Subject: RE: [EXT] [RFC PATCH 1/5] crypto/mlx5: add AES-GCM capability Thread-Topic: [EXT] [RFC PATCH 1/5] crypto/mlx5: add AES-GCM capability Thread-Index: AQHZcdeOwDEUUa5Oyk21Cok2IGw/qq9eQQ2AgAAA0HCAAAINAIAAAEfA Date: Wed, 17 May 2023 07:51:52 +0000 Message-ID: References: <20230418092325.2578712-1-suanmingm@nvidia.com> <20230418092325.2578712-2-suanmingm@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR12MB5396:EE_|DS7PR12MB6287:EE_ x-ms-office365-filtering-correlation-id: e01b0a8c-49e3-40d1-17f0-08db56ab940b x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xwzOASMzhP0CYbbHQeYbuDMbhmWuj8T5t6lEaIf9fO47ug+hhlf6N6bjylb5BeEPFKyZN+MMBpWZFHm4br49hqtV/UZhYU+f0rztdfA2tnGJ+dDG2mC3veENTZdVY0nYnAJXsVuJYQbJ+uf+Jff83mkiiDGzX4DKQrygkgniP2teRfLNyzzi3jcVJXz8GWrAZT0806ukMGj6cJABZ1JqGV89Gtw7TfTORny1SVQ+XApbnBrVY8XeseVjPL5Ke9Z1lXZP6dLodhouLglt0YEaVUWIkQ3ygaGzO4YqCODnQqywssa92ngYXCBQhyesmaw8w3Ha1ft2E1whiDI+0854ZzY4qYDNzmMp3LmMGdMD/obCM+EULVZw8E5KF+7wv+RQIrLg2VPp7mvSr1i4vPyRka+9Fd6COoXqVxnH25Fdxm4NfUjt6m2m1MfY2e5ainplMv8uj499LexBoWnOF8qRypBHtFUwuGSDqdCI4krzdM6NgIbV58PpkxNqVPVocQvaH7LLLdal+4lmiIkVhVYevbssAlXxG40JT+KXLcBIWKcx5oeFlw5x54qz70pnwt+Ah0CgT8ZlXkPZkofptVb8COjHtxddP1Vb8fBMRGLfpNUPI/wX0yGXqkDmW0uDgSov x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR12MB5396.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(366004)(376002)(396003)(136003)(39860400002)(451199021)(122000001)(33656002)(41300700001)(8676002)(2906002)(8936002)(52536014)(5660300002)(6636002)(55016003)(86362001)(316002)(38070700005)(4326008)(38100700002)(64756008)(66446008)(66476007)(66556008)(66946007)(76116006)(83380400001)(53546011)(9686003)(6506007)(26005)(186003)(7696005)(478600001)(54906003)(110136005)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ChFN0DtfyqpQK78p9gkGiMpgjB8FsJundeX7SwSOtjgNZml10hlAPtV+Ru/6?= =?us-ascii?Q?zlY5yd4mYYo4KYSoO/qR5Mt1LCeBPr+lhxryIVBM+dxfgtu2ICiutN8aPVWk?= =?us-ascii?Q?rYrV/onPEJJLvCyB7pVh16usO0oUeLtoEdeeqdz8k5bg1CC0UfZrMjH+3TDP?= =?us-ascii?Q?PXMGendndWc+K6L3vdqivhLADdQBEOTNKx9nNTYfIZv7bx+5yIis66i/i+80?= =?us-ascii?Q?aVdleqEM8O6pujKNLMXdyEjErTHgagXzWgYd9v+WQQ476Ux7tgcwDbcTggaf?= =?us-ascii?Q?L3s6/Vgj45mqk9zShFiPR8KNeawAAzUW9p/Pvo832a8x7vcHgCfcwpYXptlc?= =?us-ascii?Q?86d4stcHsPJYi7PFesLsaW/RrvHuKVKKRtUxqWSPzR1MZT8ZOS/66zDAZtPw?= =?us-ascii?Q?tHiat6foCwozQuKgXTQnZQWZrHdIt4KdE8YeYAPXcRiGezH6ZyzBZxJx3TDw?= =?us-ascii?Q?brnJwz0GH3bQ5y5M59YP/cpClBw2KSf2vOhu1L0vo+OQ5x24XluD3g8AMvJo?= =?us-ascii?Q?Y1b5WmZ1s3v2YuBPxTHrhn4Qv/7EMyv7OCj8+XkJ+UPXK+2OTTIyxIlMrega?= =?us-ascii?Q?eaB7nCwI29wacxy+tX2/t+Q8o6X53tpWzpqsZUHfJxYqMcTG5vzlg0oXTr6c?= =?us-ascii?Q?ydbzz5wqr1ddLn8ki0TPwqcuri8i/YCjeunyRzvRo+WiyFN4KkpZH0VG2fwE?= =?us-ascii?Q?ATAFK2t9FAn57mXR2bHcdAwFmtW9HXXPzZwVpQGwK64HpUm39aLmYg20sfH7?= =?us-ascii?Q?ZGj5kYPABf/hcVJInDNcxN1hT5zSM+R4M0/lOPlcM5XgJuID94ixnGiQmhmr?= =?us-ascii?Q?JvWxBY+FIoK7vKvuqvF3iato2tVHHtfckGRACoVywCYFoG9S9o6M1Lt8qWZi?= =?us-ascii?Q?1dLfu+vrNorvKM1sS79XyaVk8wFKUidAaDUwGxoPPH8LZ4HH7evdP/xMLuF1?= =?us-ascii?Q?mDM51wOoz8RYxLQ6ONXqwUZUyB3rAI/sWvlT+mn3SMDsQydOjl0nleYsqKFQ?= =?us-ascii?Q?T5J7m+FEWfSTigosmLLoZOu3Y/8LIxEokbSGqiAbD9xtelxQnbjPKUGIrYqT?= =?us-ascii?Q?nF28aYHHs1j5MitXJa+TYLCX4oRqM5NwM7Mf9QXQyA1vurBVQgOSBbrm3fr9?= =?us-ascii?Q?+WFNGftHLzhNcL8vIpUSwf7ch7A0A47Gu6YV4QHoRo2yBx05LcLXTWVpnWaS?= =?us-ascii?Q?0fQ5ktExETfPDvgSl41fA+PHaR3e5Ce8Pa0QwL0viKf3PtLpvmmID5234wq4?= =?us-ascii?Q?qFalIIlXi3Mj+bwLvZPlK0BF6mo3Bl/0P6FvHbJPskJ1vHkDq7j8kJy/khG/?= =?us-ascii?Q?9yLFNGRiab8RgBdzBoOYG3qVmNfSTwI3C5t/NF11CpadxvIRejBl7qaC8I0e?= =?us-ascii?Q?Phc/dF/T+5/QXP0ibX0diPY3IVS1psL67kkwpwl9Xtkur03o/twmAqjHW0v0?= =?us-ascii?Q?xrDk8mkRG/sve2HqvkAPrm28puZ3t28rVq94mT/1/mfVixYgdAVo3fPMrV9y?= =?us-ascii?Q?imCpy6Cx98m5kO+pxWal6A7khc0NKOQQZkqgMsMJJwiRQPctPc+QpZgy8FQQ?= =?us-ascii?Q?2MB4Db4aJmouTJyIJEFiWg4vtLfn9tL5pXVb8r2q?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5396.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e01b0a8c-49e3-40d1-17f0-08db56ab940b X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2023 07:51:52.5657 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vcoUmxGwLijf85wLP5jpcFgslnUu1w0nf/RhLK/7Wpy213i1K1C1tKfBOpV6WWMHmJXpbuqajFuEc6WOennQig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6287 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Wednesday, May 17, 2023 3:47 PM > To: Suanming Mou ; Matan Azrad > > Cc: Raslan Darawsheh ; Maayan Kashani > ; dev@dpdk.org; NBU-Contact-Thomas Monjalon > (EXTERNAL) > Subject: RE: [EXT] [RFC PATCH 1/5] crypto/mlx5: add AES-GCM capability >=20 > > > Subject: RE: [EXT] [RFC PATCH 1/5] crypto/mlx5: add AES-GCM > > > capability > > > > > > > Subject: [EXT] [RFC PATCH 1/5] crypto/mlx5: add AES-GCM capability > > > > > > > > AES-GCM provides both authenticated encryption and the ability to > > > > check the integrity and authentication of additional authenticated > > > > data (AAD) that is sent in the clear. > > > > > > > > This commit adds the AES-GCM capability query and check. An new > > > > devarg "algo" is added to identify if the crypto PMD will be > > > > initialized as > > > > AES-GCM(algo=3D1) or AES-XTS(algo=3D0, default). > > > > > > Why do you need a devarg for identifying the algorithm? > > > Is it not sufficient to use enums rte_crypto_aead_algorithm and > > > rte_crypto_cipher_algorithm? > > > > > > Devargs are normally added for things which are specific to a > > > particular PMD > > And > > > which is not exposed via public APIs. > > > For identification of algo, it is not needed to use devargs. > > Due to current HW limitation, the NIC can only be initialized as GCM > > or XTS working mode during probe. It's not able to provide both in > > running time. That's the main reason for the devarg. > > Session configure with algo is too late. >=20 > Is it not possible to reconfigure the NIC when GCM is detected in session= create? That means in dev info, we need to put both XTS and GCM in the capability. = But the fact is if we reconfigure the NIC to GCM, XTS will not be supporte= d. If user wants to create both XTS and GCM session, one of them will fail.= =20 >=20