From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86E774331B; Mon, 13 Nov 2023 14:58:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 28137402AE; Mon, 13 Nov 2023 14:58:01 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2057.outbound.protection.outlook.com [40.107.220.57]) by mails.dpdk.org (Postfix) with ESMTP id 86D934021F; Mon, 13 Nov 2023 14:57:59 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aADFY7UkqIJCjzVWJ68cPnTcjRU4lnjetLk+IxmdBM9MRHuB5nU2GdbKgEMe0xGajmFggUcijw9IKOq8+bZfvKp2HahlEj0GNOWYUdkaPKyW9D6L5lspuALhXSdxlfzc1+x26lwCDeaKTlDc1oT+qNwsiOMRTztXjMrvp0sa9W06m/8dOzXaEcUFXGCiT9NDocUlDcCfS6FrRZrlTynI+Vwoy45Nq8x37WY/jTMNNPXOU7/uDoeuHoNHAqVXs3RN09yIDpw9RgV/8zz4S45E7EFaSSt07rN0nezoiqHkfcxa4LLxkh+KfkkM8jh66t4Vd7B22FgCHyjZ/eb6iKF6nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I3KIOvLFX+Uk68lcFjHgX9xKxQmGAs1cFjlHPmRn4TY=; b=gwcyo0Il8dUBeT/mR/CfrRA8Ltn7WXT/7ImB85zrniiS4jv7jkcr0JsasYIe7LFa/Mbl/LFX9RrwABE4ZmM1rqaYi5vSOidqcRgcTa3pxw0BeayDmIJbeX36HElHEMDbIkpYBNmH6IPtTYYkY7gKYWYpSsmJZn8xCKF2wijx48rmdxVQa3Hr7VD515S9WCIS3BuZHPXR2vlm59VHQpWNxyE1jExWFwUDMMLzvx0q+/7Fx3QeC4omv3c0wpevYX9IGx56DyGBJbatYilM/qCuOOIIt+IThesg8Z/UWBHpy1U6gCBN5ibkUXLd5skumBZVhbH1MJKcr6G+Da1k5z050Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I3KIOvLFX+Uk68lcFjHgX9xKxQmGAs1cFjlHPmRn4TY=; b=a7YOoenmVzRfIWPlyhOz07RggBoj6k9NhRVIr9i+KK2+WRBsP6LhjuNKTi7hWVQSSBU/7irumf4jM7RLqv8J9bebi8Zu7wgtWa9+I7xqi+wjnwuyXfnUV6QnCqzlIe6KFRzPsojhAwIU+X81XsR/V/K2SlOkreFIBCUAyCCFbPCoSygO3c8eMJx5iRnvAbbPn6JkhDGJ3sJZJ0BNr83RWK6hgTTz8AsVt0MwXH50+hLZL3uRw3TgcDQGcdyMz3cwW69PJirbJD9ehyhPBStU1Znn1gwHH7wkkbjF2T3hPo1f4HcPd90thveqKl2N04DdgEz/Clj6elij3CR5d67+Xg== Received: from CO6PR12MB5396.namprd12.prod.outlook.com (2603:10b6:303:139::8) by MN2PR12MB4536.namprd12.prod.outlook.com (2603:10b6:208:263::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.29; Mon, 13 Nov 2023 13:57:56 +0000 Received: from CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::62e9:ab3c:240b:ea17]) by CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::62e9:ab3c:240b:ea17%4]) with mapi id 15.20.6977.029; Mon, 13 Nov 2023 13:57:56 +0000 From: Suanming Mou To: Bing Zhao , Matan Azrad , Slava Ovsiienko , Raslan Darawsheh , Ori Kam CC: "dev@dpdk.org" , Dariusz Sosnowski , "stable@dpdk.org" Subject: RE: [PATCH] net/mlx5: fix the LACP redirection in Rx domain Thread-Topic: [PATCH] net/mlx5: fix the LACP redirection in Rx domain Thread-Index: AQHaFi7KeBbC9vJT40CL79oZJKvNV7B4OMzwgAAL0oCAAAF6wA== Date: Mon, 13 Nov 2023 13:57:56 +0000 Message-ID: References: <20231113124136.8071-1-bingz@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR12MB5396:EE_|MN2PR12MB4536:EE_ x-ms-office365-filtering-correlation-id: d69f6ab6-397b-41e8-e84e-08dbe45089af x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 04ERdFYz8qXaGL6ziEUCG81S/ARdplKKsHMto0cwOSdIrxxk2Xf80OH76hPV793o3n/RQW+mSvI699fGuj+2Qp4mgv3lPZJ/Q0JI7OZUHPSwdIYCgLmpnPxBCwPm6eswclOzwlhdyaT9jsOAlWAC7A0tVespfm1oi2C2EoUh0Hh0kB73nVikjmgJFiIqHoIWrRBO+whaWIzzSBe8cbSF7IXkATU6heFe+EFmBWTcfT5r6I+lNdSbvNZUT6uYEMWWh/as5M3QG/8Vy3m2XC6/Zzfn8ANQzM9/tx7Xazt/dr3qZ8heTH8uyBiCN8g/F90tvcvr74O/XOlGJVrGQ9lzPoLGmmoyj0zvqrC3lBVYwP+EBbNPDYgImSv+ZSABAKKENTr5nnHPpLyp+DeFfwLmjzwo59mM+jDaITba3G9pF7NzH/zIxoEfEthp6M7Gaot3Uf2edx4DIfEkcAaTqs9e66x1E5CDzPXyW+z4Wi5vATZm0ki4G1CXyfCzH9NYYOVYnFCfhR0LZYcNbtOCD54TAx5ltN9R8XlyrIr01OmTXS1KWo1GXLXTT1t6RNHZdJ1XgkmH1FXpwoad3x0qW5oIgZG9ek/lj3jAxKCXIn3mOBQgSiL2hewyIu0vzdLmvsFh x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR12MB5396.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(376002)(366004)(136003)(346002)(39860400002)(230922051799003)(64100799003)(451199024)(186009)(1800799009)(450100002)(8936002)(4326008)(8676002)(52536014)(316002)(66946007)(76116006)(66446008)(6636002)(66556008)(66476007)(64756008)(54906003)(110136005)(2906002)(33656002)(41300700001)(86362001)(5660300002)(83380400001)(55016003)(38070700009)(122000001)(26005)(38100700002)(478600001)(71200400001)(9686003)(53546011)(6506007)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?h40P3BOPC3ome2ntyTPFQgpZ2uuEPHcNZxdYlhr6PmGItmlxpRKZHC5EKKQm?= =?us-ascii?Q?z8iMR4zubz3yXerzHJZiI/3P7nXpvnXZ4gMYjcRitJS4byu96bWJBrmGlf0Q?= =?us-ascii?Q?gZVu6P9Tq2n8NLq/YyD6j+OVrmbZYjMfRGj/lanLXu9Sz6nfYtLarlj0cYH1?= =?us-ascii?Q?9DqVpnIFAHKfzFmuP/nxzp3Gc19TT0blTKdBn4/EC9jEr6z+LDAgVBvWBY7t?= =?us-ascii?Q?8vsjkRCNLe1AKlFfXsUXwJUgdRQbLa2/6WgpbRHlF2Nf+Op0vLCv2HpQY/Dn?= =?us-ascii?Q?SejDIxjD02cV//+Fu0rxBr0osuNPv2/DWHA4UZaQlAsnC1QObO3yYTbQ+WUv?= =?us-ascii?Q?ldDNwBbUYw8VbJafERHF7psREImET1Yms7VINCCi/uz2d7QmlnVRzhbzpXto?= =?us-ascii?Q?pSqJbmUekYaXpmrOa5Q2MX/K5pnLId/H7lnrO64S2IsL/XHmXLatqyAz7yI/?= =?us-ascii?Q?AFIGMIbxDT6wrqvP15s73riQltJSInz1vyCGw/a4NcL+0zvIZPs2qqEG2p28?= =?us-ascii?Q?BuMFGtI0CHoaDNUhixmm8Pei/P4BF4pkjYhPMiL8G47mME4bGiRLyJ+zyjSS?= =?us-ascii?Q?Y3oLg+Lg9yimllpiTk1/ga4FWYSUXrKNP5h2gkibobffR3qTdeHsJA7rRraO?= =?us-ascii?Q?LvcyfISxNyKxxc66qN7taASfiWEiIr2PMxvtZob4J93lUjGECWonptbNx25f?= =?us-ascii?Q?EwKOVGVKzaFkssxF6IkpvfO06km7H2kEJTRZd1lxwnOq7GqgNRWvlLNwqCCe?= =?us-ascii?Q?GCgRcJtQP+UDbTQmvFXZU30wNEClvLoe2A4NWNfuLRpo100qPqahSTO6ltmX?= =?us-ascii?Q?81ZXrgPQu3d9yT1k+037LyYy/UPeZthLbx9EoUOyPQpmwTixym4y0673Ci3I?= =?us-ascii?Q?7VwfjeHqGKIeqGTlCaCCLChv3yc0JrJL29whLTNSmmqpWM0LwyB+feFkYOpM?= =?us-ascii?Q?/HVMxSl7tNn+oiHEcfSuZyfzGPypdR/BTFp7IbNpMV4ig9Bo0TOeuQe8cdap?= =?us-ascii?Q?VN4MNNWKWv/sOC73nMC4IBDHy1QCiKeJ78fszMKLBHw71LytOYo2FRh+cG7w?= =?us-ascii?Q?dgc1KtP/yEOQpNKJtBbn4pWu0+P4DSFifMhBeUtUeIXObtxc9EeKL2XNZNe9?= =?us-ascii?Q?VXZgKLbqHgir0ebhzl+qqKvX8WbiemCrwbvXdCXihs4yAX+6G68dBzLVvdjd?= =?us-ascii?Q?1UOu/i6w3+WqnsGUndm1J2Tbh2Dx1LbuESAlRsU61NtcSn4I6JFiQwde2HNC?= =?us-ascii?Q?RHZfyclg+CIWCf91JdrpFqczIAXFUFffj6LVV4bmMGq0I+tfcfRhJouc2Top?= =?us-ascii?Q?vFu5119nJ7FrEFOeEwUQXGEWnuEdbeladlwePVKHnSfeur0eESDk1uB9LR/P?= =?us-ascii?Q?TATnVn1HkfaSNvKTrvay7gNBJLDEVjJI9P0syX1vUHnDxYW1IfGDM2MAR/ci?= =?us-ascii?Q?eU9Gx67WclKNGrNsmW1CxLw/hIWzGNWjfQFmfh8ETem09iGO7InVZc6jl2PH?= =?us-ascii?Q?qVsA1ZNzI1TMZcsFfMhvNuryruDsnKVYL6HJU1A5LBU6G7XqROTFS920sMgT?= =?us-ascii?Q?zVJEDJrk4BymBUmscScRflcvw12jauO/vW1Qz8Mr?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5396.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d69f6ab6-397b-41e8-e84e-08dbe45089af X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2023 13:57:56.1290 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: diOgTPS70AQ0+0o4WKq0UjdKFNOsClB1QA9B7Jc0qDpXrd1qjPIevjWhPWSR42lA7/wfxztIA6K3neWMKO5vUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4536 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Bing Zhao > Sent: Monday, November 13, 2023 9:51 PM > To: Suanming Mou ; Matan Azrad > ; Slava Ovsiienko ; Raslan > Darawsheh ; Ori Kam > Cc: dev@dpdk.org; Dariusz Sosnowski ; > stable@dpdk.org > Subject: RE: [PATCH] net/mlx5: fix the LACP redirection in Rx domain >=20 > Hi Suanming, >=20 > My answers are inline. >=20 > > -----Original Message----- > > From: Suanming Mou > > Sent: Monday, November 13, 2023 9:14 PM > > To: Bing Zhao ; Matan Azrad ; > > Slava Ovsiienko ; Raslan Darawsheh > > ; Ori Kam > > Cc: dev@dpdk.org; Dariusz Sosnowski ; > > stable@dpdk.org > > Subject: RE: [PATCH] net/mlx5: fix the LACP redirection in Rx domain > > > > Hi, > > > > One small comment, v2 is needed. > > > > > -----Original Message----- > > > From: Bing Zhao > > > Sent: Monday, November 13, 2023 8:42 PM > > > To: Matan Azrad ; Slava Ovsiienko > > > ; Raslan Darawsheh ; > > > Suanming Mou ; Ori Kam > > > Cc: dev@dpdk.org; Dariusz Sosnowski ; > > > stable@dpdk.org > > > Subject: [PATCH] net/mlx5: fix the LACP redirection in Rx domain > > > > > > When the "lacp_by_user" is not set from the application in bond > > > mode, the LACP traffic should be handled by the kernel driver by defa= ult. > > > > > > This commit adds the missing support in the template API when > > "dv_flow_en=3D2". > > > The behavior will be the same as that in the DV mode with > > > "dv_flow_en=3D1". The LACP packets will be redirected to the kernel > > > when starting the steering in the NIC Rx domain. > > > > > > With this commit, the DEFAULT_MISS action usage is refactored a bit. > > > In the HWS, one unique action can be created with supported bits set > > > in the > > "flag" > > > per port. The *ROOT_FDB and *HWS_FDB flag bits will only be set when > > > the port is in switchdev mode and working as the E-Switch manager > > > proxy port. The SF/VF and all other representors won't have the FDB > > > flag bits when creating the DEFAULT_MISS action. > > > > > > Fixes: 9fa7c1cddb85 ("net/mlx5: create control flow rules with HWS") > > > Cc: dsosnowski@nvidia.com > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Bing Zhao > > > --- > > > drivers/net/mlx5/linux/mlx5_os.c | 8 +- > > > drivers/net/mlx5/mlx5.h | 1 + > > > drivers/net/mlx5/mlx5_flow.h | 1 + > > > drivers/net/mlx5/mlx5_flow_hw.c | 249 > > +++++++++++++++++++++++++++++-- > > > drivers/net/mlx5/mlx5_trigger.c | 3 + > > > 5 files changed, 249 insertions(+), 13 deletions(-) > > > > > > diff --git a/drivers/net/mlx5/linux/mlx5_os.c > > > b/drivers/net/mlx5/linux/mlx5_os.c > > > > [snip] > > > > > @@ -8327,6 +8503,10 @@ flow_hw_create_ctrl_tables(struct rte_eth_dev > > > *dev, struct rte_flow_error *error > > > ret =3D rte_flow_error_set(error, EINVAL, > > > > > > RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, > > > "Failed to create control tables."); > > > + if (priv->hw_tx_meta_cpy_tbl) { > > > > I assume it should be hw_lacp_rx_tbl here. Can you please send v2 for = that? > > And LGTM for left code. It's OK to add my ack for v2. > > Acked-by: Suanming Mou >=20 > Since it is a "goto" label, when arriving here from the LACP error branch= , the > previous tables were created successfully. > The LACP table is the last one from the code and it will never be NULL wh= en > reaching here. What should be rollbaked is the previous one. >=20 > This is some disadvantage of using goto in the code, not quite straightfo= rward. OK, got it. Then no need for v2. Thanks. >=20 > > > > > > > + flow_hw_table_destroy(dev, priv->hw_tx_meta_cpy_tbl, > > NULL); > > > + priv->hw_tx_meta_cpy_tbl =3D NULL; > > > + } > > > > [snip] > > > > > 2.34.1 >=20 > BR. Bing