From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0CBB945459; Fri, 14 Jun 2024 09:15:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 005AD402F0; Fri, 14 Jun 2024 09:15:23 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2087.outbound.protection.outlook.com [40.107.244.87]) by mails.dpdk.org (Postfix) with ESMTP id 05AC9402DD for ; Fri, 14 Jun 2024 09:15:21 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nYyMuIfFw2xK8lOhSh3sk6yspF3PsdIIu6oH8+ormd3pIehRCjWJkP67cKwzVWbuH0j8ccvySWmzCKV52nqTi1xYRQKPRY6CMLLvpY96cmNzOwAhyYdojfLkEzMc1H14bKzh1T+g69yKXu4oc5QaRtvNuK05bRKSNmesX1WC6Kyqd1IwLY/ROtCWgcDbNy3rufFe7qELw/W4tA4izPSAi4/078Qgn6mYadSYiMlPU5C4+88LlRDG03Wg9a9NNk6e6dhOKrWr+rnGyj2X0Iiv6d+feW5xZTkcVSD8ZobGN1VprIDZ2A59RqPbLWWKulOqD2tc+vYoWhRwXxctM70p5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sZXfCdIeFWvVQ2UJ8PeidnrUXGABRzoCy3gps2X4VkE=; b=ZUk8p06yKOXCVylbGy91cYCh9lSWNv3pWwRboUR2dqIHXSJA9MyJdxzUf0UUyhwZrYy4pwjAgqsf1wvV+JiES3+nIt2ylGNkMCgJwj8UTvZyBGZVJRY8cmDq23uB9w/+jrubZKa7H0qt4k8y+KA3dHf5Y9+ikNrSxvi7PZtvE568MweD575Bo8XCGR9QV699wzof3IWoYkcqYEnkbRnaYt3ZK3O9TJUbjsoZNs0GLlmQlehFgAsDpLmpI595OF1ZbBFiqC9MoXWoNAG0ljB7rJPS+5nbQkGy31dpOaA8BhrAmvdAK8k3fATkJtic7E1KDaT6DJUBI1dj0EKcG0re4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sZXfCdIeFWvVQ2UJ8PeidnrUXGABRzoCy3gps2X4VkE=; b=MmVTYcWXj0qRLizrLGsZNyZHqWysxKhhFRY3patZa48qWWG7/KcJqFOr/d2r9JJQcro2V0jTSz2m5oqVpmeexRt0pNzNzd5L5BbS0W87+/JJ5zDEqxCIsLsXRcDNO3f4qsRIiCE+3c0ppOApqIUuscHiYFTsIFqvExGxMJ7iC9kajOWxkzB8fBQ/KxrM6R4eLz3qAs5xGGkV45q66IBWZ1t0fhlJI+sCJFc3brhvZzUHl3/XjRDcQ1yP1RyHreS6rULyacLFGzJHiwA7pDU9MhKTD2Xb8NVDInd+vXRtKSvGJbOrvJNimOC2ZRfnIzeHHKyDcX2xDiiprvpF+pKhWw== Received: from CO6PR12MB5396.namprd12.prod.outlook.com (2603:10b6:303:139::8) by LV8PR12MB9084.namprd12.prod.outlook.com (2603:10b6:408:18e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.21; Fri, 14 Jun 2024 07:15:16 +0000 Received: from CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::25bf:da1b:77ac:ed7c]) by CO6PR12MB5396.namprd12.prod.outlook.com ([fe80::25bf:da1b:77ac:ed7c%7]) with mapi id 15.20.7633.037; Fri, 14 Jun 2024 07:15:16 +0000 From: Suanming Mou To: Akhil Goyal , Matan Azrad CC: "dev@dpdk.org" Subject: RE: [EXTERNAL] [PATCH v2 1/2] crypto/mlx5: optimize AES-GCM IPsec operation Thread-Topic: [EXTERNAL] [PATCH v2 1/2] crypto/mlx5: optimize AES-GCM IPsec operation Thread-Index: AQHavfIs3Mx4p6I/E0ifQ+WKXCfqjbHG0hSAgAADKaA= Date: Fri, 14 Jun 2024 07:15:16 +0000 Message-ID: References: <20240530072413.1602343-1-suanmingm@nvidia.com> <20240614003031.2006131-1-suanmingm@nvidia.com> <20240614003031.2006131-2-suanmingm@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR12MB5396:EE_|LV8PR12MB9084:EE_ x-ms-office365-filtering-correlation-id: 51979427-27df-4bf2-b7b8-08dc8c41bd9c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230035|376009|1800799019|366011|38070700013; x-microsoft-antispam-message-info: =?us-ascii?Q?dwK+0QB41DyO0VMLPORn7ye79yJRCMmc1dLw3o+qiUU/ThlVgLT2MHdx+p8J?= =?us-ascii?Q?ps+UoVMscOERz4lxwyYV9969v23ecJf05jOCJM0rHycuE+Kbs9rZFlUZGuoO?= =?us-ascii?Q?KEjaqEOk7/YtGqBZJNDARjhVBvnZUgNSW63rOKrco6koWyhOtNsn7tW1lSg2?= =?us-ascii?Q?kJE50EZ8lKJAK0BMlIkYWESyhup5JhJdBNEyy5r79FYUyxu/L95woYfoXJ6o?= =?us-ascii?Q?ISXuSL5roINz+6CdG3mtaW5BBAupPhUWh0OPh7uu5xBMx+5tmIePi9Q6PIBO?= =?us-ascii?Q?8hUxLaWobKJbKKugr0gpFBydKysk8JRXEwWTdW5SYtxNoqjMmlWD1jIHiTFH?= =?us-ascii?Q?aZkPyKldu64z8ww9Oc8c6dGsk23ksEpnSqdl0LzUWun02cPPV57T8P15U1C8?= =?us-ascii?Q?B/7CaJ+XkB157QaRqpsg/y7ZqQa4LGDFe6WsIzzhwW4SG5KpOMg4e22wyF9M?= =?us-ascii?Q?ckNiGEOEd9BjiromZ+zAOVRQfCUTeJhJQqr303BDWVmAovuNfodQes9UnxL4?= =?us-ascii?Q?VMqf+SP1Wta8ITQd6Wv2dybU8g8kIkjux9R3wIKo9H+poA+yAP5T93iKhNBb?= =?us-ascii?Q?PMjj5rJSvUNEPEbsHUXe0GdLnhz2cQzVliFWR4OKhnlysccVv+DpzJ7XEKu1?= =?us-ascii?Q?mdqN6CIhCj3+qaGUxMaUWxPLSmEpDgmOyOSJef1yCtlFGpw4MaP37ikZEG3P?= =?us-ascii?Q?PA598YJKC5mKr94AOM80unpzr269YC1Xw6C+zCXVCIHaXq6ctKEC/vT++rFI?= =?us-ascii?Q?x6QEron/GldT6bxqWjLkQ1A9+3jv2c9GM6cx/uvQlvuUeRTrakT/OZ4IxDgZ?= =?us-ascii?Q?saIw4lA3O4MyIeIfWTk8pptCMT8a7SQNaUr5AKFXFD+3qjVDjrsixZg1svip?= =?us-ascii?Q?ClvgSP0J6JieSB5m+N9H886bZFLZ/5V4gCGXUWh2iWsvzEXfAWLUed7nr4jL?= =?us-ascii?Q?1SE4m8IfucQrH+6j6KNV6CLtbdJig8tJMQvCdmibiItasqDHimUXbFQFOQAk?= =?us-ascii?Q?CLU5a8T/1i23NY29eOPQZ9Cf+KBapKeFD4tVQJZbO/pGmEPeoEJLvu7Tkr5p?= =?us-ascii?Q?extoTMCKS1U1RQT0FP3B1rvk7sK+GTMU7KFGJcVdBC/mK6G/WRQ9tYjXfwaE?= =?us-ascii?Q?MUSDTgMRhyqMU0IRipnSh+yNXOzTbC5mpjGV1cn46LVekPWLjX6yQX81qbLr?= =?us-ascii?Q?w3tGk0CMxN1L6ZqU/vf7W5kkbCwOA4GxqnjmMH+b5bZpBoSoNRINTx5OzLIT?= =?us-ascii?Q?NAJorAW3rxwboaJ/dBfuzG5bdeq3+qzc9JL/22/o8BCviqXfP2u5fVMel6Pj?= =?us-ascii?Q?cYpTftNumq1QfPzcpC8kODBvdXRbUhqXyMQ/6YTnfiflHMQ6MYMW4d41ROx3?= =?us-ascii?Q?JOvtw+U=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR12MB5396.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230035)(376009)(1800799019)(366011)(38070700013); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cbYYqHn3ZDJSe8wtbM2P4OCBICWrkUV+/gQhxFgq30fWOlEM6QKEiOQCoqeq?= =?us-ascii?Q?VXnN1i3biu2y1rDTP4rNFcT0/1QIPEvJSGYQ2DMGGaN5ZoCBwB6lBABSMx3a?= =?us-ascii?Q?BalwTfCQoRoZZ6VL2BcTH19BrBlELgQ0sl4Drha3vpzgP5OYz/iQy4TYilKk?= =?us-ascii?Q?sUNd4l+tfzFk8LbOnDyMoa9kujHNHSVC70QjIVzh1gUB6swqtJgdGeTEZAR2?= =?us-ascii?Q?11tgiZ/YwNyjmrxvnFrtSz5IwLeyQRPJpxzASkmctbWGe8luFt8bh6bEdS48?= =?us-ascii?Q?4Z3I/NS6RwdiDb51NP1H/B9vDgLBc7JYOtWspXwsjzeRu3Zoi/2+3bny0ufG?= =?us-ascii?Q?pJmXK+BaLYzc/N0JQu26yfLAenJ0eZh24AvlP4qrSpaceGRXUkXZzf3aTCzZ?= =?us-ascii?Q?RZ02feAVByo+D4ykQ9ll25za+XuIVyF8r01CjtlO5vM+IcV4F3/xkzD/Z0L5?= =?us-ascii?Q?i9NMqiz0vVPdpJrVgEk39/su0vxL70UAYrQzNDDv3aN1ljADmrFduT9U4qk2?= =?us-ascii?Q?/VhRRkvYEnOiNQEpwElRaWUMVi6giq+0ijiIe9qh7DMdHkByVWN3R3S/TgNG?= =?us-ascii?Q?j5dQ6WuK3nMlsZ0SYrWVqBsmOSMZY3ntP2xrO9Rx8aINt60baTKot9qwynDL?= =?us-ascii?Q?HCjpKjtKZJHi0Sju152x4lQ3mWNXAMTDZEU4/HaYDKMhE2KYVn5AuZ0j1Ffo?= =?us-ascii?Q?gsZocfX+RaF9Czl7C7WxPk3VFcQ0aiw9PsjFj50uO4XLPv0kO04LCPKEaQZr?= =?us-ascii?Q?2yu5qh7C+7AwNz7/OA2Fen6+scDR9VHBFF1Hio2jWZoARMDBZNvOW2PUIHak?= =?us-ascii?Q?urjoW4bLXiZ2OF9ao9fQvrQ4GZtlfQBtZ3ZSvc0AKVc3VRRahPle3ravixg+?= =?us-ascii?Q?/zy/5vmyff59D2RUg0nQUb/RpvP56ee2c35YWDW4ysE63aJTzsePic9+E9wZ?= =?us-ascii?Q?25aWiJKqw84LjTXUliuSkVlAMfp1psbJsq9m+nI0wZ71Clwv7dthBf62NnBD?= =?us-ascii?Q?XPtDLJY1yqYpD25w7EEuKJU9eJogQT2MpcFign6acaJTrLwmHcH+L+Kyrs5q?= =?us-ascii?Q?AlOaUt/8CJyTCDHj9AqtVEg8oQWHzxXH0ydQwWkOTQcRHpcA/biwNunCTXUn?= =?us-ascii?Q?GD+WssN7+VG2AQgAyD9G4DRj28ElT9WtoyEY/OxX52HcWpnb9Z+stlbRJEVL?= =?us-ascii?Q?XY/Z5M/ogVycslFPwcDH6jnDYEjs2l1cI1djmlwGIpm6Taw2f43KfS1kKRm6?= =?us-ascii?Q?qfIyyapIaOVs8pF5FM70KhGLhdcmgnc31rv56EN+liuQAwe+u1suRcUWPmul?= =?us-ascii?Q?Xsn6IlY3Gylsv16qiMwSOOufWPo5tQC8zORddEXSNwlgps3sBoRTtGZ0eh2v?= =?us-ascii?Q?EqhTT5BoUk7JzNqd/ijc+/ulcoJslaDElEpaqaggcaXQ8NEPAO+arlmYXASX?= =?us-ascii?Q?kOVC+4eHQ2WPRIjgHZKK14Bc2EiasGelN1bvA/yE9my4aXRrm1Qo61oP7CTf?= =?us-ascii?Q?cYGR1c13ykjAg4LrsLPDEzuEFkCg6ZY8u7BCFqOhHVF5Wfbu5vK/wZRddqzi?= =?us-ascii?Q?WoL0NLWFqoFXNJIb6iKXRNvuF01ED7VYCiBLOHM1?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5396.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51979427-27df-4bf2-b7b8-08dc8c41bd9c X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jun 2024 07:15:16.1201 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JJZeCqWIRHtslEpR0CaG/K4K5wUgSzO67KtTHOmcsWGheGseLh1RT+W9+yWoxwPEO2TwmIoYyWCoPg5/NLAgLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9084 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Akhil, > -----Original Message----- > From: Akhil Goyal > Sent: Friday, June 14, 2024 2:49 PM > To: Suanming Mou ; Matan Azrad > > Cc: dev@dpdk.org > Subject: RE: [EXTERNAL] [PATCH v2 1/2] crypto/mlx5: optimize AES-GCM IPse= c > operation >=20 > > To optimize AES-GCM IPsec operation within crypto/mlx5, the DPDK API > > typically supplies AES_GCM AAD/Payload/Digest in separate locations, > > potentially disrupting their contiguous layout. In cases where the > > memory layout fails to meet hardware (HW) requirements, an UMR WQE is > > initiated ahead of the GCM's GGA WQE to establish a continuous > > AAD/Payload/Digest virtual memory space for the HW MMU. > > > > For IPsec scenarios, where the memory layout consistently adheres to > > the fixed order of AAD/IV/Payload/Digest, directly shrinking memory > > for AAD proves more efficient than preparing a UMR WQE. To address > > this, a new devarg "crypto_mode" with mode "ipsec_opt" is introduced > > in the commit, offering an optimization hint specifically for IPsec > > cases. When enabled, the PMD copies AAD directly before Payload in the > > enqueue_burst function instead of employing the UMR WQE. Subsequently, > > in the dequeue_burst function, the overridden IV before Payload is > > restored from the GGA WQE. It's crucial for users to avoid utilizing > > the input mbuf data during processing. >=20 > This seems very specific to mlx5 and is not as per the expectations of cr= yptodev > APIs. >=20 > It seems you are asking to alter the user application to accommodate this= to > support IPsec. >=20 > Cryptodev APIs are for generic crypto processing of data as defined in > rte_crypto_op. > With your proposed changes, it seems the behavior of the crypto APIs will= be > different in case of mlx5 which I believe is not correct. >=20 > Is it not possible for you to use rte_security IPsec path? >=20 Sorry I don't understand why that conflicts the API, IIUC crypto API only j= ust defines the AAD/Payload/Digest in struct rte_crypto_sym_op, but not res= trict the sequence, and AAD/Payload/Digest may come from difference memory = space. Am I missing something here? The input requirements from mlx5 HW is AAD/Payload/Digest sequence, if the = input memory of AAD/Payload/Digest does not meet the requirements, PMD will= try to combine the memory address space with UMR WQE as that commit does b= y software shrink. And the most important thing is that "ipsec_opt" is not mandatory, only if = user have such case of layout and allows that optimization happens. Otherwi= se, the existing UMR WQE will still be the default behavior here. > > 2.34.1