DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
To: Feifei Wang <feifei.wang2@arm.com>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>,
	"nd@arm.com" <nd@arm.com>, Ruifeng Wang <ruifeng.wang@arm.com>
Subject: Re: [dpdk-dev] [EXT] [PATCH v1 2/5] app/eventdev: remove unnecessary barriers for perf test
Date: Mon, 25 Jan 2021 17:48:22 +0000
Message-ID: <CO6PR18MB382864B6F049E8C41A97BAEFDEBD9@CO6PR18MB3828.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20210114070830.707550-3-feifei.wang2@arm.com>

>For "processed_pkts" and "total_latency" functions, no operations
>should
>keep the order that being executed before loading
>"worker[i].processed_pkts". Thus rmb is unnecessary before loading.
>
>For "perf_launch_lcores" function, wmb after that the main lcore
>updates the variable "t->done", which represents the end of the test
>signal, is unnecessary. Because after the main lcore updates this
>siginal variable, it will jump out of the launch function loop, and wait
>other lcores stop or return error in the main function(evt_main.c).
>During this time, there is no important storing operation and thus no
>need for wmb.
>
>Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
>Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

>---
> app/test-eventdev/test_perf_common.c | 4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/app/test-eventdev/test_perf_common.c b/app/test-
>eventdev/test_perf_common.c
>index 955edb752..34cded373 100644
>--- a/app/test-eventdev/test_perf_common.c
>+++ b/app/test-eventdev/test_perf_common.c
>@@ -224,7 +224,6 @@ processed_pkts(struct test_perf *t)
> 	uint8_t i;
> 	uint64_t total = 0;
>
>-	rte_smp_rmb();
> 	for (i = 0; i < t->nb_workers; i++)
> 		total += t->worker[i].processed_pkts;
>
>@@ -237,7 +236,6 @@ total_latency(struct test_perf *t)
> 	uint8_t i;
> 	uint64_t total = 0;
>
>-	rte_smp_rmb();
> 	for (i = 0; i < t->nb_workers; i++)
> 		total += t->worker[i].latency;
>
>@@ -327,7 +325,6 @@ perf_launch_lcores(struct evt_test *test, struct
>evt_options *opt,
> 					opt->prod_type ==
>
>	EVT_PROD_TYPE_EVENT_TIMER_ADPTR) {
> 					t->done = true;
>-					rte_smp_wmb();
> 					break;
> 				}
> 			}
>@@ -341,7 +338,6 @@ perf_launch_lcores(struct evt_test *test, struct
>evt_options *opt,
> 				rte_event_dev_dump(opt->dev_id,
>stdout);
> 				evt_err("No schedules for seconds,
>deadlock");
> 				t->done = true;
>-				rte_smp_wmb();
> 				break;
> 			}
> 			dead_lock_remaining = remaining;
>--
>2.25.1


  reply	other threads:[~2021-01-25 17:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-14  7:08 [dpdk-dev] [PATCH v1 0/5] refactor smp barriers in app/eventdev Feifei Wang
2021-01-14  7:08 ` [dpdk-dev] [PATCH v1 1/5] app/eventdev: fix SMP barrier bugs for perf test Feifei Wang
2021-01-25 17:50   ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2021-01-14  7:08 ` [dpdk-dev] [PATCH v1 2/5] app/eventdev: remove unnecessary barriers " Feifei Wang
2021-01-25 17:48   ` Pavan Nikhilesh Bhagavatula [this message]
2021-01-14  7:08 ` [dpdk-dev] [PATCH v1 3/5] app/eventdev: replace wmb with thread fence " Feifei Wang
2021-01-25 17:50   ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2021-01-14  7:08 ` [dpdk-dev] [PATCH v1 4/5] app/eventdev: remove unnecessary barriers for pipeline test Feifei Wang
2021-01-25 17:50   ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2021-01-14  7:08 ` [dpdk-dev] [PATCH v1 5/5] app/eventdev: remove unnecessary barriers for order test Feifei Wang
2021-01-25 17:49   ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2021-01-26 15:56     ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CO6PR18MB382864B6F049E8C41A97BAEFDEBD9@CO6PR18MB3828.namprd18.prod.outlook.com \
    --to=pbhagavatula@marvell.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=dev@dpdk.org \
    --cc=feifei.wang2@arm.com \
    --cc=jerinj@marvell.com \
    --cc=nd@arm.com \
    --cc=ruifeng.wang@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git