From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 404D7A052A; Mon, 25 Jan 2021 18:48:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BD5BA14113F; Mon, 25 Jan 2021 18:48:31 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 78E3F14111E for ; Mon, 25 Jan 2021 18:48:30 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 10PHddQl012064; Mon, 25 Jan 2021 09:48:26 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=WFDi396ZMgAFkBQeh+ykDeS+ZFSPXvh5mVJGlxKzMnY=; b=fGF4rEKzkY5L5sBxVxkQuTAGrJzXgLEIDRMZ/uSJZiJy1tCn2gFKmWuM93TXQHlvVyhv MgJn5xMIhVY99ehCiEtQbzYCz4le573qlqtbU6Ehg+KcWaZ1dwhOo/YxP+dCpIvOSD2A bhSTQY6ffs7N3yp0dVvlPwGucEEGz+Q22hVUog1w/JByUMBJ73vitYlqvATqHi9tSrG2 jMnCRsgqO2tbq44b5yfKOfck8Qiw/E6jnZ+d1P6SDLInQ5jpDrVhw4zX7QX07xHTSTRu DTYQfdV0X6IEanU3lmKGKhlzhpuOFr99EtYlYoKwEVL3pT4DjgSJRWl69VB8Zc1t0oLC KA== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0b-0016f401.pphosted.com with ESMTP id 368m6ud7fc-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 25 Jan 2021 09:48:26 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 25 Jan 2021 09:48:24 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.174) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 25 Jan 2021 09:48:24 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GJbSl1s3ygkfmCkQFmkpEe4KDqCg1Nyamyb2//UGRzK4P9DV5xPEDqcAMsd8PHzZE3hzV3RUMkg8vSgWnpglqc1pfdDMI3b6+XZXjSH+yB0EL4BIZI8s0zOyeVRsxfln5lSYF9yDHKif08i7LKKcvuqgniwdKmayCAF5Uc8aa/IKDZDK+fJMBwZad+YlLsgNB8eME2NMtpIwQAIUYc/+O0TYET9y4n9jck0wNH9LYaLGvwQ8jSpsFjJg21+eKztmeYLVp08ZgDOJeIjmN/PojC0xxW6ZsYlgO6bqtBA4ZdFNRVmoVRbMPzk0+KhY6blt7wDP5xFcqPhtwHzgZPrajg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WFDi396ZMgAFkBQeh+ykDeS+ZFSPXvh5mVJGlxKzMnY=; b=lnjcs+04U9FNBgiH6RlE0Dc/NRM2z9RI4tDvNWh/B5oLmJmQXV45PyRK7vIesb2fv6ImnYNSHaclXEXGxv+VRUzBODLV7UeKtPAD65PpwwHUSn++CUYPt4oJFMQl3n5UTJ/i6pyWZXeQx0J51VTWJDSpaGm9+pqvKVPxYBBRQ4yTS3YMROQ76MBLRVIbUYM3CvvQd6uIjD0MbaIRyZjKwGzhfgL4Y4uUr8qmFFvlD1jTXh+85Em6A1QiTYjzRQSMkkaAXhzOyOK0XcRlLqDKmcsxoPm2qtqH1UWLoMvyn4I/HWJsBT1JUu2KD/MTfogEV93kd/kVOk2dj8v1wIjp6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WFDi396ZMgAFkBQeh+ykDeS+ZFSPXvh5mVJGlxKzMnY=; b=Ga7PIqKONcFccqIuHw2NdstgvnS9zm4ozFrdAR87bTwB2+zNye8mTd+2K+da7COR+EcryKC+OxGrHsyBqWXpkXb54ohBKNJlc5kjCMdPObKAJryHBuTAzX/bJAsTIM8Hxzx9B949WB0xrJCMTb59kjqxYOfCDUyE6hYpiT5zRMU= Received: from CO6PR18MB3828.namprd18.prod.outlook.com (2603:10b6:5:346::20) by CO6PR18MB3860.namprd18.prod.outlook.com (2603:10b6:5:34d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.13; Mon, 25 Jan 2021 17:48:23 +0000 Received: from CO6PR18MB3828.namprd18.prod.outlook.com ([fe80::5c2c:a13a:4f3d:94df]) by CO6PR18MB3828.namprd18.prod.outlook.com ([fe80::5c2c:a13a:4f3d:94df%5]) with mapi id 15.20.3784.019; Mon, 25 Jan 2021 17:48:23 +0000 From: Pavan Nikhilesh Bhagavatula To: Feifei Wang , Jerin Jacob Kollanukkaran CC: "dev@dpdk.org" , "Honnappa.Nagarahalli@arm.com" , "nd@arm.com" , Ruifeng Wang Thread-Topic: [EXT] [dpdk-dev] [PATCH v1 2/5] app/eventdev: remove unnecessary barriers for perf test Thread-Index: AQHW6kRsVuXrYIY7ZE2pl4/TWCSP06o4r+Ng Date: Mon, 25 Jan 2021 17:48:22 +0000 Message-ID: References: <20210114070830.707550-1-feifei.wang2@arm.com> <20210114070830.707550-3-feifei.wang2@arm.com> In-Reply-To: <20210114070830.707550-3-feifei.wang2@arm.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [2405:201:d009:380f:50b:3c28:481f:4468] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7d2ab821-2d30-474c-f23e-08d8c1596900 x-ms-traffictypediagnostic: CO6PR18MB3860: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3044; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: b7to33KE/zipoBdznCp+CmGG3G2VprQ7eunvHd2w7thwSD9o+bupvFonHG+N8FIhh23Z4yb6oIon68MuRXX+s8xiqFKa4jncbNv4QsFtVRvj1ZfePy7+A+uO56H7OARTJgpahZoBM7e6/pOcrzGimKG5e9fQy4emsF2y4XvYBGmQN/XvITxVNdRFyEJ6+UoUNPuhYr8KP3+f2gWEm8Vd2sANKOX58ebKgk1nZ6jDyAPn4l/liedBDU0q/hPnGDRG319oPlEWcBXwHcJj+hrongj13ft6Rv/GMBscBTY87R9jpN/oVXH6D3PIcNt6zhSg+NHrYAnuQx0Cj/OkpfKvNPVe0F0TteC7eDm30l5vYVgSz5t3QXEdZeuMGijG0nGrDKHcdoJDAO7F0kMOuj+oOQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB3828.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(366004)(376002)(396003)(136003)(6636002)(8936002)(66556008)(9686003)(186003)(2906002)(64756008)(66446008)(71200400001)(33656002)(66476007)(4326008)(66946007)(83380400001)(76116006)(55016002)(8676002)(86362001)(52536014)(7696005)(5660300002)(110136005)(316002)(6506007)(54906003)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?xrQPIYREp3gN9jYap13YMXTCodwmmKvUa15O7SwcD+1RDHLBQdw2iOkxYVEv?= =?us-ascii?Q?RbCT6u1VWnmyTmlAqBFPk7nwQX2HDkNXXUk9Iiy6I9jxfJWwRLKOOX/Q1FyL?= =?us-ascii?Q?cYeE/OKqCegOS7dzJunTN5Dl6Ngy5fyW0iyrE9ychDufXYoKsqKgbRk7iovl?= =?us-ascii?Q?9t7lt3ArQ6+N7pdJu4yV1F/9iDj44bK1kX5zr2xASfT/2cDkFbLydvGu9g9Y?= =?us-ascii?Q?g7SgjwDOLQa2QdWvihlKL0L5AMooC/vE8YpvLBT5nMT3zLdl6kwk6RchBpUS?= =?us-ascii?Q?F3j569CxjpR/Ec9AXYmfZ3ANkHEZbbd5FdXn8xx9x0ruVqOflo+IImj6huxx?= =?us-ascii?Q?U5yLSXZdEBIIlmDwYZjPb/b5KwzAJyCEA9juQfuFC4pj/wyPweRq68yTEQEl?= =?us-ascii?Q?tK0aO7rldOR5iafkG2GlpseIHeHecayWF64sZ5Gs80EsL0XqR3qLtrzOOq+8?= =?us-ascii?Q?KxfsTYUk1YZDL466mr6paX6dR6Vdo+1nbGuOJ+VCjs3ydKBH4M2w1BDZpm+A?= =?us-ascii?Q?b5qIhQypNtg4+JggbNbTJ6hHsMQpoU5J2ck0/rEhZ6pOLslRH2ITqVWVaTFr?= =?us-ascii?Q?hkW6QiVN7USCmwbfggRiQxfYAySnxWFeD33ci3OR5ZQFqMZhYAgSOF73x6M2?= =?us-ascii?Q?E4zCnZgeAGnDlGbecxq+C2sLdfa9UXdUyhM0A7++D1X8hBKlco3j2KhxDHA0?= =?us-ascii?Q?a3z/L798r5cbPcFljC3gXiD5o0IWPF1l8T3iArBm3rAerJmcpxMtll5A4yOM?= =?us-ascii?Q?0DZYOvgp+ZgcjwQTnX81oYN/ZvcAxKGkGCbcCPfDD0MceOY0zANwuBOKYBB6?= =?us-ascii?Q?Q/8UW4rfCsMlgcuk/UFyJ7h/M30QT6id5YIycj7lzhp2/D8rebblkhduWqVZ?= =?us-ascii?Q?GiHCx4Cye9pUVFo/wtDuGJTDhz8YKw2N1lW81dp+iUsRna/PGd/CgaG1tVS8?= =?us-ascii?Q?sUD5TSHDFeUyT3UYSseVtr8O0ufrgk5p5xQj9EcF9130FhB9+i49Hh5/cJFE?= =?us-ascii?Q?RQgDVoKwt2Qk1AcwqI7fIGTfGtprr0Jo4QlYtgFSsuzOk7BsOeMa0ruIt2O/?= =?us-ascii?Q?FcQev0qd7hRTIuGV7dUDQ1TMkOUOoFRVxCTmJbqaLxD4F73nEPn0OennmSL3?= =?us-ascii?Q?AMdtYpFDeOL5?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB3828.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d2ab821-2d30-474c-f23e-08d8c1596900 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2021 17:48:22.9570 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fXFO3ZNYGJLzUpITtwAI2L9fpUmtevBtH5G2Zcgb/YBipFDNo059WRNEzlySboJs2KoWU1pDCJJ19mNz+ejvEcB2UH5E2wKWVxr1huZPktg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB3860 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2021-01-25_07:2021-01-25, 2021-01-25 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v1 2/5] app/eventdev: remove unnecessary barriers for perf test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >For "processed_pkts" and "total_latency" functions, no operations >should >keep the order that being executed before loading >"worker[i].processed_pkts". Thus rmb is unnecessary before loading. > >For "perf_launch_lcores" function, wmb after that the main lcore >updates the variable "t->done", which represents the end of the test >signal, is unnecessary. Because after the main lcore updates this >siginal variable, it will jump out of the launch function loop, and wait >other lcores stop or return error in the main function(evt_main.c). >During this time, there is no important storing operation and thus no >need for wmb. > >Signed-off-by: Feifei Wang >Reviewed-by: Ruifeng Wang Acked-by: Pavan Nikhilesh >--- > app/test-eventdev/test_perf_common.c | 4 ---- > 1 file changed, 4 deletions(-) > >diff --git a/app/test-eventdev/test_perf_common.c b/app/test- >eventdev/test_perf_common.c >index 955edb752..34cded373 100644 >--- a/app/test-eventdev/test_perf_common.c >+++ b/app/test-eventdev/test_perf_common.c >@@ -224,7 +224,6 @@ processed_pkts(struct test_perf *t) > uint8_t i; > uint64_t total =3D 0; > >- rte_smp_rmb(); > for (i =3D 0; i < t->nb_workers; i++) > total +=3D t->worker[i].processed_pkts; > >@@ -237,7 +236,6 @@ total_latency(struct test_perf *t) > uint8_t i; > uint64_t total =3D 0; > >- rte_smp_rmb(); > for (i =3D 0; i < t->nb_workers; i++) > total +=3D t->worker[i].latency; > >@@ -327,7 +325,6 @@ perf_launch_lcores(struct evt_test *test, struct >evt_options *opt, > opt->prod_type =3D=3D > > EVT_PROD_TYPE_EVENT_TIMER_ADPTR) { > t->done =3D true; >- rte_smp_wmb(); > break; > } > } >@@ -341,7 +338,6 @@ perf_launch_lcores(struct evt_test *test, struct >evt_options *opt, > rte_event_dev_dump(opt->dev_id, >stdout); > evt_err("No schedules for seconds, >deadlock"); > t->done =3D true; >- rte_smp_wmb(); > break; > } > dead_lock_remaining =3D remaining; >-- >2.25.1