From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03794A052A; Mon, 25 Jan 2021 18:49:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD52E140F48; Mon, 25 Jan 2021 18:49:14 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 5131E140F29 for ; Mon, 25 Jan 2021 18:49:11 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 10PHfNYP015634; Mon, 25 Jan 2021 09:49:06 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=8dd6AVbTx6yyyNWiwfG245fNV8P6Fg3rdRljEdSKxFo=; b=ZKynDRXFPnrO6bL9sRFVxsv0UBYKo2dVsUNHMPjjk9+bbBEFDecXFcu5qEaJvVQ5Vzo1 tTAlijPa76ch5LjxDToFUcGQGj6N49wAhIIc/W3CSwrmcjcKKp5UK2ltSRwLR9grHtur GhCs4FgqlxL5Cq8zjyOF7SlxVvyxrq5PkJJGb4XBqdbVusewRbouqJMBzApkJDTg2Y+O 7MhbEpbspLqNvocFi68Dic5x3I25WWCGMRhoMqjjolpdo9mx/5+KsmHy360yChQZl2/y xD7ZDVZDooiZbpFU+wvKpVg4ifDA6oBJgO2PykSdm8x+hIgjYgOM0Wk05szzyU5kufVs 5g== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0a-0016f401.pphosted.com with ESMTP id 368j1u5fvw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 25 Jan 2021 09:49:06 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 25 Jan 2021 09:49:05 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 25 Jan 2021 09:49:05 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VPq+brWjrktCJ0Y/+betQekC3jySqSzFZgvkbqo2f88k5X0vbQwyO2UCyvtTao9U1IaFClow11Fojst8ZwRNjH0u+VACxKaFwFmLY0saLIVpY/eCmzb5aVWljRE1ECVrQsT/fomFVc4R6mdgh9p1oIykAgyfyK5Wg6qxW/6O6HS3X+/VDs5NQkUzTt+WQ8WLPESBee06fj42WPvzOSW5+0li1wtNsrdeEkYBo8/zGk6GlSQ+dPuOXeHoR7wwO251/791CNbDnJ5Ek7w0y6PTHcxHeBCiUsKaxXgdpopAZ8Phtjt2qYjzSIU7OtDYeQfIeiOyVyP8xo5k3NcrDPZ8dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8dd6AVbTx6yyyNWiwfG245fNV8P6Fg3rdRljEdSKxFo=; b=LmTaBQViA5u9w1uPdUIgkYXgehVkwaPaloGzcktbbOg7bjbbqDgQ93qtbofjKtvsw+UzVJQ18Pw5DuwDOU+137UYBMVVya9OqDYGECdMmDS4kdZV2sblMA4k3atZD/CRTy7w4cWrNB7qs0WA5ed+Hpy2ti83Y4kagvHQZW4G8K3fbJocaAcra0RE8tzoJcg3MqNajprJGrxn0uoZ9OgwRbacEDTu7MKWkwmURXaey/p4ohmD5920TcyqWAliMPC4Pu+67phlYW/ZFc6sm+OqM7bOBi6TqurskJ3ls+2XRtZNEFc/eLwoLSphjrlNwwN6zxt5tZw0O4Ax5puoHEogrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8dd6AVbTx6yyyNWiwfG245fNV8P6Fg3rdRljEdSKxFo=; b=FDu3UkwXrCnT50r/SYF0pSU4rz88YbFPKZiRpf5OTYE0x6aKOHkSKGhC37vKJahWtNvjw53MeZORAUu22EbcFPPuyOpIDqfkayUrF/kCpEoLd+6Q87BJ4QMlVZDqaCar6e/1Rx0OxpKvXbWY6UL+hpEdhFKnFw6JVDIukRz1xmQ= Received: from CO6PR18MB3828.namprd18.prod.outlook.com (2603:10b6:5:346::20) by CO6PR18MB3860.namprd18.prod.outlook.com (2603:10b6:5:34d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.13; Mon, 25 Jan 2021 17:49:03 +0000 Received: from CO6PR18MB3828.namprd18.prod.outlook.com ([fe80::5c2c:a13a:4f3d:94df]) by CO6PR18MB3828.namprd18.prod.outlook.com ([fe80::5c2c:a13a:4f3d:94df%5]) with mapi id 15.20.3784.019; Mon, 25 Jan 2021 17:49:03 +0000 From: Pavan Nikhilesh Bhagavatula To: Feifei Wang , Jerin Jacob Kollanukkaran CC: "dev@dpdk.org" , "Honnappa.Nagarahalli@arm.com" , "nd@arm.com" , Ruifeng Wang Thread-Topic: [EXT] [dpdk-dev] [PATCH v1 5/5] app/eventdev: remove unnecessary barriers for order test Thread-Index: AQHW6kSN8yQTN+qaLUeZgxoHOcoY5ao4sCZw Date: Mon, 25 Jan 2021 17:49:03 +0000 Message-ID: References: <20210114070830.707550-1-feifei.wang2@arm.com> <20210114070830.707550-6-feifei.wang2@arm.com> In-Reply-To: <20210114070830.707550-6-feifei.wang2@arm.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [2405:201:d009:380f:50b:3c28:481f:4468] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c6d70466-16f2-4246-f301-08d8c1598144 x-ms-traffictypediagnostic: CO6PR18MB3860: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Bmb8Y31bTP/a34abMJdxX0ocroy9LPqDrDBGr5LP5lfIWnBXQSVdRSVnM22/+mmm9QFqXAqCVlUPgcjHE3l9jeOxlIITrpkqplYHsUIrjKSczzmOynXuql8qw3jSutlaGN3bb/i4My5BWoEjI9mZTXsRYj7uKMlG+3Y/ceoWSYELfSJ6PrSANknpofl065oKTM6WzkZxb96WsRb3VCxobQumNw5/SmQjbd0swXNNqEYNnX0NIc4RR9G+h0i6MadL3XPIb7NDf+SxoPbV4mqhxRdP/nBgFMD8ES3d8sNGfuJdRyH16XtrzfzX6g1G+P6uKh+Ugt/RG1LUdZkMUoW7l12XcrsgdOprg8MXe37skw7EEPVkG937eJCtduk0jFCGnxMMOTgnZStKHFWL0AyH0g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB3828.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(366004)(376002)(396003)(136003)(6636002)(8936002)(66556008)(9686003)(186003)(2906002)(64756008)(66446008)(71200400001)(33656002)(66476007)(4326008)(66946007)(83380400001)(76116006)(55016002)(8676002)(86362001)(52536014)(7696005)(5660300002)(110136005)(316002)(6506007)(54906003)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Q1/Dfs8CiWmZERL1fxfNapfeMuTHqFIT/BekyP2E0GFF1eVENA8VP7dpEpWB?= =?us-ascii?Q?oT1fp+36EgopKbIvbtKC/6WS+BNMbZ/jnCstle0S90rwIAw1hg8h54fFPwrK?= =?us-ascii?Q?0A8KLqZiJoPWgeqbGMao8m9401mSiQuyrYvhkrIjX25xgl4Q0LN8bqUS4fkL?= =?us-ascii?Q?D6BFfpwogcLCbQPUS/aRk0xIKs6dLuUhGFFPRcYE6bF+lIXCXZf1rsp8f6Cl?= =?us-ascii?Q?DeC08jIlqmHrClsylfB28Sh2jrSDMi+Zt5ydT9sP7o01owIpAPCJAniTywAl?= =?us-ascii?Q?b4cvSyE2uDzJyWevRftkWsBF8p1Lbh6iDmQ5L6UnOVHG2oKZGPKEILgZJX4/?= =?us-ascii?Q?tXZkl+KJFJoekpTJoAgAc5UC2hPx7OrzaO3DsM7uV7iReqbg5H3KZ3HmbR5S?= =?us-ascii?Q?bP5w/wEy45UghF7htX2rLeCa8MKEmAIQr0RtE4swcFkscnDcwYT8b596w+2x?= =?us-ascii?Q?rbwrD1aGFAeLeEN5Ul9zJ7mpcXvRHBm4jTCFbh56FHfzPt22FAIzsNTWRg9S?= =?us-ascii?Q?S4N8zOSc+mFWjwLyHr3Slb0TdtMC864bHKeU9zyszK7Bu52x0wh+14tz8XzV?= =?us-ascii?Q?dymQdNFOfBOwvT+haPo3We6hZ6V3DqtanvulG2eo1pEHlvwuvk3wzPKIawIb?= =?us-ascii?Q?CSYW617zvTZUgvy8xnzVhs7gsYRWtrDhx2Rai7uhQvWqW1KaUanY+q3ZExSN?= =?us-ascii?Q?Orrvo6nR7dXpRU/5gF30D5b8Pl59OCzMGVBsa/G371P79L1/OLXJbjfHuTAT?= =?us-ascii?Q?geykschtUtLBsFKp2foJujyrZLN3FK4OkmHQTZwjBSdFbZ3bobbdqUEkRBOP?= =?us-ascii?Q?xTdW1LG7tpY9Ii/r1wvgFR3sQDb+CnpDib2oIK+Ak9PWPiw5aVcAcRco0PBc?= =?us-ascii?Q?vQDP0Oy/zF9CQxKYyG6x555q8mR5gNnaS9swtgmWom1/u06lJy9ZOX8e4lCv?= =?us-ascii?Q?3h56ubKmsC6m6F4lowTkJeMf1p694C85v8rzsjwi5Aq7qdC76aYWJLtT5TF2?= =?us-ascii?Q?5wURV9d0JXFe/bTnJzYQwH0+D0mFacEGGf70Uecj4Lym+ORUiTcGKTqmRPgZ?= =?us-ascii?Q?pqY55Ko0OKKcoo1roZEgETcvrI+qo+CiiNiMtUlVmWE/cobZX0Mdu2+koxdJ?= =?us-ascii?Q?55XOxhbYaSrQ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB3828.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6d70466-16f2-4246-f301-08d8c1598144 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2021 17:49:03.6660 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +ShZNgybIII7QatXElxR7JxjN1I67gt1QDF0dqy2CFY0nmnwNaZ2yymBmnTu33w5g7yE5IkKeoYms/6KbcxxcKcbtRiVdHt3jOk1ENM0dqo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB3860 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2021-01-25_07:2021-01-25, 2021-01-25 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v1 5/5] app/eventdev: remove unnecessary barriers for order test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >For the wmb in order_process_stage_1 and >order_process_stage_invalid in >the order test, they can be removed. This is because when the test >results >are wrong, the worker core writes 'true' to t->err. Then other worker >cores, producer cores and the main core will load the 'error' index and >stop testing. So, for the worker cores, no other storing operation needs >to be guaranteed after this when errors happen. > >Signed-off-by: Feifei Wang >Reviewed-by: Ruifeng Wang Acked-by: Pavan Nikhilesh >--- > app/test-eventdev/test_order_common.h | 2 -- > 1 file changed, 2 deletions(-) > >diff --git a/app/test-eventdev/test_order_common.h b/app/test- >eventdev/test_order_common.h >index 5ef840493..cd9d6009e 100644 >--- a/app/test-eventdev/test_order_common.h >+++ b/app/test-eventdev/test_order_common.h >@@ -104,7 +104,6 @@ order_process_stage_1(struct test_order >*const t, > flow, *order_mbuf_seqn(t, ev->mbuf), > expected_flow_seq[flow]); > t->err =3D true; >- rte_smp_wmb(); > } > /* > * Events from an atomic flow of an event queue can be >scheduled only to >@@ -123,7 +122,6 @@ order_process_stage_invalid(struct test_order >*const t, > { > evt_err("invalid queue %d", ev->queue_id); > t->err =3D true; >- rte_smp_wmb(); > } > > #define ORDER_WORKER_INIT\ >-- >2.25.1