From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9BE84A0093; Thu, 23 Jun 2022 11:37:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4553C4069D; Thu, 23 Jun 2022 11:37:10 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id DA2B74067B for ; Thu, 23 Jun 2022 11:37:08 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25N3kgAD011236; Thu, 23 Jun 2022 02:37:06 -0700 Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04lp2048.outbound.protection.outlook.com [104.47.74.48]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3guye7x7x0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Jun 2022 02:37:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fodItE9epGwAvn6bDVO/EWEg4MyYDB3v6CtiFh9I80nphUD/9bFgCNCt3ZRn9W8n4gDthfH+UHZX9CKJICcLmCpGuqDRGMC0ft3gK80O1kMWNFgyst0PKakhTocfFGI0gKAAWv3JhJ+hd27y58cxFOzGQANScwWHlVuUPdqZ4WQBukbkFWgBrWegxE75vYpxH/1LMYWD8APlXcNim03HioRAURzAJOdQ1EL4oXWZTpDqhXzQMOllwiPvfgUy5xhST57flT5woJb5hii1MaUiPTxu9UxKLcghJkvlkvza6rcd3ThgtjbHL31jzB+jsb+fhJ/64+rYCYq0Ukr9LBKZCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kCRotVT4OGuC9By172pqoDBhPCYQZgiK/6Fot/bSm3E=; b=KGW44eKvKMVCXX8NSE0VuQoJr030TXlFzdlzCNNZKyASJoALkzS2By26LwVENVdboATjc1or8Aa8SZ4qtcpcqICsDUWTlWTejScxc5uDtJE+9Lb7cBXMDLENXyZWv0AUgo7AbGGpmer/rj8QKPXbmEEHNjgzNjtokBM4FQz8HeYQtY4h6llVLi7YbZRDfESeUQ7eD1aQR6I7nJZKRzTSm1wJAulG/STMXaKWee0+uZrE+QYCOUqV900LJczDNZnCIc/q+YNas7Jyp8lt/0MpnuBn47E2dMDqYyG3rvbO9WxhzgI9hdgPI1kXtclxsMcPIR5DSBPxZ5wQtoutFyXEpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kCRotVT4OGuC9By172pqoDBhPCYQZgiK/6Fot/bSm3E=; b=Xh53VkG6tJqVh9c1Vr2EhED6EKT5JtIcfgwh1jcyp8WTMJCz6goOO3C1csVzuPmrkOP1ThJsmHD7CFoXbIylIgjf+KZL3cr+wVBwgSOZOlw8VKtxO5N5XAaEj5jFM5EllPcTbGpFWEwPFT/sLIwArreyHTBxr0XtifeEHRty7YY= Received: from CO6PR18MB3844.namprd18.prod.outlook.com (2603:10b6:5:340::7) by CO1PR18MB4572.namprd18.prod.outlook.com (2603:10b6:303:ff::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15; Thu, 23 Jun 2022 09:37:03 +0000 Received: from CO6PR18MB3844.namprd18.prod.outlook.com ([fe80::49a2:55d5:e27b:7038]) by CO6PR18MB3844.namprd18.prod.outlook.com ([fe80::49a2:55d5:e27b:7038%5]) with mapi id 15.20.5373.016; Thu, 23 Jun 2022 09:37:03 +0000 From: Rahul Bhansali To: "Zhang, Roy Fan" , "dev@dpdk.org" , "Nicolau, Radu" , Akhil Goyal , Ruifeng Wang CC: Jerin Jacob Kollanukkaran Subject: RE: [PATCH v2 2/2] examples/ipsec-secgw: add support of NEON with poll mode Thread-Topic: [PATCH v2 2/2] examples/ipsec-secgw: add support of NEON with poll mode Thread-Index: AQHYgh3rd9yah0OEq0ylj6Ud4j2Djq1ctz0AgAALBIA= Date: Thu, 23 Jun 2022 09:37:03 +0000 Message-ID: References: <20220524095717.3875284-1-rbhansali@marvell.com> <20220617074241.3260496-1-rbhansali@marvell.com> <20220617074241.3260496-2-rbhansali@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e2aadc57-f1bb-41a2-3f77-08da54fbee59 x-ms-traffictypediagnostic: CO1PR18MB4572:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yJR1Ok8uhWpYoG0YH4xXGJxd5fJP58UBtrNy02B3hcnTENCwlfu0oto8XtXKrmCRIum8tn5W1/JyMdfiI+5ol4PHZ4ToNy5uk+6B2MYlWUNq5Rv+nkFaMlO2jEf2GZ994NFufPO58Ht/45yoFNFw/kdQk09reC9gMF3GIRqDDDUNF3dmMGdQpIRpOrlwIPhM6xuzaUarwLdLfz8cmVZORsXCVDv2K3v1aLBz0f60dmub3Cd3MuaeA7Xoi7LOQCPeSqiYBEJMM2/t7xpRP/dMQSJCDlMQa7eRhgMyWHUMcJ5MODnjjcy3hQu9FD2u/YclyAyOZdpgdo1tRBkgvdvtZFpm+/eXlo7fmo0yOAiCbPYGr9Y19lSqj09DLQwlHGlGesZ/6hj0jyS0A17C9D3oBhAbPf8tSG0/uPajLntRXXvDIWg4ejQZ4q8X+NPDF1vnZ8LeDhe09up87tXxk/39pJHHN+dddIhBe9nyazizaJC7m2iVgKORHlP5OB6Veq/GZsjl8BBx4GronRs2058wxf+KlUEFDjrsPds9NRQe3bqqJFxBzHKLy82Kn5zhQmfQV2wVEyjm4kIQNJ8W1b4FnvA1yFIiUPEVtT8/n59luBeVCWqS/tfuN/xRpgXKOrHugvT1ojjojRQmSruz7L4y09OUNRMs7S0rBix6zTKB23oWvWMPwqCFz52n5JxgHaGg+5tJZC3qYw9X02KbWgbech4bSRnmfU/5YQyTS6hCXTijZ1M+FnGtVilCPoYxQe9IoRIMV76Su+mLxQpthYCxLQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB3844.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(376002)(136003)(396003)(346002)(39860400002)(366004)(26005)(5660300002)(7696005)(8936002)(6506007)(2906002)(33656002)(8676002)(9686003)(122000001)(478600001)(53546011)(41300700001)(52536014)(55016003)(83380400001)(66556008)(38100700002)(107886003)(110136005)(86362001)(186003)(71200400001)(4326008)(66446008)(316002)(38070700005)(64756008)(76116006)(66946007)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6gQEB93IYwOs9ZyWkdsY2wGqd4EIOSTcbOW+wso3JH2wdPuuZAZJ0HWCvV0t?= =?us-ascii?Q?3wnG++vsosB48LmPTahtGivatmmXDZvItNhAc2xLPyG4sVKxwn+uW+5g3zXo?= =?us-ascii?Q?09DYyEL/SpOqTiIPuCh0BOUhwWMcd5hs2xuK3xmQcG+uAA8b/MXCIOruoy1V?= =?us-ascii?Q?h65ciCbKRP1s6/MoQUPWXkd6vuPEeB+xSnHealos7nc8ruYJDuLz1NUBeWar?= =?us-ascii?Q?HSOzX4otde4Jry27f3TBais0dvmivsfU0D4I8crOTvhbCb6C+F6WpQVo8y8W?= =?us-ascii?Q?CW0PkEu9F0uPABZKgP8jrtnuyVbsL+VvFaGHJCbACDq/yQN1DVJQ5ips0xmj?= =?us-ascii?Q?V+3w4E4Q/lV9u1Wgum30wie984WI6f+E6MsObgAxDitlkR1RKwqCK4vOGOHj?= =?us-ascii?Q?ItpoJkaMZ4T+e5fESwrh4F9yQeNII174iqk17KMjMxsTKzfi3hP7kqTc61Os?= =?us-ascii?Q?AwMn5DrK5/YpppNB8bLZZVz7mEeUOZAg2X6gTbmWPt4Sn/h1+MZl4AAAfZ1f?= =?us-ascii?Q?zxFKHtgGOrhrmRTW5XsGNe2CjA7kySiY3wCzUQqS0lD5QrqXgCYqnaOLAfZl?= =?us-ascii?Q?7p1kENa64JjIpnjuBRgLyi8xl4UwDiZ10BFbYq4qM9AGiIso5nxrA6A2i+L5?= =?us-ascii?Q?0byjDQ75og9vEc49MZOfdCDKwrxK2xc4DB7IqMyI3y5ZxUnbKN2SInBG+OoX?= =?us-ascii?Q?pSNpg2eIE0YobwVvNXEXwuSgViAgvdtijEyAWYtoVeo31Ape5jOucP6oM1ta?= =?us-ascii?Q?sq/VzwLNl/piNnxQs7atKUyJZIx4NkTdKGoxV5kTmpuNk24KhbDWvcbstMiv?= =?us-ascii?Q?GZDRmeefNwTjondI3ZVlkfojztRozxjPtiIdHwfLuSgW3/5s1Wg43sgOAawo?= =?us-ascii?Q?w5HCB66A98JRrZc29QPaCa0sL1Y72SjamDZgCLbV2naIIv7qyi4YDrpDPfz9?= =?us-ascii?Q?TRiVibJver9cNHJ1K3GrzDqqQesHy6n2YjgV9UOMN3fzZvQtr+jNg2DrWthw?= =?us-ascii?Q?jr3n5LdoGTRjl6uq2sL+h0XcMOMjEbYQnGVuRr9Tebrl98wh5xedPzp0aHgo?= =?us-ascii?Q?YgakEq4tkzCl8X54PeINEHW729SL9ce5ikFEMdxryKmJgfnDDo7KAe+utF6s?= =?us-ascii?Q?OHXrbsJ3mZ0UiGf05PO4dDHjxTGPyOr2wNDe0TqW2vWvZPsdhl0t7ICaAv2C?= =?us-ascii?Q?RzAJbWX3s/i4mCdHQ9CqX0jD/cSZlyCa6Ddp1j6j7RtfHExx/FMzVspd4XeM?= =?us-ascii?Q?3R6qHCzG6OtHCcCuHeFfuN0XFj4BWw5GPP5a0zS2sZDvoAnyNEboSOmIBN+l?= =?us-ascii?Q?JZPVx6G9LnFdXkZvfB29fsykF7kdVobaM2XUvGyZlIxokmtlHtpToYlsOTT+?= =?us-ascii?Q?uk4cKirNLt1bWs6vSERR0I5lsBm7ZX9r+UAbM/stWUFafpQYCgvrB8Ax+TZe?= =?us-ascii?Q?SUwv3cfsn/+EGiJoY6uTaAqjbM/ow98joxbUQMsjk5cJNIJtl7O0wGG7l9Hb?= =?us-ascii?Q?kIRB2tHRnIGT2EYR64HBazlAw9GSd/uttTBOjX1UzHDeLJ8l+l8tPccju4la?= =?us-ascii?Q?QrYz9y9qmOyM+vKpTPcsbn4L82G66xCipDAaKnG7?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB3844.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2aadc57-f1bb-41a2-3f77-08da54fbee59 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2022 09:37:03.8384 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: E8BHxXmr7v7dws7b+9vo+fBPV/Qj0ljU3747hbbbRv/x4CDFgDBZ6u6FK3I5Y6r8F1KKbM72TYbXz9Pa0DS8kw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4572 X-Proofpoint-GUID: QcfRdcoYxTdQRS6Y1JEOk_w6wqX5077U X-Proofpoint-ORIG-GUID: QcfRdcoYxTdQRS6Y1JEOk_w6wqX5077U X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-06-23_04,2022-06-22_03,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Roy Fan > Sent: Thursday, June 23, 2022 2:17 PM > To: Rahul Bhansali ; dev@dpdk.org; Nicolau, Radu > ; Akhil Goyal ; Ruifeng Wang > > Cc: Jerin Jacob Kollanukkaran > Subject: [EXT] RE: [PATCH v2 2/2] examples/ipsec-secgw: add support of NE= ON > with poll mode >=20 > External Email >=20 > ---------------------------------------------------------------------- > Hi Rahul >=20 > > -----Original Message----- > > From: Rahul Bhansali > > Sent: Friday, June 17, 2022 8:43 AM > > To: dev@dpdk.org; Nicolau, Radu ; Akhil Goyal > > ; Ruifeng Wang > > Cc: jerinj@marvell.com; Rahul Bhansali > > Subject: [PATCH v2 2/2] examples/ipsec-secgw: add support of NEON with > > poll mode > > > > This adds the support of NEON based lpm lookup along with multi packet > > processing for burst send in packets routing. > > > > Performance impact: > > On cn10k, with poll mode inline protocol, outbound performance > > increased by upto ~8% and inbound performance increased by upto ~6%. > > > > Signed-off-by: Rahul Bhansali > > --- > --snip-- > > > > static inline void > > @@ -1403,6 +1420,8 @@ add_dst_ethaddr(uint16_t port, const struct > > rte_ether_addr *addr) > > return -EINVAL; > > >=20 > Fan: I failed to understand why do we need to overwrite address to do an > address copy here. Was it a bug? It is not overwriting the ethaddr_tbl[port].dst address, instead it is copy= ing from dst to xmm_t val_eth data in a format as required by Neon based p= acket processing path on routing. >=20 > > ethaddr_tbl[port].dst =3D ETHADDR_TO_UINT64(addr); > > + rte_ether_addr_copy((struct rte_ether_addr *)ðaddr_tbl[port].dst, > > + (struct rte_ether_addr *)(val_eth + port)); > > return 0; > > } > > > > @@ -1865,6 +1884,12 @@ port_init(uint16_t portid, uint64_t > > req_rx_offloads, uint64_t req_tx_offloads) > > portid, rte_strerror(-ret)); > > > > ethaddr_tbl[portid].src =3D ETHADDR_TO_UINT64(ðaddr); >=20 > Fan: Same here >=20 > > + > > + rte_ether_addr_copy((struct rte_ether_addr *)ðaddr_tbl[portid].dst= , > > + (struct rte_ether_addr *)(val_eth + portid)); > > + rte_ether_addr_copy((struct rte_ether_addr *)ðaddr_tbl[portid].src= , > > + (struct rte_ether_addr *)(val_eth + portid) + 1); > > + > > print_ethaddr("Address: ", ðaddr); > > printf("\n");