From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53104A0540; Mon, 4 Jul 2022 14:49:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB402410E5; Mon, 4 Jul 2022 14:49:52 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id D7EC040E09 for ; Mon, 4 Jul 2022 14:49:51 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 264AsQn7001790; Mon, 4 Jul 2022 05:49:48 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3h2nhnnhvp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 04 Jul 2022 05:49:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dcIXz3N5MSNOGFIaaHIkuAL2T8kWozH79+DSzMIQqcicx2FA/xGkG6la9SzYh+f3iXcBjTedqZv1GVVC7reWDFUdjcJQow5m3zao70Y6yuoKRNfcY/Zffl2YDvLRYlfnbncB+jSYjMKxzHENb3wQQz3W/AZ7H+8LAb58blGlPIHw4Y/ij2qSG0FnfJMYaZXiyB6A2tiUMi1KnnbFVUrAqSvuU4/SuirQmymKDwEB5qprt5VipMuolBQy57TX1ODvkIqX7MbfaHo8BsKYcUrOPLV6YfIpXiPd4/214rUvolesKXrZ+CetnfMLjp70rNClSnJpyiGrNsHz/iV0yNxoeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YkUrXbr1JSUseLqcV/xxQZLVo4irH7D2ncnloAx6kUY=; b=WI2bW2OofUZfQdewduNwZhAQxtI1XuUy5IrcuHRTWyaxEbGfRf5RiNqB8ZtFLB7lbHId35iJIOfGjvvgsogL8FXBzEdZTOzdAAYGXcSuC0RbYFo/hTmQsmgAfypE45QPBZQYXnQV7S9pikDCRwP5PMPt91lNZNLPWChwcXTbj2MZr4fqznZFZthTsCCS0QtOCVzk+noAggrdYjLVeUCHvck9X7pjI21OE8EtkSN0OQUnDL8Ouiakt+c7ziqp+vDXRdmK2awMFabF2M1XKNqNdmcw1qBdoR44ngJfN01Jf8EvhZx5UtU6jiDYDrCXj2+XhdDW0rPoNP9mLJTcLBEoeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YkUrXbr1JSUseLqcV/xxQZLVo4irH7D2ncnloAx6kUY=; b=XLiCd5nAOEYebL96VNMeGjTgdO49bXJpWomEgw22rGjo1jDrIZeif/fRVH4fvhpBrZl9p7YHmdiEbmmmv12mZ59ylFd84lDgjG7nDkqNwIjBBJFUDPHoNbBmUpAmHhI0dk2LLpTSDuv3EgiU6IHTmbSlOqG9LHbyBpi/Jk6DLtg= Received: from CO6PR18MB3844.namprd18.prod.outlook.com (2603:10b6:5:340::7) by DM6PR18MB3241.namprd18.prod.outlook.com (2603:10b6:5:1c8::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Mon, 4 Jul 2022 12:49:45 +0000 Received: from CO6PR18MB3844.namprd18.prod.outlook.com ([fe80::c800:c01f:1cac:d1b3]) by CO6PR18MB3844.namprd18.prod.outlook.com ([fe80::c800:c01f:1cac:d1b3%5]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 12:49:44 +0000 From: Rahul Bhansali To: Thomas Monjalon CC: "dev@dpdk.org" , David Christensen , Ruifeng Wang , Bruce Richardson , Konstantin Ananyev , Jerin Jacob Kollanukkaran , Akhil Goyal , "david.marchand@redhat.com" Subject: RE: [EXT] Re: [PATCH v3 1/2] examples/l3fwd: common packet group functionality Thread-Topic: [EXT] Re: [PATCH v3 1/2] examples/l3fwd: common packet group functionality Thread-Index: AQHYhuUCxxBePGbHmkWmIuRKqfUkZK1tPSEAgADzvhA= Date: Mon, 4 Jul 2022 12:49:44 +0000 Message-ID: References: <20220524095717.3875284-1-rbhansali@marvell.com> <20220623093816.254830-1-rbhansali@marvell.com> <7631125.c0te8JeNC1@thomas> In-Reply-To: <7631125.c0te8JeNC1@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8f544a95-655d-494f-315e-08da5dbbabc7 x-ms-traffictypediagnostic: DM6PR18MB3241:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aIGrIqKuXF1Mc1Du949bk8t1vhcMRdQS+FPPx8ClPYDbvc8wpxXZDQharmv40Elct1U6Q5I/ejiSmXIctWE7Ta3CqD7epX2NQXvyqei2HqKTRRXDHl1IlI1b71Spcx2LMnpUOAqfrnzDTJno7FhAFDzikE9n/GjZ1TixkiONisejyb6iZjYL9kj5rvo2f8v6cAaXvhKwEojlabLwMP3YWLORPByi2dQ+wWYHNfhXTWcJ0pYcTnHGeD2KuJ+wN44Hgj3DF1m+KMXl5wjWBfUxVgxfz3Ai5VFuVVC2QWfw9aBUNAH1MMNh+wgUH+lSvvah/jZlg9y98ybA9W/YabHjTeoKdjpJcq40ET4Q1bZ2cu26OXCZWxwU9k66VhRliPFkH0EdbvdiWATmctheCtcm14UCUHTDNRWgONfjSxbyPhHfwCU/JKg64RKoVtnEurSntIzwHT8uj6zdoJaVIymZCdXem5E7Fm8gkzGB206Z0YDrLwW6jEwg1suC1tks827q+G429b4XFueNwD9wo9XyOsRBLUIWFXN+Eh1NaHygUPb5KC8dbEgdm/uT8tVz1K3cwHaIc1Y7C5UXUo9wk2EiScKzKLR518H7O337tNV5qso84qcGWrzcdX5/gG9ND1AOR1R876x4wk2twttdBFj7JRH3AztAKRCWvcAOfMZfviHX2h/aDAGZI/QCttINDY21GbsSmiGglHDdWjNONzaNLvNuhftLtGa9SVOrUmkeakQhSflfc4/JP2/gmlaZo87H+v5YT5bbVrTFXqYcxxWWXs5JpNsvekc8t8s3RaEaSZWiH0ZwafOQp6MCbf+PrSjJ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB3844.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(376002)(366004)(136003)(396003)(346002)(39860400002)(38070700005)(71200400001)(66446008)(41300700001)(54906003)(64756008)(66946007)(66556008)(76116006)(4326008)(86362001)(122000001)(8676002)(478600001)(6916009)(66476007)(316002)(186003)(33656002)(83380400001)(55236004)(6506007)(26005)(38100700002)(9686003)(53546011)(8936002)(52536014)(7696005)(55016003)(5660300002)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sTr6EPy5gKBfL60p2dB61mZBXq6st367zfePGG6QAJTvoHj4QegpmgwTjDH7?= =?us-ascii?Q?6WeAluyIYxxNlVj/i1+BS+kZPrrLlYcRG4tY5J3zIQpOpsf+7olbubQZrPXm?= =?us-ascii?Q?rxgDxEPnnkbveLqGFuO0wklqcbEPMynuegxCmbsv5K+svAzygmGX7QsQzr56?= =?us-ascii?Q?hYWwL9WtlwloxkOrnusFFu1LHAYH3mnLSvviDJ9Ox6G8WGi7BMRrpHyViva8?= =?us-ascii?Q?711mNJPCjCZfqpOvbRmY38PqkqeV6XLiWO8oxy1A43TCykyzZNcD76TvRxdG?= =?us-ascii?Q?NhznidaM02LwKXgxgyYxgu0NMWYLTo2yN4NssgghRQM/AsHGSUvvCE1h6gh6?= =?us-ascii?Q?5gI97AoWr41DEMM22YW/5LpU3iP24xbMJgN+KNikoF1MZVsQD/Pn89WSBIbI?= =?us-ascii?Q?ZcdYwxkJfHfbltSvYFhW5oJyC4pU59NpLfxCqde0bukHovoXwzv8AYpaYXiy?= =?us-ascii?Q?rO4qXaSPhykd7Cj+r5K2rGD8qr7NgHtXCoUG41XGFidNSbcx5LmuNS7b2efC?= =?us-ascii?Q?hz9TEiC5QEGQYxaXmOozR8AbdrlS96mYlHmNRjlX2ftCFgarvAxVrwwU7MCN?= =?us-ascii?Q?3MAIU7Y3L8MRrQIhXaLjUdlN/2BOa9SWy6ZXIwujGEi5SpSRuNydTbJBjWpP?= =?us-ascii?Q?XhEi08neMAqkHeK/Kbx59cLNcYZ/CrEzvA0BktyvQJ7Vp6Yl1QJKDWaGTcw0?= =?us-ascii?Q?yeC1La0tO9KzS+aWCKbZI4TqMBuny5TuorhDKiCq3NXB83jSR6U1sMBPtvGW?= =?us-ascii?Q?yX0t/JS0D+kY2f+XIuGzqNnReFizCjkI5CwAmzE0qBKbrbDhVRbGreTgGzWq?= =?us-ascii?Q?ubZMhPAks0QG32NZGcdklen3SLbUfkgRGdWLoHubsHWLr0rGXw1LtS12XXjj?= =?us-ascii?Q?joX/d7xZ2GCnUK89X18UUfeT8x+z0l+PZnEIVaYQDTQNmTqi5BH276czCmN2?= =?us-ascii?Q?SLjUL2aNJgPXhiqVxOpgA6XsGV0RJSiFc3RvpHdA8tF7Hzr4VE/UeTOj05k/?= =?us-ascii?Q?9uDO1qH1cdBeMgebmAADVGdxFN+UvZKw6bzEuigazkVhHHyiyV7NyUOlL+bR?= =?us-ascii?Q?RNuJ/2SbDSgGdhtueuWnLGJZiN1rPT+MohfkU+Cf2ewWuLVD7qWL3Dz5Py4g?= =?us-ascii?Q?uCycGaSWzuo7SgY6DqbAokz+vDfT3iylWrJSqizzkcb7nT5oWJzW3UOgPilw?= =?us-ascii?Q?QfVe3aPUhHwZd+WAwkJbyGv1BHGf8y3vxPILOH10PoJ7WTgpj1NkrxArKfRh?= =?us-ascii?Q?9ZfbeqagaXRZR+N3Mg0dRtuh3nhTtwezrqn5wmID51EKdCH9Z87PUpW3OULQ?= =?us-ascii?Q?qqo+bgXBA0W1I1zApadM7wYb8TT1I7IuBV5Ka2NrmmTz3QLmHwnZ7305tPN/?= =?us-ascii?Q?gSEMId80mGN34ITCGP7GTz3bQS8Ge+MP+XWHHkrv1Fw12Ae4dfl5Mkiu/TNG?= =?us-ascii?Q?o+8xAD3YRTKA8CJ/YIUL64qHc/HlvNWfL0ekxOWC3I+wteeNQy7jtNI+F4sb?= =?us-ascii?Q?QCERDGpsfWga3P14vDG0P6X7t5bQd+XaEHlVi+1RMqW/Qw2c6WOnO3WqMp+8?= =?us-ascii?Q?2um0F2GHlldwENNo4eNJbg4Z4kUOlBuA5P+HaEpS?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB3844.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f544a95-655d-494f-315e-08da5dbbabc7 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2022 12:49:44.7947 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6ys6ZfZh4eBqZOI+JWE/uuroj/OPH3/Bx7y5CrEdwVFcOyNKpwM1zRbiWHLSfBtlMsIYZp++wFGS7L/eVJ0gdw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3241 X-Proofpoint-ORIG-GUID: nTtNsdP56AoxYQ2zofVquZHNq0tEGiNM X-Proofpoint-GUID: nTtNsdP56AoxYQ2zofVquZHNq0tEGiNM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-04_11,2022-06-28_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, July 4, 2022 3:10 AM > To: Rahul Bhansali > Cc: dev@dpdk.org; David Christensen ; Ruifeng Wan= g > ; Bruce Richardson ; > Konstantin Ananyev ; Jerin Jacob > Kollanukkaran ; Akhil Goyal ; > david.marchand@redhat.com > Subject: [EXT] Re: [PATCH v3 1/2] examples/l3fwd: common packet group > functionality >=20 > External Email >=20 > ---------------------------------------------------------------------- > 23/06/2022 11:38, Rahul Bhansali: > > This will make the packet grouping function common, so that other > > examples can utilize as per need. > > > > For each architecture sse/neon/altivec, port group headers will be > > created under examples/common/. > > > > Signed-off-by: Rahul Bhansali > > --- > > Changes in v3: Created common port-group headers for architectures > > sse/neon/altivec as suggested by Konstantin. > > > > Changes in v2: New patch to address review comment. > > > > examples/common/altivec/port_group.h | 48 +++++++++ > > examples/common/neon/port_group.h | 50 ++++++++++ > > examples/common/pkt_group.h | 139 +++++++++++++++++++++++++++ > > examples/common/sse/port_group.h | 47 +++++++++ > > examples/l3fwd/Makefile | 5 +- > > examples/l3fwd/l3fwd.h | 2 - > > examples/l3fwd/l3fwd_altivec.h | 37 +------ > > examples/l3fwd/l3fwd_common.h | 129 +------------------------ > > examples/l3fwd/l3fwd_neon.h | 39 +------- > > examples/l3fwd/l3fwd_sse.h | 36 +------ > > examples/meson.build | 2 +- >=20 > OK you move code from l3fwd to another place. > That's probably a step in the right direction. > What about taking the extra step of making it an EAL API? Thanks for the suggestion. These changes are specific to fast path and I th= ink EAL is more focused towards control path (Correct me if I am wrong). Instead of EAL API, we can have it in library, but currently these are very= few changes to form a library.=20 Later in future if we can identify more such common APIs then we can form a= library around these specific things, so that more examples/app/library ca= n use it. Please suggest if this makes sense. >=20 >=20 >=20