From: Rahul Bhansali <rbhansali@marvell.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [EXT] Re: [PATCH] examples/l2fwd: add check of Rx packets count
Date: Wed, 2 Nov 2022 13:47:49 +0000 [thread overview]
Message-ID: <CO6PR18MB38448FD6087D6C7951B7AECEB8399@CO6PR18MB3844.namprd18.prod.outlook.com> (raw)
In-Reply-To: <CO6PR18MB3844D05292DBF6A9E281DBACB8469@CO6PR18MB3844.namprd18.prod.outlook.com>
Ping.
> -----Original Message-----
> From: Rahul Bhansali
> Sent: Wednesday, September 14, 2022 4:04 PM
> To: 'Thomas Monjalon' <thomas@monjalon.net>; 'dev@dpdk.org'
> <dev@dpdk.org>
> Cc: 'Bruce Richardson' <bruce.richardson@intel.com>; 'ferruh.yigit@xilinx.com'
> <ferruh.yigit@xilinx.com>; 'ajit.khaparde@broadcom.com'
> <ajit.khaparde@broadcom.com>; 'aboyer@pensando.io'
> <aboyer@pensando.io>; 'andrew.rybchenko@oktetlabs.ru'
> <andrew.rybchenko@oktetlabs.ru>; 'beilei.xing@intel.com'
> <beilei.xing@intel.com>; 'chas3@att.com' <chas3@att.com>;
> 'chenbo.xia@intel.com' <chenbo.xia@intel.com>; 'ciara.loftus@intel.com'
> <ciara.loftus@intel.com>; Devendra Singh Rawat <dsinghrawat@marvell.com>;
> 'ed.czeck@atomicrules.com' <ed.czeck@atomicrules.com>;
> 'evgenys@amazon.com' <evgenys@amazon.com>; 'grive@u256.net'
> <grive@u256.net>; 'g.singh@nxp.com' <g.singh@nxp.com>;
> 'zhouguoyang@huawei.com' <zhouguoyang@huawei.com>;
> 'haiyue.wang@intel.com' <haiyue.wang@intel.com>; Harman Kalra
> <hkalra@marvell.com>; 'heinrich.kuhn@corigine.com'
> <heinrich.kuhn@corigine.com>; 'hemant.agrawal@nxp.com'
> <hemant.agrawal@nxp.com>; 'hyonkim@cisco.com' <hyonkim@cisco.com>;
> 'igorch@amazon.com' <igorch@amazon.com>; Igor Russkikh
> <irusskikh@marvell.com>; 'jgrajcia@cisco.com' <jgrajcia@cisco.com>;
> 'jasvinder.singh@intel.com' <jasvinder.singh@intel.com>;
> 'jianwang@trustnetic.com' <jianwang@trustnetic.com>;
> 'jiawenwu@trustnetic.com' <jiawenwu@trustnetic.com>;
> 'jingjing.wu@intel.com' <jingjing.wu@intel.com>; 'johndale@cisco.com'
> <johndale@cisco.com>; 'john.miller@atomicrules.com'
> <john.miller@atomicrules.com>; 'linville@tuxdriver.com'
> <linville@tuxdriver.com>; 'keith.wiles@intel.com' <keith.wiles@intel.com>;
> Kiran Kumar Kokkilagadda <kirankumark@marvell.com>; 'oulijun@huawei.com'
> <oulijun@huawei.com>; Liron Himi <lironh@marvell.com>;
> 'longli@microsoft.com' <longli@microsoft.com>; 'mw@semihalf.com'
> <mw@semihalf.com>; 'spinler@cesnet.cz' <spinler@cesnet.cz>;
> 'matan@nvidia.com' <matan@nvidia.com>; 'matt.peters@windriver.com'
> <matt.peters@windriver.com>; 'maxime.coquelin@redhat.com'
> <maxime.coquelin@redhat.com>; 'mk@semihalf.com' <mk@semihalf.com>;
> 'humin29@huawei.com' <humin29@huawei.com>; Pradeep Kumar Nalla
> <pnalla@marvell.com>; Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>;
> 'qiming.yang@intel.com' <qiming.yang@intel.com>; 'qi.z.zhang@intel.com'
> <qi.z.zhang@intel.com>; Radha Chintakuntla <radhac@marvell.com>;
> 'rahul.lakkireddy@chelsio.com' <rahul.lakkireddy@chelsio.com>; Rasesh Mody
> <rmody@marvell.com>; 'rosen.xu@intel.com' <rosen.xu@intel.com>;
> 'sachin.saxena@oss.nxp.com' <sachin.saxena@oss.nxp.com>; Satha Koteswara
> Rao Kottidi <skoteshwar@marvell.com>; 'Shahed Shaikh'
> <shshaikh@marvell.com>; 'shaibran@amazon.com' <shaibran@amazon.com>;
> 'shepard.siegel@atomicrules.com' <shepard.siegel@atomicrules.com>;
> 'asomalap@amd.com' <asomalap@amd.com>;
> 'somnath.kotur@broadcom.com' <somnath.kotur@broadcom.com>;
> 'sthemmin@microsoft.com' <sthemmin@microsoft.com>;
> 'steven.webster@windriver.com' <steven.webster@windriver.com>; Sunil
> Kumar Kori <skori@marvell.com>; 'mtetsuyah@gmail.com'
> <mtetsuyah@gmail.com>; Veerasenareddy Burru <vburru@marvell.com>;
> 'viacheslavo@nvidia.com' <viacheslavo@nvidia.com>; 'xiao.w.wang@intel.com'
> <xiao.w.wang@intel.com>; 'cloud.wangxiaoyun@huawei.com'
> <cloud.wangxiaoyun@huawei.com>; 'yisen.zhuang@huawei.com'
> <yisen.zhuang@huawei.com>; 'yongwang@vmware.com'
> <yongwang@vmware.com>; 'xuanziyang2@huawei.com'
> <xuanziyang2@huawei.com>
> Subject: RE: [EXT] Re: [PATCH] examples/l2fwd: add check of Rx packets count
>
> Hi Thomas,
>
> This got ack from Stephen Hemminger also. It is pending from long time, Can we
> consider this for RC1 ?
>
> Regards,
> Rahul
>
> > -----Original Message-----
> > From: Rahul Bhansali
> > Sent: Wednesday, July 20, 2022 10:22 PM
> > To: Thomas Monjalon <thomas@monjalon.net>; dev@dpdk.org
> > Cc: Bruce Richardson <bruce.richardson@intel.com>;
> > ferruh.yigit@xilinx.com; ajit.khaparde@broadcom.com;
> > aboyer@pensando.io; andrew.rybchenko@oktetlabs.ru;
> > beilei.xing@intel.com; chas3@att.com; chenbo.xia@intel.com;
> > ciara.loftus@intel.com; Devendra Singh Rawat
> > <dsinghrawat@marvell.com>; ed.czeck@atomicrules.com;
> > evgenys@amazon.com; grive@u256.net; g.singh@nxp.com;
> > zhouguoyang@huawei.com; haiyue.wang@intel.com; Harman Kalra
> > <hkalra@marvell.com>; heinrich.kuhn@corigine.com;
> > hemant.agrawal@nxp.com; hyonkim@cisco.com; igorch@amazon.com; Igor
> > Russkikh <irusskikh@marvell.com>; jgrajcia@cisco.com;
> > jasvinder.singh@intel.com; jianwang@trustnetic.com;
> > jiawenwu@trustnetic.com; jingjing.wu@intel.com; johndale@cisco.com;
> > john.miller@atomicrules.com; linville@tuxdriver.com;
> > keith.wiles@intel.com; Kiran Kumar Kokkilagadda
> > <kirankumark@marvell.com>; oulijun@huawei.com; Liron Himi
> > <lironh@marvell.com>; longli@microsoft.com; mw@semihalf.com;
> > spinler@cesnet.cz; matan@nvidia.com; matt.peters@windriver.com;
> > maxime.coquelin@redhat.com; mk@semihalf.com; humin29@huawei.com;
> > Pradeep Kumar Nalla <pnalla@marvell.com>; Nithin Kumar Dabilpuram
> > <ndabilpuram@marvell.com>; qiming.yang@intel.com;
> > qi.z.zhang@intel.com; Radha Chintakuntla <radhac@marvell.com>;
> > rahul.lakkireddy@chelsio.com; Rasesh Mody <rmody@marvell.com>;
> > rosen.xu@intel.com; sachin.saxena@oss.nxp.com; Satha Koteswara Rao
> > Kottidi <skoteshwar@marvell.com>; Shahed Shaikh
> > <shshaikh@marvell.com>; shaibran@amazon.com;
> > shepard.siegel@atomicrules.com; asomalap@amd.com;
> > somnath.kotur@broadcom.com; sthemmin@microsoft.com;
> > steven.webster@windriver.com; Sunil Kumar Kori <skori@marvell.com>;
> > mtetsuyah@gmail.com; Veerasenareddy Burru <vburru@marvell.com>;
> > viacheslavo@nvidia.com; xiao.w.wang@intel.com;
> > cloud.wangxiaoyun@huawei.com; yisen.zhuang@huawei.com;
> > yongwang@vmware.com; xuanziyang2@huawei.com
> > Subject: RE: [EXT] Re: [PATCH] examples/l2fwd: add check of Rx packets
> > count
> >
> > Ping
> >
> > > -----Original Message-----
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > Sent: Monday, June 27, 2022 2:42 AM
> > > To: dev@dpdk.org
> > > Cc: Bruce Richardson <bruce.richardson@intel.com>;
> > > ferruh.yigit@xilinx.com; ajit.khaparde@broadcom.com;
> > > aboyer@pensando.io; andrew.rybchenko@oktetlabs.ru;
> > > beilei.xing@intel.com; chas3@att.com; chenbo.xia@intel.com;
> > > ciara.loftus@intel.com; Devendra Singh Rawat
> > > <dsinghrawat@marvell.com>; ed.czeck@atomicrules.com;
> > > evgenys@amazon.com; grive@u256.net; g.singh@nxp.com;
> > > zhouguoyang@huawei.com; haiyue.wang@intel.com; Harman Kalra
> > > <hkalra@marvell.com>; heinrich.kuhn@corigine.com;
> > > hemant.agrawal@nxp.com; hyonkim@cisco.com; igorch@amazon.com;
> Igor
> > > Russkikh <irusskikh@marvell.com>; jgrajcia@cisco.com;
> > > jasvinder.singh@intel.com; jianwang@trustnetic.com;
> > > jiawenwu@trustnetic.com; jingjing.wu@intel.com; johndale@cisco.com;
> > > john.miller@atomicrules.com; linville@tuxdriver.com;
> > > keith.wiles@intel.com; Kiran Kumar Kokkilagadda
> > > <kirankumark@marvell.com>; oulijun@huawei.com; Liron Himi
> > > <lironh@marvell.com>; longli@microsoft.com; mw@semihalf.com;
> > > spinler@cesnet.cz; matan@nvidia.com; matt.peters@windriver.com;
> > > maxime.coquelin@redhat.com; mk@semihalf.com; humin29@huawei.com;
> > > Pradeep Kumar Nalla <pnalla@marvell.com>; Nithin Kumar Dabilpuram
> > > <ndabilpuram@marvell.com>; qiming.yang@intel.com;
> > > qi.z.zhang@intel.com; Radha Chintakuntla <radhac@marvell.com>;
> > > rahul.lakkireddy@chelsio.com; Rasesh Mody <rmody@marvell.com>;
> > > rosen.xu@intel.com; sachin.saxena@oss.nxp.com; Satha Koteswara Rao
> > > Kottidi <skoteshwar@marvell.com>; Shahed Shaikh
> > > <shshaikh@marvell.com>; shaibran@amazon.com;
> > > shepard.siegel@atomicrules.com; asomalap@amd.com;
> > > somnath.kotur@broadcom.com; sthemmin@microsoft.com;
> > > steven.webster@windriver.com; Sunil Kumar Kori <skori@marvell.com>;
> > > mtetsuyah@gmail.com; Veerasenareddy Burru <vburru@marvell.com>;
> > > viacheslavo@nvidia.com; xiao.w.wang@intel.com;
> > > cloud.wangxiaoyun@huawei.com; yisen.zhuang@huawei.com;
> > > yongwang@vmware.com; xuanziyang2@huawei.com; Rahul Bhansali
> > > <rbhansali@marvell.com>
> > > Subject: [EXT] Re: [PATCH] examples/l2fwd: add check of Rx packets
> > > count
> > >
> > > External Email
> > >
> > > --------------------------------------------------------------------
> > > -- Please could we have some tests on other hardware with this
> > > improvement?
> > >
> > >
> > > 25/05/2022 11:13, Rahul Bhansali:
> > > > An additional check is added to avoid extra processing if receive
> > > > packets are 0.
> > > >
> > > > Performance impact: with Marvell OCTEON TX2 platform, observed an
> > > > improvement by ~14%.
> > > >
> > > > Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>
> > > > ---
> > > > nb_rx = rte_eth_rx_burst(portid, 0,
> > > > pkts_burst, MAX_PKT_BURST);
> > > >
> > > > + if (unlikely(nb_rx == 0))
> > > > + continue;
> > > > +
> > >
> > >
> > >
next prev parent reply other threads:[~2022-11-02 13:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 9:13 Rahul Bhansali
2022-06-02 7:48 ` Jerin Jacob
2022-06-23 11:09 ` [EXT] " Rahul Bhansali
2022-06-26 21:12 ` Thomas Monjalon
2022-07-20 16:52 ` [EXT] " Rahul Bhansali
2022-09-14 10:34 ` Rahul Bhansali
2022-11-02 13:47 ` Rahul Bhansali [this message]
2022-11-02 15:29 ` Thomas Monjalon
2022-07-20 17:32 ` Stephen Hemminger
2022-11-02 14:09 ` Hemant Agrawal
2022-11-02 15:47 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB38448FD6087D6C7951B7AECEB8399@CO6PR18MB3844.namprd18.prod.outlook.com \
--to=rbhansali@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).