From: Sunil Kumar Kori <skori@marvell.com>
To: David Marchand <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Jerin Jacob <jerinj@marvell.com>,
Tyler Retzlaff <roretzla@linux.microsoft.com>,
Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: RE: [EXTERNAL] [PATCH v4 4/5] trace: support expression for blob length
Date: Wed, 5 Mar 2025 05:20:54 +0000 [thread overview]
Message-ID: <CO6PR18MB386053E2F2EE694D8B185178B4CB2@CO6PR18MB3860.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20250304160633.385185-5-david.marchand@redhat.com>
> Support any expression as a blob length by using an intermediate variable in
> the trace point emitter itself.
> This also avoids any side effect on the passed variable.
>
> On the "register" side, prefix the length variable in the trace metadata with
> the name of the emitted argument.
>
> With this, we can update ethdev traces and avoid intermediate variables.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Changes since v2:
> - fixed length field in CTF metadata,
>
> Changes since v1:
> - removed code relying on arguments in "registering"
> rte_trace_point_emit_blob implementation (see patch 3),
> - moved build check in non registering __rte_trace_point_emit,
>
> ---
> lib/eal/include/rte_trace_point.h | 12 ++++++----
> lib/eal/include/rte_trace_point_register.h | 6 ++++-
> lib/ethdev/ethdev_trace.h | 27 ++++++----------------
> 3 files changed, 19 insertions(+), 26 deletions(-)
>
> 2.48.1
Acked-by: Sunil Kumar Kori <skori@marvell.com>
next prev parent reply other threads:[~2025-03-05 5:21 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 16:14 [PATCH 1/2] " David Marchand
2025-01-24 16:14 ` [PATCH 2/2] dmadev: avoid copies in tracepoints David Marchand
2025-01-27 8:25 ` [EXTERNAL] [PATCH 1/2] trace: support expression for blob length Jerin Jacob
2025-01-30 14:58 ` [PATCH v2 1/3] " David Marchand
2025-01-30 14:58 ` [PATCH v2 2/3] dmadev: avoid copies in tracepoints David Marchand
2025-01-30 14:58 ` [PATCH v2 3/3] trace: fix undefined behavior in register David Marchand
2025-01-30 19:10 ` Stephen Hemminger
2025-01-30 21:06 ` David Marchand
2025-02-07 8:49 ` David Marchand
2025-02-07 11:39 ` [EXTERNAL] " Sunil Kumar Kori
2025-02-10 9:02 ` Sunil Kumar Kori
2025-02-10 9:36 ` David Marchand
2025-02-10 13:37 ` [EXTERNAL] " Jerin Jacob
2025-02-10 14:04 ` David Marchand
2025-02-10 13:38 ` [EXTERNAL] [PATCH v2 1/3] trace: support expression for blob length Jerin Jacob
2025-02-10 17:44 ` [PATCH v3 0/6] Trace point framework enhancement for dmadev David Marchand
2025-02-10 17:44 ` [PATCH v3 1/6] ci: check traces validity David Marchand
2025-02-10 17:44 ` [PATCH v3 2/6] trace: support dereferencing arguments David Marchand
2025-02-11 8:44 ` [EXTERNAL] " Sunil Kumar Kori
2025-02-11 9:53 ` David Marchand
2025-02-12 5:08 ` Sunil Kumar Kori
2025-02-10 17:44 ` [PATCH v3 3/6] trace: support expression for blob length David Marchand
2025-02-10 17:44 ` [PATCH v3 4/6] trace: support dumping binary inside a struct David Marchand
2025-02-11 8:52 ` [EXTERNAL] " Sunil Kumar Kori
2025-02-11 9:54 ` David Marchand
2025-02-12 5:14 ` Sunil Kumar Kori
2025-02-18 14:28 ` David Marchand
2025-02-19 11:17 ` Jerin Jacob
2025-02-10 17:44 ` [PATCH v3 5/6] dmadev: avoid copies in tracepoints David Marchand
2025-02-10 17:44 ` [PATCH v3 6/6] trace: fix undefined behavior in register David Marchand
2025-02-11 8:41 ` [EXTERNAL] [PATCH v3 0/6] Trace point framework enhancement for dmadev Sunil Kumar Kori
2025-03-04 16:06 ` [PATCH v4 0/5] " David Marchand
2025-03-04 16:06 ` [PATCH v4 1/5] ci: check traces validity David Marchand
2025-03-04 16:06 ` [PATCH v4 2/5] dmadev: avoid copies in tracepoints David Marchand
2025-03-04 16:06 ` [PATCH v4 3/5] trace: support dereferencing pointers David Marchand
2025-03-05 5:19 ` [EXTERNAL] " Sunil Kumar Kori
2025-03-04 16:06 ` [PATCH v4 4/5] trace: support expression for blob length David Marchand
2025-03-05 5:20 ` Sunil Kumar Kori [this message]
2025-03-04 16:06 ` [PATCH v4 5/5] trace: fix undefined behavior in register David Marchand
2025-03-05 5:20 ` [EXTERNAL] " Sunil Kumar Kori
2025-03-05 17:49 ` [PATCH v4 0/5] Trace point framework enhancement for dmadev David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB386053E2F2EE694D8B185178B4CB2@CO6PR18MB3860.namprd18.prod.outlook.com \
--to=skori@marvell.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=jerinj@marvell.com \
--cc=roretzla@linux.microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).