From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45795A0543; Thu, 22 Sep 2022 13:00:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D25FE40156; Thu, 22 Sep 2022 13:00:27 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id A1BFC400D7; Thu, 22 Sep 2022 13:00:26 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28M7h2Vr032186; Thu, 22 Sep 2022 04:00:25 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2171.outbound.protection.outlook.com [104.47.56.171]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3jr1qmmpas-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Sep 2022 04:00:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CCYv3oezX0RuIEhpLoBhYGQh/43ecKQnBD7rWzc+2B5sBHhQTRSBuGm8MGMIn1FZY8alJrQG9sR315BgN531lUF1B/wBizsSmhjxv9njc2K5MoDZBp5qTNkwk3C3mKxihx1Y688noVMMprH8dMq5ZYUds9lu6Y2vAMdT5GDEZfClVqKEt4X1U1fo5IMy4V2oF2TEsIvjTnBYyhnTszQTcrPQQIEMq12Fg25BfoZ789D6yLzuF77FS6YZJGcOAMLqp2L2dbeLDrvUPo8q/a+bsiNKyO+cvRd6gatgbbZzaL9zNV7rRo9uaJPtFwyajP/fWUVOSuMmVoMom9qOMFFCsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vg+glNPuwldZPHAqeVwUiIQ2gyrhE84jfMo78jnED7M=; b=HWfLjo8vHRoblSzwicxjHUap9xQXYJAw/kAVFg0FZ5ZOexx9D2T7csj4ejLEhW9xg1OT1BmzlhjOIeTRq0G9eBU6eKPajyKR6VGBBZpZpuTGRzOQtABTlvd2ojaZxHaCGoKliGYPMmIqb1HMraEd0fNTclBx2ysMgX2KajXVVcvpXg7a5uWCXJ2f1H4UWzYsUCY7RPre/2tfUXTGdaXCV4ReM0lhVU6qMc1rDw6Of41XWGXbgXoVSqOoCYRW5ZVwvekWYHDqt834dsOmG75cT3SjsIOdo8eGtU47CkGtENdVQAw5OlF4i/SPChHAT0QIOZSo1FlucfDkWGbFF6Vbxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vg+glNPuwldZPHAqeVwUiIQ2gyrhE84jfMo78jnED7M=; b=TNzmGqOkGg80VgBhzDffJihB1UxWnn5cF1taf4gSUgVuYhSk+hIuZW8XZIbMj8Jp5ozvC8Zj/+uugdIk6QpVt/8KTEgUUGlr5Ez/KsZZGOpYwEYKd3YqWFDDnukUnvXXtwJRwRoGaezTPbGqjXI8Cep7Hqi7OXTgkT1KEs9hkxQ= Received: from CO6PR18MB3860.namprd18.prod.outlook.com (2603:10b6:5:34d::12) by SN7PR18MB3997.namprd18.prod.outlook.com (2603:10b6:806:105::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.19; Thu, 22 Sep 2022 11:00:22 +0000 Received: from CO6PR18MB3860.namprd18.prod.outlook.com ([fe80::90e5:b580:882e:96bc]) by CO6PR18MB3860.namprd18.prod.outlook.com ([fe80::90e5:b580:882e:96bc%5]) with mapi id 15.20.5654.016; Thu, 22 Sep 2022 11:00:22 +0000 From: Sunil Kumar Kori To: David Marchand , "dev@dpdk.org" CC: "stable@dpdk.org" , Jerin Jacob Kollanukkaran Subject: RE: [EXT] [PATCH 3/8] trace: fix leak with regexp Thread-Topic: [EXT] [PATCH 3/8] trace: fix leak with regexp Thread-Index: AQHYzbJQaUmI5dj8B0qC50663uLBEa3rRu8Q Date: Thu, 22 Sep 2022 11:00:22 +0000 Message-ID: References: <20220921120359.2201131-1-david.marchand@redhat.com> <20220921120359.2201131-4-david.marchand@redhat.com> In-Reply-To: <20220921120359.2201131-4-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-rorf: true x-dg-ref: =?us-ascii?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcc2tvcmlcYXBw?= =?us-ascii?Q?ZGF0YVxyb2FtaW5nXDA5ZDg0OWI2LTMyZDMtNGE0MC04NWVlLTZiODRiYTI5?= =?us-ascii?Q?ZTM1Ylxtc2dzXG1zZy1iZTM4ZTMwMC0zYTY1LTExZWQtYjZiZC05NGU2Zjc5?= =?us-ascii?Q?MjY4OTBcYW1lLXRlc3RcYmUzOGUzMDEtM2E2NS0xMWVkLWI2YmQtOTRlNmY3?= =?us-ascii?Q?OTI2ODkwYm9keS50eHQiIHN6PSIyMzc0IiB0PSIxMzMwODMxODAxODc2NTA0?= =?us-ascii?Q?NjgiIGg9IjF5cE9vclhhb3lFTGFzZkZ4UzJxQmhTMlJzdz0iIGlkPSIiIGJs?= =?us-ascii?Q?PSIwIiBibz0iMSIgY2k9ImNBQUFBRVJIVTFSU1JVRk5DZ1VBQVA0RkFBQ2tD?= =?us-ascii?Q?YXFBY3M3WUFWTnpsRlJWSWZ2MlUzT1VWRlVoKy9ZSkFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFIQUFBQUNPQlFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFF?= =?us-ascii?Q?QUFRQUJBQUFBNlBxZWxBQUFBQUFBQUFBQUFBQUFBSjRBQUFCaEFHUUFaQUJ5?= =?us-ascii?Q?QUdVQWN3QnpBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVB?= =?us-ascii?Q?QUFBQUFBQUFBZ0FBQUFBQW5nQUFBR01BZFFCekFIUUFid0J0QUY4QWNBQmxB?= =?us-ascii?Q?SElBY3dCdkFHNEFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQWdBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFB?= =?us-ascii?Q?QUNlQUFBQVl3QjFBSE1BZEFCdkFHMEFYd0J3QUdnQWJ3QnVBR1VBYmdCMUFH?= =?us-ascii?Q?MEFZZ0JsQUhJQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJqQUhVQWN3?= =?us-ascii?Q?QjBBRzhBYlFCZkFITUFjd0J1QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refone: =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFBQUFBbmdBQUFHUUFi?= =?us-ascii?Q?QUJ3QUY4QWN3QnJBSGtBY0FCbEFGOEFZd0JvQUdFQWRBQmZBRzBBWlFCekFI?= =?us-ascii?Q?TUFZUUJuQUdVQVh3QjJBREFBTWdBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQUFBWkFCc0FIQUFYd0J6QUd3QVlR?= =?us-ascii?Q?QmpBR3NBWHdCakFHZ0FZUUIwQUY4QWJRQmxBSE1BY3dCaEFHY0FaUUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUJBQUFBQUFBQUFB?= =?us-ascii?Q?SUFBQUFBQUo0QUFBQmtBR3dBY0FCZkFIUUFaUUJoQUcwQWN3QmZBRzhBYmdC?= =?us-ascii?Q?bEFHUUFjZ0JwQUhZQVpRQmZBR1lBYVFCc0FHVUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdV?= =?us-ascii?Q?QWJRQmhBR2tBYkFCZkFHRUFaQUJrQUhJQVpRQnpBSE1BQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUJ3QUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFDZUFBQUFiUUJoQUhJQWRnQmxBR3dB?= =?us-ascii?Q?YkFCZkFIUUFaUUJ5QUcwQWFRQnVBSFVBY3dBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?us-ascii?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reftwo: QUFBQUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBQT09Ii8+PC9tZXRhPg== x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR18MB3860:EE_|SN7PR18MB3997:EE_ x-ms-office365-filtering-correlation-id: 84a1253b-a064-4067-7a50-08da9c89a52a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BZ05sfrTG31ld0OMqeLNxqr055+4TDnCH2ZHMQAMtUOTAoW1yOR3xEAT10rY5W2cC/g0m7WKZHceVBGrjCX2AgKkoM7/sgxe8HJZ310hO7V9RNOlkTqKPRncbxsQybTcPqwtZ2Fgk0oyOla7nVl0LsIv5fTJ/z9vY7o0HNjPAaO42J8v9UHk4b8VApBWAtXJm8KP9F5skRY/PiHpmXMU13VMcsi18WuM1in2w6lJSgiAw/cX7hDUHxhT8x7XSkHYkXGD6akNDl59DKUmgUSy97g5jkhALdPxMArQn9DG+Hi/aJbgquwPMvlhgPaUAdJ/P3s+dWQCBcF0IRMLYx8Xlj45GB6jUquk2cSNkPNR5Cv+LUUPwUOdgVL0roINLhzgYFXJoUvuWWQ0PgE+1+tKtKYiKTsB4Rwmlr6NIux+x0tZ4EYlhI2Z1R/hlu5cO2BKGHh3FdwuKC5wNBAzK6Gcdo8S2T4yABLPxGJFeAAb1NFgMw9FcMzfmijAGlehVNp0c115WxxQzB7h/Py4Ij2K0kAZa0UoxiK4F4ly2C0TKaKFiyfLKk6gTnhUtz3do50QNQBzdcgLT6T1ARRuP1aL4dAWFaRKJgit9yvSFkNkHtjWw6thYzxHRywt47keK4cf1XltoA27zoW/xJM/uu/EJjogZTZ+cn0bWJEKl28Ky6vc7pR8riDK+R466U4xux/OIkQh7fQdiTBcQTgb2XnT+Dm3+3/aeRYLDP6i1TshDJ4U53pWnvUQBI9IkMi+BlkE60VRyAKt3QfkPJdr36ULiA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB3860.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(376002)(39860400002)(366004)(346002)(396003)(451199015)(41300700001)(52536014)(8936002)(38100700002)(55016003)(122000001)(66946007)(66446008)(66476007)(66556008)(64756008)(76116006)(8676002)(4326008)(33656002)(86362001)(5660300002)(38070700005)(2906002)(9686003)(26005)(6506007)(7696005)(53546011)(186003)(478600001)(71200400001)(107886003)(316002)(83380400001)(54906003)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jm8HvNLN7gpE2sFWbm5tfEcimDz+y04/Ca9/nR68AROuXqqCMqG4WDU8eURQ?= =?us-ascii?Q?bj8O4ykF46E+0wjI5RQxPah6b1+mpIeJEXginZYwvWeuSrmslBW/hL0siaPQ?= =?us-ascii?Q?dJ0DPzpkF8M5WxOoQwp69qG8ge6+Kf1QPzFSPs+ZZy9DTvzp6LrZ/yyAJ219?= =?us-ascii?Q?5bOUo1JTVlVy4iIal//rD1ybUrtzitSteI8jLWUYGK+gFyKX7vNeF3DN7pea?= =?us-ascii?Q?Sr2TQxAuELOt/tTocLQujAj6H6I9mnVE+1vTpcetllrdUg99CWKLin5+xXJp?= =?us-ascii?Q?Y4ciCm7wyoSOyucSsdkVsGvzH99fvv7rgrjmlw+0JNi7OtDATq7HekKv2Ja5?= =?us-ascii?Q?pjx5ytVCriEzIhAuuD5tvyT1ERCyuARyFIkNvkybzRfnRar4WLAZrpWzPn7C?= =?us-ascii?Q?glAnpdqtIRa1tBE6t8n1ye8riOnO9lV6MTBs2X+4NWss4Yvon4b9uRhOv8W0?= =?us-ascii?Q?pn0iket+PB6sb1wTGzFt4bq3Ztoxkaf5E9J1lpQ7Il8nZOMkNEJNzSMnWzTL?= =?us-ascii?Q?oxhoTtyEuDKm7E2LUGXYr+j29tpPVkxJp6mVF5bbAzat8rH9EIBLEEoUxXvX?= =?us-ascii?Q?5b0n5uunGea5NyLW+N5c9Pat2VWASNoimbn+kxRIDcei5t1I6FUysNNxACUB?= =?us-ascii?Q?NPGSWcacl4x5brlH4dlTiMzjBLtA+U1CIykG1e4fP6uXwIjmRQ9xmCZ5+Wc8?= =?us-ascii?Q?Szn2lWeiaS9wWqj6kP+baWmW64FkCBnp1zuByxOBheQx5+dI9/5FWf1GeNme?= =?us-ascii?Q?DrN+VfDPZRaNgYXl6CXzVHCIyR9+YKfd6Eq8R6jwb2mEiCKtGQ9meq0n8WJz?= =?us-ascii?Q?Uipf0GliPu4jmCzCZxfpbz7YgwRZea/1eXiiClctnt9b0QETolRROpyMdR1R?= =?us-ascii?Q?ZJeuQZZNF/MN2/U8iRvfOggA4HcWG/wiY2NaDWxjb9IwMUbXXoiGiqMxY6w5?= =?us-ascii?Q?gZXH7WAOA6wlddLmRm4b4DMruhfZ7dZ/r5XLsYrS0E76zwv3Rc7LtWX+JUKa?= =?us-ascii?Q?b2K4lKxYPM59aHT8lxcPc9SzWx8h5zDKNjpriEQMRyqn2V8LobgTTCJjerg7?= =?us-ascii?Q?IhqiwBCxj+zv2d7pnP81JrOUPutRkkdfob86h9DJgqmfLiHehqHYa/CMsurf?= =?us-ascii?Q?V3ED1DSxHi73gwkuEMHImIppEqDp1KAJgDRoXOfOXQCuUm+l2kAtm0yWqbMc?= =?us-ascii?Q?CV3Oge2GAOWDNKe0nwraaDmeYpDZeCNSQ2QY0/99rkWT/KJ0x3RuCqA4ZeUc?= =?us-ascii?Q?8HJsT4KpUTxP2W+noxUmfIQuPH59bQ6sbry4l/6Vs9PEjxiTsfkwR2aeGb8h?= =?us-ascii?Q?jWbhODcJ8AKczGjWsJwJP56dJ+AeFbSBfiRpedmlwAxwOMRaJhuOAwl8eAiG?= =?us-ascii?Q?+El4QA3trtM8GeJiyt42MX0msq85VImAfN1jY16Bt/MwmfFb/pQ0VIks7FA7?= =?us-ascii?Q?Kl2wcuVLFWO322NmtQbfIzk8Jzq1XKFOTtKfEV/mMw4OvMd74esikBX/kTdf?= =?us-ascii?Q?qFNLAmJEva15w/8do6RfmGbBbTHuJA+bS7pD75O9J66+PG58FGwjdmsvBbgO?= =?us-ascii?Q?YUOfybVsIK00HURUEmZhDdVdUUxPopwqQV1lRztO?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB3860.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84a1253b-a064-4067-7a50-08da9c89a52a X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2022 11:00:22.1511 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ow629MixSKu3RPkxj890nvdcpJHGUdI2DSDWCGKrwBwf3/L6fg65CYowUZhFN/qin+BkcQ5xpPZg6biYj67VJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR18MB3997 X-Proofpoint-GUID: b4FjzFk43l8qxwc9ZFWMXYVlnQS7vu4W X-Proofpoint-ORIG-GUID: b4FjzFk43l8qxwc9ZFWMXYVlnQS7vu4W X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-22_06,2022-09-22_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: David Marchand > Sent: Wednesday, September 21, 2022 5:34 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Jerin Jacob Kollanukkaran ; Suni= l > Kumar Kori > Subject: [EXT] [PATCH 3/8] trace: fix leak with regexp >=20 > External Email >=20 > ---------------------------------------------------------------------- > The precompiled buffer initialised in regcomp must be freed before leavin= g > rte_trace_regexp. >=20 > Fixes: 84c4fae4628f ("trace: implement operation APIs") > Cc: stable@dpdk.org >=20 > Signed-off-by: David Marchand > --- > lib/eal/common/eal_common_trace.c | 19 +++++++++++-------- > 1 file changed, 11 insertions(+), 8 deletions(-) >=20 > diff --git a/lib/eal/common/eal_common_trace.c > b/lib/eal/common/eal_common_trace.c > index 1db28a441d..c835b0d16e 100644 > --- a/lib/eal/common/eal_common_trace.c > +++ b/lib/eal/common/eal_common_trace.c > @@ -210,15 +210,18 @@ rte_trace_regexp(const char *regex, bool enable) > return -EINVAL; >=20 > STAILQ_FOREACH(tp, &tp_list, next) { > - if (regexec(&r, tp->name, 0, NULL, 0) =3D=3D 0) { > - if (enable) > - rc =3D rte_trace_point_enable(tp->handle); > - else > - rc =3D rte_trace_point_disable(tp->handle); > - found =3D 1; > + if (regexec(&r, tp->name, 0, NULL, 0) !=3D 0) > + continue; > + > + if (enable) > + rc =3D rte_trace_point_enable(tp->handle); > + else > + rc =3D rte_trace_point_disable(tp->handle); > + if (rc < 0) { > + found =3D 0; > + break; > } > - if (rc < 0) > - return rc; > + found =3D 1; > } > regfree(&r); >=20 > -- I understand the problem addressed by this fix but may be following changes= will be sufficient to fix it. Please highlight, If I am missing. Just trying to reduce the line of change= s. @@ -220,8 +220,10 @@ rte_trace_regexp(const char *regex, bool enable) rc =3D rte_trace_point_disable(tp->handle); found =3D 1; } - if (rc < 0) - return rc; + if (rc < 0) { + found =3D 0; + break; + } } > 2.37.3