RE: [EXT] Re: [PATCH v2 1/1] app/testpmd: support different input color method

[Sunil Kumar Kori <skori@marvell.com>]

> -----Original Message-----
> From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Sent: Tuesday, May 31, 2022 9:12 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Sunil Kumar Kori
> <skori@marvell.com>; Li, Xiaoyun <xiaoyun.li@intel.com>; Singh, Aman
> Deep <aman.deep.singh@intel.com>; Zhang, Yuying
> <yuying.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: [EXT] Re: [PATCH v2 1/1] app/testpmd: support different input color
> method
> 
> External Email
> 
> ----------------------------------------------------------------------
> On 5/25/22 17:41, Dumitrescu, Cristian wrote:
> >
> >
> >> -----Original Message-----
> >> From: skori@marvell.com <skori@marvell.com>
> >> Sent: Wednesday, May 25, 2022 3:37 PM
> >> To: Li, Xiaoyun <xiaoyun.li@intel.com>; Singh, Aman Deep
> >> <aman.deep.singh@intel.com>; Zhang, Yuying
> <yuying.zhang@intel.com>;
> >> Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> >> Cc: dev@dpdk.org; Sunil Kumar Kori <skori@marvell.com>
> >> Subject: [PATCH v2 1/1] app/testpmd: support different input color
> >> method
> >>
> >> From: Sunil Kumar Kori <skori@marvell.com>
> >>
> >> To enable input coloring, based on VLAN or DSCP, patch adds command
> >> line interface to configure the following:
> >>
> >>   - configuring input coloring using VLAN or DSCP while creating
> >>     meter i.e. during rte_mtr_create()
> >>
> >>   - Update VLAN input coloring table at runtime.
> >>
> >>   - configures protocol priorities.
> >>
> >>   - retrieve protocol and priority information
> >>
> >> Depends-on: patch-22751 ("ethdev: mtr: support protocol based input
> >> color
> >> selection")
> >>
> >> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> >> ---
> >> v1..v2:
> >>   - Rebased to branch dpdk-next-net
> >>   - add CLIs for input coloring mechanism
> >>
> >>   app/test-pmd/cmdline.c     |   4 +
> >>   app/test-pmd/cmdline_mtr.c | 558
> >> ++++++++++++++++++++++++++++++++++++-
> >
> > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> >
> 
> The patch breaks build as reported by CI [1].
> Please, fix and send v4 (since since one should be v3 in fact).
> 
> [1]
> https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__patches.dpdk.org_project_dpdk_patch_20220525143716.996398-2D1-
> 2Dskori-
> 40marvell.com_&d=DwICaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=dXeXaAMkP5
> COgn1zxHMyaF1_d9IIuq6vHQO6NrIPjaE&m=lkdKT4ugU3ZTqTy2ee3r4GXH3m
> UCXIAOjWy80VtchoG__s3ty0EDuqXy3jL5y-
> 48&s=XHgyW7qwxFzk4FTe3Ul3gGCFbvRDegKDCAcqr1sAe1g&e=
> 
> Note that you need to rebase on top of dpdk-next-net/main since nearby
> lines change due to static keyword addition. Don't forget to add to newly
> added cmdline_parse_* structs which are used in the file only.

Sure, I will rebase the changes on dpdk-next-net/main after fixing static keyword for
cmdline_parse_*.

Based on build error logs, I am suspecting that source is being compile against the dpdk/main.