From: Sunil Kumar Kori <skori@marvell.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [EXT] [PATCH] buildtools/dpdk-cmdline-gen: fix code gen for IP addresses
Date: Wed, 6 Dec 2023 06:18:35 +0000 [thread overview]
Message-ID: <CO6PR18MB3860C86CB6253094AB46578EB484A@CO6PR18MB3860.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20231205113104.473203-1-bruce.richardson@intel.com>
> -----Original Message-----
> From: Bruce Richardson <bruce.richardson@intel.com>
> Sent: Tuesday, December 5, 2023 5:01 PM
> To: dev@dpdk.org
> Cc: Bruce Richardson <bruce.richardson@intel.com>; stable@dpdk.org;
> Sunil Kumar Kori <skori@marvell.com>
> Subject: [EXT] [PATCH] buildtools/dpdk-cmdline-gen: fix code gen for IP
> addresses
>
> External Email
>
> ----------------------------------------------------------------------
> The C code generated for the tokens for matching IP addresses in
> commandlines was missing the "static" prefix present in the output for the
> other data-types.
>
> Fixes: 37666691e9ed ("buildtools: add a tool to generate cmdline
> boilerplate")
> Cc: stable@dpdk.org
>
> Reported-by: Sunil Kumar Kori <skori@marvell.com>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> buildtools/dpdk-cmdline-gen.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/buildtools/dpdk-cmdline-gen.py b/buildtools/dpdk-cmdline-
> gen.py index 49b03bee4a..bf1253d949 100755
> --- a/buildtools/dpdk-cmdline-gen.py
> +++ b/buildtools/dpdk-cmdline-gen.py
> @@ -71,7 +71,7 @@ def process_command(lineno, tokens, comment):
> elif t_type in ["IP", "IP_ADDR", "IPADDR"]:
> result_struct.append(f"\tcmdline_ipaddr_t {t_name};")
> initializers.append(
> - f"cmdline_parse_token_ipaddr_t cmd_{name}_{t_name}_tok =\n"
> + f"static cmdline_parse_token_ipaddr_t
> cmd_{name}_{t_name}_tok =\n"
> f"\tTOKEN_IPV4_INITIALIZER(struct cmd_{name}_result,
> {t_name});"
> )
> elif t_type.startswith("(") and t_type.endswith(")"):
> --
Acked-by: Sunil Kumar Kori <skori@marvell.com>
> 2.40.1
next prev parent reply other threads:[~2023-12-06 6:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 11:31 Bruce Richardson
2023-12-06 6:18 ` Sunil Kumar Kori [this message]
2023-12-12 10:25 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB3860C86CB6253094AB46578EB484A@CO6PR18MB3860.namprd18.prod.outlook.com \
--to=skori@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).