RE: [dpdk-dev] [EXT] [PATCH 1/5] examples/l2fwd-event: free resources in case of error

[Sunil Kumar Kori <skori@marvell.com>]

Previous mail was destined to me which I believe is not correct.
Updating "To recipient". 

Regards
Sunil Kumar Kori

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Monday, June 12, 2023 10:27 PM
> To: Sunil Kumar Kori <skori@marvell.com>
> Cc: Muhammad Bilal <m.bilal@emumba.com>; declan.doherty@intel.com;
> tomasz.kantecki@intel.com; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>; dev@dpdk.org; jgrajcia@cisco.com;
> vipin.varghese@intel.com
> Subject: Re: [dpdk-dev] [EXT] [PATCH 1/5] examples/l2fwd-event: free
> resources in case of error
> 
> On Tue, 16 Jun 2020 10:38:01 +0000
> Sunil Kumar Kori <skori@marvell.com> wrote:
> 
> > >> >> >>
> > >> >> >> Also I think, it is better to release the relevant resources on error.
> > >> >> >Here I'm solving the problem reported in bugzilla id 437. The
> > >> >> >bug was that if we use --vdev=net_memif with l2fwd application
> > >> >> >(and with its other variants) then a socket is created by memif
> > >> >> >PMD, after rte_eal_init function has run successfully. And if
> > >> >> >an error occurs then the application exits without freeing the
> > >> >> >resources (socket). On running the application 2nd time we get
> > >> >> >an error of "socket
> > >already exists".
> 
> Bottom line: Fix memif, don't wallpaper over the bug by fixing the examples.
> 
> Other user applications, can and do crash. The driver needs to be robust and
> handle that.