From: Srikanth Yalavarthi <syalavarthi@marvell.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Shivah Shankar Shankar Narayan Rao <sshankarnara@marvell.com>,
Srikanth Yalavarthi <syalavarthi@marvell.com>
Subject: RE: [EXT] Re: [PATCH] mldev: remove weak symbols use in type conversions
Date: Mon, 13 Mar 2023 11:37:57 +0000 [thread overview]
Message-ID: <CO6PR18MB393927AA78D08151ACBDECDBAEB99@CO6PR18MB3939.namprd18.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8zXDWRcEZXru61946hJ6hdAtkAra9Gjvt3ov3hWQb1Xtg@mail.gmail.com>
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: 13 March 2023 16:22
> To: Srikanth Yalavarthi <syalavarthi@marvell.com>
> Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao
> <sshankarnara@marvell.com>
> Subject: [EXT] Re: [PATCH] mldev: remove weak symbols use in type
> conversions
>
> External Email
>
> ----------------------------------------------------------------------
> Hello,
>
> On Sat, Mar 11, 2023 at 3:51 PM Srikanth Yalavarthi
> <syalavarthi@marvell.com> wrote:
> >
> > Drop use of weak symbols to select the type conversion functions.
> > Select NEON implementation only on Aarch64 builds. Enable windows
> > build.
> >
> > Fixes: 3c54f91ad8c9 ("mldev: disable build on Windows")
>
> Strictly speaking we are not fixing this change above, but rather
> Fixes: 9637de38a2e3 ("mldev: add scalar type conversion")
>
Updated in v2.
>
> >
> > Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
>
> The change looks good to me and the UNH Windows build target seems to
> agree :-).
Ack.
> Reviewed-by: David Marchand <david.marchand@redhat.com>
>
> Thanks Srikanth.
>
>
> --
> David Marchand
next prev parent reply other threads:[~2023-03-13 11:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 14:50 Srikanth Yalavarthi
2023-03-13 10:52 ` David Marchand
2023-03-13 11:37 ` Srikanth Yalavarthi [this message]
2023-03-13 11:36 ` [PATCH v2 1/1] " Srikanth Yalavarthi
2023-03-15 9:49 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR18MB393927AA78D08151ACBDECDBAEB99@CO6PR18MB3939.namprd18.prod.outlook.com \
--to=syalavarthi@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=sshankarnara@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).